[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...

2017-01-08 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1862 @jongyoul Sure :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...

2017-01-08 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1862 @cloverhearts Can you make a new PR of writing test cases? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...

2017-01-07 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1862 Tested and LGTM! Thanks @jongyoul --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...

2017-01-07 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1862 It's good idea to make it but, for now, we cannot do it because we have zombie process problem when we test it. I think we can do it after we solve that former problem. --- If your project is

[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...

2017-01-07 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1862 Great! I guess I was asking if it's possible to have automated tests so it wouldn't break in the future. --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...

2017-01-07 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1862 Hello @felixcheung I have created and tested a remote interpreter. 1. Go to zeppelin/bin. 2. Run the following:     `bin/bash ./interpreter.sh -d ../interpreter/python -p

[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...

2017-01-06 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1862 @jongyoul Yes, I was take look! LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...

2017-01-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1862 LGTM should there be tests for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1862: [HOTFIX] Removed non-string properties values since it...

2017-01-06 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1862 @cloverhearts Can you look into it? I think it can solve the problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your