[GitHub] zeppelin issue #1952: [ZEPPELIN-753] TableData abstraction

2017-02-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1952 @1ambda further discussion about "how interpreter access data from other interpreter" can be done in https://issues.apache.org/jira/browse/ZEPPELIN-2019. Merge this PR to master if no

[GitHub] zeppelin issue #1952: [ZEPPELIN-753] TableData abstraction

2017-02-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1952 @1ambda Thanks for taking a look. Regarding query directly over the TableData in the ResourcePool, it depends on each interpreter. For example, SparkInterpreter can implement

[GitHub] zeppelin issue #1952: [ZEPPELIN-753] TableData abstraction

2017-02-07 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1952 Sorry for late reply. I was taking a look also recent resource related commit to understand fully. 1. This PR is well abstracted and shipped with enough unit test. 2. And easy to

[GitHub] zeppelin issue #1952: [ZEPPELIN-753] TableData abstraction

2017-02-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1952 @1ambda do you have any comment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1952: [ZEPPELIN-753] TableData abstraction

2017-02-01 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1952 @Leemoonsoo Nice to have abstracted table structure inside zeppelin. It enable us many things even i just glanced at. I will take look deeply and comment soon. --- If your project is