[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

2017-02-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2000 Merge into `gh-pages` if there are no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

2017-02-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2000 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

2017-02-09 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2000 Looks nice :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

2017-02-09 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2000 Hi~ @AhyoungRyu @1ambda I updated this as your comment! Thanks for that could you review again, please? :smiley: --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin issue #2000: [gh-pages] update contribution/webapplication.html

2017-02-09 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2000 Hi @soralee :) I would like to suggest using `'ngInject'l` instead of `$inject = ['$location'];` as like https://github.com/apache/zeppelin/pull/1994 >