[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...

2017-03-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2099 @Remilito Thanks for great work! LGTM and merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...

2017-03-20 Thread Remilito
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2099 @Leemoonsoo : updated! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...

2017-03-18 Thread Remilito
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2099 @Leemoonsoo thanks for the feedback, I think we should keep only B. I'll update the PR in a couple of days. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...

2017-03-17 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2099 @Remilito Thanks for explain. Let's say `graph: {mode: {...}}` is api A, and `config: {results: [{graph: mode: {...}}]}` is api B. When user use api A with multiple results,

[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...

2017-03-15 Thread Remilito
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2099 @Leemoonsoo : the most common usages would be to set visual paramaters, i.e. graph options, paragraph width and paragraph title show, so the idea was to provide a more direct way to configure

[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...

2017-03-15 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2099 Thanks @Remilito for the contribution! Could you elaborate why do you support two different forms of message? ``` { ... "graph": {