[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 Merge into master and branch-0.7 if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 Selenium tests are red in Travis but due to: `SparkParagraphIT.testSqlSpark:185 » NoSuchElement Unable to locate element: {"... `

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 @AhyoungRyu Fixed the issue with my commits, big shoutout to @DrIgor for helping resolve my issue! I also updated the tests (ex. `testSingleDynamicFormSelectForm`,

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 @guicaro There are some unrelated commits in here after you rebased. Can you try to fix it? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 @AhyoungRyu no worries, will be glad to review your work, fix `testMultipleDynamicFormsSameType` and fox my commits, will definetly ping you about this last issue :) Thanks --- If your project

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 @guicaro I feel so sorry to you since it was my bad. Just created hotfix patch #2154 to fix below two issues that you reported. - Select form is not shown up when multiple dynamic forms

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 @guicaro Thanks for letting me know. Let me check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 Quick question, what is the behavior when we have more than 2 select forms? Shouldn't we also have a **"Run on selection"** check box? I believe this was one of the pain points for some (see

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 @AhyoungRyu I'm currently looking at why testMultipleDynamicFormsSameType is failing. It now fails after I rebased from master. It's the test case that includes two select forms in one single

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 Seems some review comments are mixed up in github side :( I just removed some of them and left comment again. Please let me know if you're confused. --- If your project is set up for

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 @guicaro Thanks for your great contribution! I left some comments. Could you take a look at them? Please let me know if there is something that I missed :) --- If your project is set up

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 Thanks again @1ambda it all worked like a charm and now all green :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2141 @guicaro I see. There are many ways to trigger travis again. but what you actually need is pushing new commits so that travis get noticed. - Amend your last commit with `git commit

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 @1ambda Thanks, I actually did setup Travis while I was developing, I did not realize that every commit triggered a build so I deactivated my Zeppelin fork on Travis after I noticed this (so only

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2141 Hi @randerzander. Thanks for contribution. - Zeppelin build system relies on travis. So please setup your travis account and travis project for Zeppelin. -

[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...

Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 Cool! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if