[GitHub] zeppelin issue #2161: [ZEPPELIN-1697] Fix multiuser ws connection for second...

2017-03-21 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/2161 Tested with some basic case, look good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2161: [ZEPPELIN-1697] Fix multiuser ws connection for second...

2017-03-20 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2161 I tested two scenarios that you described and both(turn on & off Shiro) are working well. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin issue #2161: [ZEPPELIN-1697] Fix multiuser ws connection for second...

2017-03-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2161 @anthonycorbacho thanks for the feedback, addressed them above. Let me know if there's something else and if it works fine for you. Also would be nice if other members could

[GitHub] zeppelin issue #2161: [ZEPPELIN-1697] Fix multiuser ws connection for second...

2017-03-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2161 /cc @anthonycorbacho @Leemoonsoo @AhyoungRyu plz help to review and test this one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #2161: [ZEPPELIN-1697] Fix multiuser ws connection for second...

2017-03-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2161 yes, i think my fork was integrated with travis since i have the build here https://travis-ci.org/khalidhuseynov/incubator-zeppelin/builds/212981024 . also the branch was rebased today and

[GitHub] zeppelin issue #2161: [ZEPPELIN-1697] Fix multiuser ws connection for second...

2017-03-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2161 Current jenkins script check only https://travis-ci.org/khalidhuseynov/zeppelin/ not https://travis-ci.org/khalidhuseynov/incubator-zeppelin/. Could you setup travis with 'zeppelin'

[GitHub] zeppelin issue #2161: [ZEPPELIN-1697] Fix multiuser ws connection for second...

2017-03-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2161 Can you setup [CI](http://zeppelin.apache.org/contribution/contributions.html#continuous-integration) for you fork? And then you'll need rebase this branch to include some fixes for