Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2195
There can be simpler way to make a test for wrapper function using mockito.
Other way is adding like
Github user meniluca commented on the issue:
https://github.com/apache/zeppelin/pull/2195
@jongyoul, everybody, would you suggest where to put the test? Consider
that all these methods are wrapping the ``ZeppelinContext.run("parID")`` method
that is NOT tested in this module (simply
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2195
Can you make tests for that new method? there's no tests here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user meniluca commented on the issue:
https://github.com/apache/zeppelin/pull/2195
Guys, do you need something else from my side to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user meniluca commented on the issue:
https://github.com/apache/zeppelin/pull/2195
@AhyoungRyu now I think it's done :)
@zjffdu to answer your questions: it works with all interpreters and the
kind of use case is exactly like PR #2151. In principle he should be able to
use
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2195
@meniluca Great initiative! Thanks for detailed explanation and it makes
sense to me as well. That would be helpful to any other reviewers.
But before you go further, need to setup travis
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2195
Sorry for late response. @meniluca I am very interested in your scenario.
It make sense to me for adding these api, another concern is whether it is more
proper to expose it via ui or expose this
Github user meniluca commented on the issue:
https://github.com/apache/zeppelin/pull/2195
@zjffdu I agree in principle, but if you look at the code they are few
rather trivial new methods, all of them wrapping up the already existing
``run()``. I have these function running in my
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2195
@meniluca I am a little conservative for adding new public api in
ZeppelinContext. As new api means more overhead to maintain it and keep
backward compatibility. Could you describe the scenario of
