Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2207
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2207
will be merging if no further comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2207
hmm, right. Seems document is not needed ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2207
@zjffdu
How to use is the same as the existing one.
If I add a document, should I add something like __zeppelin__ or __spark__?
What do you think? :)
---
If your project is set
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2207
@cloverhearts I left one minor comment. Besides, we need to add document
for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2207
I would like to merge this.
This solves the problem of usability.
I will merge this if I no longer have any opinion.
Thank you :)
---
If your project is set up for it, you can
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2207
Okay, Ci pass :)
@felixcheung @zjffdu
Could you please check on this pr?
Thank you :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2207
and tested environment.
| | pyspark intp | python intp |
|-||--|
|python3 with matplotlib | O| O |
|python2 with matplotlib | O | O |
---
If your
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2207
apply to namespace on python
and zeppelin context name change
before
```
z = _zc = zeppelin context
```
to
```
z = __zeppelin__ = zeppelin context
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2207
@zjffdu
Yes, I will also reflect the namespace.
Thank you for your advice :)
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2207
we need to check if namespace work properly on py2 and py3...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2207
I think a more thorough solution is to separate the namespace between
python process and python repl. Only `ZeppelinContext` should be `available` in
python repl namespace. It would be better to
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2207
right, I think it's everything that is called after calling `exec(code)`,
might have been overwritten by the user code
```
or node in to_run_exec:
mod =
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2207
@felixcheung Thank you for your good advice.
I will check your opinion.
and fix :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2207
Nice!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2207
@cloverhearts Great! Tested this patch and it works well as you described.
- Before
