Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2233
LGTM and merge to master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2233
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AlexanderShoshin commented on the issue:
https://github.com/apache/zeppelin/pull/2233
This PR is ready for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2233
sounds reasonable. are your TO-DO completed and this PR ready for review?
If not, it's customary to have `[WIP]` in your PR title.
---
If your project is set up for it, you can reply to
Github user AlexanderShoshin commented on the issue:
https://github.com/apache/zeppelin/pull/2233
Hi Felix,
thank you for looking through my PR.
Method name must correspond an action it performs. Methods with names like
`addSomething()` usually mean that we must pass this
