Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2274
LGTM and merge to master if no further comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2274
Ping!
And this CI fail is irrelevant this PR.
```
Tests in error:
SecurityRestApiTest.testGetUserList:69 » JsonSyntax
java.lang.IllegalStateExce...
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2274
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2274
CI failed but irrelevant.
```
Tests in error:
SecurityRestApiTest.testGetUserList:69 » JsonSyntax
java.lang.IllegalStateExce...
SecurityRestApiTest.testTicket:55 »
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2274
@1ambda Thanks, I did.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2274
need to be rebased to make CI green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2274
very nice! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2274
I updated as @felixcheung suggestion such as the following screenshot!
Could @felixcheung check it again, please?
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2274
great - just my preference - I actually like the tighter spacing and
without line separator look better...
---
If your project is set up for it, you can reply to this email and have your
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2274
LGTM!!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2274
Thanks @tae-jun for seeing :slightly_smiling_face:
And, @1ambda I updated this as your comments!
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/2274
Cool! Significantly better than before ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2274
Thank you @1ambda @felixcheung for seeing this!
Yeah, I like @1ambda's opinions! Let me update those as @1ambda's comments.
---
If your project is set up for it, you can reply to this email
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2274
awesome!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2274
really great improvement! let me test and comment soon!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2274
@kun @Leemoonsoo Could you guys review this PR, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
16 matches
Mail list logo