[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-05-12 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2274 LGTM and merge to master if no further comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-05-12 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 Ping! And this CI fail is irrelevant this PR. ``` Tests in error: SecurityRestApiTest.testGetUserList:69 » JsonSyntax java.lang.IllegalStateExce...

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-05-09 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2274 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-05-09 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 CI failed but irrelevant. ``` Tests in error: SecurityRestApiTest.testGetUserList:69 » JsonSyntax java.lang.IllegalStateExce... SecurityRestApiTest.testTicket:55 »

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-05-07 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 @1ambda Thanks, I did. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-05-04 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2274 need to be rebased to make CI green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-24 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2274 very nice! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-23 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 I updated as @felixcheung suggestion such as the following screenshot! Could @felixcheung check it again, please?

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-22 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2274 great - just my preference - I actually like the tighter spacing and without line separator look better... --- If your project is set up for it, you can reply to this email and have your

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-22 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2274 LGTM!!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-22 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 Thanks @tae-jun for seeing :slightly_smiling_face: And, @1ambda I updated this as your comments!

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-22 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2274 Cool! Significantly better than before 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-22 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 Thank you @1ambda @felixcheung for seeing this! Yeah, I like @1ambda's opinions! Let me update those as @1ambda's comments. --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-21 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2274 awesome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-21 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2274 really great improvement! let me test and comment soon! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-21 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 @kun @Leemoonsoo Could you guys review this PR, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not