Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2337
@felixcheung Thank you for reviewing this.
Will merge this to master and branch-0.7, if no more discussion.
---
If your project is set up for it, you can reply to this email and
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2337
Thank you @VipinRathor, @Leemoonsoo for the review.
@felixcheung Does this looks OK?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2337
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/2337
Looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2337
Sure, I see, have added a check before sending it to the AD server.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2337
The issue is the value could have been just @ or @foo.com
So after a split on @ the user could become an empty string or just
whitespace
---
If your project is set up for it,
