[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2442 Could you create another PR to trigger the build ? ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 Cache is clean now. I try to retrigger from both accounts. The result is the sameю ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2442 ping @tinkoff-dwh @mebelousov ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-10 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2442 @mebelousov Could you clean the travis cache and for a dummy force push to trigger the build ? ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-10 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu I have retriggered several times. Travis fails with the same error on all jobs. ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-09 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2442 @tinkoff-dwh @mebelousov Could you retrigger the build ? Travis seems fail ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-09 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2442 @tinkoff-dwh Could you rebase the PR ? ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-06 Thread Sanikadze
Github user Sanikadze commented on the issue: https://github.com/apache/zeppelin/pull/2442 +1 ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-06 Thread Aspekt112
Github user Aspekt112 commented on the issue: https://github.com/apache/zeppelin/pull/2442 +1 ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-06 Thread anermakov
Github user anermakov commented on the issue: https://github.com/apache/zeppelin/pull/2442 +1 Must have ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-06 Thread kapustor
Github user kapustor commented on the issue: https://github.com/apache/zeppelin/pull/2442 +1 Must-have feature for enterprise usage. Pre-code may be a resource-management code, or a security code, etc. - users must not have possibility to change it, only admins. ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-04-03 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu hooks are user defined code. We want to have opportunity to log the user sessions, to bind queries to notes. It can be possible only by force execution of special query before

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-03-26 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2442 Sorry @mebelousov I don't get why the general hooks could not satisfy you. The hook can run for each paragraph. Could you explain a little bit more ? Maybe an example would be very helpful.

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-03-26 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu The hooks as pre-code were discussed [previously ](https://github.com/apache/zeppelin/pull/2096#issuecomment-284220634) We want precode execute before pre-hook for easy finding

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-03-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2442 @tinkoff-dwh I just realised that zeppelin already support hooks for interpreter. I think you don't need to do it specifically for jdbc interpreter, instead we could introduce one general property

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-03-13 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu, you are right, sessionPrecode is renamed to statementPrecode. Since 0.8.0 I will recommend to run JDBC interpreter per note in isolated mode due to Interpreter Lifecycle

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-03-13 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2442 Mostly LGTM, one concern is about the name `session` which might confuse users. How about changing it to `statement` ? Besides, I am curious to know how do you use jdbc interpreter. Which

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2018-03-13 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu @felixcheung Every day our users run about 1000 queries in the Greenplum (open source Postgres-based DB). There is great need for binding the query to the user and/or to

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-11-29 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2442 Ready to review ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-11-14 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2442 Ready to review ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-09-11 Thread dwhsys
Github user dwhsys commented on the issue: https://github.com/apache/zeppelin/pull/2442 Can someone review please? ---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-08-09 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2442 Ready to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-08-04 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2442 Ready to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-07-31 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2442 Ready to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-07-24 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2442 Ready to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-07-16 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2442 Ready to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-07-10 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2442 Ready to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-07-03 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2442 it is JDBC interpretator, set variables in first paragraph will not work because we have connection pool and the paragraphs will be executed in different statemnets. What problem with shared

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-07-03 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2442 I am thinking that every interpreter could have one special interpreter for initializing interpreter setting and custom enviroment requirement for his note. And do the initialization at the first

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-07-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2442 I am not sure whether this is a good idea to put custom initialization code in interpreter setting. Because I think one goal of notebook is to allow user to reproduce it easily without change

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-06-29 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu yep, per statement. for exp. There is jdbc interpreter per user (postgres). There are many users and each user has scheme to work. 1. set search_path='#{user}'

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-06-29 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2442 @tinkoff-dwh What do you mean `database session` ? From the code, `precode` is executed per statement. And what is the usage scenario for this ? Could you give an example ? Thanks --- If your

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

2017-06-28 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2442 @felixcheung session == database session. added documentation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your