[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again

2017-09-08 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2563 we are just wrapping up, shouldn't need anything at this point. ---

[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again

2017-09-08 Thread pellmont
Github user pellmont commented on the issue: https://github.com/apache/zeppelin/pull/2563 do I have to do something else before it can be merged? or just wait? ---

[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again

2017-09-07 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2563 @pellmont Cool! LGTM and merge to master if no further comment. ---

[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again

2017-09-07 Thread pellmont
Github user pellmont commented on the issue: https://github.com/apache/zeppelin/pull/2563 finally a green build :-) ---

[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again

2017-09-07 Thread pellmont
Github user pellmont commented on the issue: https://github.com/apache/zeppelin/pull/2563 Hey guys I finally found why some integration tests fail! In scala 2.11.8 the REPL had been improved a lot. So the tests work well with either scala 2.10 (with SparkJLineCompletion)

[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again

2017-09-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2563 Tested manually and it works well. @pellmont could you setup CI and see all tests become green? ``` Looks like travis-ci is not configured for your fork. Please setup by