Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@zjffdu Thank you a lot :)
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2578
LGTM, just one concern about `PythonCondaInterpreterTest.java`. It is using
mock which may not found potential bugs. I think we can do unit without mock.
But anyway this could be done in a
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
If there are no comments anymore, I will merge to master on this pr.
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
LGTM.
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@zjffdu I created one. Thanks.
- https://issues.apache.org/jira/browse/ZEPPELIN-2923
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@1ambda This is due to IPythonInterpreter, could create a ticket ? I will
fix it in another PR.
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
Checked that `conda list` works beautifully. But I am getting this ipython
related message when activate a new env. Can we remove this message which is
not related to conda at all.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
fixed test case and conda list feature
---
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@1ambda okay :)
---
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2578
Tested locally and works well. @cloverhearts Can we fix `conda list`
command as well? it will need exactly the same code with `conda install`.
LGTM except for it.
---
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@zjffdu Sure, Thank you :)
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2578
Thanks @cloverhearts , Is it possible to add unit test for
`PythonCondaInterpreter` ? Regarding the CI failure, I know this failure and
will fix it in another PR
---
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
The problem of CI is irrelevant to this pr.
```
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 12.462 sec
<<< FAILURE! - in
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2578
@1ambda @zjffdu @felixcheung
Sorry.
I divided the existing PR by the minimum function.
Can you review this PR again?
Thank you for your help :)
---
14 matches
Mail list logo