[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class

2017-09-17 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2591 Merge if there's no more discussion ---

[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class

2017-09-17 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2591 Thanks @jongyoul ---

[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class

2017-09-17 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2591 @zjffdu I found S3,VFS,Zeppelinhub repo used different gson from Note. I know it's fixed in master but need to fix them in 0.7.x branch. ---

[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class

2017-09-17 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2591 @jongyoul Which code path use vanila gson for handling json ? ---

[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class

2017-09-17 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2591 Some code used only vanila gson for handling json. ---

[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class

2017-09-17 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2591 Yes, if we use that gson, it can be solved. But there're several gson instances and used different one. I fixed it in order to use the same one to handle that type. ---

[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class

2017-09-17 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2591 @jongyoul I hit this issue before, I think just adding `-MM-dd HH:mm:ss.SSS` into `NotebookImportDeserializer` should be able to resolve this issue. ---

[GitHub] zeppelin issue #2591: [HOTFIX] Forward compatibility of Note class

2017-09-17 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2591 @Leemoonsoo This is hotfix. Please test it and leave comments. ---