[GitHub] zeppelin issue #2613: ZEPPELIN-2982. Copy interpreter-setting.json to interp...

2017-10-12 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2613 will merge if no more discussion ---

[GitHub] zeppelin issue #2613: ZEPPELIN-2982. Copy interpreter-setting.json to interp...

2017-10-12 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2613 Ah, i see. I think i have confused between parent project and dependency. ---

[GitHub] zeppelin issue #2613: ZEPPELIN-2982. Copy interpreter-setting.json to interp...

2017-10-11 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2613 @Leemoonsoo parent project must be pom type, but zeppelin-interpreter is jar. So I have to introduce module `interpreter-parent`. Interpreter dev guide is updated in the new commit. ---

[GitHub] zeppelin issue #2613: ZEPPELIN-2982. Copy interpreter-setting.json to interp...

2017-10-11 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2613 I see. Could you also explain little bit about why you decided to make `interpreter-parent` module instead of just add copy plugin to existing common parents `zeppelin-interpreter` ?

[GitHub] zeppelin issue #2613: ZEPPELIN-2982. Copy interpreter-setting.json to interp...

2017-10-10 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2613 Yes, it keeps capability. The interpreter is not changed. interpreter-setting.json is still packaged into interpreter jar, but copied to interpreter dir as well in this PR. And

[GitHub] zeppelin issue #2613: ZEPPELIN-2982. Copy interpreter-setting.json to interp...

2017-10-10 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2613 Each release, interpreter jars are published in maven repository and `bin/install-interpreter.sh` lets user download and install interpreters. Is this change keeps capability to both publish