Github user namanmishra91 commented on the issue:
https://github.com/apache/zeppelin/pull/2619
Closed as PR 2627 addresses the same thing
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2619
https://github.com/apache/zeppelin/pull/2627 merged
maybe close this PR?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2619
@namanmishra91 I made another PR #2627 which only change the backend code.
Let me know whether this meet your requirement.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2619
@namanmishra91 I don't understand why it would invoke frontend. Backend
know more context about paragraph status and backend could control the workflow
of paragraph running easily.
---
Github user namanmishra91 commented on the issue:
https://github.com/apache/zeppelin/pull/2619
@zjffdu Yeah, I can change the implementation to make
`persistAndExecuteSingleParagraph` paragraph blocking. Then we won't need UI
side changes for separate event handling etc. However, we
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2619
ping @namanmishra91
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2619
@namanmishra91 I don't see the current behavior is retained in this PR.
Personally I don't think the current behavior needs to be retained. Even we
want to keep the current behavior, it should be
Github user namanmishra91 commented on the issue:
https://github.com/apache/zeppelin/pull/2619
@zjffdu Thanks for the feedback. Directly modifying the
`persistAndExecuteSingleParagraph` method will lead to the current behaviour
getting lost completely. The reason I chose to not
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2619
@namanmishra91 I don't mean your PR doesn't do it correctly. I mean you
could do it in an easier approach with less code changes. Just modifying
`persistAndExecuteSingleParagraph` to make it run
Github user namanmishra91 commented on the issue:
https://github.com/apache/zeppelin/pull/2619
@zjffdu
> What we need to do it to run it blocking way.
The code does exactly that. It might look complicated overall as a lot of
code is related to handling and passing
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2619
@namanmishra91 Thanks for the contribution. But the implementation is a
little complicated to me. I think the easiest implementation is just run
paragraphs sequentially in backend. Look at the
11 matches
Mail list logo
