[GitHub] zeppelin issue #2621: [Minor] Remove hardcoded key in zeppelinhub.

2017-10-12 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2621 Merging this if no more discussion. ---

[GitHub] zeppelin issue #2621: [Minor] Remove hardcoded key in zeppelinhub.

2017-10-12 Thread krishna-pandey
Github user krishna-pandey commented on the issue: https://github.com/apache/zeppelin/pull/2621 LGTM. It seems we are using SecureRandom which does not require seed explicitly to initialise and hence hardcoded key can be removed, unless we intentionally wanted a deterministic

[GitHub] zeppelin issue #2621: [Minor] Remove hardcoded key in zeppelinhub.

2017-10-12 Thread krishna-pandey
Github user krishna-pandey commented on the issue: https://github.com/apache/zeppelin/pull/2621 We need to consider below while removing the key. Are we relying on any such behaviour by specifying the seed value? "If two instances of Random are created with the same seed, and the

[GitHub] zeppelin issue #2621: [Minor] Remove hardcoded key in zeppelinhub.

2017-10-12 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2621 @Leemoonsoo ---

[GitHub] zeppelin issue #2621: [Minor] Remove hardcoded key in zeppelinhub.

2017-10-11 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2621 LGTM ---

[GitHub] zeppelin issue #2621: [Minor] Remove hardcoded key in zeppelinhub.

2017-10-11 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/zeppelin/pull/2621 @prabhjyotsingh Please help review. ---