[GitHub] zeppelin issue #2770: ZEPPELIN-3207. fix search content not appearing

2018-02-19 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2770 LGTM! Merge to master and branch-0.8 if no further discussions. ---

[GitHub] zeppelin issue #2770: ZEPPELIN-3207. fix search content not appearing

2018-02-19 Thread swkimme
Github user swkimme commented on the issue: https://github.com/apache/zeppelin/pull/2770 @Leemoonsoo now it's good to go! ---

[GitHub] zeppelin issue #2770: ZEPPELIN-3207. fix search content not appearing

2018-02-09 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2770 Tested and fix works well. But it's getting build failure with following error. ``` [INFO] [INFO] /zeppelin/zeppelin-web/src/app/search/result-list.controller.js [INFO]

[GitHub] zeppelin issue #2770: ZEPPELIN-3207. fix search content not appearing

2018-02-07 Thread swkimme
Github user swkimme commented on the issue: https://github.com/apache/zeppelin/pull/2770 I'm not a web guy, and not sure why ```_editor.getSession().setValue(lines.join('\n'))``` this part is broken. At least I know now it's working with my changes, any comments or