[GitHub] zeppelin issue #2963: [ZEPPELIN-3450] Number sorting issue

2018-05-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2963 Merging this to master and branch-0.8 if no more discussion. ---

[GitHub] zeppelin issue #2963: [ZEPPELIN-3450] Number sorting issue

2018-05-22 Thread sameer79
Github user sameer79 commented on the issue: https://github.com/apache/zeppelin/pull/2963 @Tagar Your welcome and thanks for your comments. ---

[GitHub] zeppelin issue #2963: [ZEPPELIN-3450] Number sorting issue

2018-05-22 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2963 @sameer79 I refreshed my Zeppelin to latest master snapshot. Can't reproduce any longer the issue I specified on the screenshot above. Please disregard my earlier comment. LGTM. This

[GitHub] zeppelin issue #2963: [ZEPPELIN-3450] Number sorting issue

2018-05-21 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2963 @sameer79 I was using latest Zeppelin from master snapshot. Chrome browser. Can you reproduce the same sorting issue for strings? Here's the code I used: ```python %pyspark

[GitHub] zeppelin issue #2963: [ZEPPELIN-3450] Number sorting issue

2018-05-17 Thread sameer79
Github user sameer79 commented on the issue: https://github.com/apache/zeppelin/pull/2963 @Tagar Thanks for your comments - please provide the environment details. ---

[GitHub] zeppelin issue #2963: [ZEPPELIN-3450] Number sorting issue

2018-05-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2963 Is it possible to have unit test for this ? ---

[GitHub] zeppelin issue #2963: [ZEPPELIN-3450] Number sorting issue

2018-05-15 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2963 Thanks for fixing this - I just had a chance to test and confirm it fixes number sorting. PR title reads "Number sorting issue", but code change seems tries to address String and Date sorting is

[GitHub] zeppelin issue #2963: [ZEPPELIN-3450] Number sorting issue

2018-05-13 Thread r-kamath
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/2963 will merge this if there are no more discussions ---