Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
Will merge this to master (only) if no more discussion.
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
When I build Zeppelin, I see in maven build log
> [INFO] Including org.apache.thrift:libthrift:jar:0.9.3 in the shaded jar.
> [INFO] Including org.apache.thrift:libfb303:jar:0.9.3 in
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@Tagar @felixcheung not sure if I fully understand maven-shade-plugin is
this
https://github.com/apache/zeppelin/pull/2975/commits/19b21b1624da552ea8168fe07919134e1a7bcb2f
what we are
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2975
hmmm - agreed maybe shade is the way to go
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
thanks @prabhjyotsingh
bumping up 0.9.3 seems a good idea to me, but I'd like somebody else to
review this too.
my 2 cents - It might be also good to shade Thrift to avoid future
conflicts
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
Have pushed a commit with regenerating those files with Thrift Version
0.9.3 hope
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@prabhjyotsingh yes, seems that way.
It might be more specific for Cloudera or more generic.
I know that Cloudera packages CDH with a specific version of Thrift.
It used to be 0.9.2 in
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@Tagar is this because of Zeppelin's thrift@0.9.2 and Spark/Hive's
thrift@0.93?
Should I also regenerate all the thrift files as well?
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@felixcheung as an example, I've seen NoSuchMethodError exceptions like one
below when working with Spark interpreter reading Hive tables and Thrift
version had a version mismatch .. so it may not
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@felixcheung yes, it only affects internal uses.
Thanks for the review will merge this if no more discussion.
---
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2975
LGTM
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
checked a few newer CDH 5 versions and they're packaged with 0.9.3.
older CDH 5 version come with 0.9.2.
CDH 6 will be shipped with 0.9.3 too.
my two cents: +1 from me.
thanks.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@zjffdu , @r-kamath , @felixcheung can you help review this.
The variability doesn't apply to this, but this is for future accidental
usage.
---
13 matches
Mail list logo
