Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3013
@sanjaydasgupta Hi, I missed this issue fully. So sorry. I think there was
no objection about this issue. Correct?
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Allow me to remind you of the history of this PR:
1) There was an [initial
commit](https://github.com/apache/zeppelin/pull/3013/commits/cabb83e82a2e77326e214a6e506e53f6fb00ff07)
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Sure ~
On Wed, Oct 17, 2018 at 3:22 PM Felix Cheung
wrote:
> ok, let's go ahead then?
>
> â
> You are receiving this because you were mentioned.
> Reply to
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3013
ok, let's go ahead then?
---
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3013
I remembered it didn't have any objection for it.
On Tue, Oct 16, 2018 at 3:57 PM Felix Cheung
wrote:
> possibly? any objection from reviewers of this change/PR?
>
>
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3013
possibly? any objection from reviewers of this change/PR?
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
As suggested by @jongyoul earlier, a mail was sent out to the dev list on
9th July 2018 with this subject: Should we remove "Download Data as CSV/TSV"
button from version 0.8.0?
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3013
any update?
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
I have been a little busy @jongyoul, but have not forgotten it ;-)
Will be done today. Thanks.
---
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3013
ping @sanjaydasgupta
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
@jongyoul I agree.
Will return to this in a day or two.
---
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3013
@sanjaydasgupta As a longterm plan, I like to remove old button as it's not
maintained at all for now. But discussing those kinds of issues in a PR is not
proper. How about moving this
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3013
my 2 cents: 1. yes. 2,3. yes. except that `grid-ui` doesn't have native
`tsv` export, right? I thought `grid-ui` only allows to export as `csv` and as
`xlsx`, is this correct? If it is, we might
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
@jongyoul, @Tagar, could you please confirm my understanding of your
suggestions below:
1) The old button should **not** be removed. It should retain its visual
form and function
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3013
I agree that the hook up `ui-grid` from `old button` makes sense. @Tagar
@sanjaydasgupta
---
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3013
@sanjaydasgupta I agree with what you're saying
but what I was suggesting is just hook up **old button** to **ui-grid**
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Thanks for the ideas @Tagar
If we focus on long term advantages and stability, then continuing to
maintain the old button will be a disadvantage. If the old button is retained,
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Was thinking of another solution.. is it possible to *move* grid-ui's
- Export all/visible data as csv/xls
four options to that old Download menu?
So grid-ui would only have
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Thanks @prabhjyotsingh.
I will wait for a clear common view before making any further changes.
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Sure, looks good.
---
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3013
@sanjaydasgupta I'm not sure your option is better than noticing with a
release message. Generally, we add breaking change message like this kind of
modification. Personally, I like to remove
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Please see my suggestion (described above) implemented in the image below.
The legacy method's button (with the very familiar download icon) has been
retained with a different tool-tip
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Thanks for the input @prabhjyotsingh.
Allow me to list the advantages of both methods, and to suggest a possible
way forward for your consideration.
1) **The legacy
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Tested this PR locally on FF, Safari, Chrome, and Edge25 works well.
The only concern over here is which one should we be removing the "legacy
method" or the one that is avail with
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3013
LGTM, @prabhjyotsingh Could you please verify it finally? I'll merge it
there's no more discussion.
---
25 matches
Mail list logo
