Github user oxygen311 commented on the issue:
https://github.com/apache/zeppelin/pull/3090
Solution must be improved to use by real users.
---
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3090
@felixcheung I agree that support of LSP in Zeppelin is unmature idea.
Share please undesired cases with open ip and port.
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3090
open ip and port to connect to has become a huge problem recently, so
unless LSP has some sort of authentication story, my vote would be "no" even if
this is disabled by default, because this
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3090
@oxygen311 This is what I concern about the behavior consistency. Let's
assume user use PySpark (ipython is disabled). User may find code completion
works pretty well in p1, but works badly in p2
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3090
Very interesting improvements. Thanks for working on this.
Shouldn't LSP server be embedded into Python / PySpark interpreter itself
and not be a separate process?
This would address both
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3090
Is there any session concept in LSP ? so that multiple LSP request could
belong to the same session
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3090
Then it looks like LSP can only work in paragraph level. This seems not
workable for users. Let's assume we also want to make PySpark support LSP. Then
I guess if I type `sc.`, I will get nothing
Github user oxygen311 commented on the issue:
https://github.com/apache/zeppelin/pull/3090
1. LSP is usable and powerful solution:
- LSP can understand imports in the start of paragraph;
- We can use already made solution for every language and don't write new
one;
- LSP
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3090
1. Do you have any examples to show how much better LSP is compared to the
current approach ?
2. Does the auto completion works across paragraphs ? e.g. I create string
variable `a` in p1, can
Github user oxygen311 commented on the issue:
https://github.com/apache/zeppelin/pull/3090
@zjffdu
If LSP has no complete for `sc.`, iPython complete will be shown.
LSP does not support sessions, but it can keep connection.
---
Github user oxygen311 commented on the issue:
https://github.com/apache/zeppelin/pull/3090
@felixcheung
I have added property `zeppelin.python.useLsp` which is disabled by
default. It does not seem unsecured for me now. We also can specify host and
port by ourselves with
Github user oxygen311 commented on the issue:
https://github.com/apache/zeppelin/pull/3090
@zjffdu
Sorry, correct line is `pip install python-language-server`, i will fix it.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3090
@oxygen311 I can not install it. Let me know if there any other dependency
I need to install
```
â zeppelin pr/3090 â pip install pyls
Collecting pyls
Using cached
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3090
@oxygen311 I can not install it. Let me know if there any other dependency
I need to install
```
â zeppelin pr/3090 â pip install pyls
Collecting pyls
Using cached
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3090
Could you add instruction in python.md ? Otherwise it is hard for users to
know how to enable this feature except you.
---
Github user oxygen311 commented on the issue:
https://github.com/apache/zeppelin/pull/3090
Now this feature is enabled only in python interpreter. So you can specify
`zeppelin.python.lspHost` and `zeppelin.python.lspPort` properties and use it.
Server is a separate process. I have
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3090
Is there any document of how to use this ? Like how to configure and start
the LSP server
---
17 matches
Mail list logo
