Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@felixcheung @zjffdu
FYI, I have added https://issues.apache.org/jira/browse/ZEPPELIN-3742 based
on the discussion we had in this PR.
---
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@felixcheung yes I think so as it's not something new, it has been there
since the beam interpreter was created but nobody noticed until now that all
interpreter specific profiles have been
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3092
so we need to open a JIRA then?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3092
Thanks @selvinsource for the investigation, the analysis seems correct to
me.
---
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
Found something that could cause the issue.
in beam/pom.xml there is
```2.0.0```
then
```
beam-runners-flink_${scala.binary.version}```
But looking at
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@zjffdu @mebelousov I sent you a comment before, please ignore, I thought
that scio was only built for 2.10 but I noticed that changing scala version
using the script does update the pom for
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@zjffdu
the issue reported by @mebelousov may have been caused by
https://issues.apache.org/jira/browse/ZEPPELIN-3557
and not this PR, as I only added in the beam interpreter the
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@mebelousov
If you see
https://travis-ci.org/selvinsource/zeppelin/builds/411153675
it seems fine with SCALA_VER="2.11".
What options are you running maven build
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3092
Seems this PR broke build for scala 2.11
After execution of ` ./dev/change_scala_version.sh 2.11` I have got error
```
[ERROR] Failed to execute goal on project zeppelin-beam:
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@zjffdu @felixcheung thanks for reviewing this PR and merging it in the
master. I am going to work on the Hazelcast Jet interpreter next and send a new
PR once ready.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3092
merging
---
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@zjffdu yes I did before opening the pull request.
I manually re-run it and it's fine now
https://travis-ci.org/selvinsource/zeppelin/builds/411153675
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@selvinsource Do you set up travis ?
https://zeppelin.apache.org/contribution/contributions.html
---
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@zjffdu I have made the change, if you can re-run Jenkins please.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@selvinsource I think you need to update this line of .travis.xml
https://github.com/apache/zeppelin/blob/master/.travis.yml#L44
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3092
right. just want to clarify that it is perfectly fine to run Scala, Python
etc without Spark. The session context is maintained in the REPL implementation
and not in SparkContext or
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@selvinsource Travis still fails, I will commit after travis is passed
```
[ERROR] Failed to execute goal on project zeppelin-beam: Could not resolve
dependencies for project
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@zjffdu yeah I think I understood and JShell should be able to achieve this.
I meant as JavaContext a way to maintain the same JShell instance to run
multiple snipper across paragraph in
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@selvinsource What @felixcheung mentioned is not sharing varaibles via
JavaContext, he mean share variable in the same java repl as spark repl did
right now.
---
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@felixcheung
I see what you mean now and I added explicitly to the Java Interpreter doc
that the Java interpreter do not support it.
Eventually, when we move the Java interpreter
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3092
no, I mean
paragraph 1
```
%java
Map counts = new HashMap<>();
```
paragraph 2
```
%java
counts.put("key", 1);
```
---
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@zjffdu thanks
@felixcheung should I mention explicitly that one cannot share variables
between paragraph? I think other interpreters do not allow that either but it's
not
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3092
did you add the behavior in doc?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3092
LGTM, will merge soon
---
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@zjffdu @felixcheung I have pushed the requested changes.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@selvinsource Just one minor comment, could you fix that ? After that I
will merge it if no more comments.
---
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@zjffdu I have done the rebase.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@selvinsource I have removed property `zeppelin.interpreters`, could you do
rebase ?
---
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@zjffdu
I made the requested changes except zeppelin.interpreter.group.order,
should I just remove the whole property? I can't see where it's used to be
honest.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3092
There's no exact plan for 0.9.0, my rough plan is to release 0.9.0 in the
next half year of 2018.
---
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@zjffdu as soon as this PR is merged in the master I will update the
upstream master and start working on Jet interpreter, I have created a Jira
ticket already (with a dependency on the Java
Github user selvinsource commented on the issue:
https://github.com/apache/zeppelin/pull/3092
@zjffdu thanks for reviewing the PR.
Let me give you a bit of background before I answer your question on using
another java interpreter.
First of all, I found lately
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3092
Thanks @selvinsource Very glad that you willing to improve the current java
interpreter when JShell is available in Java 11. It make sense to use the
current java repl that Beam use, and improve
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3092
Thanks @selvinsource for the contribution. Have you thought about other
implementation of java interpreter. like
https://github.com/albertlatacz/java-repl and JShell of Java 9
---
34 matches
Mail list logo
