Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3163
Wow!! Thank you guys for all your efforts @zjffdu @mebelousov
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3163
Thanks all for reviewing and testing, will merge it soon
---
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3163
@zjffdu
No, I didn't see the popup with error explanation for user.
I have tested a lot with Russian symbols. Seems that Zeppelin works fine.
Thank you for this
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3163
@mebelousov Do you see popup windows saying `Fail to create note, cause:
Note name can not contain '..'` ? This is by design.
Regarding 2, 3, this is a known issue, this is due to whether
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3163
@zjffdu, I'm back
1. I get IOException if folder name equals to "..". The same need for name
"." (single dot).
1. Try to create 2 notes with the same path and name, then press
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3163
@mebelousov The issues you mentioned are resolved except the tooltip. I
think the tooltip is correct, this is what zeppelin right now, first move note
to trash, then user can remove it from trash
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3163
@zjffdu
- In note tree plus sing near folder must create note in this folder not at
root.
- It's seems double dots as folder name is still not fixed.
- Can we avoid CR/LF chars as
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3163
@zjffdu
* Now usual note has tooltip "Move this note to trash" on trash button.
Trashed note has tooltip "Remove this note permanently".
* Trashed note must be deleted on "Trash"
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3163
Thanks @mebelousov for testing.
* Need show another tooltip
Sorry I don't get it, what another tooltip do you mean ?
* And delete note, but not add another "~Trash" to note path
Do
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3163
@zjffdu
- Need change the behavior for button "Move note to Trash" for notes in
Trash:
- * Need show another tooltip
- * And delete note, but not add another "~Trash" to note path
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3163
Thanks @mebelousov for verifying this PR, I have addressed the issue.
---
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3163
@zjffdu
- note can't be cloned
- need to deny folder name as ".." (double dot), because of after restart
note will be in another folder
- note with only one empty paragraph doesn't
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3163
Thanks @jongyoul I created ZEPPELIN-3758 for that, will do it after this PR
is merged.
---
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3163
@zjffdu Basically, I agree with this idea. BTW, do you have any plan to
migrate from old format to new format?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3163
@jongyoul @felixcheung I will merge it if no more comments, so that I can
continue the follow up improvement.
---
15 matches
Mail list logo
