[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages

2018-09-18 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3180 Is it necessary to backport to branch-0.8 ? Does it fix some critical issue ? ---

[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages

2018-09-18 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/3180 Sure, thanks for the review will merge this soon to both master and branch-0.8 ---

[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages

2018-09-18 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3180 Thanks @prabhjyotsingh LGTM ---

[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages

2018-09-18 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/3180 Changes consist of two files; - The larger one being package-lock.json; It stores an exact, versioned dependency tree rather than using starred versioning like package.json itself

[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages

2018-09-18 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/3180 oops, it seems a large change, not sure why node npm package upgrade needs so large change. I am not an frontend expert, just need some explanation. 😄 ---

[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages

2018-09-18 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/3180 CI green. @zjffdu @felixcheung can you help review this. ---