Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/806
Wow thanks for your patience. This PR is a long period and lots of
comments. I'll keep on trying my best.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/806
Thanks for the contribution. I'm looking forward to see your next PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/806
Yes, those test are not relevant to you. LGTM. I'll merge it into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/806
- [ ] https://travis-ci.org/apache/zeppelin/jobs/138874097
`ZeppelinSparkClusterTest.sparkRTest:90`
- [ ] https://travis-ci.org/apache/zeppelin/jobs/138874103
```
Tests run: 3,
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/806
I reopened this PR. But I think I have to fix some test case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/806
@mwkang Could you please re-trigger test once again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/806
@jongyoul If user enter wrong name, I ignore that name. Is it okay?
Or do I try to figure similar name out ?
---
If your project is set up for it, you can reply to this email and have your
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/806
@mwkang I have one more question. See below.
https://cloud.githubusercontent.com/assets/3612566/16153092/d3b8e618-34df-11e6-9649-3540c11f86cd.png;>
Can you fix the case of wrong
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/806
@mwkang Those tests are enough. I've tested it and LGTM. Thanks for
contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/806
I am not sure that this test case is you expected
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/806
@mwkang Could you please re-trigger this PR? Close and reopen this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/806
Okay. I am going to fix it.
I show real interpreter name instead of '%..'
@jongyoul I think about single responsibility. But if you have thought it
is redundant, I will change code.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/806
It works well with another default interpreter except `%spark`. See the
below.
https://cloud.githubusercontent.com/assets/3612566/15959490/0720f9e6-2f36-11e6-9f8b-ad6f627c4582.png;>
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/806
@mwkang I still get `%..` when I create a new note, is it normal?
Could you also add a space after the %interpreter when you add it to the
note?
That way we can start typing
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/806
@corneadoug I fix whole issue. Can you check my code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
15 matches
Mail list logo
