[GitHub] zeppelin issue #964: filtering subdirectory names.

2016-06-12 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/964 Tested, Merging if no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #964: filtering subdirectory names.

2016-06-10 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/964 @corneadoug I refactored the codes that you pointed out. please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] zeppelin issue #964: filtering subdirectory names.

2016-06-10 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/964 @corneadoug Thank you for your review. I'll refactor the code as you mentioned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] zeppelin issue #964: filtering subdirectory names.

2016-06-09 Thread corneadoug
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/964 @astroshim Tested, works well, except for those 2 comments LGTM. The code handling those notebook lists and their filtering became quite messy and error prone. I will take some time