GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2351

    [ZEPPELIN-2544] fix: prebuild doens't work in zeppelin-web

    ### What is this PR for?
    
    `prebuild` task in package.json doesn't work for `build:*` tasks in 
zeppelin-web
    
    otherwise we will get overwritten result, if previous build for 
zeppelin-web failed like
    
    ```
    [INFO] Running "cacheBust:taskName" (cacheBust) task
    [INFO] Warning: Unable to write 
"/Users/jl/local/src/g/zeppelin/zeppelin-web/dist/styles/vendor.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.e7906afb60fa5267.css"
 file (Error code: ENAMETOOLONG). Use --force to continue.
    ```
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    
    DONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2544](https://issues.apache.org/jira/browse/ZEPPELIN-2544)
    
    ### How should this be tested?
    
    - `cd zeppelin-web`
    - `npm run build:dist`
    
    Then, check the console output whether `prebuild` is applied or not.
    
    ### Screenshots (if appropriate)
    
    ```
    ## Before
    
    $ zeppelin-web git:(ZEPPELIN-2544/prebuild-does-not-work) npm run build:dist
    
    > zeppelin-web@0.0.0 build:dist 
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web
    > grunt pre-webpack-dist && webpack && grunt post-webpack-dist
    
    ## After
    
    zeppelin-web git:(ZEPPELIN-2544/prebuild-does-not-work) ✗ npm run 
build:dist
    
    > zeppelin-web@0.0.0 build:dist 
/Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web
    > npm-run-all prebuild && grunt pre-webpack-dist && webpack && grunt 
post-webpack-dist
    ```
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2544/prebuild-does-not-work

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2351
    
----
commit 47d4f87553ad60a4dacd0c5022bc84711e76f13e
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-18T16:15:27Z

    fix: Use prebuild in pcakage.json

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to