[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-06 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1730 Let me review and give some feedbacks :) Thanks for implementing the useful feature! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1727: [ZEPPELIN-1695] Use shared versions in test libraries ...

2016-12-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1727 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-06 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 Thanks, @1ambda 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

2016-12-06 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1689 @bzz Let me know if there is anything to do before merging this :) thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-06 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1730 ![image](https://cloud.githubusercontent.com/assets/8201019/20929471/8897948a-bc0d-11e6-941b-4123bc09c8a7.png) It failed only at Selenium test twice. I guess it's because I **changed the

[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade

2016-12-06 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1692 LGTM and merge to master if there're no more discussions. Great work @cloverhearts ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] zeppelin pull request #1714: [ZEPPELIN-1743] Use explicit arguments in funct...

2016-12-06 Thread felizbear
GitHub user felizbear reopened a pull request: https://github.com/apache/zeppelin/pull/1714 [ZEPPELIN-1743] Use explicit arguments in functions in paragraph.controller.js ### What is this PR for? This is `paragraph.controller.js` maintenance PR. It refactors most functions in

[GitHub] zeppelin pull request #1714: [ZEPPELIN-1743] Use explicit arguments in funct...

2016-12-06 Thread felizbear
Github user felizbear closed the pull request at: https://github.com/apache/zeppelin/pull/1714 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1719: [ZEPPELIN-965] missing lastExecuteTime function

2016-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1719 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (ZEPPELIN-1762) How to reconfigure zeppelin to use SSL port 636 for ldap instead of port 398

2016-12-06 Thread Bandhu Gupta (JIRA)
Bandhu Gupta created ZEPPELIN-1762: -- Summary: How to reconfigure zeppelin to use SSL port 636 for ldap instead of port 398 Key: ZEPPELIN-1762 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1762

[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...

2016-12-06 Thread conker84
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 Sure, i'm working on it! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

2016-12-06 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1716 @cloverhearts thank you for contribution! In my experience, if PR author or one of reviewers post the reason for CI failure - that speeds up the review\merge process dramatically. CI is

[GitHub] zeppelin issue #1727: [ZEPPELIN-1695] Use shared versions in test libraries ...

2016-12-06 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1727 Looks great to me, thank you @1ambda for valuable build improvements! Merging to master if there is no further discussion. --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin pull request #1612: ZEPPELIN-1607. Refactor Livy Interpreter to ada...

2016-12-06 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1612 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1612: ZEPPELIN-1607. Refactor Livy Interpreter to ada...

2016-12-06 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1612 ZEPPELIN-1607. Refactor Livy Interpreter to adapt scope mode ### What is this PR for? ZEPPELIN-1606 will make scoped mode as the default interpreter mode of livy. This PR is to refactor

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-12-06 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1538 @mfelgamal could you please explain, why do you think one more script is needed - `start-zeppelin.sh` and why `CMD["/bin/zeppelin.sh"]` can not be used as entrypoint for the image? @1ambda

[GitHub] zeppelin pull request #1727: [ZEPPELIN-1695] Use shared versions in test lib...

2016-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1727 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1731: [ZEPPELIN-1239] Google WebFont: goog-webfont-dl Grunt ...

2016-12-06 Thread bzz
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1731 👍 Idea sounds great to me. It looks like https://github.com/optimalisatie/grunt-goog-webfont-dl is not maintained but https://github.com/Mika-/grunt-google-fonts had changes this year. I

[GitHub] zeppelin issue #1731: [ZEPPELIN-1239] Google WebFont: goog-webfont-dl Grunt ...

2016-12-06 Thread cuspymd
Github user cuspymd commented on the issue: https://github.com/apache/zeppelin/pull/1731 @bzz Thanks for your comment. The file 'google-fonts.css' is created during zeppelin-web build. You need to run `npm run build`. --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-06 Thread cuspymd
Github user cuspymd commented on the issue: https://github.com/apache/zeppelin/pull/1730 @tae-jun Yes. Good Idea~!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Created] (ZEPPELIN-1761) CI: pySparkDepLoaderTest fails the build

2016-12-06 Thread Alexander Bezzubov (JIRA)
Alexander Bezzubov created ZEPPELIN-1761: Summary: CI: pySparkDepLoaderTest fails the build Key: ZEPPELIN-1761 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1761 Project: Zeppelin

[GitHub] zeppelin issue #1721: [ZEPPELIN-969] order by note name in job menu

2016-12-06 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1721 @cloverhearts It works well as expected. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1721: [ZEPPELIN-969] order by note name in job menu

2016-12-06 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1721 @soralee Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...

2016-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1723 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-06 Thread tae-jun
GitHub user tae-jun opened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for?

[jira] [Created] (ZEPPELIN-1759) Zeppelin NoteBook Error logs are truncated

2016-12-06 Thread Prabhu Joseph (JIRA)
Prabhu Joseph created ZEPPELIN-1759: --- Summary: Zeppelin NoteBook Error logs are truncated Key: ZEPPELIN-1759 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1759 Project: Zeppelin

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-06 Thread tae-jun
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

2016-12-06 Thread tae-jun
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for?

[jira] [Created] (ZEPPELIN-1760) Option to disable auto-formatting and type detection in table displays

2016-12-06 Thread Everett Anderson (JIRA)
Everett Anderson created ZEPPELIN-1760: -- Summary: Option to disable auto-formatting and type detection in table displays Key: ZEPPELIN-1760 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1760

[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...

2016-12-06 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1582 I reviewed these changes again and didn't see why they would cause that error. Could you rebase this PR and check our my comment (which should simplify the diff). These