[GitHub] zeppelin issue #2043: [ZEPPELIN-2114] adding reload endpoint

2017-02-22 Thread Remilito
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2043 @AhyoungRyu: let me know if need me to enrich the new notebook-repositories doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[DISCUSS] Behaviour of Interpreter when it is restarted

2017-02-22 Thread Prabhjyot Singh
This is WRT the PR that I've created https://github.com/apache/zeppelin/pull/2034. The issue that I want to discuss over here is how should an Interpreter behave when it is; - restarted from notebook - restarted from Interpreter setting page - edited from Interpreter setting page - deleted

[GitHub] zeppelin issue #2049: [ZEPPELIN-1586][MINOR] add new line char before "[urls...

2017-02-22 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2049 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #2049: [ZEPPELIN-1586][MINOR] add new line char before "[urls...

2017-02-22 Thread r-kamath
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/2049 Good catch. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1983: [ZEPPELIN-1808] disable shortcut key of window created...

2017-02-22 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1983 Hi @Leemoonsoo, I opened two issue as your comment (#2045, #2054) so it would be nice if you could check some PRs. Furthermore this CI is green now :) --- If your project is set up for it,

[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...

2017-02-22 Thread gfalcone
Github user gfalcone commented on the issue: https://github.com/apache/zeppelin/pull/2051 CI passed all the tests : https://travis-ci.org/gfalcone/zeppelin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [DISCUSS] Behaviour of Interpreter when it is restarted

2017-02-22 Thread Jeff Zhang
I think we can combine scenario 2 and 3 if user click yes button on the popup window of whether you want to restart interpreter in scenario 3. Regarding the restarting scenario of 1,2,3, IMHO I think we don't need to differentiate them. Otherwise it might confuse users that restarting in

[GitHub] zeppelin pull request #2028: [MINOR] Supported old note format in case of no...

2017-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2028 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2053: [ZEPPELIN-1964] Layout info is lost after refresh

2017-02-22 Thread soralee
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2053 Thanks @astroshim for fixing this! Tested and it works well like below! LGTM :+1:

[GitHub] zeppelin issue #2028: [MINOR] Supported old note format in case of not havin...

2017-02-22 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2028 Will merge it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Created] (ZEPPELIN-2151) Add integration test for livy cancel api

2017-02-22 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-2151: Summary: Add integration test for livy cancel api Key: ZEPPELIN-2151 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2151 Project: Zeppelin Issue Type:

[GitHub] zeppelin pull request #1794: [WIP][MINOR][ZEPPELIN-804] Remove static method...

2017-02-22 Thread jongyoul
Github user jongyoul closed the pull request at: https://github.com/apache/zeppelin/pull/1794 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1794: [WIP][MINOR][ZEPPELIN-804] Remove static method...

2017-02-22 Thread jongyoul
GitHub user jongyoul reopened a pull request: https://github.com/apache/zeppelin/pull/1794 [WIP][MINOR][ZEPPELIN-804] Remove static method for static initialization ### What is this PR for? This is one of steps of ZEPPELIN-804 to change the way of registration of interpreter.

[GitHub] zeppelin pull request #2055: [ZEPPELIN-1999] get interpreter property with r...

2017-02-22 Thread tinkoff-dwh
GitHub user tinkoff-dwh opened a pull request: https://github.com/apache/zeppelin/pull/2055 [ZEPPELIN-1999] get interpreter property with replaced context parameters ### What is this PR for? Adds posibility to use context parameters (types: String.class, Double.class,

[GitHub] zeppelin pull request #2056: ZEPPELIN-2151. Add integration test for livy ca...

2017-02-22 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/2056 ZEPPELIN-2151. Add integration test for livy cancel api ### What is this PR for? Just add integration test for livy cancel api. Only do it for livy 0.3 as the cancel api is only

[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...

2017-02-22 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2056 @felixcheung @prabhjyotsingh Please help review. CI failure is not relevant. ``` Failed tests: NotebookTest.testPublicPrivateNewNote:1173 expected:<2C[A7GB62Y]> but

[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...

2017-02-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2051 This looks OK to me, can you add a line note on https://github.com/apache/zeppelin/blob/master/docs/interpreter/jdbc.md#apache-hive to update the documentation. --- If your project is

[GitHub] zeppelin issue #2050: ZEPPELIN-2137 Changed "show line chart with focus" to ...

2017-02-22 Thread samthebest
Github user samthebest commented on the issue: https://github.com/apache/zeppelin/pull/2050 thanks @felixcheung checks should be passing now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Created] (ZEPPELIN-2152) Binaries for a setup behind corp firewall and proxy

2017-02-22 Thread Mathieu D (JIRA)
Mathieu D created ZEPPELIN-2152: --- Summary: Binaries for a setup behind corp firewall and proxy Key: ZEPPELIN-2152 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2152 Project: Zeppelin

[GitHub] zeppelin issue #2050: ZEPPELIN-2137 Changed "show line chart with focus" to ...

2017-02-22 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2050 great! thanks for the contribution. merging if no more comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Created] (ZEPPELIN-2153) branch-0.7 not building - bower issue

2017-02-22 Thread krish arunachalam thayappan (JIRA)
krish arunachalam thayappan created ZEPPELIN-2153: - Summary: branch-0.7 not building - bower issue Key: ZEPPELIN-2153 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2153

[GitHub] zeppelin issue #2032: [ZEPPELIN-791] Build infra: move all RAT to root pom.x...

2017-02-22 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2032 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #2056: ZEPPELIN-2151. Add integration test for livy ca...

2017-02-22 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/2056 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #2056: ZEPPELIN-2151. Add integration test for livy ca...

2017-02-22 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/2056 ZEPPELIN-2151. Add integration test for livy cancel api ### What is this PR for? Just add integration test for livy cancel api. Only do it for livy 0.3 as the cancel api is only

[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...

2017-02-22 Thread gfalcone
Github user gfalcone commented on the issue: https://github.com/apache/zeppelin/pull/2051 @prabhjyotsingh thank you for reviewing, just pushed the doc :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] zeppelin pull request #2052: [ZEPPELIN-2048] Can't run first paragraph when ...

2017-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2052 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...

2017-02-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2056 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin pull request #2036: [ZEPPELIN-2135] Don't re-license jdbc/src/main/...

2017-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2036 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #2015: [ZEPPELIN-2103] Unnecessary read to Helium regi...

2017-02-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2015 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2049: [ZEPPELIN-1586][MINOR] add new line char before "[urls...

2017-02-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2049 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: [DISCUSS] Behaviour of Interpreter when it is restarted

2017-02-22 Thread Prabhjyot Singh
Yes, agreed we need some components to manage lifecycle of interpreters. > "I agree that we need to keep same behavior even though users restart in any place." I too agree we should have same behaviour. > Thus we must not assume that "admin" exists. In Zeppelin we can do this

[GitHub] zeppelin issue #2049: [ZEPPELIN-1586][MINOR] add new line char before "[urls...

2017-02-22 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/2049 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Created] (ZEPPELIN-2154) Not work in the web dev mode if changing default port

2017-02-22 Thread Sora Lee (JIRA)
Sora Lee created ZEPPELIN-2154: -- Summary: Not work in the web dev mode if changing default port Key: ZEPPELIN-2154 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2154 Project: Zeppelin

[jira] [Created] (ZEPPELIN-2155) Flaky test: NotebookTest

2017-02-22 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-2155: Summary: Flaky test: NotebookTest Key: ZEPPELIN-2155 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2155 Project: Zeppelin Issue Type: Bug

[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...

2017-02-22 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2056 CI continue fail in the same place. But this is not livy relevant, as I didn't change any code outside livy interpreter. I have created ticket ZEPPELIN-2155 for this ``` Failed

[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...

2017-02-22 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2056 I also think those tests not related to this PR and can be handled in that separate issue, probably some resource note name was changed --- If your project is set up for it, you can reply

[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...

2017-02-22 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2056 Even though test is not directly related to this PR I have experienced some code change or additional test may break other test, because of resource consumption or other unexpected reason.

[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...

2017-02-22 Thread gfalcone
Github user gfalcone commented on the issue: https://github.com/apache/zeppelin/pull/2051 @prabhjyotsingh right, didn't see that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [DISCUSS] Behaviour of Interpreter when it is restarted

2017-02-22 Thread Jongyoul Lee
Yes, we can set some roles by Shiro but what I mean is we didn't implement role-based functions like hiding or showing some menu. On Thu, Feb 23, 2017 at 12:17 PM, Prabhjyot Singh wrote: > Yes, agreed we need some components to manage lifecycle of interpreters. > >

[DISCUSS] Admin feature

2017-02-22 Thread Jongyoul Lee
Hi folks, Recently, I've heard some new feature assumed that it needed the admin account or similar role. But Apache Zeppelin doesn't have any admin feature like hiding/showing menu and settings. I want to know how community thinks about that feature. My first concern is that we have to consider

[GitHub] zeppelin issue #1985: [ZEPPELIN-2075] Can't stop infinite `while` statement ...

2017-02-22 Thread astroshim
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1985 @FireArrow Note has permission in the zeppelin so if user doesn't have `write` permission on that note, user can't cancel job. --- If your project is set up for it, you can reply to this email

[GitHub] zeppelin pull request #2057: ZEPPELIN-2057 InterpreterSettingManager for bra...

2017-02-22 Thread jongyoul
GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/2057 ZEPPELIN-2057 InterpreterSettingManager for branch-0.7 ### What is this PR for? ZEPPELIN-2057 is already merged into master but it's conflicted when it merges into branch-0.7.

[GitHub] zeppelin issue #2057: ZEPPELIN-2057 InterpreterSettingManager for branch-0.7

2017-02-22 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/2057 Will merge it into 0.7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin pull request #1794: [WIP][MINOR][ZEPPELIN-804] Remove static method...

2017-02-22 Thread jongyoul
Github user jongyoul closed the pull request at: https://github.com/apache/zeppelin/pull/1794 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zeppelin pull request #1794: [WIP][MINOR][ZEPPELIN-804] Remove static method...

2017-02-22 Thread jongyoul
GitHub user jongyoul reopened a pull request: https://github.com/apache/zeppelin/pull/1794 [WIP][MINOR][ZEPPELIN-804] Remove static method for static initialization ### What is this PR for? This is one of steps of ZEPPELIN-804 to change the way of registration of interpreter.

Re: [DISCUSS] Admin feature

2017-02-22 Thread Alec Lee
We have multiple uses in our organization share same anonymous account, which will potentially cause the problems, we hope to have true authenticated mode. thanks AL > On Feb 22, 2017, at 9:14 PM, Jongyoul Lee wrote: > > Hi folks, > > Recently, I've heard some new

Re: [DISCUSS] Admin feature

2017-02-22 Thread Jeff Zhang
I think in authenticated mode, admin is necessary. What admin should take charge can be in the following 4 areas: 1. Interpreter setting. Admin can control a template for each interpreter, and each user's template extend this base template but can also customize his own setting. Besides that,

[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...

2017-02-22 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2037 @Leemoonsoo Thanks for your feedback and sorry for my late response. I updated again as you said. - overall looks

[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...

2017-02-22 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2056 looks good, hmm, but the livy 0.3 test is failing https://travis-ci.org/zjffdu/zeppelin/builds/204166190 and you are saying it's not related to this? shall we kick it off one more