[GitHub] zeppelin issue #2354: Allow group/role based authentication using LdapRealm ...

2017-05-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2354 thanks for clarification, then i may look into #932 as well, and after finalising that we can rebase this one --- If your project is set up for it, you can reply to this email and have

[GitHub] zeppelin issue #2354: Allow group/role based authentication using LdapRealm ...

2017-05-20 Thread sohaibiftikhar
Github user sohaibiftikhar commented on the issue: https://github.com/apache/zeppelin/pull/2354 @khalidhuseynov At front it seems that the issues are unrelated however for reasons I do not know #2182 is triggered when using the LdapRealm for me. #932 fixes that issue and hence for

[GitHub] zeppelin issue #2354: Allow group/role based authentication using LdapRealm ...

2017-05-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2354 @sohaibiftikhar thanks for adding option for authentication with role check, I was wondering if these changes are related to the issue in #932, from first look seems a bit unrelated and i

[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization

2017-05-20 Thread conker84
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/2125 @jongyoul this contribution is the result of the split of #1582 in two little PR; the classes under `org.apache.zeppelin.interpreter.graph` provide the basic abstraction that can be used by

[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-05-20 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2268 looks good. initially, the idea with the type well, as the type indicated the type of the stored value (widget is pointing to), but **password** all broke) @1ambda what do you

[GitHub] zeppelin pull request #2355: [ZEPPELIN-2573] Improve navbar style

2017-05-20 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2355 [ZEPPELIN-2573] Improve navbar style ### What is this PR for? Improved navbar style. Refer the screenshots for detail. ### What type of PR is it? [Improvement]

[GitHub] zeppelin pull request #2355: [ZEPPELIN-2573] Improve navbar style

2017-05-20 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2349: [ZEPPELIN-2214] Set npm installer default npm registry

2017-05-20 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2349 Yes, we can split. Then, - Let's make CI green - I left one comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] zeppelin pull request #2355: [ZEPPELIN-2573] Improve navbar style

2017-05-20 Thread 1ambda
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2355 [ZEPPELIN-2573] Improve navbar style ### What is this PR for? Improved navbar style. Refer the screenshots for detail. ### What type of PR is it? [Improvement]

[GitHub] zeppelin pull request #2355: [ZEPPELIN-2573] Improve navbar style

2017-05-20 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2227: [ZEPPELIN-2359] Support Spell as Display

2017-05-20 Thread echarles
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2227 @1ambda thx a lot for the follow-up and your great work. This branch now supports what we want: ``` println("""%json

[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-05-20 Thread 1ambda
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2268 IMO, It's ok if we are not going to add other types like `JSON` which can be `type` and used for other widgets (e.g `textarea`, ...) --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #2349: [ZEPPELIN-2214] Set npm installer default npm registry

2017-05-20 Thread necosta
Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2349 @1ambda , thanks for the quick feedback :) This ticket has related ticket ZEPPELIN-2152 which has a recent comment related to your question:

[GitHub] zeppelin pull request #2355: [ZEPPELIN-2573] Improve navbar style

2017-05-20 Thread 1ambda
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2355 [ZEPPELIN-2573] Improve navbar style ### What is this PR for? Improved navbar style. Refer the screenshots for detail. ### What type of PR is it? [Improvement]

[GitHub] zeppelin pull request #2355: [ZEPPELIN-2573] Improve navbar style

2017-05-20 Thread 1ambda
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #2355: [ZEPPELIN-2573] Improve navbar style

2017-05-20 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2355 Tested and LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

2017-05-20 Thread vipul1409
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Fixed all the issues and the tests have also passed. Please let me know if any more details are needed. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #2352: [ZEPPELIN-2570] fix: indistinguishable director...

2017-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2352 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is