[GitHub] zeppelin issue #2506: [ZEPPELIN-2813] revisions comparator

[sravan-s]

Github user sravan-s commented on the issue:

https://github.com/apache/zeppelin/pull/2506
  
Tested this PR, worked fine. Nice addition 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/986
  
@ChrisMcVey Thank you for providing so much inside, is it possible for you 
to create a JIRA, with if possible some steps to reproduce, or even dump of 
these comments will do, and will try to resolve.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

[ChrisMcVey]

Github user ChrisMcVey commented on the issue:

https://github.com/apache/zeppelin/pull/986
  
Well... I'm back again.  :)

Apparently, Office 365 requires that userPrincipalName be changed to the 
user's routable email address in order for it to be used in any cloud 
environments.  Company-wide I have found that where I am currently working, no 
sAMAccountNames match userPrincipalNames.  Further, no usernames match the new 
userPrincipalNames set for compliance with Office 365.

So, the current design of the provider will implicitly not work with AD 
going forward.


https://blogs.technet.microsoft.com/askpfeplat/2013/09/01/office-365-single-sign-on-how-to-handle-different-userprincipalname-upn-values/










---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2509: [ZEPPELIN-2818] Improve to better rendering from jupyt...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2509
  
I see. Thanks for explain


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2509: [ZEPPELIN-2818] Improve to better rendering from jupyt...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2509
  
@Leemoonsoo 

## Original Markdown
```
  ---
keyword   text
  ---
red   Sunsets, apples, and
  other red or reddish
  things.

green Leaves, grass, frogs
  and other things it's
  not easy being.
  ---
```

## Jupyter
```

keyword text

  red   Sunsets, apples, and
  other red or reddish
  things.


  green Leaves, grass, frogs
  and other things it's
  not easy being.


```
## Pagedown
```

  keyword text
  ——– ———————–
  red Sunsets, apples, and 
  other red or reddish things.

```

## Markdown4j
```

keyword   text
red   Sunsets, apples, and
  other red or reddish
  things.

green Leaves, grass, frogs


and other things it's
not easy being.
  


```

I did some testing.
And some of the Markdown documents I used as samples
Sometimes there are grammars close to exceptions.

When I checked in jupyter,
If you try to apply a syntax close to the exception,
The structure of the changed html document is most similar to Markdown4j.
(actually, some element is little different)
If the structure of the document is similar, it is easy to implement the 
same experience as Jupyter in `LooknFeel`, so I chose Markdown4j which showed 
the most similar results.

one problem is that if you run the markdown paragraph with the default 
interpreter,
some results may look different.

What do you think?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2509: [ZEPPELIN-2818] Improve to better rendering from jupyt...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2509
  
Thanks @cloverhearts for the improvement.

One question. Is there a special reason use Markdown4j instead of Pegdown 
processor? (Pegdown is default processor of 
[Markdown](https://github.com/apache/zeppelin/blob/master/markdown/src/main/java/org/apache/zeppelin/markdown/Markdown.java)
 interpreter) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-2818) Improve to better rendering from jupyter note

[CloverHearts (JIRA)]

CloverHearts created ZEPPELIN-2818:
--

 Summary: Improve to better rendering from jupyter note
 Key: ZEPPELIN-2818
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2818
 Project: Zeppelin
  Issue Type: Improvement
Reporter: CloverHearts
Assignee: CloverHearts


Zeppelin currently has a library to convert and use the Jupiter Notes.
However, there is a problem with paragraphs in some notes.
We need to improve this for maximum data validation and experience.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zeppelin pull request #2508: [ZEPPELIN-2817] Support default interpreter set...

[reminia]

GitHub user reminia opened a pull request:

https://github.com/apache/zeppelin/pull/2508

[ZEPPELIN-2817] Support default interpreter setting in create note re…

…st api

### What is this PR for?
Can set default interpreter in create note rest api.


### What type of PR is it?
[Improvement]

### Todos
None

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2817

### How should this be tested?
Post name and interpreter to rest api/notebook, a note with the interpreter 
should be created.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/reminia/zeppelin default-int

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2508.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2508


commit 5b452ba3dde1003f1c5393c493b65be763b9aa61
Author: lichenyang 
Date:   2017-07-28T09:59:46Z

[ZEPPELIN-2817] Support default interpreter setting in create note rest api




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

[sanjaydasgupta]

Github user sanjaydasgupta commented on the issue:

https://github.com/apache/zeppelin/pull/2502
  
Agreed, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2483
  
@1ambda 
travis link:
https://travis-ci.org/nokia/zeppelin/builds/256876805

I think that tests are not really "stable", I mean, they are time and 
context dependent.

i.e. if one test doesn't clean properly it's execution env next test will 
fail
selenium tests should be splitted to use less time.
It will require time, sorry I do not have enough to contribute this fix.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

[ChrisMcVey]

Github user ChrisMcVey commented on the issue:

https://github.com/apache/zeppelin/pull/986
  
Well through some more testing, I've found that it it will accept logins as 
_either_ the userPrincipalName (without the realm) _or_ the sAMAccountName.  
This true if the principal suffix is NOT set in shiro.

I.E.  
If the object has these two defined in AD:

  sAMAccountName=userexample
  userPrincipalName=userex/hostname1.domain@realm.com

AND shiro.ini does not have the principal suffix:

   #activeDirectoryRealm.principalSuffix = @REALM.COM

Then I am able to login to the UI with either userexample or 
userex/hostname1.domain.com as the username.

If the principal suffix is enabled:

   activeDirectoryRealm.principalSuffix = @REALM.COM

Then, I cannot login to the UI with any form of userex/hostname1.domain.com 
but I can login with userexample.   Logging in with userexample is useless 
because userexam...@realm.com will not be found for group mappings by the UPN 
search filter.

Adding all this for clarity... Zeppelin ActiveDirectoryGroupRealm does not 
explicity authentication the user using sAMAccountName but it does permit it.  
It will also accept UPN.  In most cases, these match.  In some cases, they may 
not.

The more I look at this, it is becoming apparent that as an AD provider and 
not an LDAP provider, they are assuming that running ktpass for a keytab as we 
have done is not a valid user for this provider. 

Hopefully, this info is at least helpful if someone else has this same odd 
config!






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2495: [HOTFIX] JDBC completions. fix cursor position

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2495
  
@felixcheung 
done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2502
  
I guess that's tricky.
like in your example, if it is in `'`, should we leave it alone, or not? 
`%sql select * from table where name rlike '#{2}'`

I suppose we should first make sure the behavior is consistent in all 
interpreters and in all/most of token replacement


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2495: [HOTFIX] JDBC completions. fix cursor position

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2495
  
@felixcheung 
done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #986: [Zeppelin 946] Permissions not honoring group

[ChrisMcVey]

Github user ChrisMcVey commented on the issue:

https://github.com/apache/zeppelin/pull/986
  
FYI...  I have been having similar issues and above and until reading this 
thread in detail did I realize it is searching against userPrincipalName and 
not sAMAccountName which is a better option.

Above it is mentioned the builtin user filter/subsearch is 
"(&(objectClass=*)(userPrincipalName=user1))"

However, if a user ever runs ktpass on AD to export a keytab with a 
different principal name, the userPrincipalName can end up differing from 
sAMAccountName.

It does not make sense to authenticate users via sAMAccountName 
successfully, then search for them again using a *different* AD property 
userPrincipalName... especially when these can differ.  userPrincipalName is 
set for Kerberos which is not always gonna to be consistent with LDAP logins 
which is what AD provider is doing.

Spent a lot of time scratching my head!  Thanks for the detailed post above 
about the search filter.  I'm quite certain my case where sAMAccountName 
differs from UPN is the exception to the rule but there is no reason not to 
match these up just in case.

Best Regards



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2465: [ZEPPELIN-2724] Move NotebookSocket.send() out of sync...

[jeffonia]

Github user jeffonia commented on the issue:

https://github.com/apache/zeppelin/pull/2465
  
I'm curios about can we change the noteSocketMap from the HashMap to 
ConcurrentHashMap, a segment level lock make the throughput about 16 times than 
this for the most optimistic scenario.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---