[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

2018-04-19 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2925 I am saying using group is not good, it just depends on user's setting. BTW, it looks like this PR also works for your scenario. In this PR, I would always choose the owner to run the cronjob. And

[GitHub] zeppelin issue #2932: [ZEPPELIN-3415] Fix export notebook functionality

2018-04-19 Thread r-kamath
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/2932 LGTM ---

[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

2018-04-19 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2925 @mebelousov Your solution depends on shiro setting, we could not assume that in code. ---

[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

2018-04-19 Thread mebelousov
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2925 @zjffdu This is your solution ;) I have tested your branch. Do we have uniform opinion that running document as the group is not good? ---

[GitHub] zeppelin issue #2932: [ZEPPELIN-3415] Fix export notebook functionality

2018-04-19 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2932 Merging this to master and branch-0.8 if no more discussion. ---

[GitHub] zeppelin issue #2930: ZEPPELIN-3414. branch-0.8 - download py4j from main re...

2018-04-19 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2930 @mebelousov I don't think this will work for 0.8. In 0.9, I just put py4j in the code base of zeppelin, that's why I can avoid downloading it in pom. ---

[GitHub] zeppelin issue #2930: ZEPPELIN-3414. branch-0.8 - download py4j from main re...

2018-04-19 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2930 @mebelousov I don't think this will work for 0.8. In 0.9, I just put py4j in the code base of zeppelin, that's why I can avoid downloading it in pom. ---

[GitHub] zeppelin issue #2864: ZEPPELIN-3325: R interpreter build bugfix

2018-04-19 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2864 4 is flaky test, LGTM ---

[GitHub] zeppelin issue #2864: ZEPPELIN-3325: R interpreter build bugfix

2018-04-19 Thread necosta
Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2864 ping @zjffdu https://travis-ci.org/nokia/zeppelin/builds/368034675 (stage 4 looks broken) Thanks ---

[GitHub] zeppelin pull request #2933: ZEPPELIN-3416: Bump up the version of xercesImp...

2018-04-19 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2933 ZEPPELIN-3416: Bump up the version of xercesImpl to 2.11.0.SP5 ### What is this PR for? Update xercesImpl to 2.11.0.SP5 to get some fixes. This is a required dependency for

[GitHub] zeppelin issue #2933: ZEPPELIN-3416: Bump up the version of xercesImpl to 2....

2018-04-19 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2933 @zjffdu @r-kamath Please help review this. ---

[jira] [Created] (ZEPPELIN-3416) Update xercesImpl to 2.11.0.SP5 to get some fixes.

2018-04-19 Thread Prabhjyot Singh (JIRA)
Prabhjyot Singh created ZEPPELIN-3416: - Summary: Update xercesImpl to 2.11.0.SP5 to get some fixes. Key: ZEPPELIN-3416 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3416 Project: Zeppelin

[GitHub] zeppelin pull request #2934: [ZEPPELIN-3417] fix dependency in zeppelin-web/...

2018-04-19 Thread Savalek
GitHub user Savalek opened a pull request: https://github.com/apache/zeppelin/pull/2934 [ZEPPELIN-3417] fix dependency in zeppelin-web/package.json ### What is this PR for? The address of the dependency in zeppelin-web/package.json changed from "shahata/angular-viewport-watch"

[GitHub] zeppelin issue #2931: ZEPPELIN-3405 Zeppelin fails to display the User home ...

2018-04-19 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2931 LGTM ---

[GitHub] zeppelin issue #2931: ZEPPELIN-3405 Zeppelin fails to display the User home ...

2018-04-19 Thread r-kamath
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/2931 will merge this if there are no more discussions ---

[GitHub] zeppelin pull request #2931: ZEPPELIN-3405 Zeppelin fails to display the Use...

2018-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2931 ---

[GitHub] zeppelin pull request #2864: ZEPPELIN-3325: R interpreter build bugfix

2018-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2864 ---

[jira] [Created] (ZEPPELIN-3417) Change the dependency in zeppelin-web/package.json

2018-04-19 Thread Aleksey Savelenko (JIRA)
Aleksey Savelenko created ZEPPELIN-3417: --- Summary: Change the dependency in zeppelin-web/package.json Key: ZEPPELIN-3417 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3417 Project:

[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

2018-04-19 Thread weand
Github user weand commented on the issue: https://github.com/apache/zeppelin/pull/2925 @mebelousov I fully agree that running document as the group is not what a user would expect. That's why I'm proposing another approach again: 1) prior to #2914 the cronExecutionUser

[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

2018-04-19 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2925 Thanks @weand , I agree with you that your proposal seems much easier. I have updated the PR, please help verify it, thanks ---