[GitHub] zeppelin pull request #3020: ZEPPELIN-3535. Disable flaky test

2018-06-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3020


---


[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-18 Thread xixikaikai
Github user xixikaikai commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
BTW  can I use local keycloak for oidc connect to zeppelin?
I now set up a local env of keycloak @andreaTP 


---


[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-18 Thread xixikaikai
Github user xixikaikai commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
@andreaTP  thanks, I am now trying keycloak with the oidc 


---


[GitHub] zeppelin pull request #3032: ZEPPELIN-3149. checkstyle of beam

2018-06-18 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/3032

ZEPPELIN-3149. checkstyle of beam

### What is this PR for?
Straightforward fix for the code style issue of beam module


### What type of PR is it?
[Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3149

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3149

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3032.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3032


commit 3a6a5c7bf593b764cb18fb5b9ca472c84d5677b0
Author: Jeff Zhang 
Date:   2018-06-19T02:52:28Z

ZEPPELIN-3149. checkstyle of beam




---


[GitHub] zeppelin pull request #3031: ZEPPELIN-3336. Remove sending spark web url to ...

2018-06-18 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/3031

ZEPPELIN-3336. Remove sending spark web url to interpreter setting page

### What is this PR for?
This PR  is to remove the spark web url of interpreter setting page. As it 
doesn't make sense to do that. There would many spark interpreter processes 
associated with one interpreter setting when it is in isolated mode.


### What type of PR is it?
[Bug Fix ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3336

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3336

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3031


commit e3a7be2bddef80a5a5c881c47a5c75b95cc4e6ae
Author: Jeff Zhang 
Date:   2018-06-19T02:18:02Z

ZEPPELIN-3336. Remove sending spark web url to interpreter setting page




---


[GitHub] zeppelin pull request #3030: ZEPPELIN-3155. checkstyle for geode

2018-06-18 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/3030

ZEPPELIN-3155. checkstyle for geode

### What is this PR for?
Straightforwrad fix for code style of geode module. 


### What type of PR is it?
[Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3155

### How should this be tested?
* CI pass

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3155

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3030.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3030


commit 3fec610710894857669e02ee1cd262535c5cad4c
Author: Jeff Zhang 
Date:   2018-06-19T02:38:10Z

ZEPPELIN-3155. checkstyle for geode




---


[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-06-18 Thread Tagar
Github user Tagar commented on the issue:

https://github.com/apache/zeppelin/pull/3013
  
Was thinking of another solution.. is it possible to *move* grid-ui's 
- Export all/visible data as csv/xls 

four options to that old Download menu? 

So grid-ui would only have more rare-used "Columns: .. " items, and 
export items will be moves completely to that older button that users got 
used to.

So old button would exposes newer angular-ui-grid export functionality.
Thoughts?


---


Re: Drop Java 7 support? (re-open ZEPPELIN-621?)

2018-06-18 Thread Alex Ott
I've opened the PR for it: https://github.com/apache/zeppelin/pull/3029

On Mon, Jun 18, 2018 at 6:49 AM, Jongyoul Lee  wrote:

> +1, too.
>
> On Mon, Jun 18, 2018 at 11:33 AM, Jeff Zhang  wrote:
>
> > +1
> >
> > Alex Ott 于2018年6月18日周一 上午2:01写道:
> >
> > > Hi all
> > >
> > > Right now Zeppelin is compiled for Java 7 as minimal version.
> > > But it already EOL for a long time, so it makes sense to stop
> supporting
> > > it.
> > >
> > > There are several reasons for it:
> > >
> > >- Spark 2.2.0 that is used by Zeppelin (at least in master) supports
> > >only Java 8+
> > >- Switch to Java 8 will allow to write more clear code for Java part
> > of
> > >the Zeppelin code.
> > >
> > > This switch was already discussed as
> > > https://issues.apache.org/jira/browse/ZEPPELIN-621, but it was more
> > than 2
> > > years ago.
> > >
> > > What do you think?
> > >
> > > --
> > > With best wishes,Alex Ott
> > > http://alexott.net/
> > > Twitter: alexott_en (English), alexott (Russian)
> > >
> >
>
>
>
> --
> 이종열, Jongyoul Lee, 李宗烈
> http://madeng.net
>



-- 
With best wishes,Alex Ott
http://alexott.net/
Twitter: alexott_en (English), alexott (Russian)


[GitHub] zeppelin pull request #3029: ZEPPELIN-621 - Bump Java version to Java 8

2018-06-18 Thread alexott
GitHub user alexott opened a pull request:

https://github.com/apache/zeppelin/pull/3029

ZEPPELIN-621 - Bump Java version to Java 8

### What is this PR for?

This PR switches the project to use Java 8 - we already have dependency on 
Spark 2.2.0 that is Java 8+ only.

### What type of PR is it?

Improvement

### What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-621


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alexott/zeppelin ZEPPELIN-621

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3029.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3029


commit 07e80bb219e5a4b1e0da66920ef3b05d6c47
Author: Alex Ott 
Date:   2018-06-17T14:38:05Z

bump Java to 1.8

commit 764bd341712e926ae326ae69058730b2cac87c5f
Author: Alex Ott 
Date:   2018-06-18T18:15:23Z

update Vagrant to 16.04 + Java 8

commit 51b9eccfba69c2c46d7a189cd8ce10a8c487a74d
Author: Alex Ott 
Date:   2018-06-18T18:15:35Z

Mention Java 8 as dependency




---


[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout

2018-06-18 Thread andreaTP
Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2552
  
waiting is over but `pac4j` introduced a few regressions that needs to be 
fixed to have the documented process working...
I'm looking into, slowly, but if you wanna take over feel free to go ahead 
and contact me privately if you need any help. @saba0815 


---


[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout

2018-06-18 Thread saba0815
Github user saba0815 commented on the issue:

https://github.com/apache/zeppelin/pull/2552
  
Is waiting now over?


---


[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-06-18 Thread sanjaydasgupta
Github user sanjaydasgupta commented on the issue:

https://github.com/apache/zeppelin/pull/3013
  
Thanks @prabhjyotsingh. 

I will wait for a clear common view before making any further changes.


---


[GitHub] zeppelin issue #3019: [ZEPPELIN-3540] Show Spark inline UI in Non-Secure mod...

2018-06-18 Thread shahsank3t
Github user shahsank3t commented on the issue:

https://github.com/apache/zeppelin/pull/3019
  
@prabhjyotsingh @r-kamath - Just a reminder to review this.


---


[jira] [Created] (ZEPPELIN-3550) Make Downloading of data as CSV/TSV configurable

2018-06-18 Thread Paul Ganzon (JIRA)
Paul Ganzon created ZEPPELIN-3550:
-

 Summary: Make Downloading of data as CSV/TSV configurable
 Key: ZEPPELIN-3550
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3550
 Project: Zeppelin
  Issue Type: New Feature
  Components: conf, GUI
Affects Versions: 0.8.1
Reporter: Paul Ganzon
 Attachments: Screen Shot 2018-06-18 at 6.20.32 pm.png

Zeppelin allows users to download data from a query as a CSV/TSV. This 
functionality is available  once a query is submitted through hive, jdbc, spark 
sql and others. It will be great if this functionality is configurable and can 
be turned OFF/ON. There are companies with strict security policies and does 
not allow users to download data from data sources for security reasons. 

Is it possible to add this functionality to zeppelin-web? Line of codes 
affected are as follows.
 * 
[https://github.com/apache/zeppelin/blob/4eea33ad57addcab42ce8fd88df19624be729063/zeppelin-web/src/app/notebook/paragraph/result/result-chart-selector.html#L76-L94]
 * 
[https://github.com/apache/zeppelin/blob/7dc4dbea5a9b49d66113275ad1ffd31abe1d1d4d/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js#L851-L890]

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] zeppelin pull request #3028: [ZEPPELIN-3549] Add to shiro.ini authorization ...

2018-06-18 Thread mebelousov
GitHub user mebelousov opened a pull request:

https://github.com/apache/zeppelin/pull/3028

[ZEPPELIN-3549] Add to shiro.ini authorization for notebook-repositories

### What is this PR for?
Small improvement that users cannot change notebook repositories by default.

### What type of PR is it?
Improvement

### What is the Jira issue?
[ZEPPELIN-3549](https://issues.apache.org/jira/browse/ZEPPELIN-3549)

### How should this be tested?
- Check correct ulr for `/api/notebook-repositories/**`

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3549

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3028.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3028


commit 567ac3fe0ddf8566e86f10225c4386b4b86724f3
Author: mebelousov 
Date:   2018-06-18T07:34:47Z

ZEPPELIN-3549 Add to shiro.ini authorization for notebook-repositories




---


[jira] [Created] (ZEPPELIN-3549) Add to shiro.ini authorization for notebook-repositories

2018-06-18 Thread Maxim Belousov (JIRA)
Maxim Belousov created ZEPPELIN-3549:


 Summary: Add to shiro.ini authorization for notebook-repositories
 Key: ZEPPELIN-3549
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3549
 Project: Zeppelin
  Issue Type: Improvement
Affects Versions: 0.8.0, 0.9.0
Reporter: Maxim Belousov
Assignee: Maxim Belousov


By default users can change notebook repositories
Just add a row to ini.

{code}
/api/notebook-repositories/** = authc, roles[admin]
{code}





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] zeppelin pull request #3027: [ZEPPELIN-2605] Import notebook has 1MB size li...

2018-06-18 Thread sanjaydasgupta
GitHub user sanjaydasgupta opened a pull request:

https://github.com/apache/zeppelin/pull/3027

[ZEPPELIN-2605] Import notebook has 1MB size limit but bigger notebooks can 
be saved without error or warning

### What is this PR for?
Notebooks of any size can be exported and saved, but the import facility 
only accepts notebooks up to 1Mb in size. Allowing notebooks bigger than 1Mb to 
be saved silently (without any warning or error notification) is therefore a 
dangerous trap for users.

It has been argued that notebooks bigger than 1Mb are rare and unusual, but 
a saved notebook also contains the displayed output - and can contain large 
volumes of tabular data, and even images from matplotlib output. Large 
notebooks can be common when zeppelin is used for presentation of visual 
analysis.

This PR adds a popup dialog which is displayed when the user attempts to 
export a notebook that has a size exceeding 1Mb. A screenshot of the popup is 
shown below.


![popup-dialog](https://user-images.githubusercontent.com/477015/41522941-cb2c5c7c-72f5-11e8-83e6-b3f6f29ee834.png)

### What type of PR is it?
[Bug Fix]

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2605

### How should this be tested?
CI pass
Manual testing. A notebook that is small when outputs are cleared, but 
becomes bigger than the limit when all cells are run is included 
(big-output-tester.json).


[big-output-tester.json.zip](https://github.com/apache/zeppelin/files/2110281/big-output-tester.json.zip)

### Screenshots (if appropriate)
See above.

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanjaydasgupta/zeppelin 
z2605-import-notebook-has-1mb-limit

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3027.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3027


commit 943eb5df21a5563ccc588164d0799724e7dd3260
Author: Sanjay Dasgupta 
Date:   2018-06-17T17:17:38Z

z2605-import-notebook-has-1mb-limit: Initial content




---


[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-06-18 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/3013
  
Sure, looks good.


---