[GitHub] felixcheung commented on a change in pull request #3309: [ZEPPELIN-4007]. Travis CI is broken for branch-0.8

2019-02-18 Thread GitBox 
felixcheung commented on a change in pull request #3309: [ZEPPELIN-4007]. 
Travis CI is broken for branch-0.8
URL: https://github.com/apache/zeppelin/pull/3309#discussion_r257866363
 
 

 ##
 File path: 
zeppelin-integration/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
 ##
 @@ -480,7 +480,7 @@ public void testShowAndHideLineNumbers() throws Exception {
 }
   }
 
-  @Test
+  //  @Test
 
 Review comment:
   JIRA?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] felixcheung commented on a change in pull request #3309: [ZEPPELIN-4007]. Travis CI is broken for branch-0.8

2019-02-18 Thread GitBox 
felixcheung commented on a change in pull request #3309: [ZEPPELIN-4007]. 
Travis CI is broken for branch-0.8
URL: https://github.com/apache/zeppelin/pull/3309#discussion_r257866348
 
 

 ##
 File path: 
zeppelin-server/src/test/java/org/apache/zeppelin/rest/KnoxRestApiTest.java
 ##
 @@ -56,7 +56,7 @@ public void setUp() {
   }
 
 
-  @Test
+  //  @Test
 
 Review comment:
   bug/JIRA?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Leemoonsoo opened a new pull request #3312: [ZEPPELIN-4004] Fix RemoteResource.invokeMethod()

2019-02-18 Thread GitBox 
Leemoonsoo opened a new pull request #3312: [ZEPPELIN-4004] Fix 
RemoteResource.invokeMethod()
URL: https://github.com/apache/zeppelin/pull/3312
 
 
   ### What is this PR for?
   RemoteResource is a representation of object in ResourcePool in Interpreter 
running on another process.
   
   RemoteResource provides a invokeMethod() to call method of an object 
remotely, which is not working now. This PR provide a fix for that. Also 
improve the test case to cover this case.
   
   Also provide small improvement to inference parameter type on remote 
invocation.
   
   ### What type of PR is it?
   Bug Fix, Improvement
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-4004
   
   ### How should this be tested?
   Unittest included. CI pass.
   
   ### Questions:
   * Does the licenses files need update? no
   * Is there breaking changes for older versions? no
   * Does this needs documentation? no
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Leemoonsoo commented on a change in pull request #3312: [ZEPPELIN-4004] Fix RemoteResource.invokeMethod()

2019-02-18 Thread GitBox 
Leemoonsoo commented on a change in pull request #3312: [ZEPPELIN-4004] Fix 
RemoteResource.invokeMethod()
URL: https://github.com/apache/zeppelin/pull/3312#discussion_r257877678
 
 

 ##
 File path: 
zeppelin-zengine/src/test/java/org/apache/zeppelin/resource/DistributedResourcePoolTest.java
 ##
 @@ -44,8 +46,9 @@
   public void setUp() throws Exception {
 super.setUp();
 InterpreterSetting interpreterSetting = 
interpreterSettingManager.getByName("mock_resource_pool");
+interpreterSetting.getOption().setPerNote(ISOLATED);
 intp1 = (RemoteInterpreter) interpreterSetting.getInterpreter("user1", 
"note1", "mock_resource_pool");
-intp2 = (RemoteInterpreter) interpreterSetting.getInterpreter("user2", 
"note1", "mock_resource_pool");
+intp2 = (RemoteInterpreter) interpreterSetting.getInterpreter("user2", 
"note2", "mock_resource_pool");
 
 Review comment:
   While `intp1` and `intp2` were configured to the same Note `note1` with 
`SHARED` mode, the test was instantiating `intp1` and `intp2` in the same 
process and didn't test access to the remote object in the remote process.
   
   Therefore, changed interpreter option to per note `ISOLATED` and configured 
`intp1` for `note1` and `intp2 for `note2`, make sure `intp1` and `intp2` runs 
in different process.
   
   In this way, it can reproduce error described in ZEPPELIN-4004


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Leemoonsoo commented on a change in pull request #3312: [ZEPPELIN-4004] Fix RemoteResource.invokeMethod()

2019-02-18 Thread GitBox 
Leemoonsoo commented on a change in pull request #3312: [ZEPPELIN-4004] Fix 
RemoteResource.invokeMethod()
URL: https://github.com/apache/zeppelin/pull/3312#discussion_r257877678
 
 

 ##
 File path: 
zeppelin-zengine/src/test/java/org/apache/zeppelin/resource/DistributedResourcePoolTest.java
 ##
 @@ -44,8 +46,9 @@
   public void setUp() throws Exception {
 super.setUp();
 InterpreterSetting interpreterSetting = 
interpreterSettingManager.getByName("mock_resource_pool");
+interpreterSetting.getOption().setPerNote(ISOLATED);
 intp1 = (RemoteInterpreter) interpreterSetting.getInterpreter("user1", 
"note1", "mock_resource_pool");
-intp2 = (RemoteInterpreter) interpreterSetting.getInterpreter("user2", 
"note1", "mock_resource_pool");
+intp2 = (RemoteInterpreter) interpreterSetting.getInterpreter("user2", 
"note2", "mock_resource_pool");
 
 Review comment:
   While `intp1` and `intp2` were configured to the same Note `note1` with 
`SHARED` mode, the test was instantiating `intp1` and `intp2` in the same 
process and didn't test access to the remote object in the remote process.
   
   Therefore, changed interpreter option to per note `ISOLATED` and configured 
`intp1` for `note1` and `intp2` for `note2`. This make sure `intp1` and `intp2` 
runs in different process.
   
   In this way, it can reproduce error described in ZEPPELIN-4004


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (ZEPPELIN-4013) Spark Scala paragraph output is out of order

2019-02-18 Thread Mathew Wicks (JIRA) 
Mathew Wicks created ZEPPELIN-4013:
--

 Summary: Spark Scala paragraph output is out of order
 Key: ZEPPELIN-4013
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4013
 Project: Zeppelin
  Issue Type: Improvement
Affects Versions: 0.8.1
 Environment: Zeppelin 0.8.1

Spark 2.4
Reporter: Mathew Wicks
 Attachments: image-2019-02-19-17-07-02-442.png

I have found some strange behaviour in Zeppelin 0.8.1, where Spark Scala 
paragraphs display their console outputs in the wrong order.

*Example Picture:*

*!image-2019-02-19-17-09-59-079.png!*

*Expected output:*
{code:java}
import org.apache.hadoop.fs
x: Boolean = true
true
{code}
 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)