[GitHub] [zeppelin] zjffdu commented on a change in pull request #4135: [ZEPPELIN-5290] NPE on empty dynamic form input

2021-06-16 Thread GitBox
zjffdu commented on a change in pull request #4135: URL: https://github.com/apache/zeppelin/pull/4135#discussion_r652428776 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/display/Input.java ## @@ -373,7 +373,11 @@ public static String getSimpleQuery(Map

[GitHub] [zeppelin] zjffdu commented on pull request #4089: [ZEPPELIN-5249]. Update to thrift 0.14.1

2021-06-16 Thread GitBox
zjffdu commented on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-862140754 @PrarthiJain AlluxioInterpreterTest is failed https://github.com/apache/zeppelin/pull/4089/checks?check_run_id=2801927837 -- This is an automated message from the Apache Git

[GitHub] [zeppelin] Reamer commented on pull request #4126: [ZEPPELIN-5393] Polish rest, socket package of zeppelin-server

2021-06-16 Thread GitBox
Reamer commented on pull request #4126: URL: https://github.com/apache/zeppelin/pull/4126#issuecomment-862068327 > @Reamer #4129 is merged, could you rebase this PR ? This PR is from @cuspymd :smile: @cuspymd please rebase. -- This is an automated message from the Apache Git

[GitHub] [zeppelin] zjffdu commented on pull request #4135: [ZEPPELIN-5290] NPE on empty dynamic form input

2021-06-16 Thread GitBox
zjffdu commented on pull request #4135: URL: https://github.com/apache/zeppelin/pull/4135#issuecomment-862112387 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] Reamer commented on pull request #4135: [ZEPPELIN-5290] NPE on empty dynamic form input

2021-06-16 Thread GitBox
Reamer commented on pull request #4135: URL: https://github.com/apache/zeppelin/pull/4135#issuecomment-862130900 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [zeppelin] Reamer commented on a change in pull request #4135: [ZEPPELIN-5290] NPE on empty dynamic form input

2021-06-16 Thread GitBox
Reamer commented on a change in pull request #4135: URL: https://github.com/apache/zeppelin/pull/4135#discussion_r652425047 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/display/Input.java ## @@ -373,7 +373,11 @@ public static String getSimpleQuery(Map

[GitHub] [zeppelin] zjffdu opened a new pull request #4140: [ZEPPELIN-5413] Throw proper error message when user set execution.runtime-mode in flink sql

2021-06-16 Thread GitBox
zjffdu opened a new pull request #4140: URL: https://github.com/apache/zeppelin/pull/4140 ### What is this PR for? `execution.runtime-mode` is available in flink sql-client, but it is not available in zeppelin flink interpreter. So we need to throw proper error message when

[GitHub] [zeppelin] zjffdu opened a new pull request #4141: [ZEPPELIN-5405] ClassNotFoundException in YarnAppMonitor when hadoop client is not installed

2021-06-16 Thread GitBox
zjffdu opened a new pull request #4141: URL: https://github.com/apache/zeppelin/pull/4141 ### What is this PR for? Minor PR to only use YarnAppMonitor when hadoop client is installed, otherwise ClassNotFoundException will be thrown ### What type of PR is it? [ Improvement

[GitHub] [zeppelin] Reamer commented on a change in pull request #4135: [ZEPPELIN-5290] NPE on empty dynamic form input

2021-06-16 Thread GitBox
Reamer commented on a change in pull request #4135: URL: https://github.com/apache/zeppelin/pull/4135#discussion_r652425047 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/display/Input.java ## @@ -373,7 +373,11 @@ public static String getSimpleQuery(Map

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4097: [ZEPPELIN-5330]. Support conda env for python interpreter in yarn mode

2021-06-16 Thread GitBox
zjffdu commented on a change in pull request #4097: URL: https://github.com/apache/zeppelin/pull/4097#discussion_r652430602 ## File path: zeppelin-plugins/launcher/yarn/src/main/java/org/apache/zeppelin/interpreter/launcher/YarnLauncherUtil.java ## @@ -0,0 +1,49 @@ +/* + *

[jira] [Created] (ZEPPELIN-5414) Increase shell interpreter timeout threshold

2021-06-16 Thread Jeff Zhang (Jira)
Jeff Zhang created ZEPPELIN-5414: Summary: Increase shell interpreter timeout threshold Key: ZEPPELIN-5414 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5414 Project: Zeppelin Issue