[GitHub] zeppelin issue #990: [MINOR] Removed classloaderInterpreter on RemoteInterpr...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/990
  
@Leemoonsoo Review this, please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #996: [ZEPPELIN-890] Cache downloaded file from 'maven...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/996


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #996: [ZEPPELIN-890] Cache downloaded file from 'maven-downlo...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/996
  
Sure, I think we can merge this as a hotfix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #974: ZEPPELIN-614 Part 1. Merge PostgresqlInterpreter...

[jongyoul]

GitHub user jongyoul reopened a pull request:

https://github.com/apache/zeppelin/pull/974

ZEPPELIN-614 Part 1. Merge PostgresqlInterpreter's sql completer into JDBC 
Interpreter

### What is this PR for?
Supporting Sql completer into JDBC Interpreter which is merged by the 
function of Postgresql Interpreter. And this is the first step to merge 
Postgresql into generic JDBC Interpreter

### What type of PR is it?
[Improvement]

### Todos
* [x] - Adopted the function of auto completion

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-614

### How should this be tested?

### Screenshots (if appropriate)
https://cloud.githubusercontent.com/assets/3612566/15884224/e241f6b4-2d89-11e6-9746-8c8951ef6708.png;>
https://cloud.githubusercontent.com/assets/3612566/15884229/e7993e24-2d89-11e6-9f5b-018e6eac7f6a.png;>


### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-614

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/974.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #974


commit 6491cba0d319a7f520fae10c820a9d233d3e593c
Author: Jongyoul Lee 
Date:   2016-06-08T05:50:18Z

Added auto completion from PostgresqlInterpreter

commit e49f73c3b03310351ba525d956d1c10de0185cf3
Author: Jongyoul Lee 
Date:   2016-06-08T05:54:54Z

Updated original documentation

commit d4823957bc784ede3d926eb844bcecabba4dbbd5
Author: Jongyoul Lee 
Date:   2016-06-09T13:58:56Z

Fixed typo and coding style

commit 99ce452b68c757c1959b9d4b7983f7d81000256e
Author: Jongyoul Lee 
Date:   2016-06-09T14:13:21Z

Updated license document

commit 998352c4e746c1e97f49487d176aa84d1abf79ce
Author: Jongyoul Lee 
Date:   2016-06-09T14:17:24Z

Fixed old styles




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #996: [ZEPPELIN-890] Cache downloaded file from 'maven-downlo...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/996
  
@prabhjyotsingh Thanks for suggestion. Once travis caches 
'.m2/repository/.cache/maven-download-plugin' directory, 
'maven-download-plugin' will not even try to download files from internet. So i 
think i'll be okay without increasing retry count.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #965: [ZEPPELIN-957] Normalize note name.

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/965
  
@astroshim Thanks!
`MyNote` and `/MyNote` are treated differently. And i think it's right. 
(compatible to previous version)
Therefore I think it's more consistent to treat differently `MyNote/sub` 
and `/MyNote/sub`, too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #974: ZEPPELIN-614 Part 1. Merge PostgresqlInterpreter...

[jongyoul]

GitHub user jongyoul reopened a pull request:

https://github.com/apache/zeppelin/pull/974

ZEPPELIN-614 Part 1. Merge PostgresqlInterpreter's sql completer into JDBC 
Interpreter

### What is this PR for?
Supporting Sql completer into JDBC Interpreter which is merged by the 
function of Postgresql Interpreter. And this is the first step to merge 
Postgresql into generic JDBC Interpreter

### What type of PR is it?
[Improvement]

### Todos
* [x] - Adopted the function of auto completion

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-614

### How should this be tested?

### Screenshots (if appropriate)
https://cloud.githubusercontent.com/assets/3612566/15884224/e241f6b4-2d89-11e6-9746-8c8951ef6708.png;>
https://cloud.githubusercontent.com/assets/3612566/15884229/e7993e24-2d89-11e6-9f5b-018e6eac7f6a.png;>


### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-614

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/974.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #974


commit 6491cba0d319a7f520fae10c820a9d233d3e593c
Author: Jongyoul Lee 
Date:   2016-06-08T05:50:18Z

Added auto completion from PostgresqlInterpreter

commit e49f73c3b03310351ba525d956d1c10de0185cf3
Author: Jongyoul Lee 
Date:   2016-06-08T05:54:54Z

Updated original documentation

commit d4823957bc784ede3d926eb844bcecabba4dbbd5
Author: Jongyoul Lee 
Date:   2016-06-09T13:58:56Z

Fixed typo and coding style

commit 99ce452b68c757c1959b9d4b7983f7d81000256e
Author: Jongyoul Lee 
Date:   2016-06-09T14:13:21Z

Updated license document

commit 998352c4e746c1e97f49487d176aa84d1abf79ce
Author: Jongyoul Lee 
Date:   2016-06-09T14:17:24Z

Fixed old styles




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #974: ZEPPELIN-614 Part 1. Merge PostgresqlInterpreter...

[jongyoul]

Github user jongyoul closed the pull request at:

https://github.com/apache/zeppelin/pull/974


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #984: [ZEPPELIN-982] Improve interpreter completion API

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/984
  
@AhyoungRyu I see. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #965: [ZEPPELIN-957] Normalize note name.

[astroshim]

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/965
  
I really appreciate your detailed review. @Leemoonsoo 
I will fix 1,2,3 but in case 4, 
I thought ```/MyNote/sub``` and ```MyNote/sub``` are the same from 
directory point of view.
Do you think they should be treated differently?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #990: [MINOR] Removed classloaderInterpreter on Remote...

[jongyoul]

Github user jongyoul closed the pull request at:

https://github.com/apache/zeppelin/pull/990


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #990: [MINOR] Removed classloaderInterpreter on Remote...

[jongyoul]

GitHub user jongyoul reopened a pull request:

https://github.com/apache/zeppelin/pull/990

[MINOR] Removed classloaderInterpreter on RemoteInterpreterServer

### What is this PR for?
Removed usage of ClassloaderInterpreter while RemoteInterpreter is being 
created.

### What type of PR is it?
[Refactoring]

### Todos
* [x] - Fixed the codes for not using ClassloaderInterpreter

### What is the Jira issue?
N/A

### How should this be tested?
This PR should not change any user experience

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Classloader in RemoteInterpreter uses system classloader, thus there's no 
reason why interpreter is wrapped by Classloader

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin 
minor-unwrap-classloaderinterpreter-in-remoteinterpreterserver

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/990.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #990


commit 212368f6d014156b81d087490c8dabc454fd6f7d
Author: Jongyoul Lee 
Date:   2016-06-10T11:38:30Z

Removed classloaderInterpreter on RemoteInterpreterServer
Classloader in interpreter uses system classloader, thus there's no reason 
why interpreter is wrapped by Classloader




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---