[GitHub] zeppelin pull request #1175: use static field logger instead of function

2016-07-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1175


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1197: [ZEPPELIN-1196] Fix for bug ZEPPELIN-1196

2016-07-17 Thread SachinJanani
Github user SachinJanani commented on the issue:

https://github.com/apache/zeppelin/pull/1197
  
Can someone please review this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1181: ZEPPELIN-1168 Add http header X-Requested-By in...

2016-07-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1181


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1140: [ZEPPELIN-1125] Application does not logout use...

2016-07-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1140


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1170: BigQuery Interpreter for Apazhe Zeppelin[ZEPPELIN-1153...

2016-07-17 Thread bzz
Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1170
  
Regarding 
>Is it ok if I do the following,
> 1. Create a NOTICE file in the root of bigquery project. i.e 
./bigquery/NOTICE and add something like 
https://github.com/apache/incubator-beam/blob/master/NOTICE

[ASF policy](http://www.apache.org/legal/src-headers.html#notice) requires 
"Every Apache distribution should include a NOTICE file in the top directory, 
along with the standard LICENSE file.", so I think we need to keep it in 
https://github.com/apache/zeppelin/blob/master/NOTICE  

> 2. Change all copyright headers to standard ASF text.

This sounds great


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1199: ZEPPELIN-1169 Fix wrong Guava version

2016-07-17 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1199
  
At first, revert the version and will find how to do selenium test via 
Safari.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1199: ZEPPELIN-1169 Fix wrong Guava version

2016-07-17 Thread jongyoul
GitHub user jongyoul opened a pull request:

https://github.com/apache/zeppelin/pull/1199

ZEPPELIN-1169 Fix wrong Guava version

### What is this PR for?
Fixing the incompatible version for guava 

### What type of PR is it?
[Hot Fix]

### Todos
* [x] - Revert guava.version for fitting in hadoop-2.6

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1169

### How should this be tested?
1. `mvn clean package -Pspark-1.6 -Phadoop-2.4 -Pyarn -Ppyspark -DskipTests`
1. Run spark interpreter with simple script

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1169

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1199


commit e0b11c152be9516d3be88032ce196d0f52d28225
Author: Jongyoul Lee 
Date:   2016-07-18T04:38:13Z

Reverted guava.version for fitting in hadoop-2.6




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1170: BigQuery Interpreter for Apazhe Zeppelin[ZEPPELIN-1153...

2016-07-17 Thread babupe
Github user babupe commented on the issue:

https://github.com/apache/zeppelin/pull/1170
  
Got it, so regarding the copyright license.

Is it ok if I do the following,
1. Create a NOTICE file in the root of bigquery project. i.e 
./bigquery/NOTICE and add something like 
https://github.com/apache/incubator-beam/blob/master/NOTICE
2. Change all copyright headers to standard ASF text.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1170: BigQuery Interpreter for Apazhe Zeppelin[ZEPPELIN-1153...

2016-07-17 Thread babupe
Github user babupe commented on the issue:

https://github.com/apache/zeppelin/pull/1170
  
Sorry about that, I have removed the bad package import from the class


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1198: [ZEPPELIN-1202] Documentation typo under writing inter...

2016-07-17 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1198
  
LGTM 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1179: [ZEPPELIN-1109] Remove bootstrap dialog fade-in/out an...

2016-07-17 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1179
  
Merge into master if there're no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1190: ZEPPELIN-1187. Redirect output of the process running ...

2016-07-17 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1190
  
Merge if there're no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1195: [ZEPPELIN-759] Spark 2.0 support

2016-07-17 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1195
  
Now CI is green. Review this please.

CI profile for spark 2.0 force spark version `2.0.0-preview` instead of 
`2.0.0`, because of spark 2.0.0 is not yet released. If this PR merges before 
spark 2.0.0 release, i'll create a separate issue to change `2.0.0-preview` to 
`2.0.0`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1198: [ZEPPELIN-1202] Documentation typo under writing inter...

2016-07-17 Thread zmhassan
Github user zmhassan commented on the issue:

https://github.com/apache/zeppelin/pull/1198
  
Thank you. I believe all pending work on this is complete. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1170: BigQuery Interpreter for Apazhe Zeppelin[ZEPPELIN-1153...

2016-07-17 Thread bzz
Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1170
  
Thanks @babupe I think we are almost there! Did another pass and add few 
last things above.

One more thing I noticed is - right now this PR fails the project's CI 
build and we heavily rely on this CI automation in the overall progress of the 
project. So we need to make it green again, in order to be able to merge this. 

From [the 
logs](https://s3.amazonaws.com/archive.travis-ci.org/jobs/145380794/log.txt) it 
looks like tests are failing

```
[INFO] Zeppelin: BigQuery interpreter . FAILURE [  
2.834 s]
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile 
(default-testCompile) on project zeppelin-bigquery: Compilation failure: 
Compilation failure:
[ERROR] 
/home/travis/build/apache/zeppelin/bigquery/src/test/java/org/apache/zeppelin/bigquery/BigQueryInterpreterTest.java:[41,41]
 package com.google.cloud.bigquery.testing does not exist
[ERROR] 
/home/travis/build/apache/zeppelin/bigquery/src/test/java/org/apache/zeppelin/bigquery/BigQueryInterpreterTest.java:[41,41]
 package com.google.cloud.bigquery.testing does not exist
[ERROR] -> [Help 1]
[ERROR] 
```

I tried running `mvn test -pl bigquery` on my machine and got 
```
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR] 
/Users//zeppelin-incubator/bigquery/src/test/java/org/apache/zeppelin/bigquery/BigQueryInterpreterTest.java:[41,41]
 package com.google.cloud.bigquery.testing does not exist
[ERROR] 
/Users//zeppelin-incubator/bigquery/src/test/java/org/apache/zeppelin/bigquery/BigQueryInterpreterTest.java:[41,41]
 package com.google.cloud.bigquery.testing does not exist
[INFO] 2 errors
[INFO] -
[INFO] 

[INFO] BUILD FAILURE
[INFO] 

[INFO] Total time: 20.704 s
[INFO] Finished at: 2016-07-18T11:34:19+09:00
[INFO] Final Memory: 37M/363M
[INFO] 

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile 
(default-testCompile) on project zeppelin-bigquery: Compilation failure: 
Compilation failure:
[ERROR] 
/Users//zeppelin-incubator/bigquery/src/test/java/org/apache/zeppelin/bigquery/BigQueryInterpreterTest.java:[41,41]
 package com.google.cloud.bigquery.testing does not exist
[ERROR] 
/Users//zeppelin-incubator/bigquery/src/test/java/org/apache/zeppelin/bigquery/BigQueryInterpreterTest.java:[41,41]
 package com.google.cloud.bigquery.testing does not exist
[ERROR] -> [Help 1]
```

I'm not 100% sure why is that, may be you could point me to the 
documentation on some pre-requests that I'm missing?

But in case some useful tests can not work without external service 
dependency - the simplest way to fix the CI is to:
 - exclude them from the default build and 
 - document the way to run it manually

You can see an example of how the same was recently done for the python 
interpreter in #1164, in particular regarding 
[PythonInterpreterWithPythonInstalledTest](https://github.com/apache/zeppelin/pull/1164/files#diff-177dacc81c4b28b15b73263d3540968cL33)
 and it's excludion in 
[pom.xml](https://github.com/apache/zeppelin/pull/1164/files#diff-db5740cf5cd90cf11935b92eb80d7908R38)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1180: [ZEPPELIN-1059] Fix the Print CSS file

2016-07-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1180


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1185: Redirect home when requested a wrong notename path.

2016-07-17 Thread corneadoug
Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1185
  
Merging if there is no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1198: [ZEPPELIN-1202] Documentation typo under writin...

2016-07-17 Thread zmhassan
GitHub user zmhassan opened a pull request:

https://github.com/apache/zeppelin/pull/1198

[ZEPPELIN-1202] Documentation typo under writing interpreter docs

### What is this PR for?
To correct typo found in documentation

### What type of PR is it?
 Documentation

### Todos
* [ ] - Replace sentence with incorrect english docs with correction.

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1202

### How should this be tested?
Build docs and see correct docs on 
`https://zeppelin.apache.org/docs/latest/development/writingzeppelininterpreter.html`
### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zmhassan/zeppelin ZEPPELIN-1202

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1198


commit 8d6e0688ae23a6824d4341992dd5100fd74539aa
Author: Zak Hassan 
Date:   2016-07-17T21:42:19Z

Documentation typo creation.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1202) Typo in documentation under

2016-07-17 Thread Zak Hassan (JIRA)
Zak Hassan created ZEPPELIN-1202:


 Summary: Typo in documentation under 
 Key: ZEPPELIN-1202
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1202
 Project: Zeppelin
  Issue Type: Task
  Components: documentation
Affects Versions: 0.6.0
 Environment: 
https://zeppelin.apache.org/docs/latest/development/writingzeppelininterpreter.html
Reporter: Zak Hassan
Assignee: Zak Hassan
Priority: Trivial
 Fix For: 0.6.1


In the documentation on page: 

https://zeppelin.apache.org/docs/latest/development/writingzeppelininterpreter.html

There is a typo in the docs I found:
{quote}
And you should your jars under your interpreter directory with specific 
directory name.
{quote}


The correction is:

{quote}
And you should `put` your jars under your interpreter directory with `a` 
specific directory name
{quote}





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1187: [ZEPPELIN-1163] Change some parameter name properly in...

2016-07-17 Thread zmhassan
Github user zmhassan commented on the issue:

https://github.com/apache/zeppelin/pull/1187
  
@AhyoungRyu I've fixed the merge conflict and all changed are now in. Let 
me know if there is anything else left as I think this task is complete.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1187: [ZEPPELIN-1163] Change some parameter name properly in...

2016-07-17 Thread zmhassan
Github user zmhassan commented on the issue:

https://github.com/apache/zeppelin/pull/1187
  
Thank you @AhyoungRyu I'm going to fix the rest of jobmanager.controller.js 
and then rebase. 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1197: [ZEPPELIN-1196] Fix for bug ZEPPELIN-1196

2016-07-17 Thread SachinJanani
Github user SachinJanani commented on the issue:

https://github.com/apache/zeppelin/pull/1197
  
One of the travis check is failing but its not related to my changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #418: [DOCS] Zeppelin Flink Spark tutorial

2016-07-17 Thread rawkintrevo
Github user rawkintrevo commented on the issue:

https://github.com/apache/zeppelin/pull/418
  
Good  eye @AhyoungRyu , the navigation made more sense in December, I 
didn't look at it again since the rebase. 

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1198) Documents for running zeppelin on production environments.

2016-07-17 Thread Shim HyungSung (JIRA)
Shim HyungSung created ZEPPELIN-1198:


 Summary: Documents for running zeppelin on production environments.
 Key: ZEPPELIN-1198
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1198
 Project: Zeppelin
  Issue Type: Improvement
  Components: documentation
Affects Versions: 0.7.0
Reporter: Shim HyungSung


I know that the most of zeppelin users are using with spark on their production 
environments.
but, It seems lack of documents for this.
I think we need at least three of documents about using zeppelin with spark 
cluster mode (http://spark.apache.org/docs/latest/cluster-overview.html) and 
plus one for amazone EMR.
What do you think guys?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ZEPPELIN-1197) Should print output directly without invoking function print in pyspark interpreter.

2016-07-17 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-1197:


 Summary: Should print output directly without invoking function 
print in pyspark interpreter. 
 Key: ZEPPELIN-1197
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1197
 Project: Zeppelin
  Issue Type: Improvement
  Components: Interpreters
Affects Versions: 0.6.0
Reporter: Jeff Zhang
Assignee: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1170: BigQuery Interpreter for Apazhe Zeppelin[ZEPPELIN-1153...

2016-07-17 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1170
  
+1 for technical docs `bigquery/README.md` that @bzz suggested and it looks 
great that you added! 
How about adding below one sentence in the end of `bigquery.md` so that 
users can know the existence of this file?

```
## Technical description

For in-depth technical details on current implementation please refer to 
[bigquery/README.md](https://github.com/apache/zeppelin/blob/master/bigquery/README.md).
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1191: [ZEPPELIN-1186] Prevent NPE when unbind interpreter

2016-07-17 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1191
  
Thanks for the review. Merging if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1191: [ZEPPELIN-1186] Prevent NPE when unbind interpreter

2016-07-17 Thread astroshim
Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1191
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---