date:20160801

[GitHub] zeppelin issue #1193: [ZEPPELIN-1192] Block pyspark paragraph hang.

2016-08-01 Thread astroshim

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1193
  
\cc @bzz for review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1236: [ZEPPELIN-1237] Auto-suggestion of notebook permission...

2016-08-01 Thread prabhjyotsingh

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1236
  
I think a part of this problem is solved by 
https://github.com/apache/zeppelin/pull/993 
([ZEPPELIN-987](https://issues.apache.org/jira/browse/ZEPPELIN-987)). But, yes 
I agree this has scope for improvising. 

Will merge this if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1223: [WIP Zeppelin-945] Interpreter authorization

2016-08-01 Thread astroshim

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1223
  
I'll do this at the another PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1223: [WIP Zeppelin-945] Interpreter authorization

2016-08-01 Thread astroshim

Github user astroshim closed the pull request at:

https://github.com/apache/zeppelin/pull/1223


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #673: [Zeppelin-630] Introduce new way of dependency loading ...

2016-08-01 Thread minahlee

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/673
  
@zjffdu If you click gear button located top right side, it will toggle 
repository management page


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...

2016-08-01 Thread mwkang

Github user mwkang commented on the issue:

https://github.com/apache/zeppelin/pull/1248
  
@jongyoul Can you review this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ZEPPELIN-1008] Improve Interpreter binding dialog

2016-08-01 Thread Corneau Damien

Originally, the default interpreter is never saved on front-end side.
It is set on back-end side.


On Tue, Aug 2, 2016 at 3:35 AM, Minudika Malshan 
wrote:

> On Sat, Jul 30, 2016 at 7:30 PM, Minudika Malshan 
> wrote:
>
> > Hi all,
> >
> > Currently I am working on above subjected issue. I went through the
> > implementation of notebook.html[1] and notebook.controller.js.[2]
> > I want to know the location of the notebook-controller.js where the
> *default
> > interpreter* is set to the notebook.
> > According to the current implementation, it would be the first
> interpreter
> > which can be sorted from the interpreter binding window.
> > Your kind help would be much appreciated.
> >
> > [1]
> >
> https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/notebook.html
> > [2]
> >
> https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/notebook.controller.js
> >
> > Thank you!
> > Miudika
> >
>

[GitHub] zeppelin issue #1256: [ ZEPPELIN-1259 ] create ace.editor configuration mana...

2016-08-01 Thread cloverhearts

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1256
  
@corneadoug 
please, can you review for this pr?
i divided to  https://github.com/apache/zeppelin/pull/1218 pr.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1254: [ZEPPELIN-1257] storage - fix get note revision api

2016-08-01 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1254
  
@bzz regarding the CI issue, I keep getting the following: 
```
14:05:27,226 ERROR 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter:237 - Failed to create 
interpreter: org.apache.zeppelin.interpreter.remote.mock.MockInterpreterA
14:05:27,227 ERROR 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter:264 - Failed to 
initialize interpreter: 
org.apache.zeppelin.interpreter.remote.mock.MockInterpreterA. Remove it from 
interpreterGroup
14:05:27,240  INFO org.apache.zeppelin.scheduler.SchedulerFactory:131 - Job 
jobName1 started by scheduler test
14:05:27,240  INFO 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter:223 - Create remote 
interpreter org.apache.zeppelin.interpreter.remote.mock.MockInterpreterA
14:05:27,242 ERROR 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter:237 - Failed to create 
interpreter: org.apache.zeppelin.interpreter.remote.mock.MockInterpreterA
14:05:27,243 ERROR org.apache.zeppelin.scheduler.Job:189 - Job failed
org.apache.zeppelin.interpreter.InterpreterException: 
org.apache.thrift.TApplicationException: Internal error processing 
createInterpreter
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.init(RemoteInterpreter.java:238)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.getFormType(RemoteInterpreter.java:383)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.interpret(RemoteInterpreter.java:299)
at 
org.apache.zeppelin.scheduler.RemoteSchedulerTest$2.jobRun(RemoteSchedulerTest.java:210)
at org.apache.zeppelin.scheduler.Job.run(Job.java:176)
at 
org.apache.zeppelin.scheduler.RemoteScheduler$JobRunner.run(RemoteScheduler.java:329)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.thrift.TApplicationException: Internal error 
processing createInterpreter
at 
org.apache.thrift.TApplicationException.read(TApplicationException.java:111)
at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:71)
at 
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Client.recv_createInterpreter(RemoteInterpreterService.java:196)
at 
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Client.createInterpreter(RemoteInterpreterService.java:180)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.init(RemoteInterpreter.java:227)
... 12 more
```
filed an issue [here](https://issues.apache.org/jira/browse/ZEPPELIN-1264)

Regarding this pr, I'll consider your comments on using OO way here and 
open new pr with a fix. Also separating Revision is a valid point and might be 
addressed there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1264) CI failure on master with ParallelSchedulerTest

2016-08-01 Thread Khalid Huseynov (JIRA)

Khalid Huseynov created ZEPPELIN-1264:
-

 Summary: CI failure on master with ParallelSchedulerTest 
 Key: ZEPPELIN-1264
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1264
 Project: Zeppelin
  Issue Type: Bug
Reporter: Khalid Huseynov
Priority: Critical


The CI keeps failing on org.apache.zeppelin.scheduler.ParallelSchedulerTest 
after continues errors and exit. Here's the stacktrace: 

{noformat}
14:05:27,226 ERROR org.apache.zeppelin.interpreter.remote.RemoteInterpreter:237 
- Failed to create interpreter: 
org.apache.zeppelin.interpreter.remote.mock.MockInterpreterA
14:05:27,227 ERROR org.apache.zeppelin.interpreter.remote.RemoteInterpreter:264 
- Failed to initialize interpreter: 
org.apache.zeppelin.interpreter.remote.mock.MockInterpreterA. Remove it from 
interpreterGroup
14:05:27,240  INFO org.apache.zeppelin.scheduler.SchedulerFactory:131 - Job 
jobName1 started by scheduler test
14:05:27,240  INFO org.apache.zeppelin.interpreter.remote.RemoteInterpreter:223 
- Create remote interpreter 
org.apache.zeppelin.interpreter.remote.mock.MockInterpreterA
14:05:27,242 ERROR org.apache.zeppelin.interpreter.remote.RemoteInterpreter:237 
- Failed to create interpreter: 
org.apache.zeppelin.interpreter.remote.mock.MockInterpreterA
14:05:27,243 ERROR org.apache.zeppelin.scheduler.Job:189 - Job failed
org.apache.zeppelin.interpreter.InterpreterException: 
org.apache.thrift.TApplicationException: Internal error processing 
createInterpreter
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.init(RemoteInterpreter.java:238)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.getFormType(RemoteInterpreter.java:383)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.interpret(RemoteInterpreter.java:299)
at 
org.apache.zeppelin.scheduler.RemoteSchedulerTest$2.jobRun(RemoteSchedulerTest.java:210)
at org.apache.zeppelin.scheduler.Job.run(Job.java:176)
at 
org.apache.zeppelin.scheduler.RemoteScheduler$JobRunner.run(RemoteScheduler.java:329)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.thrift.TApplicationException: Internal error processing 
createInterpreter
at 
org.apache.thrift.TApplicationException.read(TApplicationException.java:111)
at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:71)
at 
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Client.recv_createInterpreter(RemoteInterpreterService.java:196)
at 
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Client.createInterpreter(RemoteInterpreterService.java:180)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.init(RemoteInterpreter.java:227)
... 12 more
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZEPPELIN-1263) Should specify zeppelin's spark configuration through --conf arguments of spark-submit

2016-08-01 Thread Jeff Zhang (JIRA)

Jeff Zhang created ZEPPELIN-1263:


 Summary: Should specify zeppelin's spark configuration through 
--conf arguments of spark-submit
 Key: ZEPPELIN-1263
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1263
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.6.0
Reporter: Jeff Zhang
Assignee: Jeff Zhang


For now, we load zeppelin's spark configuration at runtime in the 
RemoteInterpreter Process rather than loading them before starting the process 
(through --conf of spark-submit). It is fine for most of spark configuration, 
but for some configuration, it would introduce some weird issues.  Like 
ZEPPELIN-1242, and if you specify spark.master as yarn-client in 
spark-defaults.conf but specify spark.master as local in zeppelin side, you 
will see the spark interpreter fail to start due to this inconsistency. 
So I propose to specify zeppelin's spark configuration through --conf arguments 
of spark-submit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1255: Adding extra libraries to livy

2016-08-01 Thread zjffdu

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1255
  
@jimdowling  Right, there's no ZeppelinContext in livy right now. Would 
allowing user to specify jars/packages when creating livy session more general 
? (like --jars/--packages in spark-submit)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1240: [ZEPPELIN-1246] In JDBCInterpreter.getScheduler...

2016-08-01 Thread prasadwagle

GitHub user prasadwagle reopened a pull request:

https://github.com/apache/zeppelin/pull/1240

[ZEPPELIN-1246] In JDBCInterpreter.getScheduler, use 
getMaxConcurrentConnection instead of hardcoding maxConcurrency to 10

### What is this PR for?
In JDBCInterpreter.getScheduler, use getMaxConcurrentConnection instead of 
hardcoding maxConcurrency to 10


### What type of PR is it?
Improvement

### Todos
* [ ] - Task

### What is the Jira issue?
[ZEPPELIN-1246] (https://issues.apache.org/jira/browse/ZEPPELIN-1246)

### How should this be tested?
Set zeppelin.jdbc.concurrent.max_connection to 2 and verify after starting 
two long-running queries, a third query is pending.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
No

* Is there breaking changes for older versions?
No

* Does this needs documentation?
No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prasadwagle/incubator-zeppelin ZEPPELIN-1246

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1240.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1240


commit 62affdfd77a03f597acfc304280d8c40f3a796af
Author: Prasad Wagle 
Date:   2016-07-28T21:27:15Z

In JDBCInterpreter.getScheduler, use getMaxConcurrentConnection instead of 
hardcoding maxConcurrency to 10




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1240: [ZEPPELIN-1246] In JDBCInterpreter.getScheduler...

2016-08-01 Thread prasadwagle

Github user prasadwagle closed the pull request at:

https://github.com/apache/zeppelin/pull/1240


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ZEPPELIN-1008] Improve Interpreter binding dialog

2016-08-01 Thread Minudika Malshan

On Sat, Jul 30, 2016 at 7:30 PM, Minudika Malshan 
wrote:

> Hi all,
>
> Currently I am working on above subjected issue. I went through the
> implementation of notebook.html[1] and notebook.controller.js.[2]
> I want to know the location of the notebook-controller.js where the *default
> interpreter* is set to the notebook.
> According to the current implementation, it would be the first interpreter
> which can be sorted from the interpreter binding window.
> Your kind help would be much appreciated.
>
> [1]
> https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/notebook.html
> [2]
> https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/notebook.controller.js
>
> Thank you!
> Miudika
>

[GitHub] zeppelin issue #1240: [ZEPPELIN-1246] In JDBCInterpreter.getScheduler, use g...

2016-08-01 Thread prasadwagle

Github user prasadwagle commented on the issue:

https://github.com/apache/zeppelin/pull/1240
  
I rebased my branch of latest master and pushed it to origin, closed and 
reopened pull request but the travis build hasn't started. What is the reason 
for that?

```
tw-172-25-130-195 incubator-zeppelin-prasadwagle (ZEPPELIN-1246) $ git 
rebase master
First, rewinding head to replay your work on top of it...
Applying: In JDBCInterpreter.getScheduler, use getMaxConcurrentConnection 
instead of hardcoding maxConcurrency to 10

tw-172-25-130-195 incubator-zeppelin-prasadwagle (ZEPPELIN-1246) $ git push 
-f origin
Username for 'https://github.com': prasadwagle
Password for 'https://prasadwa...@github.com': 
Counting objects: 215, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (115/115), done.
Writing objects: 100% (215/215), 188.52 KiB | 0 bytes/s, done.
Total 215 (delta 91), reused 168 (delta 62)
To https://github.com/prasadwagle/incubator-zeppelin.git
 + 4b2990f...62affdf ZEPPELIN-1246 -> ZEPPELIN-1246 (forced update)
tw-172-25-130-195 incubator-zeppelin-prasadwagle (ZEPPELIN-1246) $ git log
commit 62affdfd77a03f597acfc304280d8c40f3a796af
Author: Prasad Wagle 
Date:   Thu Jul 28 14:27:15 2016 -0700

In JDBCInterpreter.getScheduler, use getMaxConcurrentConnection instead 
of hardcoding maxConcurrency to 10

commit 6f867ceb0c2b93ecca3be8a16c155547182eb0dc
Author: paulbustios 
Date:   Mon Aug 1 01:13:27 2016 -0300

```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1240: [ZEPPELIN-1246] In JDBCInterpreter.getScheduler...

2016-08-01 Thread prasadwagle

GitHub user prasadwagle reopened a pull request:

https://github.com/apache/zeppelin/pull/1240

[ZEPPELIN-1246] In JDBCInterpreter.getScheduler, use 
getMaxConcurrentConnection instead of hardcoding maxConcurrency to 10

### What is this PR for?
In JDBCInterpreter.getScheduler, use getMaxConcurrentConnection instead of 
hardcoding maxConcurrency to 10


### What type of PR is it?
Improvement

### Todos
* [ ] - Task

### What is the Jira issue?
[ZEPPELIN-1246] (https://issues.apache.org/jira/browse/ZEPPELIN-1246)

### How should this be tested?
Set zeppelin.jdbc.concurrent.max_connection to 2 and verify after starting 
two long-running queries, a third query is pending.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
No

* Is there breaking changes for older versions?
No

* Does this needs documentation?
No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prasadwagle/incubator-zeppelin ZEPPELIN-1246

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1240.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1240


commit 62affdfd77a03f597acfc304280d8c40f3a796af
Author: Prasad Wagle 
Date:   2016-07-28T21:27:15Z

In JDBCInterpreter.getScheduler, use getMaxConcurrentConnection instead of 
hardcoding maxConcurrency to 10




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1229: [BugFix] Show checkbox for "Connect to existing...

2016-08-01 Thread astroshim

Github user astroshim closed the pull request at:

https://github.com/apache/zeppelin/pull/1229


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1229: [BugFix] Show checkbox for "Connect to existing proces...

2016-08-01 Thread astroshim

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1229
  
re-trigger CI


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1229: [BugFix] Show checkbox for "Connect to existing...

2016-08-01 Thread astroshim

GitHub user astroshim reopened a pull request:

https://github.com/apache/zeppelin/pull/1229

[BugFix] Show checkbox for "Connect to existing process" on interpreter 
menu.

### What is this PR for?
This PR fixes a bug of showing checkbox for "Connect to existing process" 
on interpreter menu.


### What type of PR is it?
Bug Fix


### How should this be tested?
Go to interpreter menu and check if checkbox for "Connect to existing 
process" exists.

### Screenshots (if appropriate)
- before

![image](https://cloud.githubusercontent.com/assets/3348133/17141824/aa316672-5388-11e6-952d-50a3769a01a5.png)

- after

![image](https://cloud.githubusercontent.com/assets/3348133/17141840/babfad8c-5388-11e6-9209-e37e252e95b4.png)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin bugfix/showCheckbox

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1229


commit bbc3283c7cf21fa7340887ddc3bf7ba7b5b8f689
Author: astroshim 
Date:   2016-07-26T14:24:41Z

show checkbox on interpreter menu.

commit 47ce719eec4076d02eb2895d87f69b2fbc6eaaa5
Author: astroshim 
Date:   2016-07-29T03:15:34Z

remove height style on the checkbox




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1229: [BugFix] Show checkbox for "Connect to existing...

2016-08-01 Thread astroshim

GitHub user astroshim reopened a pull request:

https://github.com/apache/zeppelin/pull/1229

[BugFix] Show checkbox for "Connect to existing process" on interpreter 
menu.

### What is this PR for?
This PR fixes a bug of showing checkbox for "Connect to existing process" 
on interpreter menu.


### What type of PR is it?
Bug Fix


### How should this be tested?
Go to interpreter menu and check if checkbox for "Connect to existing 
process" exists.

### Screenshots (if appropriate)
- before

![image](https://cloud.githubusercontent.com/assets/3348133/17141824/aa316672-5388-11e6-952d-50a3769a01a5.png)

- after

![image](https://cloud.githubusercontent.com/assets/3348133/17141840/babfad8c-5388-11e6-9209-e37e252e95b4.png)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin bugfix/showCheckbox

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1229


commit bbc3283c7cf21fa7340887ddc3bf7ba7b5b8f689
Author: astroshim 
Date:   2016-07-26T14:24:41Z

show checkbox on interpreter menu.

commit 47ce719eec4076d02eb2895d87f69b2fbc6eaaa5
Author: astroshim 
Date:   2016-07-29T03:15:34Z

remove height style on the checkbox




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1229: [BugFix] Show checkbox for "Connect to existing proces...

2016-08-01 Thread astroshim

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1229
  
re-trigger CI


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1229: [BugFix] Show checkbox for "Connect to existing...

2016-08-01 Thread astroshim

Github user astroshim closed the pull request at:

https://github.com/apache/zeppelin/pull/1229


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

2016-08-01 Thread khalidhuseynov

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/1254


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

2016-08-01 Thread khalidhuseynov

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/1254

[ZEPPELIN-1257] storage - fix get note revision api

### What is this PR for?
Getting revision of note requires only unique revision id and the whole 
revision object isn't required. This PR is to fix the issue.


### What type of PR is it?
Bug Fix | Improvement

### Todos
* [x] - change storage api
* [x] - modify notebook server

### What is the Jira issue?
[ZEPPELIN-1257](https://issues.apache.org/jira/browse/ZEPPELIN-1257)

### How should this be tested?
Storage layer tests should pass, green CI

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
fix/get-note-revision-api

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1254


commit 96490a29295221a2dbc8f8bac50b5f87cf9bb847
Author: Khalid Huseynov 
Date:   2016-07-31T07:15:08Z

change api Revision -> String (revision id)

commit 3b7868e254bfe338755ebf4a9de8a71ac49db8b8
Author: Khalid Huseynov 
Date:   2016-07-31T07:31:39Z

change Revision -> String in NotebookServer

commit 1bab6a4c9b3bbca958c540c6c6cfd4e012504270
Author: Khalid Huseynov 
Date:   2016-07-31T07:37:46Z

consistency check: NotebookRepo.Revision -> Revision

commit f14c15afb59da0e2c7bdab0cd443653276cdbbfc
Author: Khalid Huseynov 
Date:   2016-08-01T04:59:16Z

fix tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1231: [Zeppelin - 683][WIP] BittorrentNotebookRepo

2016-08-01 Thread bzz

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1231
  
Sorry, was quite a busy week.

Great progress so far, from the first glance and on the formal side of the 
contribution:

 1. CI is failing, could you please post here the reason of failure? You 
can find it by browsing the logs of TravisCI

 2. Every new file that you add must have an Apache 2.0 licence header, 
could yo uplease add them?

 3. Every dependency you add pom.xml need to be verified to have [Apache 
2.0 compatible license](http://www.apache.org/legal/resolved.html#category-a)

 4. Every dependency you add pom.xml AND it's transitive dependencies which 
you can see with `mvn dependency:tree` will be part of the final release 
convenience binary so it's licenses must be recorded under 
[zeppelin-distribution/src/bin-license/LICENSE](https://github.com/apache/zeppelin/blob/master/zeppelin-distribution/src/bin_license/LICENSE)

Please address this feedback and I will look more into the design tommorow 
and let you know!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1249: [ZEPPELIN-1255] Add cast to string in z.show() ...

2016-08-01 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1249


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...

2016-08-01 Thread bzz

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1239
  
Looks great to me.

CI failure:
```
[INFO] Zeppelin: web Application .. FAILURE [02:13 
min]
...
[INFO] Running 'grunt build --no-color' in 
/home/travis/build/apache/zeppelin/zeppelin-web
[INFO] Running "jscs:all" (jscs) task
[INFO] >> 32 files without code style errors.
[INFO] 
[INFO] Running "jscs:test" (jscs) task
[INFO] >> 6 files without code style errors.
[INFO] 
[INFO] Running "eslint:all" (eslint) task
[INFO] Warning: Cannot find module './utils' Use --force to continue.
[INFO] 
[INFO] Aborted due to warnings.
[INFO] 
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1254: [ZEPPELIN-1257] storage - fix get note revision api

2016-08-01 Thread bzz

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1254
  
@khalidhuseynov glad to hear. But CI is red again, could you, as an author 
of PR please post here the reason of failure? This will save time for the 
reviewers.

And thank you for kind for the explanation!

> The point of this PR was not to send unnecessary info in the Revision 
object

This is exactly what I meant by "changes for the sake of changes".

Revision class implementation that you point out looks good to me - it 
represents clearly defined interface with it's own responsibilities. But String 
does the contrary. May be this class is even big enough to deserve his own 
file. And other clients may choose to replace it with their own 
implementations. I would understand if you suggest to extract it to the 
interface - this will bring even more flexibility (but increase verbosity). 

But replacing it with the `String` does not look good to me.


After some thinking - may be I lack verbal skills to convey the message 
about obejct-oriented design approach. If that is the case, please check `Item 
50: Avoid strings where other types are more appropriate`, page 224 of 
"Effective Java" 2nd edition and let me know.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1255: Adding extra libraries to livy

2016-08-01 Thread jimdowling

Github user jimdowling commented on the issue:

https://github.com/apache/zeppelin/pull/1255
  
@zjffdu - I don't think there's a ZeppelinContext available in Livy. Would 
this be acceptable until the ZeppelinContext becomes available? As of now, Livy 
is not that much use if you cannot add libraries to your Spark app.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...

2016-08-01 Thread jongyoul

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1239
  
Rebased it 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...

2016-08-01 Thread minahlee

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1239
  
Confirm that bug is gone. @jongyoul Could you rebase before merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1244: [ZEPPELIN-1251] Update interpreter artifact opt...

2016-08-01 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1244


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1236: [ZEPPELIN-1237] Auto-suggestion of notebook permission...

2016-08-01 Thread rconline

Github user rconline commented on the issue:

https://github.com/apache/zeppelin/pull/1236
  
@felixcheung i think this will continue to remain a problem, till the time 
we allow all user roles to setup/modify these permissions. Unless we can 
recognize and separate this as an admin (superuser) action, this seems okay to 
me. There will be cases when the LDAP user id's will end up in zeppelin/POSIX 
systems as 'a1890xx', based upon conversion rules, when users who setup these 
permissions will find it very hard to use. Hence for now, showing all users is 
a reasonable approach. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1228: ZEPPELIN-1175. AM log is not available for yarn...

2016-08-01 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1228


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1246: [MINOR] Fix missing validation on interpreter p...

2016-08-01 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1246


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1254: [ZEPPELIN-1257] storage - fix get note revision api

2016-08-01 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1254
  
@bzz CI failure was due to test, fixed now.

Further, regarding the flexibility and narrowing scope. Revision class is 
implemented 
[here](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java#L106)
 and as you can see currently when implementing your own NotebookRepo you reuse 
same class (without implementing your own one). Implementing your own revision 
class is a good idea which is not supported yet (it should be handled properly 
in frontend as well). 

The point of this PR was not to send unnecessary info in the Revision 
object since only thing to identify the revision is supposed to be its 
revisionId and it being String seems at least intuitive since noteId, and 
paragraphId are identified in the same way by String id. So having noteId, 
revisionId should uniquely identify the revision. Can you give some example of 
ID that's more than one element and not presented as string?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1256: [ ZEPPELIN-1259 ] create ace.editor configurati...

2016-08-01 Thread cloverhearts

GitHub user cloverhearts opened a pull request:

https://github.com/apache/zeppelin/pull/1256

[ ZEPPELIN-1259 ] create ace.editor configuration manager service object

### What is this PR for?
https://github.com/apache/zeppelin/pull/1218
Establish a foundation to personalize the code editor settings.
Remove and set of ace.editor included in paragraph.controller.js.

### What type of PR is it?
Improve

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1259

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin dev/ZEPPELIN-1259

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1256


commit 912f1a0d48568d598cd16c9a1694255ae9f7c775
Author: CloverHearts 
Date:   2016-08-01T05:54:06Z

editor configuration in pargaraph.controller.js -> service object




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

38 matches

Mail list logo