[GitHub] zeppelin issue #1257: [Zeppelin-945] Interpreter authorization

[astroshim]

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1257
  
@AhyoungRyu I fixed you pointed out and I'll create the document for this 
separated PR. 
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1274: [HOTFIX][ZEPPELIN-1240] Part 2. Removed interpreter pr...

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1274
  
This is merged to branch-0.6. @jongyoul do you mind to close it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1287) No need to call print to display output in PythonInterpreter

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-1287:


 Summary: No need to call print to display output in 
PythonInterpreter
 Key: ZEPPELIN-1287
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1287
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.6.0
Reporter: Jeff Zhang
Assignee: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1257: [Zeppelin-945] Interpreter authorization

[astroshim]

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1257
  
@AhyoungRyu Let me check. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1257: [Zeppelin-945] Interpreter authorization

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1257
  
@astroshim 
>Does this needs documentation? no

I think we need a documentation for "Interpreter Authorization" feature 
like we have below docs pages.
 - 
[security/notebook_authorization.html](http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/notebook_authorization.html)
 - 
[security/datasource_authorization.html](http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/datasource_authorization.html)
 
But separated PR would be okay i think :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter pro...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1239


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1274: [HOTFIX][ZEPPELIN-1240] Part 2. Removed interpreter pr...

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1274
  
Tested and looks good to me. Merge if there is no more discussion

FYI, there are test failure in 3 build profiles, and all of them seems 
irrelevant to this PR. Here are the logs of test failure:

Profile#1
```
[ERROR] Failed to execute goal on project zeppelin-livy: Could not resolve 
dependencies for project org.apache.zeppelin:zeppelin-livy:jar:0.6.1-SNAPSHOT: 
Could not transfer artifact org.apache.httpcomponents:httpclient:jar:4.3.4 
from/to central (http://repo.maven.apache.org/maven2): GET request of: 
org/apache/httpcomponents/httpclient/4.3.4/httpclient-4.3.4.jar from central 
failed: Connection reset -> [Help 1]
```

Profile#2
```
testClose(org.apache.zeppelin.python.PythonInterpreterTest)  Time elapsed: 
0.517 sec  <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at org.junit.Assert.assertFalse(Assert.java:74)
at 
org.apache.zeppelin.python.PythonInterpreterTest.testClose(PythonInterpreterTest.java:170)


Results :

Failed tests: 
  PythonInterpreterTest.testClose:170 null

Tests run: 5, Failures: 1, Errors: 0, Skipped: 0
```

Profile#3
```
Run starting. Expected test count is: 18
AngularModelTest:
AngularModel
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in 
[jar:file:/home/travis/build/apache/zeppelin/zeppelin-interpreter/target/zeppelin-interpreter-0.6.1-SNAPSHOT.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in 
[jar:file:/home/travis/build/apache/zeppelin/zeppelin-interpreter/target/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in 
[jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
- should able to create AngularObject
AngularModel
- should able to update AngularObject
AngularModel
- should able to remove AngularObject
AngularModelTest:
AngularModel
- should able to create AngularObject
AngularModel
- should able to update AngularObject
AngularModel
- should able to remove AngularObject
AngularElemTest:
AngularElem
- should provide onclick method *** FAILED ***
  The code passed to eventually never returned normally. Attempted 1 
times over 160.87031 milliseconds. Last failure message: 0 was not equal to 1. 
(AbstractAngularElemTest.scala:72)
AngularElem
- should print angular display directive only once in a paragraph
AngularElem
- should bind angularObject to ng-model directive
AngularElem
- should able to disassociate AngularObjects
AngularElem
- should allow access to InterpreterContext inside of callback 
function
AngularElem
- should able to be created from implicit conversion
AngularElemTest:
AngularElem
- should provide onclick method
AngularElem
- should print angular display directive only once in a paragraph
AngularElem
- should bind angularObject to ng-model directive
AngularElem
- should able to disassociate AngularObjects
AngularElem
- should allow access to InterpreterContext inside of callback 
function
AngularElem
- should able to be created from implicit conversion
Run completed in 659 milliseconds.
Total number of tests run: 18
Suites: completed 5, aborted 0
Tests: succeeded 17, failed 1, canceled 0, ignored 0, pending 0
*** 1 TEST FAILED ***
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1257: [Zeppelin-945] Interpreter authorization

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1257
  
@astroshim Awesome. I saw many people have talked about this feature :) I 
tested your patch locally, it works well as expected. But I found one issue 
regarding user suggestion,


![search_users](https://cloud.githubusercontent.com/assets/10060731/17391248/9988cb26-5a4f-11e6-9f4b-e22bff5be46c.gif)

The suggestion list doesn't disappear after pressing `Enter` key. Could you 
check this out?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1276: Add Highcharts support

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1276
  
Yes, I think it's better to close this and resolve the JIRA issue. And then 
create a new one for Helium App and post a link it here. This work will still 
be accessible so people who are interested in it as well could join efforts 
with you and build a great app.

Thanks and please do not hesitate to ask questions on Helium on the dev 
mailing list!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Invalid ticket error fills up zeppelin log when anoymous access if

[Jongyoul Lee]

I also saw it.

Can you file a new JIRA issue for it?

On Thu, Aug 4, 2016 at 1:37 PM, Sachin Janani  wrote:

> I also saw the same bug.It occurs when shiro authentication was enabled and
> someone tries to change interpreter settings.This stacktrace is more
> frequent and never stops.In spite of this everything works fine.It seems
> like a bug
>
> On Thu, Aug 4, 2016 at 5:09 AM, Weipu Zhao 
> wrote:
>
> > Hi,
> >
> > When I play around with Zeppelin 0.6.0 release with Shiro following
> > instructions in here
> >  >,
> > if
> > I just open the home page but don't login, I see the following ERROR
> > message keep show up periodically (every 10s) in zeppelin log, which
> could
> > potentially fill up this log file with this same error and make it really
> > hard to trace the real error message:
> >
> >
> > ERROR [2016-08-03 16:34:09,471] ({qtp636329330-37}
> > NotebookServer.java[onMessage]:211) - Can't handle message
> > java.lang.Exception: Invalid ticket  !=
> > 5d56af6b-a49c-4dc1-9723-abf47876c389
> > at
> >
> >
> org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:117)
> > at
> >
> >
> org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:56)
> > at
> >
> >
> org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128)
> > at
> >
> >
> org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69)
> > at
> >
> >
> org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65)
> > at
> >
> >
> org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122)
> > at
> >
> >
> org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161)
> > at
> >
> >
> org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309)
> > at
> >
> >
> org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214)
> > at org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220)
> > at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258)
> > at
> >
> >
> org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632)
> > at
> >
> >
> org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480)
> > at
> >
> org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
> > at
> >
> >
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
> > at
> >
> >
> org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
> > at java.lang.Thread.run(Thread.java:745)
> >
> >
> > Am I missing some configurations? Is this expected? I'm happy to file a
> bug
> > for this.
> >
> > Thanks,
> > Weipu
> >
>



-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net

[GitHub] zeppelin pull request #1276: Add Highcharts support

[rockiey]

Github user rockiey closed the pull request at:

https://github.com/apache/zeppelin/pull/1276


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1276: Add Highcharts support

[rockiey]

Github user rockiey commented on the issue:

https://github.com/apache/zeppelin/pull/1276
  
@bzz Thanks very much for clarification. So this PR shall be closed?

I will check the Helium framework. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1277: [ZEPPELIN-1257] Decouple revision id handling

[khalidhuseynov]

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1277
  
@bzz this is different approach to the problems you mentioned in #1254. 
Here i decouple Revision from RevisionId class and make the latter one generic 
so that developers can provide their own implementation of it. Please let me 
know whether it makes more sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

[khalidhuseynov]

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/1254


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Invalid ticket error fills up zeppelin log when anoymous access if

[Sachin Janani]

I also saw the same bug.It occurs when shiro authentication was enabled and
someone tries to change interpreter settings.This stacktrace is more
frequent and never stops.In spite of this everything works fine.It seems
like a bug

On Thu, Aug 4, 2016 at 5:09 AM, Weipu Zhao  wrote:

> Hi,
>
> When I play around with Zeppelin 0.6.0 release with Shiro following
> instructions in here
> ,
> if
> I just open the home page but don't login, I see the following ERROR
> message keep show up periodically (every 10s) in zeppelin log, which could
> potentially fill up this log file with this same error and make it really
> hard to trace the real error message:
>
>
> ERROR [2016-08-03 16:34:09,471] ({qtp636329330-37}
> NotebookServer.java[onMessage]:211) - Can't handle message
> java.lang.Exception: Invalid ticket  !=
> 5d56af6b-a49c-4dc1-9723-abf47876c389
> at
>
> org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:117)
> at
>
> org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:56)
> at
>
> org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128)
> at
>
> org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69)
> at
>
> org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65)
> at
>
> org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122)
> at
>
> org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161)
> at
>
> org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309)
> at
>
> org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214)
> at org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220)
> at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258)
> at
>
> org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632)
> at
>
> org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480)
> at
> org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
> at
>
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
> at
>
> org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
> at java.lang.Thread.run(Thread.java:745)
>
>
> Am I missing some configurations? Is this expected? I'm happy to file a bug
> for this.
>
> Thanks,
> Weipu
>

[GitHub] zeppelin issue #1276: Add Highcharts support

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1276
  
@rockiey I have just updated the comment above.

What I would suggest is - please take a look at [Helium 
framework](https://github.com/apache/zeppelin/tree/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/helium)
 inside Apache Zeppelin. 
It is under development right now, here are some 
[materials](https://cwiki.apache.org/confluence/display/ZEPPELIN/Helium+proposal)
 that [might 
help](http://www.slideshare.net/HadoopSummit/apache-zeppelin-helium-and-beyond) 
to understand it better.

It is possible to wrap your work as a Helium Application and distribute it 
outside of ASF codebase, but user will still be able to get easy access to it 
(and benefit from the awesomeness of highchart at his own risk)

This better be done in a separate PR. Let me know what you think!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1276: Add Highcharts support

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1276
  
@rockiey thank you for contributing!

Highcharts is a great library, but I belive it will be hard to include it 
as a dependency to ASF project.

If highchart gets included to project codebase, it will end up in 
convenience release binary the project that is distributed by ASF, so we must 
make sure that it's license complies with legal requirements from Apache 
Software Foundation.

Here is a process that needs to be done, in order to archive the compliance:
 - verify that it's license belongs to ASF 
[category-a](http://www.apache.org/legal/resolved.html#category-a) license, if 
that is the case - it can be included as dependency. Then
 - full text of the license must be included in the 
`zeppelin-distribution/src/bin_license/licenses`,  then
 - record must be added to `zeppelin-distribution/src/bin_license/LICENSE`
 - copyrights notice, in case it exists needs to be recorded in 
`zeppelin-distribution/src/bin_license/NOTICE` 


Looking at https://github.com/knockdata/zeppelin-highcharts - it looks 
great and it does acutally make a lot of sence to have it as separate binary, 
so that user can add it at his own will (and be responsible for adhering it's 
licence terms).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1272: Remove empty user when put permission

[zhangmq]

Github user zhangmq closed the pull request at:

https://github.com/apache/zeppelin/pull/1272


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1275: Small refactoring of Python interpreter

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1275
  
Thank you @minahlee for prompt review!

CI fails on spark 1.6 profile, same as master, and #1263  handled under 
[ZEPPELIN-1286](https://issues.apache.org/jira/browse/ZEPPELIN-1286)

Merging if there is no further discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1275: Small refactoring of Python interpreter

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1275
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1273: [Zeppelin-1276] Fix Notebook Title Input

[corneadoug]

Github user corneadoug closed the pull request at:

https://github.com/apache/zeppelin/pull/1273


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1273: [Zeppelin-1276] Fix Notebook Title Input

[corneadoug]

GitHub user corneadoug reopened a pull request:

https://github.com/apache/zeppelin/pull/1273

[Zeppelin-1276] Fix Notebook Title Input

### What is this PR for?
The Notebook Title Input would not disappear after being edited.
This is a problem made by its plugin elastic-input.
We originally used ng-if instead of ng-show so it doesn't break the Page 
Print, however that change made the scope value to toggle unusable.
So we added a trustworthy small controller on top of the component.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1276

### How should this be tested?
* Click on the Notebook title
* Try to do: Enter or Esc or Click somewhere else
* The Input border should not be there anymore
* Do the same for the Paragraph
* If you do Print Page there shouldn't any titles duplicated at the top

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1276

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1273.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1273


commit b862081c8b74632fc472fe45911a8cffbbdc7d12
Author: Damien CORNEAU 
Date:   2016-08-03T07:34:43Z

Fix Notebook input issue

commit d590d825de002bfe519a5859683e4e2c1de464c9
Author: Damien CORNEAU 
Date:   2016-08-03T07:39:43Z

apply same input changes to the paragraph

commit 24df51f684c5caf97d3ef9d646afe30defc2aedb
Author: Damien CORNEAU 
Date:   2016-08-03T07:43:10Z

Fix eslint errors




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

[anthonycorbacho]

Github user anthonycorbacho commented on the issue:

https://github.com/apache/zeppelin/pull/1173
  
@jongyoul sure, no problemo
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1286) CI for Spark 1.6 fails on master & all PRs

[Alexander Bezzubov (JIRA)]

Alexander Bezzubov created ZEPPELIN-1286:


 Summary: CI for Spark 1.6 fails on master & all PRs
 Key: ZEPPELIN-1286
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1286
 Project: Zeppelin
  Issue Type: Bug
Reporter: Alexander Bezzubov


2nd CI profile, responsible for Spark 1.6 fails on all PRs

{code}
Running org.apache.zeppelin.spark.SparkInterpreterTest
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in 
[jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in 
[jar:file:/home/travis/build/apache/zeppelin/zeppelin-interpreter/target/zeppelin-interpreter-0.7.0-SNAPSHOT.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in 
[jar:file:/home/travis/build/apache/zeppelin/zeppelin-interpreter/target/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
log4j:WARN No appenders could be found for logger 
(org.apache.zeppelin.interpreter.Interpreter).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 14, Failures: 0, Errors: 14, Skipped: 0, Time elapsed: 10.953 sec 
<<< FAILURE! - in org.apache.zeppelin.spark.SparkInterpreterTest
emptyConfigurationVariablesOnlyForNonSparkProperties(org.apache.zeppelin.spark.SparkInterpreterTest)
  Time elapsed: 7.078 sec  <<< ERROR!
java.lang.NullPointerException: null
at 
org.apache.zeppelin.spark.SparkInterpreter.createSparkSession(SparkInterpreter.java:308)
at 
org.apache.zeppelin.spark.SparkInterpreter.getSparkSession(SparkInterpreter.java:220)
at 
org.apache.zeppelin.spark.SparkInterpreter.open(SparkInterpreter.java:731)
at 
org.apache.zeppelin.spark.SparkInterpreterTest.setUp(SparkInterpreterTest.java:93)

shareSingleSparkContext(org.apache.zeppelin.spark.SparkInterpreterTest)  Time 
elapsed: 2.309 sec  <<< ERROR!
java.lang.NullPointerException: null
at 
org.apache.zeppelin.spark.SparkInterpreter.createSparkSession(SparkInterpreter.java:308)
at 
org.apache.zeppelin.spark.SparkInterpreter.getSparkSession(SparkInterpreter.java:220)
at 
org.apache.zeppelin.spark.SparkInterpreter.open(SparkInterpreter.java:731)
at 
org.apache.zeppelin.spark.SparkInterpreterTest.shareSingleSparkContext(SparkInterpreterTest.java:245)

testBasicIntp(org.apache.zeppelin.spark.SparkInterpreterTest)  Time elapsed: 
0.002 sec  <<< ERROR!

Tests in error: 
  SparkInterpreterTest.setUp:93 » NullPointer
  SparkInterpreterTest.shareSingleSparkContext:245 » NullPointer
  SparkInterpreterTest.testBasicIntp:136 » NullPointer
  SparkInterpreterTest.testCreateDataFrame:182 » NullPointer
  SparkInterpreterTest.testDisableImplicitImport:280 » NullPointer
  SparkInterpreterTest.testEnableImplicitImport:264 » NullPointer
  SparkInterpreterTest.testEndWithComment:171 » NullPointer
  SparkInterpreterTest.testListener:176 » NullPointer
  SparkInterpreterTest.testNextLineComments:160 » NullPointer
  SparkInterpreterTest.testNextLineCompanionObject:166 » NullPointer
  SparkInterpreterTest.testNextLineInvocation:155 » NullPointer
  SparkInterpreterTest.testReferencingUndefinedVal:220 » NullPointer
  SparkInterpreterTest.testSparkSql:200 » NullPointer
  SparkInterpreterTest.testZShow:193 » NullPointer
  SparkSqlInterpreterTest.setUp:61 » NullPointer
  SparkSqlInterpreterTest.setUp:61 » NullPointer
  SparkSqlInterpreterTest.setUp:61 » NullPointer

Tests run: 22, Failures: 0, Errors: 17, Skipped: 0
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1260: ZEPPELIN-1267. PySparkInterpreter doesn't work in spar...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1260
  
Let's merge if there is no further discussion!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1270: [ZEPPELIN-1273] Use Math.abs to determine if cu...

[prasadwagle]

GitHub user prasadwagle reopened a pull request:

https://github.com/apache/zeppelin/pull/1270

[ZEPPELIN-1273] Use Math.abs to determine if custom formatter should be 
called for y axis values

### What is this PR for?
Use Math.abs to determine if custom formatter should be called for y axis 
values.


### What type of PR is it?
Bug Fix

### Todos
* [ ] - Task

### What is the Jira issue?
[ZEPPELIN-1273] https://issues.apache.org/jira/browse/ZEPPELIN-1273

### How should this be tested?
Create simple table with two columns - date in one and large negative 
numbers like -1000 in other. Display line chart and see that the y axis 
values are formatted like -10M.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? 
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prasadwagle/incubator-zeppelin ZEPPELIN-1273

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1270


commit 06e12f88e3d39f6b090ad8c9fc346491f9e79908
Author: Prasad Wagle 
Date:   2016-08-03T03:57:13Z

Use Math.abs to determine if custom formatter should be called for y axis 
values

commit 2c62f5669f7a0f45e48ea1a94a8bb39ab7ea00ce
Author: Prasad Wagle 
Date:   2016-08-03T16:53:40Z

Merge branch 'master' into ZEPPELIN-1273




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1270: [ZEPPELIN-1273] Use Math.abs to determine if custom fo...

[prasadwagle]

Github user prasadwagle commented on the issue:

https://github.com/apache/zeppelin/pull/1270
  
> Or do you think we should also apply this to upcoming 0.6.1 as well?
I can do that. What branch should I use for 0.6.1?

I merged with latest master this morning. Two checks in the build failed. 
Any ideas how to fix? I am going to restart the build in case they are due to 
flaky tests.

```
https://travis-ci.org/apache/zeppelin/jobs/149535074

Results :

Failed tests:
  ZeppelinSparkClusterTest.zRunTest:204 expected: but was:


https://travis-ci.org/apache/zeppelin/jobs/149535075

Tests in error:
  SparkInterpreterTest.setUp:93 » NullPointer
  SparkInterpreterTest.shareSingleSparkContext:245 » NullPointer
  SparkInterpreterTest.testBasicIntp:136 » NullPointer
  SparkInterpreterTest.testCreateDataFrame:182 » NullPointer
  SparkInterpreterTest.testDisableImplicitImport:280 » NullPointer
  SparkInterpreterTest.testEnableImplicitImport:264 » NullPointer
  SparkInterpreterTest.testEndWithComment:171 » NullPointer
  SparkInterpreterTest.testListener:176 » NullPointer
  SparkInterpreterTest.testNextLineComments:160 » NullPointer
  SparkInterpreterTest.testNextLineCompanionObject:166 » NullPointer
  SparkInterpreterTest.testNextLineInvocation:155 » NullPointer
  SparkInterpreterTest.testReferencingUndefinedVal:220 » NullPointer
  SparkInterpreterTest.testSparkSql:200 » NullPointer
  SparkInterpreterTest.testZShow:193 » NullPointer
  SparkSqlInterpreterTest.setUp:61 » NullPointer
  SparkSqlInterpreterTest.setUp:61 » NullPointer
  SparkSqlInterpreterTest.setUp:61 » NullPointer
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1270: [ZEPPELIN-1273] Use Math.abs to determine if cu...

[prasadwagle]

Github user prasadwagle closed the pull request at:

https://github.com/apache/zeppelin/pull/1270


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1240: [ZEPPELIN-1246] In JDBCInterpreter.getScheduler, use g...

[prasadwagle]

Github user prasadwagle commented on the issue:

https://github.com/apache/zeppelin/pull/1240
  
I got the latest master with #1261  Two checks in the last build failed. I 
am going to close and reopen PR to restart build.

https://travis-ci.org/apache/zeppelin/jobs/149535134

Failed tests:
  ZeppelinSparkClusterTest.zRunTest:205 expected:<[10]> but was:<[


:28: error: not found: value a
  print(a)
^
]>




https://travis-ci.org/apache/zeppelin/jobs/149535133

java.lang.NullPointerException
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreterEventPoller.run(RemoteInterpreterEventPoller.java:174)


No output has been received in the last 10 minutes, this potentially 
indicates a stalled build or something wrong with the build itself.

The build has been terminated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1240: [ZEPPELIN-1246] In JDBCInterpreter.getScheduler...

[prasadwagle]

Github user prasadwagle closed the pull request at:

https://github.com/apache/zeppelin/pull/1240


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1240: [ZEPPELIN-1246] In JDBCInterpreter.getScheduler...

[prasadwagle]

GitHub user prasadwagle reopened a pull request:

https://github.com/apache/zeppelin/pull/1240

[ZEPPELIN-1246] In JDBCInterpreter.getScheduler, use 
getMaxConcurrentConnection instead of hardcoding maxConcurrency to 10

### What is this PR for?
In JDBCInterpreter.getScheduler, use getMaxConcurrentConnection instead of 
hardcoding maxConcurrency to 10


### What type of PR is it?
Improvement

### Todos
* [ ] - Task

### What is the Jira issue?
[ZEPPELIN-1246] (https://issues.apache.org/jira/browse/ZEPPELIN-1246)

### How should this be tested?
Set zeppelin.jdbc.concurrent.max_connection to 2 and verify after starting 
two long-running queries, a third query is pending.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
No

* Is there breaking changes for older versions?
No

* Does this needs documentation?
No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prasadwagle/incubator-zeppelin ZEPPELIN-1246

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1240.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1240


commit 62affdfd77a03f597acfc304280d8c40f3a796af
Author: Prasad Wagle 
Date:   2016-07-28T21:27:15Z

In JDBCInterpreter.getScheduler, use getMaxConcurrentConnection instead of 
hardcoding maxConcurrency to 10

commit 449245a93f87c8140379b991011587bcf3550873
Author: Prasad Wagle 
Date:   2016-08-03T16:51:48Z

Merge branch 'master' into ZEPPELIN-1246




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1284) Unable to run paragraph with default interpreter

[Kavin Kumar (JIRA)]

Kavin Kumar created ZEPPELIN-1284:
-

 Summary: Unable to run paragraph with default interpreter
 Key: ZEPPELIN-1284
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1284
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-interpreter
Affects Versions: 0.7.0
Reporter: Kavin Kumar
Priority: Critical


I have built zeppelin from 0.7.0-SNAPSHOT and ran the first paragraph under 
"Zeppelin Tutorial" or my own paragraph with another note which has the default 
interpreter settings.It threw the below error, could someone help on this?

{code}
==> logs/zeppelin-kavink-IMCHLT195.log <==
 INFO [2016-08-03 23:57:25,412] ({pool-2-thread-2} 
SchedulerFactory.java[jobStarted]:131) - Job 
paragraph_1470209854642_-1411652818 started by scheduler 
org.apache.zeppelin.interpreter.remote.RemoteInterpretershared_session339036079
 INFO [2016-08-03 23:57:25,414] ({pool-2-thread-2} Paragraph.java[jobRun]:282) 
- run paragraph 20160803-130734_1169603883 using spark 
org.apache.zeppelin.interpreter.LazyOpenInterpreter@4ef3ddcb
 INFO [2016-08-03 23:57:25,433] ({pool-2-thread-2} 
RemoteInterpreterManagedProcess.java[start]:116) - Run interpreter process 
[/home/kavink/git/zeppelin/bin/interpreter.sh, -d, 
/home/kavink/git/zeppelin/interpreter/spark, -p, 39797, -l, 
/home/kavink/git/zeppelin/local-repo/2BSQR4ASJ]
ERROR [2016-08-03 23:57:25,454] ({qtp158453976-19} 
ResourcePoolUtils.java[getAllResourcesExcept]:64) - 
java.lang.NullPointerException
at 
org.apache.zeppelin.resource.ResourcePoolUtils.getAllResourcesExcept(ResourcePoolUtils.java:58)
at 
org.apache.zeppelin.resource.ResourcePoolUtils.getAllResources(ResourcePoolUtils.java:36)
at org.apache.zeppelin.helium.Helium.suggestApp(Helium.java:153)
at org.apache.zeppelin.rest.HeliumRestApi.suggest(HeliumRestApi.java:83)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180)
at 
org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96)
at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:192)
at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:100)
at 
org.apache.cxf.interceptor.ServiceInvokerInterceptor$1.run(ServiceInvokerInterceptor.java:57)
at 
org.apache.cxf.interceptor.ServiceInvokerInterceptor.handleMessage(ServiceInvokerInterceptor.java:93)
at 
org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:272)
at 
org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
at 
org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:239)
at 
org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:248)
at 
org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:222)
at 
org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:153)
at 
org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:167)
at 
org.apache.cxf.transport.servlet.AbstractHTTPServlet.handleRequest(AbstractHTTPServlet.java:286)
at 
org.apache.cxf.transport.servlet.AbstractHTTPServlet.doGet(AbstractHTTPServlet.java:211)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:575)
at 
org.apache.cxf.transport.servlet.AbstractHTTPServlet.service(AbstractHTTPServlet.java:262)
at 
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:812)
at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)
at 
org.apache.shiro.web.servlet.ProxiedFilterChain.doFilter(ProxiedFilterChain.java:61)
at 
org.apache.shiro.web.servlet.AdviceFilter.executeChain(AdviceFilter.java:108)
at 
org.apache.shiro.web.servlet.AdviceFilter.doFilterInternal(AdviceFilter.java:137)
at 
org.apache.shiro.web.servlet.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:125)
at 
org.apache.shiro.web.servlet.ProxiedFilterChain.doFilter(ProxiedFilterChain.java:66)
at 
org.apache.shiro.web.servlet.AbstractShiroFilter.executeChain(AbstractShiroFilter.java:449)
at 
org.apache.shiro.web.servlet.AbstractShiroFilter$1.call(AbstractShiroFilter.java:365)
at 
org.apache.shiro.subject.support.SubjectCallable.doCall(SubjectCallable.java:90)
at 
org.apache.shiro.subject.support.SubjectCallable.call(Subject

Re: [GitHub] zeppelin pull request #1259: [ZEPPELIN-1260] R interpreter doesn't work with...

[Sourav Mazumder]

Hi,

Is this now put back to the main branch ?

Or do I need to pull this from ZEPPELIN-1260 ?

Regards,
Sourav

On Tue, Aug 2, 2016 at 2:38 AM, Leemoonsoo  wrote:

> GitHub user Leemoonsoo opened a pull request:
>
> https://github.com/apache/zeppelin/pull/1259
>
> [ZEPPELIN-1260] R interpreter doesn't work with Spark 2.0
>
> ### What is this PR for?
> This PR fixes R interpreter doesn't work with Spark 2.0
>
>
> ### What type of PR is it?
> Bug Fix
>
> ### Todos
> * [x] - Create and inject SparkSession into SparkRInterpreter
>
> ### What is the Jira issue?
> https://issues.apache.org/jira/browse/ZEPPELIN-1260
>
> ### How should this be tested?
> Run Zeppelin with Spark 2.0 and run following codes and see if it
> returns `[1] 3`
> ```
> %r
> localDF <- data.frame(name=c("a", "b", "c"), age=c(19, 23, 18))
> df <- createDataFrame(spark, localDF)
> count(df)
> ```
>
> ### Screenshots (if appropriate)
> ![image](
> https://cloud.githubusercontent.com/assets/1540981/17324196/fbf3df6c-586a-11e6-896f-68fd86e630e8.png
> )
>
> ### Questions:
> * Does the licenses files need update? no
> * Is there breaking changes for older versions? no
> * Does this needs documentation? no
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-1260
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/zeppelin/pull/1259.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #1259
>
> 
> commit 6bd112811d81aa871b077c655fa0980802e3bc71
> Author: Lee moon soo 
> Date:   2016-08-02T09:30:23Z
>
> Create and inject spark session into sparkr interpreter
>
> 
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] zeppelin issue #1187: [ZEPPELIN-1163] Change some parameter name properly in...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1187
  
@zmhassan Can you handle it soon?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1173
  
@anthonycorbacho I've tried to merge this PR into master and branch-0.6. 
I've succeeded to merge it into master but failed doing into branch-0.6. Is it 
OK?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1173: [ZEPPELIN-1164] ZeppelinHub Realm

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1173


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1168: [MINOR] Add formatter

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1168
  
checkstyle in my PR is too strict and if we push it, too many error occurs 
while checking style. I don't know how to handle with it. What do you think of 
it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1262: [ZEPPELIN-1268]

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1262
  
In the backend part, it looks good. But I suggest you add unit test for 
that api and docs for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1242: [ZEPPELIN-960] When there is no interpreter, paragraph...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1242
  
I suggest you'd better refactor `runAll` in order to call `run(paragraph)`. 
`runAll` actually submits all paragraphs into scheduler. How about it? In a api 
part, it looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1271: [ZEPPELIN-1274]Write "Spark SQL" in docs rather than "...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1271
  
Merging if there's no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1226: Fix logger class name to correct one

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1226


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

[mwpenny]

Github user mwpenny commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
I have made the changes/fixes you mentioned and rebased with master. I can 
create the PR for the documentation after this is merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1245: ZEPPELIN-1225. Errors before the last shell command ar...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1245
  
@zjffdu Could you please close this PR by yourself? It was merged 4 days 
ago but it's not affected into master then asfgit could not close it 
automatically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1234: [ZEPPELIN-1234] Fix issue related to indefinite...

[SachinJanani]

Github user SachinJanani closed the pull request at:

https://github.com/apache/zeppelin/pull/1234


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1234: [ZEPPELIN-1234] Fix issue related to indefinite waitin...

[SachinJanani]

Github user SachinJanani commented on the issue:

https://github.com/apache/zeppelin/pull/1234
  
@jongyoul Sure I will close it now.Thanks 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1283) SQL generated scatterplots should allow labels

[Alexander Grounds (JIRA)]

Alexander Grounds created ZEPPELIN-1283:
---

 Summary: SQL generated scatterplots should allow labels
 Key: ZEPPELIN-1283
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1283
 Project: Zeppelin
  Issue Type: Improvement
  Components: GUI
Reporter: Alexander Grounds
Priority: Minor


When a user generates a scatterplot from an SQL query, it should be possible to 
specify a "label" column. When the user mouses over a point on the plot, the 
label should be displayed.

For instance, a user might wish to generate a scatterplot comparing the average 
lifespan of a person living in some country to the GDP of that country. Since 
each point on the scatterplot represents a country, the user should be able to 
specify a "CountryName" column for the labels, and when a user mouses over a 
point, the name of the country should be displayed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1234: [ZEPPELIN-1234] Fix issue related to indefinite waitin...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1234
  
@SachinJanani This PR is merged into branch-0.6 but I think you will close 
this PR by yourself because this is not merged into master. Can you do it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1232: ZEPPELIN-1197. Should print output directly without in...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1232
  
@zjffdu @bzz How about bring this change to [python 
interpreter](https://github.com/apache/zeppelin/tree/master/python) as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1232: ZEPPELIN-1197. Should print output directly wit...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1232


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1247: ZEPPELIN-1254 Make get and save Interpreter bindings c...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1247
  
But I think this is not proper scope of this PR. We need to open discussion 
on it. Your PR looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1247: ZEPPELIN-1254 Make get and save Interpreter bindings c...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1247
  
@r-kamath Of course, it's good to support some apis with websocket, 
basically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1247: ZEPPELIN-1254 Make get and save Interpreter bindings c...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1247
  
@r-kamath Actually, I don't know well how much efficient we change rest api 
to websocket because I'm not at front-end. I just wonder if we should keep two 
different entry point with exact same function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1247: ZEPPELIN-1254 Make get and save Interpreter bindings c...

[r-kamath]

Github user r-kamath commented on the issue:

https://github.com/apache/zeppelin/pull/1247
  
@jongyoul Yes. we should keep both


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1243: [ZEPPELIN-1250] remove 2.11 suffix from zeppelin-serve...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1243
  
I have a question. Is it unrelated to test for zeppelin-server? 
zeppelin-server uses scala while testing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1240: [ZEPPELIN-1246] In JDBCInterpreter.getScheduler, use g...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1240
  
That error is handling with #1261


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1234: [ZEPPELIN-1234] Fix issue related to indefinite waitin...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1234
  
@SachinJanani Thanks for doing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1234: [ZEPPELIN-1234] Fix issue related to indefinite waitin...

[SachinJanani]

Github user SachinJanani commented on the issue:

https://github.com/apache/zeppelin/pull/1234
  
@jongyoul I revised the PR title and its description


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1234: [ZEPPELIN-1234] Fix for bug ZEPPELIN-1234

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1234
  
@SachinJanani Could you please revise the title of this PR? The title will 
be the first commit message and I think you need to revise them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1234: [ZEPPELIN-1234] Fix for bug ZEPPELIN-1234

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1234
  
I've tested it. LGTM. merging if there's no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1262: [ZEPPELIN-1268]

[kavinkumarks]

Github user kavinkumarks commented on the issue:

https://github.com/apache/zeppelin/pull/1262
  
@corneadoug thanks for the update.I will remove the changes done for 
it.Could someone review the other change that I have done as part of this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1282) [EMR] Documents for running zeppelin on production environments

[Ahyoung (JIRA)]

Ahyoung created ZEPPELIN-1282:
-

 Summary: [EMR] Documents for running zeppelin on production 
environments
 Key: ZEPPELIN-1282
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1282
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Ahyoung






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZEPPELIN-1281) [CDH] Documents for running zeppelin on production environments

[Ahyoung (JIRA)]

Ahyoung created ZEPPELIN-1281:
-

 Summary: [CDH] Documents for running zeppelin on production 
environments
 Key: ZEPPELIN-1281
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1281
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Ahyoung






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZEPPELIN-1280) Documents for running zeppelin with Spark on YARN mode

[Ahyoung (JIRA)]

Ahyoung created ZEPPELIN-1280:
-

 Summary: Documents for running zeppelin with Spark on YARN mode
 Key: ZEPPELIN-1280
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1280
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Ahyoung






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZEPPELIN-1279) Documents for running zeppelin on Spark clusters managed by Apache Mesos

[Ahyoung (JIRA)]

Ahyoung created ZEPPELIN-1279:
-

 Summary: Documents for running zeppelin on Spark clusters managed 
by Apache Mesos
 Key: ZEPPELIN-1279
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1279
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Ahyoung






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1231: [Zeppelin - 683][WIP] BittorrentNotebookRepo

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1231
  
@onkarshedge thank you for drawing very nice diagram.

Let me be very clear - you did a great job and quite possible that it is 
me, as a mentor who under communicate the expectations about the architecture 
for this project. But..

But in order to make your work useful for the project in the nearest 
future, this PR must not introduce new client-facing APIs, servlets or change 
the existing filesystem structure a lot.

So we need to refactor your implementation and simplify, so it has a single 
entry point `BittorentNotebookRepo`, a class that implements `NotebookRepo`, 
that is both a server and a client for bittorrent protocol, and that has all 
the code necessary for:
 1. listing existing notes that shared through Bittorrent (local FS cache 
of the latest version?)
 2. checkpointing AKA creating revisions (and how use `Mutable Items`  to 
[store them in DHT](http://bittorrent.org/beps/bep_0044.html))
 3. listing revisions for each note, stored in DHT
 4. importing new note by magnet URL (should work similar to current 
"import by URL")

Lifecycle of all objects that are needed to perform this task (i.e 
TorrentEngine and all others) must be tied to NotebookRepo lifecycle: 
 - all connections must be opened from it's constructor
 - all connections must be closed from `.close()`

Please let me know if that makes sense to you. 

Let's start by finding answers to the questions on how to do 1-4 on DHT. 
Let's write answers down in English first, here or on the GDoc, before 
moving on to coding\refactoring them in a programming language.

Please think about it and let me know if you have question - we can 
schedule a call.
  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1218
  
Shall we close this one now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1168: [MINOR] Add formatter

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1168
  
Sounds good! Let's rebase on master and make CI happy again first? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #928: [ZEPPELIN-116] Add Apache Mahout Interpreter

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/928
  
@rawkintrevo you did titanic job, struggling with CI here.. but now, after 
Spark 2.0 and Scala 2.11 support got merged CI fails even on *master*

Would it make sense to take a break until 0.6.1 gets released and master 
get's sustainably green?

I'm sure we are going finish this one very fast as soon as it's done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #989: Added ipfsnotebookrepo [ Zeppelin-683 WIP ]

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/989
  
ping @onkarshedge 

Could you please follow 
https://github.com/apache/zeppelin/pull/989#issuecomment-230972882 and update 
this PR




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1275: Small refactoring of Python interpreter

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1275
  
Ready to be merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1207: [DOC][ZEPPELIN-1209] Remove a useless sentence ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1207


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1274: [HOTFIX][ZEPPELIN-1240] Part 2. Removed interpr...

[jongyoul]

GitHub user jongyoul opened a pull request:

https://github.com/apache/zeppelin/pull/1274

[HOTFIX][ZEPPELIN-1240] Part 2. Removed interpreter properties are restored

### What is this PR for?
Fixing the bug that users cannot delete some interpreter settings from 
interpreter tab. This is second part of ZEPPELIN-1240 for branch-0.6 only

### What type of PR is it?
[Bug Fix | Hot Fix]

### Todos
* [x] - Changed `update` to `set`

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1240

### How should this be tested?
1. Make new interpreter via interpreter tab
1. remove some properties

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1240-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1274.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1274


commit a819261fb5eaaa82aae98e5427e882c459e44744
Author: Jongyoul Lee 
Date:   2016-08-03T08:39:33Z

Enabled removing some properties provided by default




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1265: [ZEPPELIN-1210] Run interpreter per user

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1265
  
@echarles For now, Zeppelin supports `per note` option but doesn't do `per 
user`. If two different users log in Zeppelin and want to use same spark 
interpreter with same note, they cannot run a paragraph simultaneously. This PR 
enable that feature. Concerning ZEPPELIN-1000, I don't know the meaning of the 
management of single user exactly. AFAIK, Zeppelin manages multiple users at 
the same time. Could you please describe in details? I think you'd better 
answer the moon's statement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1239: [HOTFIX][ZEPPELIN-1240] Removed interpreter properties...

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1239
  
Tested, looks good to me. I have one question. Seems like the issue exists 
both in `master` and `branch-0.6` branch, will this patch be applicable to 
branch-0.6 or shall we create another PR targeting branch-0.6?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1273: [Zeppelin-1276] Fix Notebook Title Input

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1273
  
Tried locally and renaming notebook works now as expected.

Looks great to me. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1231: [Zeppelin - 683][WIP] BittorrentNotebookRepo

[khalidhuseynov]

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1231
  
@onkarshedge conf object can be obtained on the fly from current 
configurations by `ZeppelinConfiguration.create()`. However, as you mentioned, 
all repository storages are currently  being initialized in `NotebookRepoSync` 
class and it may not be good idea to initialize it in `TorrentServlet`.  Also 
the way you mentioned, `TorrentServlet` will always be initialized regardless 
of whether corresponding conf was selected. I think it would be more logical to 
do all the initializations possible in the constructor of 
`BittorrentNotebookRepo` class. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1273: [Zeppelin-1276] Fix Notebook Title Input

[corneadoug]

GitHub user corneadoug opened a pull request:

https://github.com/apache/zeppelin/pull/1273

[Zeppelin-1276] Fix Notebook Title Input

### What is this PR for?
The Notebook Title Input would not disappear after being edited.
This is a problem made by its plugin elastic-input.
We originally used ng-if instead of ng-show so it doesn't break the Page 
Print, however that change made the scope value to toggle unusable.
So we added a trustworthy small controller on top of the component.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1276

### How should this be tested?
* Click on the Notebook title
* Try to do: Enter or Esc or Click somewhere else
* The Input border should not be there anymore
* Do the same for the Paragraph
* If you do Print Page there shouldn't any titles duplicated at the top

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1276

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1273.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1273


commit b862081c8b74632fc472fe45911a8cffbbdc7d12
Author: Damien CORNEAU 
Date:   2016-08-03T07:34:43Z

Fix Notebook input issue

commit d590d825de002bfe519a5859683e4e2c1de464c9
Author: Damien CORNEAU 
Date:   2016-08-03T07:39:43Z

apply same input changes to the paragraph

commit 24df51f684c5caf97d3ef9d646afe30defc2aedb
Author: Damien CORNEAU 
Date:   2016-08-03T07:43:10Z

Fix eslint errors




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1276) Notebook Name input is not disappearing anymore

[CORNEAU Damien (JIRA)]

CORNEAU Damien created ZEPPELIN-1276:


 Summary: Notebook Name input is not disappearing anymore
 Key: ZEPPELIN-1276
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1276
 Project: Zeppelin
  Issue Type: Bug
Reporter: CORNEAU Damien
Assignee: CORNEAU Damien


When you edit the Notebook Title, the Input is not going away after Enter, ESC 
or click outside.

It seems to be related to the change from ng-show -> ng-if in this PR:
https://github.com/apache/zeppelin/pull/1180



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZEPPELIN-1275) Comment code of PySparkInterpreter is not highlighted

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-1275:


 Summary: Comment code of PySparkInterpreter is not highlighted 
 Key: ZEPPELIN-1275
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1275
 Project: Zeppelin
  Issue Type: Improvement
Affects Versions: 0.6.0
Reporter: Jeff Zhang
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1231: [Zeppelin - 683][WIP] BittorrentNotebookRepo

[onkarshedge]

Github user onkarshedge commented on the issue:

https://github.com/apache/zeppelin/pull/1231
  
And also a note on directories..
1] torrent
   notes/
   17fa195f6c85f72d197d63896b15f456e624/note.json
   282f928f9429828e5ef0a422f13d3263e671a2d3/note.json
   resume/
   torrents/
   settings.dat

The torrent directory is created which will contain the following 
directories. When the user wants to share a note via DHT he will give the 
noteId , the note.json file is copied to torrent/notes//
and then seeded by adding to TorrentEngine.
The reason to copy before seeding is if note is changed or updated after 
added to seeding, the pieces hash will change and hence corrupt. The torrent 
state will change from seeding --> downloading because it doesn't have that 
file.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1231: [Zeppelin - 683][WIP] BittorrentNotebookRepo

[onkarshedge]

Github user onkarshedge commented on the issue:

https://github.com/apache/zeppelin/pull/1231
  
@bzz here is the diagram.
![torrent 
1](https://cloud.githubusercontent.com/assets/10570922/17356236/efedf040-5973-11e6-8a1c-06ffe4c57ff1.png)
[Link to drive] 
(https://drive.google.com/file/d/0Bwg4NhDtfdM9WFRQSGJVV09Ub1U/view?usp=sharing)


![torrentclass](https://cloud.githubusercontent.com/assets/10570922/17356237/eff419e8-5973-11e6-8b4d-c97abf76e86c.png)
[Link to 
drive](https://drive.google.com/file/d/0Bwg4NhDtfdM9UFhkMDItQlVFaHM/view?usp=sharing)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1272: Remove empty user when put permission

[zhangmq]

GitHub user zhangmq opened a pull request:

https://github.com/apache/zeppelin/pull/1272

Remove empty user when put permission

### What is this PR for?
check empty users and delete it.  

### What type of PR is it?
[Bug Fix]

### Todos

### What is the Jira issue?

### How should this be tested?
clear note permissions then your note can't read.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?no
* Is there breaking changes for older versions?no
* Does this needs documentation?no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zhangmq/zeppelin master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1272.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1272


commit 61bd580d4285135855d6610b83b367f19c5426ff
Author: zhangmengqi 
Date:   2016-08-03T06:24:48Z

remve empty user when put permission




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1271: [ZEPPELIN-1274]Write "Spark SQL" in docs rather than "...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1271
  
@sarutak Looks good. Thanks! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1271: [ZEPPELIN-1274]Write "Spark SQL" in docs rather than "...

[sarutak]

Github user sarutak commented on the issue:

https://github.com/apache/zeppelin/pull/1271
  
@AhyoungRyu Thanks for the notification. I'll fix them soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1271: [ZEPPELIN-1274]Write "Spark SQL" in docs rather than "...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1271
  
@sarutak Thanks for fixing this. I found more `SparkSQL` in the below 2 
files. 
 - 
[docs/manual/dynamicform.md#using-form-templates](https://github.com/apache/zeppelin/blob/master/docs/manual/dynamicform.md#using-form-templates)
 - 
[docs/interpreter/livy.md#configuration](https://github.com/apache/zeppelin/blob/master/docs/interpreter/livy.md#configuration)

Could you change them as well? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1258: [ ZEPPELIN-1266 ] Code editor Optimization

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1258
  
@cloverhearts Thanks for the changes and keeping this PR focused.
I saw some great improvements with big Notebook with those changes.
@Leemoonsoo Can you try it too and tell us if you also think its better?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---