[GitHub] zeppelin issue #1348: [ZEPPELIN-1313] NullPointerException when using Clone ...

[kavinkumarks]

Github user kavinkumarks commented on the issue:

https://github.com/apache/zeppelin/pull/1348
  
@felixcheung / @jongyoul could you please take care of merging this?

Thanks,
Kavin


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1241
  
LGTM :smile:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1241: [ZEPPELIN-1217] Remove horizontal scrollbar in Zeppeli...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1241
  
Is this good to go now? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1365: ZEPPELIN-1374. Should prevent use dot in interp...

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1365

ZEPPELIN-1374. Should prevent use dot in interpreter name

### What is this PR for?
dot is invalid for interpreter name as it is used as the seprater of 
interpreter group name and interpreter name.


### What type of PR is it?
[Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1374

### How should this be tested?
Tested it manually as shown in the screenshot. 

### Screenshots (if appropriate)

![image](https://cloud.githubusercontent.com/assets/164491/17995181/3047152e-6b92-11e6-9fbf-c683330359a9.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1374

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1365.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1365


commit 94ce731f1ba212f0b398db75eb4cec017032b850
Author: Jeff Zhang 
Date:   2016-08-26T05:34:46Z

ZEPPELIN-1374. Should prevent use dot in interpreter name




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1365: ZEPPELIN-1374. Should prevent use dot in interpreter n...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1365
  
\cc @minahlee @jongyoul  Ready for review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1362: [ZEPPELIN-1178] Tooltip: Show chart type when hovering...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1362
  
+1 for @corneadoug, rest LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1364: [MINOR] Remove unnecessary question mark

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1364
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1353: ZEPPELIN-1326: make profile to select dependency of ha...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1353
  
@jongyoul  does this looks OK ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1360: [ZEPPELIN-1366] Removed legacy JDBC alias

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1360
  
@jongyoul Then can we use JDBC interpreter as described in [How to 
use](http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/jdbc.html#how-to-use)
 section like before? I just wondered :D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1360: [ZEPPELIN-1366] Removed legacy JDBC alias

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1360
  
@bzz @Leemoonsoo Thanks, I don't know the proper location to describe the 
changes actually. I'll also update upgrade.md. And about changing a behaviour 
of JDBC, in case of `%jdbc(mysql)`, I thought it's not related to this issue 
directly, then I'll make another PR for handling that. We don't need to 
multiple configurations due to interpreter aliases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1283
  
@corneadoug yes, that streams output every one seconds if i try the master 
branch.

However, I did some more experiment and found

Output streaming : master branch (X), this pullrequest (X)
```
%sh
for i in {1..3}
do
date
sleep 2
done
```

Output streaming : master branch (O), this pullrequest (X)
```
%spark
(1 to 3).foreach{i=>
Thread.sleep(2000)
println(new java.util.Date)
}
```

@corneadoug @beriaanirudh Could you verify these cases, too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1301: [MINOR] Removed unused profiles from spark/pom.xml

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1301
  
@bzz Yes, what you mentioned is related to #1339 which will make a change 
to build custom Spark.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1374) Should prevent use dot in interpreter name

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-1374:


 Summary: Should prevent use dot in interpreter name
 Key: ZEPPELIN-1374
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1374
 Project: Zeppelin
  Issue Type: Improvement
Affects Versions: 0.6.1
Reporter: Jeff Zhang
 Attachments: screenshot-1.png

I create a new interpreter which I name it as "spark1_2.11" (I'd like to use 
multiple spark version for one zeppelin instance). But zeppelin didn't 
recognize it correctly as shown in the screenshot. The reason is that zeppelin 
use dot as the separator of interpreter group name and interpreter name. So 
here it takes 
"spark1_2" as the interpreter group name. So I believe we should prevent user 
to use dot in the interpreter name. We can pop up a error message box when user 
use dot in the interpreter name in the interpreter page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1356: [ZEPPELIN-1346] Add contribution guidelines to the web...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1356
  
@felixcheung I agree with @corneadoug. If this document page need to be 
posted to the external resources, then we may need to attach `Apache` in front 
of every `Zeppelin`. But we don't need to say `Apache Zeppelin` every time in 
internal project page I guess :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1362: [ZEPPELIN-1178] Tooltip: Show chart type when hovering...

[vensant]

Github user vensant commented on the issue:

https://github.com/apache/zeppelin/pull/1362
  
Hi all,

I will change the tool tip names as suggested.

Thank you all

Regards,
Venkat

On 26 Aug 2016 7:57 am, "Lee moon soo"  wrote:

> +1 for @corneadoug  's comment. Shorter
> name is actually more clear and easier to understand.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1339: [WIP][ZEPPELIN-1332] Remove spark-dependencies & sugge...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1339
  
@bzz Thank you for saying so! Then I'll continue my work in here and let 
you know :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1351: [ZEPPELIN/1356] The graph legend truncates at the near...

[Peilin-Yang]

Github user Peilin-Yang commented on the issue:

https://github.com/apache/zeppelin/pull/1351
  
@corneadoug sure, will do and push


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1339: [WIP][ZEPPELIN-1332] Remove spark-dependencies & sugge...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1339
  
Thank you for kind explanation and feedback. I think you proposal and 
implementation with recent updates makes perfect sense.

Please keep up a good work and ping me back for the final review, once you 
think it's ready!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1301: [MINOR] Removed unused profiles from spark/pom.xml

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1301
  
Quick question: just to double-check - this should not affect users 
following published build instructions like 
https://www.mapr.com/blog/building-apache-zeppelin-mapr-using-spark-under-yarn 
, right?

In a way like in 
[ZEPPELIN-1353](https://issues.apache.org/jira/browse/ZEPPELIN-1353)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/932
  
After the licenses clarification, I think we should be good to merge - I 
love the idea of having Jersey2.

\cc @Leemoonsoo @jongyoul for review as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/932
  
Sorry, been a busy week.  I think it needs to be rebased on latest master.

Few things on licensing:

There are two same **CDDL 1.1** texts now  
`zeppelin-distribution/src/bin_license/LICENSE-jersey-2` and 
`zeppelin-distribution/src/bin_license/licenses/LICENSE-jersey-2` - I think we 
need to keep only the one inside 
`zeppelin-distribution/src/bin_license/licenses/`.

Please pardon me if my previous comment was confusing:
> I will look more into that, meanwhile could you please include full text 
of this license to zeppelin-distribution/src/bin_license/ as well?

What I meant was: we need to add full text of **CDDL 2.0** in the 
`zeppelin-distribution/src/bin_license/licenses/LICENSE-`

--

Looking a bit deeper, could you please double-check that all the 
dependencies mentioned in LICENSE file have correct licenses?

```
(CDDL 2.0) javax.ws.rs-api (javax.ws.rs - https://jax-rs-spec.java.net/)
(CDDL 2.0) validation-api (javax.validation - 
http://beanvalidation.org/)
(CDDL 2.0) javax.annotation-api (javax.annotation - 
https://www.jcp.org/en/jsr/detail?id=250)
```

 -  https://jax-rs-spec.java.net/ - page mentiones only [CDDL 
1.0](https://opensource.org/licenses/cddl1.php)
 -  http://beanvalidation.org/licensing/) - page mentiones only _Apache 
2.0_ and JCP _click through license_
 - https://www.jcp.org/en/jsr/detail?id=250 the only mention of word 
`license` I could find is `JDL`

   > The Reference Implementation and associated TCK's will be made 
available from java.sun.com at no charge without support. J2EE and J2SE 
licensees will recieve support at no extra charge with an amendment to their 
active support agreement. Source code will be made available via the Java 
Distribution License (JDL).

And I can not find any mentions of CDDL 2.0 on 
https://opensource.org/licenses/alphabetical
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1362: [ZEPPELIN-1178] Tooltip: Show chart type when hovering...

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1362
  
Tested, LGTM
However maybe the tooltip names could be changed to something more simple:
* Multi Bar Chart -> Bar Chart
* Stacked Area Chart -> Area Chart
* Line With Focus Chart -> Line Chart


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1351: [ZEPPELIN/1356] The graph legend truncates at the near...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1351
  
@Peilin-Yang make sense, have updated jira fix-for version.

@corneadoug absolutely, please take your time for review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1351: [ZEPPELIN/1356] The graph legend truncates at the near...

[Peilin-Yang]

Github user Peilin-Yang commented on the issue:

https://github.com/apache/zeppelin/pull/1351
  
@bzz is that possible to apply this to 0.6.0-SNAPSHOT. We are still using 
that version in Twitter:)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1364: [MINOR] Remove unnecessary question mark

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1364
  
Thanks @zjffdu for taking care.
LGTM and merge to master if there's no more discussion.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1356: [ZEPPELIN-1346] Add contribution guidelines to the web...

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1356
  
@felixcheung I don't think that adding Apache in front of every Zeppelin is 
necessary.
Especially since this is documentation for the project itself. It is fine 
to use the shorten name without Apache, and you can actually see that projects 
are doing it (Apache Mesos, Spark, Flink for example), and we've also been 
doing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1360: [ZEPPELIN-1366] Removed legacy JDBC alias

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1360
  
I think it changes way of configuration. From single jdbc interpreter 
setting manages multiple jdbc connection, to individual interpreter setting 
manage single jdbc connection.

How about remove non-default jdbc connection configurations from default 
properties and documentation?

https://github.com/apache/zeppelin/blob/master/jdbc/src/main/resources/interpreter-setting.json
https://github.com/apache/zeppelin/blob/master/docs/interpreter/jdbc.md

And incompatible changes can be guided in 
https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1362: [ZEPPELIN-1178] Tooltip: Show chart type when hovering...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1362
  
@vensant thank you for contributing improvement!

With GUI changes, in my experience, adding simple screenshots to the PR 
itself (drag'n'drop to description) before\after usually helps to speed up the 
review process a lot.

CI failure seems not related, look lik networking issue on Travis side :\

```
[INFO] Zeppelin: web Application .. FAILURE [01:20 
min]
[INFO] grunt-ng-annotate@0.10.0 node_modules/grunt-ng-annotate
[ERROR] npm ERR! argv 
"/home/travis/build/apache/zeppelin/zeppelin-web/node/node" 
"/home/travis/build/apache/zeppelin/zeppelin-web/node/node_modules/npm/bin/npm-cli.js"
 "install" "--color=false"
[ERROR] npm ERR! node v0.12.13
[ERROR] npm ERR! npm  v2.15.0
[ERROR] 
[ERROR] npm ERR! Callback called more than once.
[ERROR] npm ERR! 
[ERROR] npm ERR! If you need help, you may report this error at:
[ERROR] npm ERR! 
[ERROR] 
[ERROR] npm ERR! Please include the following file with any support request:
[ERROR] npm ERR! 
/home/travis/build/apache/zeppelin/zeppelin-web/npm-debug.log
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1363: [ZEPPELIN-1371]add text/numeric conversion support to ...

[Peilin-Yang]

Github user Peilin-Yang commented on the issue:

https://github.com/apache/zeppelin/pull/1363
  
Well, consider it alone, yes it is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1351: [ZEPPELIN/1356] The graph legend truncates at the near...

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1351
  
@bzz I'd like to review it first


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1351: [ZEPPELIN/1356] The graph legend truncates at the near...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1351
  
Looks great to me, thank you for taking care @Peilin-Yang !

Merging if there is no further discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1360: [ZEPPELIN-1366] Removed legacy JDBC alias

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1360
  
LGTM.

> Is there breaking changes for older versions? Yes

Do we have a change-log or something where we can keep track of breaking 
changes to highlight them in the release?

>Does this needs documentation? Yes, but I don't know where the proper 
location is.

@minahlee @AhyoungRyu what do you think is the best location for such docs?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1357: ZEPPELIN-1364: Return only the ran paragraph details f...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1357
  
@vipul1409 thank you, it sounds interesting! Could you please let know, if 
it is ready for review?

@Leemoonsoo @corneadoug do you guys see any downsides\side-effects for such 
change?

Seems like CI is failing for some reason, could you please check it? 
Usually posting the reason of CI failure speeds  up the review process a lot.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1363: [ZEPPELIN-1371]add text/numeric conversion support to ...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1363
  
Go it! It would be really nice to have such defaults for numbers, that make 
them sort numerically.

As for letting user change it - it sounds good, am it looks like the main 
use case for it is basically, removing commas? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1347: ZEPPELIN-1284. Unable to run paragraph with default in...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1347
  
LGTM. Merging if there is no further discussion 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1363: [ZEPPELIN-1371]add text/numeric conversion support to ...

[Peilin-Yang]

Github user Peilin-Yang commented on the issue:

https://github.com/apache/zeppelin/pull/1363
  
@bzz Actually I am currently look into that and I think it is possible 
because numbers are automatically detected and that is why the commas are 
inserted.
But I think even we could have the initial sorting for numbers it is still 
nice to let the users change it on the fly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1283
  
@Leemoonsoo 

The behaviour is still the same with:
```
(1 to 40).foreach{ i=>
Thread.sleep(1000)
println("Hello " + i)
}
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1363: [ZEPPELIN-1371]add text/numeric conversion support to ...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1363
  
So cool - this should solve sorting issue for numeric columns! Thank you 
@Peilin-Yang!

One question - do you guys think it could be possible to detect numeric 
columns automatically using some heuristics and apply proper renderer on table 
creation time, rather than make user choose? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1363: [ZEPPELIN-1371]add text/numeric conversion support to ...

[Peilin-Yang]

Github user Peilin-Yang commented on the issue:

https://github.com/apache/zeppelin/pull/1363
  
@corneadoug thanks for your advice!
I updated the contents of PR so that it includes the use cases of this 
change.
Please let me know whether they make any sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...

[astroshim]

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1358
  
re-trigger CI


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1358: [ZEPPELIN-1365] Error of Zeppelin Application i...

[astroshim]

Github user astroshim closed the pull request at:

https://github.com/apache/zeppelin/pull/1358


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1358: [ZEPPELIN-1365] Error of Zeppelin Application i...

[astroshim]

GitHub user astroshim reopened a pull request:

https://github.com/apache/zeppelin/pull/1358

[ZEPPELIN-1365] Error of Zeppelin Application in development mode.

### What is this PR for?
This PR fixes the bug of running application in development mode.


### What type of PR is it?
Bug Fix


### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1365


### How should this be tested?
1. run zeppelin
2. run org.apache.zeppelin.interpreter.dev.ZeppelinApplicationDevServer in 
development mode.

(http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelinapplication.html)
3. and run paragraph like screenshot.

### Screenshots (if appropriate)

![image](https://cloud.githubusercontent.com/assets/3348133/17935588/d95ec2de-6a56-11e6-84d9-19030984411d.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1365

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1358


commit 9f640e5f1863e9e5b113ba31a939535e450f075e
Author: astroshim 
Date:   2016-08-24T14:52:45Z

add argument check.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1352: [ZEPPELIN-1327] Fix bug in z.show for Python in...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1352


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1363: [ZEPPELIN-1371]add text/numeric conversion support to ...

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1363
  
@Peilin-Yang Thanks for the contribution.
Small tip: Instead of hosting your screenshot, you can drop the image 
directly in the input of the PR description and the image will be hosted by 
github and shown.

Could you add more information on what is the benefit of changing the 
text/numeric conversion?
There is no example on what is happening when you actually switch the type 
and why it is useful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Accessing bound vars from JS

[Corneau Damien]

There is no real API to access the value inside of JS.

However, if we are really talking about accessing values set using
z.angularBing(), you can do it in your case with:
 angular.element('#dummy').scope().valueBinded


I have a small example here of an autocomplete input:
*Notebook:*
https://github.com/corneadoug/Zeppelin-Notebooks/tree/master/Auto-Complete-MultiSelect
*Preview:*
https://www.zeppelinhub.com/viewer/notebooks/aHR0cHM6Ly9yYXcuZ2l0aHVidXNlcmNvbnRlbnQuY29tL2Nvcm5lYWRvdWcvWmVwcGVsaW4tTm90ZWJvb2tzL21hc3Rlci9BdXRvLUNvbXBsZXRlLU11bHRpU2VsZWN0L25vdGUuanNvbg

On Fri, Aug 26, 2016 at 7:32 AM, Randy Gelhausen  wrote:

> The Angular interpreter is very useful, but I'm having a difficult time
> using values from it inside custom JavaScript.
>
> Thus far, the only means I can find of accessing variables is something
> like:
> %angular
> 
> 
>   var div = $('#dummy');
>   //Given an element in the note & list of values to fetch from Spark
>   //window.angularVars.myVal will be current value of backend Spark val of
> same name
>   function hoist(element, varNames){
> window.angularVars = {};
> var scope =
> angular.element(element.parent('.ng-scope')).scope().compiledScope;
> $.each(varNames, function(i, v){
>   window[v+'-watcher'] = scope.$watch(v, function(newVal, oldVal){
> console.log('Setting ' + v + ' to:\n');
> console.log(newVal);
> window.angularVars[v] = newVal;
>   });
> });
>   }
>   hoist(div, div.attr('vars').split(','));
> 
>
> Then in later paragraphs, I can access window.angularVars['data1'], etc.
>
> It feels quite hacky. Is there a better way to enable use of angular bound
> variables inside custom JS?
>

[GitHub] zeppelin issue #1364: [MINOR] Remove unnecessary question mark

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1364
  
\cc @Leemoonsoo


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1364: [MINOR] Remove unnecessary question mark

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1364

[MINOR] Remove unnecessary question mark

### What is this PR for?
Just remove the unnecessary question mark. 


### What type of PR is it?
[Documentation]

### Todos
* [ ] - Task

### What is the Jira issue?
* No jira created

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin doc_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1364


commit 7fed25d9e37ccdc4b6f598df35adf3599b256057
Author: Jeff Zhang 
Date:   2016-08-25T23:45:23Z

[MINOR] Remove unnecessary question mark




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1363: [ZEPPELIN-1371]add text/numeric conversion supp...

[Peilin-Yang]

GitHub user Peilin-Yang reopened a pull request:

https://github.com/apache/zeppelin/pull/1363

[ZEPPELIN-1371]add text/numeric conversion support to table display

### What is this PR for?
We people in Twitter have great demand of adding a flexible drop down menu 
for the columns in the tables which enables the text/numeric conversion.
This is because people want some columns to be of string type which, for 
example, fits to the underlying DB definition.


### What type of PR is it?
[Improvement | Feature]

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1371

### How should this be tested?

1. Click on the dropdown menu would convert the text/number of that column.
2. Other functionalities esp. the sorting function should not be affected.

### Screenshots (if appropriate)

https://drive.google.com/a/twitter.com/file/d/0B9QN74Rceec8djV6UXpUeFNyUWM/view?ts=57bf2c11

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? Probably a noticeable 
change in UI
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Peilin-Yang/zeppelin 
ypeilin/table_num_cell_format

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1363.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1363


commit b92e92ff8821a58c47d7510818ec518414499c83
Author: Peilin Yang 
Date:   2016-08-25T17:06:23Z

add text/numeric conversion support to table display




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1363: [ZEPPELIN-1371]add text/numeric conversion supp...

[Peilin-Yang]

Github user Peilin-Yang closed the pull request at:

https://github.com/apache/zeppelin/pull/1363


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1372) sorting order in the table is always lexicographically even it shows as numbers

[Peilin Yang (JIRA)]

Peilin Yang created ZEPPELIN-1372:
-

 Summary: sorting order in the table is always lexicographically 
even it shows as numbers
 Key: ZEPPELIN-1372
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1372
 Project: Zeppelin
  Issue Type: Bug
  Components: front-end, GUI
Affects Versions: 0.7.0
Reporter: Peilin Yang






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Accessing bound vars from JS

[Randy Gelhausen]

The Angular interpreter is very useful, but I'm having a difficult time
using values from it inside custom JavaScript.

Thus far, the only means I can find of accessing variables is something
like:
%angular


  var div = $('#dummy');
  //Given an element in the note & list of values to fetch from Spark
  //window.angularVars.myVal will be current value of backend Spark val of
same name
  function hoist(element, varNames){
window.angularVars = {};
var scope =
angular.element(element.parent('.ng-scope')).scope().compiledScope;
$.each(varNames, function(i, v){
  window[v+'-watcher'] = scope.$watch(v, function(newVal, oldVal){
console.log('Setting ' + v + ' to:\n');
console.log(newVal);
window.angularVars[v] = newVal;
  });
});
  }
  hoist(div, div.attr('vars').split(','));


Then in later paragraphs, I can access window.angularVars['data1'], etc.

It feels quite hacky. Is there a better way to enable use of angular bound
variables inside custom JS?

[GitHub] zeppelin pull request #1363: [ZEPPELIN-1371]add text/numeric conversion supp...

[Peilin-Yang]

GitHub user Peilin-Yang opened a pull request:

https://github.com/apache/zeppelin/pull/1363

[ZEPPELIN-1371]add text/numeric conversion support to table display

### What is this PR for?
We people in Twitter have great demand of adding a flexible drop down menu 
for the columns in the tables which enables the text/numeric conversion.
This is because people want some columns to be of string type which, for 
example, fits to the underlying DB definition.


### What type of PR is it?
[Improvement | Feature]

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1371

### How should this be tested?

1. Click on the dropdown menu would convert the text/number of that column.
2. Other functionalities esp. the sorting function should not be affected.

### Screenshots (if appropriate)

https://drive.google.com/a/twitter.com/file/d/0B9QN74Rceec8djV6UXpUeFNyUWM/view?ts=57bf2c11

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? Probably a noticeable 
change in UI
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Peilin-Yang/zeppelin 
ypeilin/table_num_cell_format

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1363.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1363


commit b92e92ff8821a58c47d7510818ec518414499c83
Author: Peilin Yang 
Date:   2016-08-25T17:06:23Z

add text/numeric conversion support to table display




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1371) Add flexible text/numeric conversion dropdown menu on table display

[Peilin Yang (JIRA)]

Peilin Yang created ZEPPELIN-1371:
-

 Summary: Add flexible text/numeric conversion dropdown menu on 
table display
 Key: ZEPPELIN-1371
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1371
 Project: Zeppelin
  Issue Type: Improvement
  Components: front-end, GUI
Affects Versions: 0.7.0
Reporter: Peilin Yang
Priority: Minor
 Fix For: 0.7.0


We people in Twitter have great demand of adding a flexible dropdown menu for 
the columns in the tables which enables the text/numeric conversion.
This is because people want some columns to be of string type which, for 
example, fits to the underlying DB definition.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin pull request #1295: [ZEPPELIN-1301] fix potential encoding problem ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1295


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1323: [HOTFIX] Add logins authentication for hdfs file inter...

[rawkintrevo]

Github user rawkintrevo commented on the issue:

https://github.com/apache/zeppelin/pull/1323
  
@cloverhearts 
Not going to pretend I'm an expert on HDFS- here's my use case, and I am 
happy to offer further explanation. 

I have a [BigInsights 
Cloud](http://www-03.ibm.com/software/products/en/ibm-biginsights-on-cloud) 
Cluster I set up on IBM [BlueMix ](http://bluemix.net).  They have a free 
30-day trial if you want to set one up to test.  

I hacked on it for about an hour, this was what made it work.  Can you tell 
me more about what authentication settings you're looking for please?  I'm 
happy to help, but I don't know enough about it to know how to answer your 
question.  Further, I can set up a dummy one and provide you creds, but I'd 
rather do that non-publicly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1283
  
Text output streaming used to work in following way (branch-0.6)

![pr1283_before](https://cloud.githubusercontent.com/assets/1540981/17974242/25200d66-6a9a-11e6-83d5-10c92de4ca6e.gif)

But somehow, this PR (and master branch) works like

![pr1283_after](https://cloud.githubusercontent.com/assets/1540981/17974271/49d459b4-6a9a-11e6-9c2b-e12e2a45b464.gif)

Shell we address this problem first, before apply this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1357: ZEPPELIN-1364: Return only the ran paragraph details f...

[echarles]

Github user echarles commented on the issue:

https://github.com/apache/zeppelin/pull/1357
  
Didn't try the changes but definitively +1 for this to enhance performance 
(tried to imagine side effects but didn't find any atm)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1362: [ZEPPELIN-1178] Tooltip: Show chart type when h...

[vensant]

GitHub user vensant opened a pull request:

https://github.com/apache/zeppelin/pull/1362

[ZEPPELIN-1178] Tooltip: Show chart type when hovering over chart icon

### What is this PR for?
A usability improvement: Added tooltips for the chart icons in Zeppelin 
paragraphs, showing the chart types when hovering over the chart icons.


### What type of PR is it?
Improvement

### Todos
NA

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1178

### How should this be tested?
1. Deploy Zeppelin and navigate to zeppelin tutorial
2. Run a paragraph and hover over the chart icon buttons to see the tooltip 
getting displayed.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vensant/zeppelin ZEPPELIN-1178

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1362


commit 8a85449a9ad705a25c6cef0a862ac89783e256de
Author: vensant 
Date:   2016-08-25T09:47:40Z

Added tooltips for the chart icons in Zeppelin paragraphs, showing the 
chart types when hovering over the chart icons




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1315: [ZEPPELIN-530] Added changes for Credential Pro...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1315


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1283: Buffer append output results + fix extra incorrect res...

[beriaanirudh]

Github user beriaanirudh commented on the issue:

https://github.com/apache/zeppelin/pull/1283
  
@corneadoug @bzz this is ready for review...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

[echarles]

Github user echarles commented on the issue:

https://github.com/apache/zeppelin/pull/932
  
@bzz  are we ok now with the license information?

Travis is red for 3 on the 9 profiles, but this comes from a timeout trying 
to launch/access spark

```16/08/17 15:36:04 INFO ExecutorRunner: Launch command: 
"/usr/lib/jvm/java-7-oracle/bin/java" "-cp" 
"/home/travis/build/apache/zeppelin/spark-1.6.1-bin-hadoop2.3/conf/:/home/travis/build/apache/zeppelin/spark-1.6.1-bin-hadoop2.3/lib/spark-assembly-1.6.1-hadoop2.3.0.jar:/home/travis/build/apache/zeppelin/spark-1.6.1-bin-hadoop2.3/lib/datanucleus-core-3.2.10.jar:/home/travis/build/apache/zeppelin/spark-1.6.1-bin-hadoop2.3/lib/datanucleus-api-jdo-3.2.6.jar:/home/travis/build/apache/zeppelin/spark-1.6.1-bin-hadoop2.3/lib/datanucleus-rdbms-3.2.9.jar"
 "-Xms1024M" "-Xmx1024M" "-Dspark.driver.port=47348" "-XX:MaxPermSize=256m" 
"org.apache.spark.executor.CoarseGrainedExecutorBackend" "--driver-url" 
"spark://CoarseGrainedScheduler@172.17.14.104:47348" "--executor-id" "0" 
"--hostname" "172.17.14.104" "--cores" "2" "--app-id" "app-20160817153604-0003" 
"--worker-url" "spark://Worker@172.17.14.104:41888"
16/08/17 15:36:40 INFO Worker: Asked to kill executor 
app-20160817153604-0003/0
16/08/17 15:36:40 INFO ExecutorRunner: Runner thread for executor 
app-20160817153604-0003/0 interrupted
16/08/17 15:36:40 INFO ExecutorRunner: Killing process!
16/08/17 15:36:41 INFO Worker: Executor app-20160817153604-0003/0 finished 
with state KILLED exitStatus 143
16/08/17 15:36:41 INFO Worker: Cleaning up local directories for 
application app-20160817153604-0003
16/08/17 15:36:41 INFO ExternalShuffleBlockResolver: Application 
app-20160817153604-0003 removed, cleanupLocalDirs = true


travis_time:end:17fafc60:start=1471448259153159015,finish=1471448259166402551,duration=13243536
```

Anything else I can do to get this merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1361: [ZEPPELIN-1354] [WIP] Inject Services

[echarles]

GitHub user echarles opened a pull request:

https://github.com/apache/zeppelin/pull/1361

[ZEPPELIN-1354] [WIP] Inject Services

### What is this PR for?

Services like authentication, authorization, security filters... should be 
injected rather than manually instanciated.

This will allow to give central + finer control and abstracting the 
functionaly in interface and allow third parties to implement their own 
functions in with configurable injection points.

For this, I propose to use Guice as injection framework.


### What type of PR is it?
Improvement

### Todos
* [ ] - Documentation
* [ ] - Tests

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1354

### How should this be tested?
Just compile and run

### Screenshots (if appropriate)
NA

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/datalayer/zeppelin-datalayer inject-services

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1361.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1361


commit 5002a1583681cff847c08977e614963a854d8f1b
Author: Eric Charles 
Date:   2016-08-24T16:05:52Z

add guice dependencies

commit 0fd9096e44c92b715cf7efa9dc82fc672564542e
Author: Eric Charles 
Date:   2016-08-25T08:16:51Z

Merge branch 'master' into inject-services

Conflicts:
pom.xml

zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java

zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java

commit 1d2b80a9be1054312ccba3b5d4b4f3086ecd3f33
Author: Eric Charles 
Date:   2016-08-25T08:17:58Z

Initial working implemenation of service injection for WebSecurity and 
SearchService




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---