[GitHub] zeppelin pull request #1439: [ZEPPELIN-1423] Allow users to specify pre/post...

2016-09-23 Thread agoodm
GitHub user agoodm reopened a pull request:

https://github.com/apache/zeppelin/pull/1439

[ZEPPELIN-1423] Allow users to specify pre/post-execute callbacks for 
interpreters

### What is this PR for?
One feature built-in to Jupyter's ipykernel that is currently missing in 
Zeppelin are pre/post-execute "callbacks". This PR allows for the possibility 
of entering code that is set to be executed by the interpreter before  the code 
entered into the paragraph (pre-execute) and after (post-execute). In addition 
to saving some users the effort of writing code that they want executed in 
every paragraph, this will help pave the way for more advanced features coming 
soon, like automatically displaying matplotlib figures without an explicit call 
to a `show()` function. See the JIRA issue for more details on this.

The core implementation for this is primarily contained in a new class 
called `InterpreterCallbackRegistry` which heavily mimics the Angular Display 
system (eg, `AngularObjectRegistry`). While this interface alone should suffice 
for Interpreter maintainers on the Java/JVM side, I also thought it might be 
useful to expose the system directly to the users in their notebooks. Hence, an 
implementation that works with the spark and pyspark interpreters (via the 
`ZeppelinContext` class) is also included here.

### What type of PR is it?
New Feature

### Todos
* [x] - Add unit tests
* [x] - Add new documentation

(Maybe) - Find a better way to check for errors in pre-execute as this can 
brick the REPL (see more info below)

### What is the Jira issue?
[ZEPPELIN-1423](https://issues.apache.org/jira/browse/ZEPPELIN-1423)

### How should this be tested?
In a new note, add the following lines of code to a paragraph:
```python
%pyspark
z.registerCallback("post_exec", "print 'This code should be executed before 
the parapgraph code!'")
z.registerCallback("pre_exec", "print 'This code should be executed after 
the paragraph code!'")
```

Then run any other paragraph in the note containing some other code, eg
```python
%pyspark
print "This code should be entered into the paragraph by the user!"
```

The output should be:
```
This code should be executed before the paragraph code!
This code should be entered into the paragraph by the user!
This code should be executed after the paragraph code!
```

You should also test out the other two methods (`getCallback()` and 
`unregisterCallback()`) specified in `ZeppelinContext.java`.

One final caveat that should be mentioned: If there are errors in the code 
you specify for a pre-execute event, it will render the interpreter useless 
since the current implementation prepends the the code specified in `pre_exec` 
directly to the paragraph entered code before calling `interpret()`. The 
current workaround for this would be to either restart the interpreter group or 
call `unregisterCallback()` via a different REPL within the interpreter group 
(eg, `z.unregisterCallback("pre_exec", "pyspark")` from the spark interpreter). 
I would appreciate if anyone here would be willing to share any better 
approaches here.

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/agoodm/zeppelin ZEPPELIN-1423

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1439.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1439


commit eb26886986ec067a6104fa5de6f8bd99deb2ee1b
Author: Alex Goodman 
Date:   2016-09-13T20:32:36Z

First attempt at adding pre/post-execute callbacks

Added support for pre/post-execute callback hooks to interpreters

commit f50eccaa56889f0feda4a48a226df6596d53
Author: Alex Goodman 
Date:   2016-09-19T22:48:34Z

Added support for user defined callbacks in spark/pyspark interpreters

commit 1594dfbcb2df805705143df913e9a5eb63c6be18
Author: Alex Goodman 
Date:   2016-09-20T18:14:47Z

Deleted unused files

commit e1ba95b4e8a8c46ac8f685d64ff1cd59ea9c71c1
Author: Alex Goodman 
Date:   2016-09-20T18:16:28Z

Regenerated thrift files using v0.9.2

commit b8265fea798c92a411324a2eb3a73f245b8e50ee
Author: Alex Goodman 
Date:   2016-09-20T20:13:33Z

Added unit tests for InterpreterCallbackRegistry

commit 3e7c8520786190891e70762828406f5ff7b431b0
Author: Alex Goodman 
Date:   2016-09-20T21:02:19Z


[GitHub] zeppelin pull request #1439: [ZEPPELIN-1423] Allow users to specify pre/post...

2016-09-23 Thread agoodm
Github user agoodm closed the pull request at:

https://github.com/apache/zeppelin/pull/1439


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1452: ZEPPELIN-1442. UDF can not be found due to 2 in...

2016-09-23 Thread zjffdu
GitHub user zjffdu reopened a pull request:

https://github.com/apache/zeppelin/pull/1452

ZEPPELIN-1442. UDF can not be found due to 2 instances of SparkSession is 
created

### What is this PR for?
The issue is that we create 2 SparkSession in zeppelin_pyspark.py (Because 
we create SQLContext first which will create SparkSession underlying). This 
cause 2 instances of SparkSession in JVM side and this means we have 2 
instances of Catalog as well. So udf registered in SQLContext can be used in 
SparkSession. This PR will create SparkSession first and then assign its 
internal SQLContext to sqlContext in pyspark. 


### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1442

### How should this be tested?
Integration test is added. 

### Screenshots (if appropriate)

![image](https://cloud.githubusercontent.com/assets/164491/18774832/7f270de4-818f-11e6-9e4f-c4def4353e5c.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

…

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1442

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1452


commit 948e8657634686f16a405b3938884a5fe48dfc1c
Author: Jeff Zhang 
Date:   2016-09-23T05:08:49Z

ZEPPELIN-1442. UDF can not be found due to 2 instances of SparkSession is 
created

commit 66ec1b9cf5f244ec3b61594f3de86c34ca117175
Author: Jeff Zhang 
Date:   2016-09-23T08:18:24Z

fix unit test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...

2016-09-23 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1426
  
@felixcheung DataFrame won't be affected, as it is handled in %livy.sql 
(`LivySparkSQLInterpreter`). And since `ZeppelinContext` is not available in 
livy, so you can not user `z.show(df)` in livy


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1452: ZEPPELIN-1442. UDF can not be found due to 2 instances...

2016-09-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1452
  
LGTM
@zjffdu Do you mind trigger CI one more time?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1440: ZEPPELIN-1427. Scala z.show() doesn't work on v.0.6.1

2016-09-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1440
  
Thanks for the fix.
LGTM and merge to master and branch-0.6 if there're no more discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1453: [ZEPPELIN-1482] Load updated dependency library on int...

2016-09-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1453
  
Tested and LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...

2016-09-23 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1426
  
I think the problem is if the output is a DataFrame now it can't be turned 
into a table since %angular is already there because only the first type is 
picked up? That would seem to me a bigger problem. 

Also, while I think it's important to support multiple output types, for 
interpreter output customization like this it might be an opportunity to create 
a new framework to allow this to plug in to the paragraph "gear" menu or 
similar UX decorators? This could be a great opportunity to add Spark UI web 
link to the Spark interpreter group too. 

I agree with @zjffdu that this is important to have in the short term, and 
I think it's a good idea if we change the output type if only under the switch 
for Livy interpreter only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1452: ZEPPELIN-1442. UDF can not be found due to 2 instances...

2016-09-23 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1452
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...

2016-09-23 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1350
  
Thanks for the contribution.
@mwkang Could you elaborate little bit more how this code change is related 
to ZEPPELIN-1351?

ZEPPELIN-1351 is about displaying paragraph status when it fails with 
"Paragraph received a SIGTERM. ExitValue: 143". But code change here is 
displaying paragraph status 'ERROR' when interpreter result is incomplete. So 
i'm bit confusion how they're related. Could you help me to understand?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1439: [ZEPPELIN-1423] Allow users to specify pre/post-execut...

2016-09-23 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1439
  
right, I was referring when the interpreter group is not the default, or 
there is multiple etc..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [Need-Help][Eclipse][Windows] Problem

2016-09-23 Thread Andrea Santurbano
Thanks Lee!

Il giorno lun 19 set 2016 alle ore 21:32 moon soo Lee  ha
scritto:

> Hi Andrea,
>
> I don't know is there a way live debug without rebuild.
>
> To reduce build time, i leverage IDE, (intellij, eclipse), they can quickly
> build single file change into class without rebuild whole modules.
>
> In case of you need to build module, using -pl switch supported by maven
> could help a lot. You can include maven modules like -pl
> 'module1,module2,...' or exclude modules like -pl '!module1,!module2...' .
> So using -pl flag, you can build only part of the project.
>
> For example when i change backend and want to test, i usually build the
> project
>
> mvn -DskipTests -pl 'zeppelin-interpreter,zeppelin-zengine,zeppelin-server'
>
> which saves time spending on building interpreters and front-end, which i
> don't need to rebuild.
>
> Hope this helps.
>
> Thanks,
> moon
>
>
> On Sun, Sep 18, 2016 at 8:28 AM Andrea Santurbano 
> wrote:
>
> > Hi Moon,
> > thanks it works!
> > If want to live debug the application how can i do this without rebuild
> > every time the project?
> >
> > Thanks again!
> > Andrea
> >
> > Il giorno sab 17 set 2016 alle ore 03:57 moon soo Lee 
> ha
> > scritto:
> >
> > > Hi Andrea,
> > >
> > > I think you can try
> > >
> > > mvn -pl 'zeppelin-server' exec:java
> > > -Dexec.mainClass="org.apache.zeppelin.server.ZeppelinServer"
> > -Dexec.args=""
> > >
> > > from project root directory (not zeppelin-server)
> > >
> > > Thanks,
> > > moon
> > >
> > > On Thu, Sep 15, 2016 at 5:43 AM Andrea Santurbano 
> > > wrote:
> > >
> > > > Hi to all,
> > > > i'm trying to execute Zeppelin via Eclipse, using this steps:
> > > > 1) *mvn clean install -DskipTests *(in Zeppelin root)
> > > > 2) *cd zeppelin-server*
> > > > 3) *mvn exec:java
> > > > -Dexec.mainClass="org.apache.zeppelin.server.ZeppelinServer"
> > > > -Dexec.args=""*
> > > >
> > > > But i get the following exception:
> > > > *java.io.FileNotFoundException: .\conf\shiro.ini (The system cannot
> > find
> > > > the path specified)*
> > > >
> > > > Where am i wrong?
> > > > Is there some issue with Windows?
> > > >
> > > > I'm developing an interpreter and i need to debug both java and
> > > javascript
> > > > code. How i can proceed?
> > > >
> > > > Thanks
> > > > Andrea
> > > >
> > >
> >
>


[GitHub] zeppelin issue #1446: ZEPPELIN-1263. Should specify zeppelin's spark configu...

2016-09-23 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1446
  
I think we still support Spark 1.2, 1.3 officially so removing this might 
be an issue.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1452: ZEPPELIN-1442. UDF can not be found due to 2 in...

2016-09-23 Thread zjffdu
GitHub user zjffdu reopened a pull request:

https://github.com/apache/zeppelin/pull/1452

ZEPPELIN-1442. UDF can not be found due to 2 instances of SparkSession is 
created

### What is this PR for?
The issue is that we create 2 SparkSession in zeppelin_pyspark.py (Because 
we create SQLContext first which will create SparkSession underlying). This 
cause 2 instances of SparkSession in JVM side and this means we have 2 
instances of Catalog as well. So udf registered in SQLContext can be used in 
SparkSession. This PR will create SparkSession first and then assign its 
internal SQLContext to sqlContext in pyspark. 


### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1442

### How should this be tested?
Integration test is added. 

### Screenshots (if appropriate)

![image](https://cloud.githubusercontent.com/assets/164491/18774832/7f270de4-818f-11e6-9e4f-c4def4353e5c.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

…

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1442

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1452


commit 948e8657634686f16a405b3938884a5fe48dfc1c
Author: Jeff Zhang 
Date:   2016-09-23T05:08:49Z

ZEPPELIN-1442. UDF can not be found due to 2 instances of SparkSession is 
created

commit 66ec1b9cf5f244ec3b61594f3de86c34ca117175
Author: Jeff Zhang 
Date:   2016-09-23T08:18:24Z

fix unit test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1455: Organize env.sh and site.xml config templates a...

2016-09-23 Thread r-kamath
GitHub user r-kamath opened a pull request:

https://github.com/apache/zeppelin/pull/1455

Organize env.sh and site.xml config templates and docs

### What is this PR for?
Organize env.sh and site.xml config templates and docs

### What type of PR is it?
Improvement

### What is the Jira issue?
ZEPPELIN-1484

### How should this be tested?
Read config templates and install doc

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? yes (done)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/r-kamath/zeppelin config-props

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1455


commit 5570be68307c22eabeaba94acddb1e42e4076f87
Author: Renjith Kamath 
Date:   2016-09-23T11:11:47Z

organize config properties




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...

2016-09-23 Thread r-kamath
Github user r-kamath commented on the issue:

https://github.com/apache/zeppelin/pull/1429
  
@felixcheung removed "Copy of" prefix.
@AhyoungRyu fixed folder related issue.
@corneadoug fixed sequence bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1416: Rewrite of "Quick Start" page.

2016-09-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1416
  
@rfilmyer Do you need any help? :D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---



[GitHub] zeppelin issue #1334: [ZEPPELIN-682] New interpreter for Apache Beam (incuba...

2016-09-23 Thread mfelgamal
Github user mfelgamal commented on the issue:

https://github.com/apache/zeppelin/pull/1334
  
@bzz rebased.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1453: [ZEPPELIN-1482] Load updated dependency library...

2016-09-23 Thread minahlee
GitHub user minahlee opened a pull request:

https://github.com/apache/zeppelin/pull/1453

[ZEPPELIN-1482] Load updated dependency library on interpreter restart

### What is this PR for?
If user specifies library path in interpreter dependency setting, even when 
the file on this path is updated, new file doesn't take effect on interpreter 
_restart_ but does only when user _clicks Edit -> Save._
The mechanism of dependency loading is copying all dependency libraries 
under `local-repo/
{interpreterId}` and add these directory to classpath of interpreter 
process. Zeppelin copies these dependencies either on Zeppelin startup or 
dependency saving/editing.

This PR checks if the library on specified local path is updated, and copy 
them to `local-repo/
{interpreterId}` on restart if there is change.

### What type of PR is it?
Bug Fix & Improvement

### What is the Jira issue?
[ZEPPELIN-1482](https://issues.apache.org/jira/browse/ZEPPELIN-1482)

### How should this be tested?
1. Download commons-csv-1.1.jar and commons-csv-1.2.jar to /my/path
2. cp commons-csv-1.2.jar /my/path/commons-csv.jar
3. Set dependency artifact of spark interpreter to /my/path/commons-csv.jar
4. Run `%spark import org.apache.commons.csv.CSVFormat.Predefined` in 
paragraph and see if it runs without error
5. cp commons-csv-1.1.jar /my/path/commons-csv.jar
6. Restart spark interpreter
7. Run `%spark import org.apache.commons.csv.CSVFormat.Predefined` in 
paragraph and see if error occurs.

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1482

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1453


commit 6662e930b4e51e2ff9195a0c8dfbf1bf9029d837
Author: Mina Lee 
Date:   2016-09-23T08:51:39Z

Check if dependency library on specified path has changed and copy them 
under local-repo/{interpreterId} on interpreter restart




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...

2016-09-23 Thread corneadoug
Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1429
  
Except for the folder issue that @AhyoungRyu reported, I found another bug 
where the number do not increment:
* Make a clone
* Go back to the original note
* Make another clone, the number is still 1 even though 1 already exist


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1339: [ZEPPELIN-1332] Remove spark-dependencies & suggest ne...

2016-09-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1339
  
I think 
[ZEPPELIN-1101](https://issues.apache.org/jira/browse/ZEPPELIN-1101) can also 
be resolved by this change. 

>It looks related to ZEPPELIN-1099 which is about removing dependencies 
from Spark. I think we don't need to build spark-dependencies by ourselves. 
we'd better support script to download spark binary and set SPARK_HOME. How 
about it?

@jongyoul As you replied like above in ZEPPELIN-1101, could you please take 
a look this one? :)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1431: [ZEPPELIN-1446] Fix broken layout of `Create ne...

2016-09-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1431


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...

2016-09-23 Thread corneadoug
Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1290
  
@mwkang Just tested quickly, I will have to run more test to check the 
behavior in general.
There is some refactoring needed, I left some comments.

Otherwise, a more global question, do we want to change the current default 
behavior of run?
I would understand about adding another CTRL + ENTER shortcut to do 
something else.
But what we are doing here is a breaking change to how Zeppelin use to 
behave.

And there is also a lot of other way to run a paragraph, where we will need 
to decide how they react to that change too:
* Click on paragraph run button
* Click on run all paragraph button
* CTRL + enter shortcut
* SHIFT + enter shortcut
* $on('runParagraph')
* Angular display system runParagraph




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1482) Reload local dependencies to interpreter on restart if the library has changed

2016-09-23 Thread Mina Lee (JIRA)
Mina Lee created ZEPPELIN-1482:
--

 Summary: Reload local dependencies to interpreter on restart if 
the library has changed
 Key: ZEPPELIN-1482
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1482
 Project: Zeppelin
  Issue Type: Bug
Reporter: Mina Lee
Assignee: Mina Lee


If user specifies dependency path in interpreter dependency setting, even when 
the file in that path is updated, updated file doesn't take effect on 
interpreter restart but only when user click Edit -> Save.

The mechanism of dependency loading is copying all dependency libraries under 
interpreter/{interpreterId} directory and add these directory to classpath of 
interpreter process. Zeppelin copies these dependency files either on Zeppelin 
startup or dependency information saving/editing.

Zeppelin also need to check if the file is updated, and copy them again on 
restart if there is change.

Here is the bug report on users mailing list
http://apache-zeppelin-users-incubating-mailing-list.75479.x6.nabble.com/Dependency-jars-not-refreshed-after-interpreter-restart-in-Zeppelin-0-6-1-td4035.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...

2016-09-23 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1429
  
@r-kamath Thanks for the improvement. It's better than just "Untitled Note 
#" . 

But regarding `Copy of`, I agree with @felixcheung. If an user tries to 
clone a notebook in `this/is`, then `is 1` note will be created under `Copy of 
this` folder. It's a bit awkward in my point of view.
https://cloud.githubusercontent.com/assets/10060731/18780471/afe6815c-81b8-11e6-9233-da67412cc82f.png;
 width="400px">  

So just numbering would be enough I guess. What do you think? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...

2016-09-23 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1426
  
Thanks for the info, I agree that the long term solution would be using [ 
support multiple interpreter 
result](https://issues.apache.org/jira/browse/ZEPPELIN-212). But for livy 
interpreter, it is very hard to figure out which spark app each session 
represent. And I think multiple user environment is common for livy users so 
additional info would be very helpful for livy users. So how about adding a new 
option to livy interpreter for this feature and by default it is turned off ? 
When [ support multiple interpreter 
result](https://issues.apache.org/jira/browse/ZEPPELIN-212) is implemented, we 
can turn the feature on by default. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1426: ZEPPELIN-1430. Display appId and webui link in LivyInt...

2016-09-23 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1426
  
Add @felixcheung for review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1396: [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.

2016-09-23 Thread astroshim
Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1396
  
CI has passed. please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1449: [MINOR] Change Markdown class name from Markdown to Ma...

2016-09-23 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1449
  
@Leemoonsoo Thank you for pointing it out. I think changing the class name 
to `Markdown` is more proper way to avoid compatibility issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1480) Blocking message pending 10000 for BLOCKING

2016-09-23 Thread SanAh Kang (JIRA)
SanAh Kang created ZEPPELIN-1480:


 Summary: Blocking message pending 1 for BLOCKING
 Key: ZEPPELIN-1480
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1480
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.6.1
Reporter: SanAh Kang
Priority: Critical


노트북을 5분 간격으로 스케쥴 걸었는데 빈번하게 Blocking message pending 1 for BLOCKING 에러 발생하면서 
멈춥니다.

spark paragraph에서 변수 초기화 하고, angular paragraph에서 값 input 받아 run 시키는 로직이고요, 
spark paragraph에서 pending 상태로 제플린 통으로 멈추며 restart 전에는 해결 안 됩니다.

해당 notebook은 jdbc, spark, angular, md 인터프리터 사용중이며, TV에 띄워놓는 KPI 화면이고요.

RUN 버튼 클릭 시 z.runParagraph로 7~8개 정도의 파라그래프를 실행시키고 있습니다.

*한국 오시거든 함 방문해보셔도 좋아요. - _-;;

[~Ahyoung] [~moon]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (ZEPPELIN-1481) Blocking message pending 10000 for BLOCKING

2016-09-23 Thread SanAh Kang (JIRA)
SanAh Kang created ZEPPELIN-1481:


 Summary: Blocking message pending 1 for BLOCKING
 Key: ZEPPELIN-1481
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1481
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.6.1
Reporter: SanAh Kang
Priority: Critical


노트북을 5분 간격으로 스케쥴 걸었는데 빈번하게 Blocking message pending 1 for BLOCKING 에러 발생하면서 
멈춥니다.

spark paragraph에서 변수 초기화 하고, angular paragraph에서 값 input 받아 run 시키는 로직이고요, 
spark paragraph에서 pending 상태로 제플린 통으로 멈추며 restart 전에는 해결 안 됩니다.

해당 notebook은 jdbc, spark, angular, md 인터프리터 사용중이며, TV에 띄워놓는 KPI 화면이고요.

RUN 버튼 클릭 시 z.runParagraph로 7~8개 정도의 파라그래프를 실행시키고 있습니다.

*한국 오시거든 함 방문해보셔도 좋아요. - _-;;

[~Ahyoung] [~moon]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1448: [MINOR] Remove spaces between intepreter group and nam...

2016-09-23 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1448
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1446: ZEPPELIN-1263. Should specify zeppelin's spark configu...

2016-09-23 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1446
  
@Leemoonsoo @jongyoul @felixcheung Please help review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1479) Blocking message pending 10000 for BLOCKING

2016-09-23 Thread SanAh Kang (JIRA)
SanAh Kang created ZEPPELIN-1479:


 Summary: Blocking message pending 1 for BLOCKING
 Key: ZEPPELIN-1479
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1479
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.6.1
Reporter: SanAh Kang
Priority: Critical


5분 간격으로 스케쥴링 도는 노트북이 빈번하게 Blocking message pending 1 for BLOCKING 에러 발생하면서 
멈춥니다.

jdbc, spark, angular, md 인터프리터 사용중이며, TV에 띄워놓는 KPI 화면입니다.

*한국 오시거든 함 방문해보셔도 좋아요. - _-;;

[~Ahyoung] [~moon]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1439: [ZEPPELIN-1423] Allow users to specify pre/post-execut...

2016-09-23 Thread agoodm
Github user agoodm commented on the issue:

https://github.com/apache/zeppelin/pull/1439
  
@felixcheung Sure thing, I can do that in a bit.

As for the issue of the default value for `replName`, are you simply 
referring to the use case for different interpreters, or some variants of 
pyspark itself (eg, `%.pyspark`)? If it's the latter, then I do 
agree that there should be a more elegant way to pick the default value in case 
the spark interpreter group is not set as the default, so any good ideas on how 
to go about this are appreciated. If you are just talking about how this is 
implemented on the scala (%spark) side though, I implemented a similar 
convenience method in the original `ZeppelinContext` class, but instead assumes 
"spark" is the default `replName`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1415: [ZEPPELIN-1026] set syntax highlight based on d...

2016-09-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1415


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1439: [ZEPPELIN-1423] Allow users to specify pre/post-execut...

2016-09-23 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1439
  
That's great - would you like to update the rest of the file to make the 
style consistent?

I understand the default value - I'm only pointing out that there are many 
users and use cases out there that do not use "pyspark" as name?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...

2016-09-23 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1445
  
I believe so.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...

2016-09-23 Thread r-kamath
Github user r-kamath commented on the issue:

https://github.com/apache/zeppelin/pull/1429
  
@felixcheung I think either we remove "Copy of" or make it localizable. 
Will wait comments from others before making the choice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1408: [ZEPPELIN-808] Changed Permissions on Notebooks do not...

2016-09-23 Thread corneadoug
Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1408
  
@kavinkumarks This look like a good start, but is it the only case we wan't 
to handle here?

Maybe it's because of the way we test this PR, but if I change the system 
notebook permission to read only (chmod 444), I can't run it, but everything I 
do is still there after page refresh.

If I restart zeppelin-server, the notebook isn't there anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---