[GitHub] zeppelin issue #1485: Prevent from version collision on test task

2016-10-04 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1485 I've tested your branch, but it occurs another error. Could you please check it? ``` [ERROR] Failed to execute goal

[jira] [Created] (ZEPPELIN-1519) AM/PM of dates are ignored when reading note.json

2016-10-04 Thread Sangmin Yoon (JIRA)
Sangmin Yoon created ZEPPELIN-1519: -- Summary: AM/PM of dates are ignored when reading note.json Key: ZEPPELIN-1519 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1519 Project: Zeppelin

[GitHub] zeppelin pull request #1486: [ZEPPELIN-1518] Fix for: Lambda expressions are...

2016-10-04 Thread mvitaly
GitHub user mvitaly opened a pull request: https://github.com/apache/zeppelin/pull/1486 [ZEPPELIN-1518] Fix for: Lambda expressions are not working on CDH 5.7.x Spark ### What is this PR for? Lambda expressions are not working on CDH 5.7.x Spark because of the backported

[jira] [Created] (ZEPPELIN-1518) Lambda expressions are not working on CDH 2.7x Spark

2016-10-04 Thread Vitaly Polonetsky (JIRA)
Vitaly Polonetsky created ZEPPELIN-1518: --- Summary: Lambda expressions are not working on CDH 2.7x Spark Key: ZEPPELIN-1518 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1518 Project:

[GitHub] zeppelin issue #1471: Closes [ZEPPELIN-1505] Add Scio interpreter

2016-10-04 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1471 @ravwojdyla Here is the list of dependencies from `mvn dependency:tree`. All of them will become part of the Zeppelin binary package. What needed to be done is - make sure that

Re: How Apache Zeppelin runs a paragraph

2016-10-04 Thread Jongyoul Lee
Hello DuyHai, Thanks for the fixing the typo. I've fixed it. Concerning the debugging, I think writing posts or updating wiki would be better. I'm willing to write a simple post for that remote debugging. On Tue, Oct 4, 2016 at 5:53 PM, DuyHai Doan wrote: > Hello

[GitHub] zeppelin pull request #1482: ZEPPELIN-1410 SLF4J: Class path contains multip...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin issue #1471: Closes [ZEPPELIN-1505] Add Scio interpreter

2016-10-04 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1471 @ravwojdyla Can you add `docs/interpreter/scio.md` path below [this line](https://github.com/apache/zeppelin/blob/master/docs/_includes/themes/zeppelin/_navigation.html#L68)? --- If your

[GitHub] zeppelin pull request #:

2016-10-04 Thread dguoy
Github user dguoy commented on the pull request: https://github.com/apache/zeppelin/commit/7d8bcbb30e5e1522f030342b3b7cd7421dc582f8#commitcomment-19297063 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin pull request #1484: [branch-0.6] Take care of comma/tab escape in c...

2016-10-04 Thread minahlee
GitHub user minahlee opened a pull request: https://github.com/apache/zeppelin/pull/1484 [branch-0.6] Take care of comma/tab escape in csv/tsv download ### What is this PR for? This PR backports #1445 to branch-0.6 since using `./dev/test_zeppelin_pr.py` throws alert for

[GitHub] zeppelin issue #1482: ZEPPELIN-1410 SLF4J: Class path contains multiple SLF4...

2016-10-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1482 Changes look good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zeppelin issue #1483: [ZEPPELIN-1509] Run certain SparkInterpreter tests onl...

2016-10-04 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1483 Changes look good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: Refactor time !

2016-10-04 Thread Anthony Corbacho
I think about the abuse of @Inject and circular deps, it is just matter of education. On Tue, Oct 4, 2016 at 8:05 PM, DuyHai Doan wrote: > About DI I have no strong opinion on the topic. > > I have coded frameworks with just manual DI (through constructor and > context

[GitHub] zeppelin issue #1481: [ZEPPELIN-1466] Make %dep work for spark 2.0 when SPAR...

2016-10-04 Thread minahlee
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1481 Merge if there is no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1471: Closes [ZEPPELIN-1505] Add Scio interpreter

2016-10-04 Thread ravwojdyla
Github user ravwojdyla commented on the issue: https://github.com/apache/zeppelin/pull/1471 ping @AhyoungRyu @zjffdu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin pull request #1483: [ZEPPELIN-1509] Run certain SparkInterpreter te...

2016-10-04 Thread minahlee
GitHub user minahlee opened a pull request: https://github.com/apache/zeppelin/pull/1483 [ZEPPELIN-1509] Run certain SparkInterpreter tests only for Spark >= 1.3 ### What is this PR for? There are several test cases that are applicable only after Spark 1.3(For example,

[jira] [Created] (ZEPPELIN-1517) Document notebook format

2016-10-04 Thread Aish Fenton (JIRA)
Aish Fenton created ZEPPELIN-1517: - Summary: Document notebook format Key: ZEPPELIN-1517 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1517 Project: Zeppelin Issue Type: Improvement

[GitHub] zeppelin issue #1482: ZEPPELIN-1410 SLF4J: Class path contains multiple SLF4...

2016-10-04 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1482 It looks like lens issue only. Can you change the title of this PR and Jira issue? Concerning the change, LGTM. Thanks for the contribution. --- If your project is set up for it, you can reply

[GitHub] zeppelin pull request #1482: ZEPPELIN-1410 SLF4J: Class path contains multip...

2016-10-04 Thread snaveenp
GitHub user snaveenp opened a pull request: https://github.com/apache/zeppelin/pull/1482 ZEPPELIN-1410 SLF4J: Class path contains multiple SLF4J bindings SLF4J is having 2 depedencies in classpath. one is slf4j-log4j12 and another is logback. The Logback is added in class path by

Re: Refactor time !

2016-10-04 Thread DuyHai Doan
About DI I have no strong opinion on the topic. I have coded frameworks with just manual DI (through constructor and context objects) and it works pretty well, even for a big project, as long as the context objects have meaningfull names Using DI frameworks like Spring or Guice is also a valid

Re: Refactor time !

2016-10-04 Thread Anthony Corbacho
You made my day, this is the kind of email i really like !! I think its a great idea and i am willing to spend sometime on it. I also want to move to a DI (guice) architecture , let me know what you think about it. On Tuesday, 4 October 2016, DuyHai Doan wrote: > Hello

[GitHub] zeppelin issue #1458: [ZEPPELIN-1486] Allow configuring whether shown values...

2016-10-04 Thread spektom
Github user spektom commented on the issue: https://github.com/apache/zeppelin/pull/1458 @r-kamath I've added documentation to the `zeppelin-env.sh.template` file, but I couldn't find any other option related to Livy interpreter in `zeppelin-site.xml.template`, so I've left this file

[GitHub] zeppelin issue #1458: [ZEPPELIN-1486] Allow configuring whether shown values...

2016-10-04 Thread r-kamath
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/1458 @spektom thanks for the improvement. Can you also update`conf/zeppelin-env.sh.template` and `conf/zeppelin-site.xml.template` with env name/property name and description. --- If your project

[GitHub] zeppelin pull request #1481: [ZEPPELIN-1466] Make %dep work for spark 2.0 wh...

2016-10-04 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1481 [ZEPPELIN-1466] Make %dep work for spark 2.0 when SPARK_HOME is not defined ### What is this PR for? %dep does not work for spark 2.0 when SPARK_HOME is not defined. Problem described

Refactor time !

2016-10-04 Thread DuyHai Doan
Hello devs The code base of Zeppelin has grown very fast in the last 12 months and it's great. It means that we have more and more contributors. However, to make the project maintainable at long term, we need regular code refactoring. I have some ideas to share with you 1) Use Java 8 to

Re: How Apache Zeppelin runs a paragraph

2016-10-04 Thread DuyHai Doan
Hello Jongyoul Excellent write up to demystify the execution life-cycle of a paragraph. There is a small typo in the blog: "At last, it has two words separated by comma, *getInterpreter* handles it as “%{group_name}.{interpreter_name}”" Instead of comma, shouldn't it be DOT (.) ? There is also

[GitHub] zeppelin issue #1477: [ZEPPELIN-1512] Support Kylin project name in interpre...

2016-10-04 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1477 I've no preference about adding some properties in a paragraph but you need to update docs for that feature in details. --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin issue #1477: [ZEPPELIN-1512] Support Kylin project name in interpre...

2016-10-04 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1477 Thanks for the contribution. I'll start review this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1467: [ZEPPELIN-1488] JDBC Interpreter throws error while th...

2016-10-04 Thread rajarajan-g
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1467 Oh. Its' ok. now i see your comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1467: [ZEPPELIN-1488] JDBC Interpreter throws error while th...

2016-10-04 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1467 I've left my review in four days ago. But I misunderstood new Github's review system. I left my comment again as a singe comment. Can you see it? --- If your project is set up for it, you can

[GitHub] zeppelin issue #1467: [ZEPPELIN-1488] JDBC Interpreter throws error while th...

2016-10-04 Thread rajarajan-g
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1467 i didn't get the question. Can you please share it again ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

How Apache Zeppelin runs a paragraph

2016-10-04 Thread Jongyoul Lee
Hello devs and users, I've submitted a post into Apache Zeppelin Stories on medium.com: https://medium.com/apache-zeppelin-stories/how-apache-zeppelin-runs-a-paragraph-783a0a612ba9#.x9ym8fovv I hope all users and contributors understand Apache Zeppelin deeply. Regards, Jongyoul -- 이종열,

[GitHub] zeppelin issue #1467: [ZEPPELIN-1488] JDBC Interpreter throws error while th...

2016-10-04 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1467 Can you answer my question? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and