[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1462
  
Livy interpreter is not a trivial interpreter although it use rest api. The 
current unit test is not sufficient to guarantee the quality of livy 
interpreter. I have found some issues there, but before doing improvement and 
fix, I would like to commit this integration test, otherwise I have to manually 
test it after each fix and refactor. I know committing jars is not a good 
practise, but this is the only workaround I can think of.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1502: [gh-pages] Separate "Supported Interpreters" table fro...

2016-10-10 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1502
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1462
  
As I have stated, I think these tests are good to have but worry about the 
added complicity for a source release having these jars in the "source", 
especially since these jars are not from an ASF project.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1503: NPE LivySparkSQLInterpreter thrown with %livy.sql inte...

2016-10-10 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1503
  
@gss2002 I have to admit there's lots of issues in livy interpreter. Your 
changes seems a little big for this fix. Would use `ConcurrentHashMap` directly 
work for you ? rather than declare `LivyPySparkSessionMap` and 
`LivySparkSessionMap`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1503: NPE LivySparkSQLInterpreter thrown with %livy.sql inte...

2016-10-10 Thread gss2002
Github user gss2002 commented on the issue:

https://github.com/apache/zeppelin/pull/1503
  
Attempted to use the work around (protected static Map 
userSessionMap = new HashMap<>(); ) provided by @zjffdu it did not work. So I 
went with the more involved re-write and it has solved our problems in our 
large scale environment and provides the correct sharing between session 
contexts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1503: NPE LivySparkSQLInterpreter thrown with %livy.s...

2016-10-10 Thread gss2002
GitHub user gss2002 opened a pull request:

https://github.com/apache/zeppelin/pull/1503

NPE LivySparkSQLInterpreter thrown with %livy.sql interpreter function

### What is this PR for?
The LivySparkSQLInterpreter class does not correctly process the 
userSessionMap throwing back an NPE when using %livy.sql or %sql when livy is 
default binding. This prevents correct sharing between Spark Sessions and 
SparkSQL Sessions. I have attached a fix that implements seperate static single 
instance classes that manage userSessionMaps.


### What type of PR is it?
Bug Fix/Improvement

### Todos
Documentation/Unit Tests

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1516

### How should this be tested?
Run %sql or %livy.sql against a sql enabled dataset such as hive metastore.

### Questions:
* Does the licenses files need update? n
* Is there breaking changes for older versions? n
* Does this needs documentation? m



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gss2002/zeppelin ZEPPELIN-1516

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1503


commit 11bcd2d1db02ff2dbb2a8e560e3f09fe37057796
Author: gss2002 
Date:   2016-10-11T04:09:23Z

ZEPPELIN-1516 Static/Singleton for userSessionMaps




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1502: [gh-pages] Separate "Supported Interpreters" ta...

2016-10-10 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request:

https://github.com/apache/zeppelin/pull/1502

[gh-pages] Separate "Supported Interpreters" table from Zeppelin download 
page

### What is this PR for?
Currently "Available Interpreters" table is located under [Zeppelin 
download 
page](https://zeppelin.apache.org/download.html#available-interpreters). But 
this page can't be the first page for the beginners(or any Zeppelin users). So 
it would be better to separate this page from download page for the future 
usage. Please see the attached screenshot gif :)

### What type of PR is it?
Documentation & gh-pages

### How should this be tested?
Checkout `gh-pages` branch and build locally as described in 
[here](https://github.com/apache/zeppelin/tree/gh-pages#build-website). 

### Screenshots (if appropriate)
Just FYI, I changed each interpreters name from plain text to header 
tag(``) so that users can use header anchor. 
(e.g. https://zeppelin.apache.org/supported_interpreters.html#jdbc )


![update](https://cloud.githubusercontent.com/assets/10060731/19257329/9e49277a-8fa9-11e6-8701-b77e9ec6a73e.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/zeppelin gh-page/separatePage

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1502.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1502


commit 7e0cb5245489f6f83467618fda269b1e9e57e393
Author: AhyoungRyu 
Date:   2016-10-11T02:53:14Z

Separate 'supported interpreters' table from download.md




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [VOTE] Release Apache Zeppelin 0.6.2 (rc1)

2016-10-10 Thread Ahyoung Ryu
+1



On Tue, Oct 11, 2016 at 10:24 AM, Jeff Zhang  wrote:

> +1, teste with spark 2.0 with basic notes,  ZeppelinContext and UDF works
> correctly.
>
> On Tue, Oct 11, 2016 at 8:41 AM, Anthony Corbacho <
> corbacho.anth...@gmail.com> wrote:
>
> > +1
> >
> > I tested with my notebooks works as expected.
> > Great job!
> >
> > On Mon, Oct 10, 2016 at 9:34 PM, Mina Lee  wrote:
> >
> > > Hi folks,
> > >
> > > I propose the following RC to be released for the Apache Zeppelin
> > > 0.6.2 release.
> > >
> > > The commit id is 9a44590841d5d83da1a297d507f6e2e67784ba1f which is
> > > corresponds to the tag v0.6.2-rc1:
> > > https://git-wip-us.apache.org/repos/asf?p=zeppelin.git;a=commit;h=
> > > 9a44590841d5d83da1a297d507f6e2e67784ba1f
> > >
> > > The release archives (tgz), signature, and checksums are here
> > > https://dist.apache.org/repos/dist/dev/zeppelin/zeppelin-0.6.2-rc1/
> > >
> > > The release candidate consists of the following source distribution
> > archive
> > > zeppelin-0.6.2.tgz
> > >
> > > In addition, the following supplementary binary distributions are
> > provided
> > > for user convenience at the same location
> > > zeppelin-0.6.2-bin-all.tgz
> > > zeppelin-0.6.2-netinst-all.tgz
> > >
> > > The maven artifacts are here
> > > https://repository.apache.org/content/repositories/
> > orgapachezeppelin-1019
> > >
> > > You can find the KEYS file here:
> > > https://people.apache.org/keys/committer/minalee.asc
> > >
> > > Release notes available at
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > projectId=12316221=12338135
> > >
> > > Vote will be open for next 72 hours (close at 6am 13/Oct PDT).
> > >
> > > [ ] +1 approve
> > > [ ] 0 no opinion
> > > [ ] -1 disapprove (and reason why)
> > >
> >
>
>
>
> --
> Best Regards
>
> Jeff Zhang
>


Re: [VOTE] Release Apache Zeppelin 0.6.2 (rc1)

2016-10-10 Thread Jeff Zhang
+1, teste with spark 2.0 with basic notes,  ZeppelinContext and UDF works
correctly.

On Tue, Oct 11, 2016 at 8:41 AM, Anthony Corbacho <
corbacho.anth...@gmail.com> wrote:

> +1
>
> I tested with my notebooks works as expected.
> Great job!
>
> On Mon, Oct 10, 2016 at 9:34 PM, Mina Lee  wrote:
>
> > Hi folks,
> >
> > I propose the following RC to be released for the Apache Zeppelin
> > 0.6.2 release.
> >
> > The commit id is 9a44590841d5d83da1a297d507f6e2e67784ba1f which is
> > corresponds to the tag v0.6.2-rc1:
> > https://git-wip-us.apache.org/repos/asf?p=zeppelin.git;a=commit;h=
> > 9a44590841d5d83da1a297d507f6e2e67784ba1f
> >
> > The release archives (tgz), signature, and checksums are here
> > https://dist.apache.org/repos/dist/dev/zeppelin/zeppelin-0.6.2-rc1/
> >
> > The release candidate consists of the following source distribution
> archive
> > zeppelin-0.6.2.tgz
> >
> > In addition, the following supplementary binary distributions are
> provided
> > for user convenience at the same location
> > zeppelin-0.6.2-bin-all.tgz
> > zeppelin-0.6.2-netinst-all.tgz
> >
> > The maven artifacts are here
> > https://repository.apache.org/content/repositories/
> orgapachezeppelin-1019
> >
> > You can find the KEYS file here:
> > https://people.apache.org/keys/committer/minalee.asc
> >
> > Release notes available at
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12316221=12338135
> >
> > Vote will be open for next 72 hours (close at 6am 13/Oct PDT).
> >
> > [ ] +1 approve
> > [ ] 0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
>



-- 
Best Regards

Jeff Zhang


[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.

2016-10-10 Thread astroshim
Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1302
  
@corneadoug, @Leemoonsoo  I re-based and added testcase. please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1433: [ZEPPELIN-1451] Bug fix of Embedding %html within %tab...

2016-10-10 Thread astroshim
Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1433
  
@Leemoonsoo ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1501: [ZEPPELIN-1532] Remove map visualization from s...

2016-10-10 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request:

https://github.com/apache/zeppelin/pull/1501

[ZEPPELIN-1532] Remove map visualization from source tree, because of 
incompatible license

### What is this PR for?
According to https://developers.arcgis.com/terms/ and and 
http://www.esri.com/legal/software-license, current map visualization depends 
on an online service that has incompatible restrictions to Apache 2 license. 
Please see https://github.com/apache/zeppelin/pull/1210#issuecomment-252484382

Possible alternative way is explained 
[here](https://github.com/apache/zeppelin/pull/1210#issuecomment-252763598).

I'm very sad to remove this very good contribution. So please anyone review 
the license and comment here if you have other opinions, or other way around.


### What type of PR is it?
[Task]

### Todos
* [x] - remove implementation from source tree

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1532


### Questions:
* Does the licenses files need update? yes
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-1532

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1501


commit 67f72fe1ccf6e29cdfe945bc8eb0ecbfc649fa14
Author: Lee moon soo 
Date:   2016-10-10T22:37:00Z

Remove map visualization from source tree

commit 85efd1bd31b6e0ae9bc98d448fb9269f90949320
Author: Lee moon soo 
Date:   2016-10-10T22:45:24Z

Remove map visualization




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1210: [ZEPPELIN-1220] Add geographical map as visualization ...

2016-10-10 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1210
  
Visualizations have incompatible license can be packaged as a [Helium 
application](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/helium/Application.java)
 and loaded dynamically. Soon, there will be [highlevel 
api](https://issues.apache.org/jira/browse/ZEPPELIN-1003) to make visualization 
easier based on helium.
In the future, we'll have online registry for applications. So, please 
consider [use helium 
framework](http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelinapplication.html).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1532) Remove Map visualization from source tree

2016-10-10 Thread Lee moon soo (JIRA)
Lee moon soo created ZEPPELIN-1532:
--

 Summary: Remove Map visualization from source tree
 Key: ZEPPELIN-1532
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1532
 Project: Zeppelin
  Issue Type: Task
Affects Versions: 0.7.0
Reporter: Lee moon soo
Assignee: Lee moon soo
 Fix For: 0.7.0


Current map visualization implementation does depends on incompatible license.

More details are commented here
https://github.com/apache/zeppelin/pull/1210#issuecomment-252484382

I think we need to remove map visualization from source tree.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1476: [WIP] ZEPPELIN-335. Pig Interpreter

2016-10-10 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1476
  
Do you intent to include the TODO in this PR, or as a follow up?
Otherwise I think this is good to go - you can remove the WIP in the title 
and I'll merge if there is no more comment.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1500: [ZEPPELIN-1371]add text/numeric conversion support to ...

2016-10-10 Thread Peilin-Yang
Github user Peilin-Yang commented on the issue:

https://github.com/apache/zeppelin/pull/1500
  
@corneadoug It was really messy to rebase so I created this new PR. The 
previous one was closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1500: [ZEPPELIN-1371]add text/numeric conversion supp...

2016-10-10 Thread Peilin-Yang
GitHub user Peilin-Yang opened a pull request:

https://github.com/apache/zeppelin/pull/1500

[ZEPPELIN-1371]add text/numeric conversion support to table display

### What is this PR for?
We people in Twitter have great demand of adding a flexible drop down menu 
for the columns in the tables which enables the text/numeric conversion.
This is because people want some columns to be of string type which, for 
example, fits to the underlying DB definition.
The use cases of the change include:

1. For now sorting on the columns is always lexicographically because 
Zeppelin front end treats the data as strings. It the values in the table can 
be convertible between string and number then we can sort the column by numeric 
values. I have filed another ticket for this: 
https://issues.apache.org/jira/browse/ZEPPELIN-1372
2. Since the users know more about their data than us it would be nice if 
we let the users decide what is the real type of their data. It is annoying if 
user wants the column to be strings but the front end forcefully inserts commas 
in it. In some scenarios, users may also want to copy/paste the table to 
somewhere else. If people want to remove the commas before other actions then 
that will be a nightmare 


### What type of PR is it?
[Improvement | Feature]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1371

### How should this be tested?

1. Click on the dropdown menu would convert the text/number of that column.
2. Other functionalities esp. the sorting function should not be affected.

### Screenshots (if appropriate)

![image](https://cloud.githubusercontent.com/assets/3334391/18445617/76071f8e-78ec-11e6-93a6-fdcf7b85b6e9.png)

![image](https://cloud.githubusercontent.com/assets/3334391/18446601/16cff4f0-78f1-11e6-9fd6-4010b5d77f17.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? Probably a noticeable 
change in UI
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Peilin-Yang/zeppelin 
ypeilin/table_num_cell_format

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1500


commit 3f1d12078704c20b92f3845d0dced41e2c668a45
Author: Peilin Yang 
Date:   2016-10-10T16:35:04Z

add dropdown menu applied on the latest branch




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1363: [ZEPPELIN-1371]add text/numeric conversion supp...

2016-10-10 Thread Peilin-Yang
Github user Peilin-Yang closed the pull request at:

https://github.com/apache/zeppelin/pull/1363


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1460: [ZEPPELIN-1490] pass subject while persisting note on ...

2016-10-10 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1460
  
ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1459: [ZEPPELIN-1487] Resolve possible NPEs in storage sync ...

2016-10-10 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1459
  
ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[VOTE] Release Apache Zeppelin 0.6.2 (rc1)

2016-10-10 Thread Mina Lee
Hi folks,

I propose the following RC to be released for the Apache Zeppelin
0.6.2 release.

The commit id is 9a44590841d5d83da1a297d507f6e2e67784ba1f which is
corresponds to the tag v0.6.2-rc1:
https://git-wip-us.apache.org/repos/asf?p=zeppelin.git;a=commit;h=9a44590841d5d83da1a297d507f6e2e67784ba1f

The release archives (tgz), signature, and checksums are here
https://dist.apache.org/repos/dist/dev/zeppelin/zeppelin-0.6.2-rc1/

The release candidate consists of the following source distribution archive
zeppelin-0.6.2.tgz

In addition, the following supplementary binary distributions are provided
for user convenience at the same location
zeppelin-0.6.2-bin-all.tgz
zeppelin-0.6.2-netinst-all.tgz

The maven artifacts are here
https://repository.apache.org/content/repositories/orgapachezeppelin-1019

You can find the KEYS file here:
https://people.apache.org/keys/committer/minalee.asc

Release notes available at
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316221=12338135

Vote will be open for next 72 hours (close at 6am 13/Oct PDT).

[ ] +1 approve
[ ] 0 no opinion
[ ] -1 disapprove (and reason why)


[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1462
  
Yes, that part I agree, it cannot be tested without jar, `org.mockito.Mock` 
will always mock. 

@Leemoonsoo  @jongyoul @felixcheung any thought about checking in jar(s) ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1531) Allow Multi sql in one paragraph

2016-10-10 Thread lichenglin (JIRA)
lichenglin created ZEPPELIN-1531:


 Summary: Allow Multi sql in one paragraph
 Key: ZEPPELIN-1531
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1531
 Project: Zeppelin
  Issue Type: Bug
  Components: Interpreters
Affects Versions: 0.6.1
Reporter: lichenglin


%sql should support multi sql like this

 
%sql
show tables;
show tables






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1462
  
mockit is for unit test, not for system test. It is just like 
[AbstractTestRestApi](https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/AbstractTestRestApi.java)
 where we will launch real spark cluster and ZeppelinServer. Using mockit can 
not cover lots of cases in real enviroment (e.g. how can I test livy handle 
comment correctly (considering we are doing some preprocessing), how can I test 
SparkContext is shared correctly between %livy.spark and %livy.sql) . I know 
committing jars are not good practise, but these jars won't be available in 
public repository in short time. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1462
  
What I mean to say was, lets mock these till the time we get livy's jar 
from public repo, how do you think about that ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1462
  
@prabhjyotsingh  I dont' get it. This is integration test where I will 
launch a real livy server, how can I use mock to simulate that ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1462
  
Any thought about using `org.mockito.Mock`; example 
https://github.com/apache/zeppelin/blob/master/python/src/test/java/org/apache/zeppelin/python/PythonInterpreterTest.java#L78
 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1530) Change the env variable name DEBUG that Zeppelin used to be a specific name of ZEPPELIN to avoid

2016-10-10 Thread Sherry Xue (JIRA)
Sherry Xue created ZEPPELIN-1530:


 Summary: Change the env variable name DEBUG that Zeppelin used to 
be a specific name of ZEPPELIN to avoid 
 Key: ZEPPELIN-1530
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1530
 Project: Zeppelin
  Issue Type: Improvement
Affects Versions: 0.6.1, 0.6.0, 0.5.6
 Environment: Zeppelin 0.5.6 , Zeppelin 0.6.0, Zeppelin 0.6.1
Reporter: Sherry Xue
Priority: Critical


  During using Zeppelin, found Zeppelin will always export the environment 
variable DEBUG even if there has no defined environment variable DEBUG in 
https://github.com/apache/zeppelin/blob/master/bin/common.sh 
if [[ -z "$DEBUG" ]]; then
  export DEBUG=0
fi
and https://github.com/apache/zeppelin/blob/master/bin/common.cmd
if not defined DEBUG (
set DEBUG=0
)
 When integrating Zeppelin with other products or projects,  this env variable 
DEBUG will unexpectedly enable other products and projects' debug model.Since 
it's one very generic environment variable, can we change this name to one more 
specified to Zeppelin like ZEPPELIN_DEBUG to avoid some such unexpected 
problems when integrating Zeppelin with others(even can we remove it if it's 
not useful now)?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-10 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1462
  
@prabhjyotsingh These jars are not available in public maven repository. Do 
you have any better ideas ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1369: [ZEPPELIN-1376] Add proxy credentials for depen...

2016-10-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1369


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1472: Add message of localhost:port on script

2016-10-10 Thread djKooks
Github user djKooks commented on the issue:

https://github.com/apache/zeppelin/pull/1472
  
@AhyoungRyu No problem~thanks for guide! I'll keep work on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---