[GitHub] zeppelin pull request #1518: [ZEPPELIN-1549] Change NotebookID variable name...

2016-10-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1518


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1553: [ZEPPELIN-1575] Notebook Repo settings UI

2016-10-24 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue:

https://github.com/apache/zeppelin/pull/1553
  
@khalidhuseynov added some tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1471: Closes [ZEPPELIN-1505] Add Scio interpreter

2016-10-24 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1471
  
ah, sorry, I added a reply but it didn't go through apparently.
I think that's good - I'm not sure if scio should be the default of the 
beam group (aren't there more Java users?)

Could you update example, documentation and so on to reflect this change? I 
can do a pass after that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1553: [ZEPPELIN-1575] Notebook Repo settings UI

2016-10-24 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1553
  
@anthonycorbacho thanks for suggesting to change repo settings via UI. 
before testing, do you think we need some unit tests for repo settings feature?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1555: [MINOR] ui improvement

2016-10-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1555


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-10-24 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1538
  
@mfelgamal first of all thanks for initiative on this one, and few points 
here: 
 * as i can see here Zeppelin images will be with hardcoded 
`$ZEPPELIN_HOME/conf` folder and in order to configure it, you'll need to 
rebuild your image. As a possible solution here would be read `conf/` from 
certain place inside container and mount `conf` folder from your local drive to 
there. that may need little change in docker file and run command. 
 * perhaps user can run with interactive (-it) as well as daemon (-d) 
modes, depending on preference. 
 * also regarding running docker with, say, Spark - the easiest should be 
running it in local mode. if you want to point to your cluster, then there will 
be problems since at least port `7077` needs to be available. 

Note that these points may not need to be addressed right in this PR, it's 
more like things to consider and maybe future improvement. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1472: Add message of localhost:port on script

2016-10-24 Thread djKooks
Github user djKooks commented on the issue:

https://github.com/apache/zeppelin/pull/1472
  
@AhyoungRyu Sorry for late reply.
I updated scripts to read port number from environment setups. Please look 
on and let me know if there is any problem on running this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...

2016-10-24 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1462
  
ping @felixcheung @prabhjyotsingh 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1339: [ZEPPELIN-1332] Remove spark-dependencies & suggest ne...

2016-10-24 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1339
  
@Leemoonsoo @jongyoul Sorry for my late update. 
I've just added new option: `get-spark` to 
[zeppelin-daemon.sh](https://github.com/apache/zeppelin/pull/1339/files#diff-bd1714fd11d1853b691468647374113dR23)
 and 
[zeppelin.sh](https://github.com/apache/zeppelin/pull/1339/files#diff-1724182f3ebaf54f5c9e202dcdf82415R46)
 to download local Spark binary. I think this is more simpler than getting 
user's answer and then separating "interactive mode" and "non-interactive mode" 
that @jongyoul mentioned in 
[here](https://github.com/apache/zeppelin/pull/1339#issuecomment-250672904).

So to sum up, ppl can download local Spark with `./bin/zeppelin-daemon.sh 
get-spark` or `./bin/zeppelin.sh get-spark` with my latest update. If this way 
is okay, i'll update related docs pages accordingly. Maybe we need to let ppl 
know the existence of `get-spark` option by updating documentation i think.

What do you think? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1471: Closes [ZEPPELIN-1505] Add Scio interpreter

2016-10-24 Thread ravwojdyla
Github user ravwojdyla commented on the issue:

https://github.com/apache/zeppelin/pull/1471
  
ping @felixcheung 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

2016-10-24 Thread astroshim
Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1538
  
@mfelgamal I checked point 1 and 3. Thank you fix properly.
Could you also fix to run the `R Tutorial` and `Python Tutorial` too?
I think all tutorial should be ran without error. 
What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1518: [ZEPPELIN-1549] Change NotebookID variable name to Not...

2016-10-24 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1518
  
CI passed in https://travis-ci.org/hyonzin/zeppelin/builds/170100291. Merge 
if there is no further discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1539: [ZEPPELIN-1567] Let JDBC interpreter use user credenti...

2016-10-24 Thread astroshim
Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1539
  
 @khalidhuseynov Thank you for sharing your good idea about the dropdown 
list. 
It might gives convenience users. 
and I agree with @Leemoonsoo about define convention for `entity` name.
Let me fix that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1580) JDBC - SQL IN CLAUSE with Form Template does not always

2016-10-24 Thread Sarvesh N (JIRA)
Sarvesh N created ZEPPELIN-1580:
---

 Summary: JDBC - SQL IN CLAUSE with Form Template does not always
 Key: ZEPPELIN-1580
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1580
 Project: Zeppelin
  Issue Type: Bug
Reporter: Sarvesh N


Below multiple checkbox statements do not work

%jdbc
select counter_date, EXTRACT(HOUR FROM counter_time) as hour, avg(value) from 
sampletable.sample1 where  
col1=124 and col2 in (${checkbox:fields='alpha','alpha'|'beta'}) and col3 > 
${date='2016-10-01'} 
and col4 in (${checkbox:fields='omega','zeta'|'delta'}) and col3='delta1'
group by 1,2 order by 1,2 asc;

The below error is thrown, the back end logs show that both the brackets have 
been transformed to empty brackets with no content, how can I set some default 
content, also the checkboxes are not visible

Vertica][VJDBC](4856) ERROR: Syntax error at or near ")"
class java.sql.SQLSyntaxErrorException
com.vertica.util.ServerErrorData.buildException(Unknown Source)
com.vertica.dataengine.VDataEngine.prepareImpl(Unknown Source)
com.vertica.dataengine.VDataEngine.prepare(Unknown Source)
com.vertica.dataengine.VDataEngine.prepare(Unknown Source)
com.vertica.jdbc.common.SStatement.executeNoParams(Unknown Source)
com.vertica.jdbc.common.SStatement.execute(Unknown Source)
org.apache.zeppelin.jdbc.JDBCInterpreter.executeSql(JDBCInterpreter.java:322)
org.apache.zeppelin.jdbc.JDBCInterpreter.interpret(JDBCInterpreter.java:408)
org.apache.zeppelin.interpreter.LazyOpenInterpreter.interpret(LazyOpenInterpreter.java:94)
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:341)
org.apache.zeppelin.scheduler.Job.run(Job.java:176)
org.apache.zeppelin.scheduler.ParallelScheduler$JobRunner.run(ParallelScheduler.java:162)
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
java.util.concurrent.FutureTask.run(FutureTask.java:262)
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1559: [ZEPPELIN-1461] Doesn't display "description" value in...

2016-10-24 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1559
  
\cc @jongyoul @cloverhearts @kjhong for review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1559: [ZEPPELIN-1461] Doesn't display "description" v...

2016-10-24 Thread minahlee
GitHub user minahlee opened a pull request:

https://github.com/apache/zeppelin/pull/1559

[ZEPPELIN-1461] Doesn't display "description" value in interpreter creation 
page

### What is this PR for?
#1522 tried to fix same issue by making as least change as possible, but 
fixing it in backend side looks like more proper approach as 
https://github.com/apache/zeppelin/pull/1522#issuecomment-255109922.
This PR fixes ZEPPELIN-1461 by changing `properties` field of 
`InterpreterSetting` class from `Properties` -> `Object`.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-1461](https://issues.apache.org/jira/browse/ZEPPELIN-1461)

### Screenshots (if appropriate)
Before
![screen shot 2016-10-24 at 8 42 02 
pm](https://cloud.githubusercontent.com/assets/8503346/19644395/5d20a864-9a2a-11e6-806a-8a44e44a108a.png)

After
![screen shot 2016-10-24 at 8 37 17 
pm](https://cloud.githubusercontent.com/assets/8503346/19644281/d72be1ce-9a29-11e6-9b67-6d5de263b0de.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1461

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1559.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1559


commit 9c345b7210f9e97a857f68c912a7a6de37301343
Author: Mina Lee 
Date:   2016-10-24T07:35:44Z

Show description when create new interpreter

commit 4d1467d337247773edf4a125729b22959acefa3e
Author: Mina Lee 
Date:   2016-10-24T08:32:19Z

Fix order of properties in ui and java code style

commit c8cec759dcbcf47cffd9c27a0df2ab3a670d950e
Author: Mina Lee 
Date:   2016-10-24T08:32:56Z

Add selenium test for display description on interpreter create

commit 78bd93f9e15f4da0cebd364d0d9054009df5f33c
Author: Mina Lee 
Date:   2016-10-24T10:54:33Z

Add test checking InterpreterProperty class




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1558: ZEPPELIN-1562 updated api doc

2016-10-24 Thread snaveenp
Github user snaveenp closed the pull request at:

https://github.com/apache/zeppelin/pull/1558


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1558: ZEPPELIN-1562 updated api doc

2016-10-24 Thread snaveenp
GitHub user snaveenp reopened a pull request:

https://github.com/apache/zeppelin/pull/1558

ZEPPELIN-1562 updated api doc

### What is this PR for?
The URL for running a paragraph synchronously using REST api is mistakenly 
given  as 
"http://[zeppelin-server]:[zeppelin-port]/api/notebook/**job**/[notebookId]/[paragraphId]
 " 

Changed the doc as per code

### What type of PR is it?
[Documentation]

### Todos

### What is the Jira issue?
* [ZEPPELIN-1562](https://issues.apache.org/jira/browse/ZEPPELIN-1562)

### How should this be tested?
Hit the url in below format for asynchrnous

http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId]

the same in synchronous 

http://[zeppelin-server]:[zeppelin-port]/api/notebook/run/[notebookId]/[paragraphId]

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/snaveenp/zeppelin ZEPPELIN-1562-api-doc-update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1558


commit 1354443d0aa3dd8bbf615ca0d4cd0db49e3ba0b2
Author: Naveen Subramanian 
Date:   2016-10-24T10:28:02Z

updated api doc




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1518: [ZEPPELIN-1549] Change NotebookID variable name to Not...

2016-10-24 Thread hyonzin
Github user hyonzin commented on the issue:

https://github.com/apache/zeppelin/pull/1518
  
@minahlee I have fixed it now. Really thank you for your great help :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1518: [ZEPPELIN-1549] Change NotebookID variable name to Not...

2016-10-24 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1518
  
@hyonzin I missed one file... 
https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/socket/NotebookServerTest.java#L157
 in this line, `notebook` should be changed to `note`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1518: [ZEPPELIN-1549] Change NotebookID variable name to Not...

2016-10-24 Thread hyonzin
Github user hyonzin commented on the issue:

https://github.com/apache/zeppelin/pull/1518
  
@minahlee Thank you. I'm going to rebase it! I was checking the failure in 
test [here](https://travis-ci.org/hyonzin/zeppelin).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1558: ZEPPELIN-1562 updated api doc

2016-10-24 Thread snaveenp
GitHub user snaveenp opened a pull request:

https://github.com/apache/zeppelin/pull/1558

ZEPPELIN-1562 updated api doc

### What is this PR for?
The URL for running a paragraph synchronously using REST api is mistakenly 
given  as 
"http://[zeppelin-server]:[zeppelin-port]/api/notebook/**job**/[notebookId]/[paragraphId]
 " 

Changed the doc as per code

### What type of PR is it?
[Documentation]

### Todos

### What is the Jira issue?
* [ZEPPELIN-1562](https://issues.apache.org/jira/browse/ZEPPELIN-1562)

### How should this be tested?
Hit the url in below format for asynchrnous

http://[zeppelin-server]:[zeppelin-port]/api/notebook/job/[notebookId]/[paragraphId]

the same in synchronous 

http://[zeppelin-server]:[zeppelin-port]/api/notebook/run/[notebookId]/[paragraphId]

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/snaveenp/zeppelin ZEPPELIN-1562-api-doc-update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1558


commit 1354443d0aa3dd8bbf615ca0d4cd0db49e3ba0b2
Author: Naveen Subramanian 
Date:   2016-10-24T10:28:02Z

updated api doc




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...

2016-10-24 Thread mwkang
Github user mwkang closed the pull request at:

https://github.com/apache/zeppelin/pull/1290


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1350: [ZEPPELIN-1351]Paragraph status should be ERROR...

2016-10-24 Thread mwkang
Github user mwkang closed the pull request at:

https://github.com/apache/zeppelin/pull/1350


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...

2016-10-24 Thread mwkang
Github user mwkang commented on the issue:

https://github.com/apache/zeppelin/pull/1290
  
I am not sure what is my next step. And this PR was created very long time 
ago. So enviroment changed before. I think other contributor can resolve better 
than me. So I closed this PR.
Thanks for your patient.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...

2016-10-24 Thread mwkang
Github user mwkang commented on the issue:

https://github.com/apache/zeppelin/pull/1350
  
I am not sure what is my next step. And this PR was created very long time 
ago. So enviroment changed before. I think other contributor can resolve better 
than me. So I closed this PR.
Thanks for your patient.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1556: [MINOR] remove comments in NotebookRestApi.java

2016-10-24 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1556
  
Merging if there's no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1537: [Zeppelin-1561] Improve sync for multiuser envi...

2016-10-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1537


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1556: [MINOR] remove comments in NotebookRestApi.java

2016-10-24 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1556
  
LGTM. CI failures is irrelevant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1578) Customize Apache Zeppelin homepage > Show notebook list > Notebook corrupted.

2016-10-24 Thread Andreas Weise (JIRA)
Andreas Weise created ZEPPELIN-1578:
---

 Summary: Customize Apache Zeppelin homepage > Show notebook list > 
Notebook corrupted.
 Key: ZEPPELIN-1578
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1578
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.6.2
Reporter: Andreas Weise


Customizing the Zeppelin Homepage to show the notebook list does not work as 
documented here 
http://zeppelin.apache.org/docs/0.6.2/manual/notebookashomepage.html#show-notebooks-list-in-your-custom-homepage

When creating a new notebook with the code mentioned in the link. The paragraph 
can be executed once. Any subsequent call will fail, and also the whole 
notebook gets erroneous.

Looking at the browser console the following error gets logged:
{code}
TypeError: Cannot read property 'name' of undefined
at C (scripts.6ddd912ca4c10818.js:1)
at scripts.6ddd912ca4c10818.js:1
at n.$broadcast (vendor.f686b78964de6852.js:38)
at n. (scripts.6ddd912ca4c10818.js:3)
at b (vendor.f686b78964de6852.js:75)
at n._onMessageHandler (vendor.f686b78964de6852.js:75)
at bound WrappedWebSocket. (vendor.f686b78964de6852.js:36)
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1557: ZEPPELIN-1577. LivyInterpreter should not use FIFOSche...

2016-10-24 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1557
  
Will add test after #1462


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1557: ZEPPELIN-1577. LivyInterpreter should not use F...

2016-10-24 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1557

ZEPPELIN-1577. LivyInterpreter should not use FIFOScheduler

### What is this PR for?
This PR create a new scheduler FIFOPerUserScheduler. So that each user's 
request is isolated. and it is FIFOSchduler per user. 


### What type of PR is it?
[Bug Fix | Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1577

### How should this be tested?
Tested manually 

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1577

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1557.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1557


commit 8fa46da0a771e735c802d5b2bfcc4d71bf47d58b
Author: Jeff Zhang 
Date:   2016-10-16T07:06:17Z

ZEPPELIN-1577. LivyInterpreter should not use FIFOScheduler




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1577) LivyInterpreter should not use FIFOScheduler

2016-10-24 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-1577:


 Summary: LivyInterpreter should not use FIFOScheduler
 Key: ZEPPELIN-1577
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1577
 Project: Zeppelin
  Issue Type: Sub-task
  Components: livy-interpreter
Affects Versions: 0.6.2
Reporter: Jeff Zhang
Assignee: Jeff Zhang
Priority: Critical
 Fix For: 0.7.0


FIFOScheduler means there's only one thread to process client requests. So you 
will see that user1's job will block user2's job which doesn't make sense. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1518: [ZEPPELIN-1549] Change NotebookID variable name to Not...

2016-10-24 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1518
  
@hyonzin I found more places to be changed. There were too much of them to 
comment here so I made PR to your repository. Can you please check and merge it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---