[GitHub] zeppelin issue #1574: ZEPPELIN-1595. Make ZeppelinContext extensible

2016-11-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1574 Do you mean ZeppelinContext would support communication between interpreter groups across JVM ? Currently ZeppelinContext only support spark interpreter, I don't see any case that it support commun

[GitHub] zeppelin issue #1574: ZEPPELIN-1595. Make ZeppelinContext extensible

2016-11-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1574 In my mind the longer term goal of Zeppelin Context is to support communication between interpreter groups. Would we be going the opposite direction somewhat by having interpreter/interpreter

[GitHub] zeppelin issue #1557: ZEPPELIN-1577. LivyInterpreter should not use FIFOSche...

2016-11-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1557 Probably something @Leemoonsoo should review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #1576: ZEPPELIN-415 document for Apache Kylin Interpreter

2016-11-01 Thread minahlee
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1576 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1567 @anthonycorbacho Thanks :-) Don't worry! I do this because I want to do 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] zeppelin issue #1578: ZEPPELIN-1599 Remove support on some old versions of S...

2016-11-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1578 @Leemoonsoo We'd better leave some notes in upgrade.md in docs, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] zeppelin issue #1578: ZEPPELIN-1599 Remove support on some old versions of S...

2016-11-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1578 I was trying to say mark 'deprecated' in the doc. but it's also good idea to mention it in mailinglist :-) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] zeppelin pull request #1559: [ZEPPELIN-1461] Doesn't display "description" v...

2016-11-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin issue #1559: [ZEPPELIN-1461] Doesn't display "description" value in...

2016-11-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1559 I'll merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] zeppelin issue #1578: ZEPPELIN-1599 Remove support on some old versions of S...

2016-11-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1578 @Leemoonsoo I'll remove those support from docs and send an email for this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...

2016-11-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1561 @meenakshisekar The failures of this PR is related to actual behavior, not flaky. Can you take a look into the result of the test? --- If your project is set up for it, you can reply to this ema

[GitHub] zeppelin issue #1578: ZEPPELIN-1599 Remove support on some old versions of S...

2016-11-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1578 @jongyoul Then, I think we can update related doc and say spark 1.1~1.3 support is deprecated. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] zeppelin issue #1578: ZEPPELIN-1599 Remove support on some old versions of S...

2016-11-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1578 I just want to remove official Spark support by Zeppelin, but if user still want to use old version, we don't have to block their usages. --- If your project is set up for it, you can reply to t

[GitHub] zeppelin issue #1578: ZEPPELIN-1599 Remove support on some old versions of S...

2016-11-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1578 @zjffdu Good catch up, but I think if users use Spark 1.3 with SPARK_HOME, we'd better support it. If we change the minimum version of Spark to 1.4 in `SparkVersion`, user cannot use spark 1.3 an

[GitHub] zeppelin issue #1578: ZEPPELIN-1599 Remove support on some old versions of S...

2016-11-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1578 `SparkVersion.java` `SparkInterpreter.java` also needs to be updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] zeppelin issue #1578: ZEPPELIN-1599 Remove support on some old versions of S...

2016-11-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1578 @AhyoungRyu Can you take a look into it briefly? I didn't change your part to avoid conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] zeppelin issue #1534: ZEPPELIN-1345 - Create a custom matplotlib backend tha...

2016-11-01 Thread agoodm
Github user agoodm commented on the issue: https://github.com/apache/zeppelin/pull/1534 Ok, that should do it for now. @Leemoonsoo @bzz @felixcheung please feel free to review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] zeppelin pull request #1578: ZEPPELIN-1599 Remove support on some old versio...

2016-11-01 Thread jongyoul
GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/1578 ZEPPELIN-1599 Remove support on some old versions of Spark. ### What is this PR for? removing support on old versions of Spark including testing and building them. ### What typ

[jira] [Created] (ZEPPELIN-1599) Remove support on some old versions of Spark.

2016-11-01 Thread Jongyoul Lee (JIRA)
Jongyoul Lee created ZEPPELIN-1599: -- Summary: Remove support on some old versions of Spark. Key: ZEPPELIN-1599 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1599 Project: Zeppelin Issu

[GitHub] zeppelin issue #1564: [ZEPPELIN-1585] Testcase for PySparkInterpreter.

2016-11-01 Thread jongyoul
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1564 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1567 @tae-jun creating an issue doenst mean that you have to handle it, of course if you want you are welcome to do so, but remember we are a community so that mean we are here to help each oth

[GitHub] zeppelin pull request #1569: pom.xml change

2016-11-01 Thread hunylee
Github user hunylee closed the pull request at: https://github.com/apache/zeppelin/pull/1569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-01 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1567 [ZEPPELIN-1586] Add security check in NotebookRestApi ### What is this PR for? Bring some security check in `NotebookRestApi`. ### What type of PR is it? [Bug Fix |

[GitHub] zeppelin issue #1569: pom.xml change

2016-11-01 Thread hunylee
Github user hunylee commented on the issue: https://github.com/apache/zeppelin/pull/1569 @AhyoungRyu Yeah PR purpose reopen. Now Closing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1567 @zjffdu Hey dudy I keep failing at Livy interpreter, i dont know why but i keep getting timeout somehow, can you take a look t it please? It also look like other pr are failing at the sam

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] zeppelin issue #1569: pom.xml change

2016-11-01 Thread hunylee
Github user hunylee commented on the issue: https://github.com/apache/zeppelin/pull/1569 @AhyoungRyu Closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1567 @anthonycorbacho Nice! I agree with you :) I will open the issue on JIRA. But since I don't know much about the code structure, I may need some help 😃 --- If your project is set up fo

[GitHub] zeppelin pull request #1571: [DOC] Update shiro after merging #1568

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1567 @tae-jun After looking at the code base, I think this case should be handle in another PR, this is kinda out of the scope of this PR and its already becoming super big. But your m

[GitHub] zeppelin issue #1575: ZEPPELIN-1597. Change cdh spark/hadoop dependency to a...

2016-11-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1575 @prabhjyotsingh @felixcheung Please help review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...

2016-11-01 Thread yoonjs2
Github user yoonjs2 commented on the issue: https://github.com/apache/zeppelin/pull/1577 @AhyoungRyu @minahlee Thanks! Let me know if patch needs any change :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] zeppelin issue #1516: ZEPPELIN-1546 - Zeppelin Livy Interpreter 404 Exceptio...

2016-11-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1516 @gss2002 CI is failed, could you check whether it is related ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...

2016-11-01 Thread minahlee
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1577 @yoonjs2 just added your name to contributor role --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] zeppelin issue #1569: pom.xml change

2016-11-01 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1569 @hunylee Yeah I think the version is not the problem now. Did you reopen the PR on purpose? If not, could you close this then? --- If your project is set up for it, you can reply to this

[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...

2016-11-01 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1577 @yoonjs2 Sure. And let me test this patch :) @minahlee Could you help me add @yoonjs2 (Jira username:Jesang Yoon) to the contributor list in Jira so that he can assign himself to assignee?

[GitHub] zeppelin pull request #1575: ZEPPELIN-1597. Change cdh spark/hadoop dependen...

2016-11-01 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1575 ZEPPELIN-1597. Change cdh spark/hadoop dependency to apache spark/hadoop ### What is this PR for? I see several times of travis failure due to downloading cdh spark/hadoop for livy interpret

[GitHub] zeppelin pull request #1575: ZEPPELIN-1597. Change cdh spark/hadoop dependen...

2016-11-01 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1575 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #1561: [Zeppelin 914]- Apply new mechanism to IgniteIn...

2016-11-01 Thread meenakshisekar
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] zeppelin pull request #1561: [Zeppelin 914]- Apply new mechanism to IgniteIn...

2016-11-01 Thread meenakshisekar
GitHub user meenakshisekar reopened a pull request: https://github.com/apache/zeppelin/pull/1561 [Zeppelin 914]- Apply new mechanism to IgniteInterpreter What is this PR for? This handles replacing the registration of interpreter with static block by the interpreter-setting

[GitHub] zeppelin pull request #1548: [ZEPPELIN-917] Apply new mechanism to LensInter...

2016-11-01 Thread meenakshisekar
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] zeppelin pull request #1548: [ZEPPELIN-917] Apply new mechanism to LensInter...

2016-11-01 Thread meenakshisekar
GitHub user meenakshisekar reopened a pull request: https://github.com/apache/zeppelin/pull/1548 [ZEPPELIN-917] Apply new mechanism to LensInterpreter ### What is this PR for? This handles replacing the registration of interpreter with static block by the interpreter-settin

[GitHub] zeppelin issue #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 with it...

2016-11-01 Thread yoonjs2
Github user yoonjs2 commented on the issue: https://github.com/apache/zeppelin/pull/1577 @AhyoungRyu Can I ask you to allow me to change JIRA ZEPPELIN-1554 assignee and progress? In case of self proposal and PR like this, It would be great to use JIRA as contributor access :) --- If

[GitHub] zeppelin pull request #1577: [ZEPPELIN-1554] Update jekyll version to 3.2.1 ...

2016-11-01 Thread yoonjs2
GitHub user yoonjs2 opened a pull request: https://github.com/apache/zeppelin/pull/1577 [ZEPPELIN-1554] Update jekyll version to 3.2.1 with its dependencies and fix document… ### What is this PR for? - Update outdated jekyll version of zeppelin documentation from 1.x to 3.x

[GitHub] zeppelin issue #1559: [ZEPPELIN-1461] Doesn't display "description" value in...

2016-11-01 Thread cloverhearts
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1559 Tested. Looks good to me! Very good and clear code! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1567 @tae-jun thanks for the feedback, let me take a look tomorrow --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1567 I also tested and was able to reproduce screenshot above. When I was another user, it returned `403` status code with message: ```json {"status":"FORBIDDEN","message":"Insufficient

[GitHub] zeppelin issue #1479: Notebook: HDFS as a backend storage (Read & Write Mode...

2016-11-01 Thread aspen01
Github user aspen01 commented on the issue: https://github.com/apache/zeppelin/pull/1479 You know, there is WebHDFS Rest API in hadoop. If we use this, we don’t need to care about library dependency and configuration. What do you think using WebHDFS Rest API? HDFS in

[GitHub] zeppelin pull request #1576: ZEPPELIN-415 document for Apache Kylin Interpre...

2016-11-01 Thread janzhongi
GitHub user janzhongi opened a pull request: https://github.com/apache/zeppelin/pull/1576 ZEPPELIN-415 document for Apache Kylin Interpreter ### What is this PR for? This is document for Apache Kylin Interpreter for Apache Zeppelin ### What type of PR is it? Doc

[GitHub] zeppelin issue #1565: [ZEPPELIN-1564] Enable note deletion and paragraph out...

2016-11-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1565 @minahlee Awesome! I just changed status to `IN PROGRESS` now. Thanks 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] zeppelin issue #1565: [ZEPPELIN-1564] Enable note deletion and paragraph out...

2016-11-01 Thread minahlee
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1565 @tae-jun I just added your name to contributor list so you will be able to set yourself as assignee from now. --- If your project is set up for it, you can reply to this email and have your repl

Update Ignite interpreter related docs on the Zeppelin site

2016-11-01 Thread Andrey Gura
Hi all. Guys, could anybody point me how to edit documentation on Zeppelin site? In particular I want to fix Ignite and Zeppelin version mentions and may be other things here https://zeppelin.apache.org/docs/0.6.2/interpreter/ignite.html. Also I have question about this quote: "We are planning t

[GitHub] zeppelin issue #1565: [ZEPPELIN-1564] Enable note deletion and paragraph out...

2016-11-01 Thread tae-jun
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/1565 Thanks @minahlee! I appreciate your kind comment 😄 I created a ticket on JIRA: [ZEPPELIN-1598](https://issues.apache.org/jira/browse/ZEPPELIN-1598) But, I don't know how to set

[jira] [Created] (ZEPPELIN-1598) Enable renaming note & folder from the main page & REST API

2016-11-01 Thread Tae Jun Kim (JIRA)
Tae Jun Kim created ZEPPELIN-1598: - Summary: Enable renaming note & folder from the main page & REST API Key: ZEPPELIN-1598 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1598 Project: Zeppelin

[GitHub] zeppelin pull request #1575: ZEPPELIN-1597. Change cdh spark/hadoop dependen...

2016-11-01 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1575 ZEPPELIN-1597. Change cdh spark/hadoop dependency to apache spark/hadoop ### What is this PR for? I see several times of travis failure due to downloading cdh spark/hadoop for livy interpreter

[jira] [Created] (ZEPPELIN-1597) Change cdh spark/hadoop dependency to apache spark/hadoop

2016-11-01 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-1597: Summary: Change cdh spark/hadoop dependency to apache spark/hadoop Key: ZEPPELIN-1597 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1597 Project: Zeppelin

[GitHub] zeppelin issue #1574: ZEPPELIN-1595. Make ZeppelinContext extensible

2016-11-01 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1574 @Leemoonsoo @jongyoul @felixcheung Please help review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] zeppelin issue #1569: pom.xml change

2016-11-01 Thread hunylee
Github user hunylee commented on the issue: https://github.com/apache/zeppelin/pull/1569 @jongyoul Sorry. I thought I did. Version're the problem. I'm sorry again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] zeppelin pull request #1569: pom.xml change

2016-11-01 Thread hunylee
GitHub user hunylee reopened a pull request: https://github.com/apache/zeppelin/pull/1569 pom.xml change ### What is this PR for? ## pom.xml is plugin version change - pom.xml - beam/pom.xml - cassandra/pom.xml - flink/pom.xml - ignite/pom.xml - r/pom.xml

[GitHub] zeppelin pull request #1569: pom.xml change

2016-11-01 Thread hunylee
Github user hunylee closed the pull request at: https://github.com/apache/zeppelin/pull/1569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zeppelin pull request #1574: ZEPPELIN-1595. Make ZeppelinContext extensible

2016-11-01 Thread zjffdu
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1574 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zeppelin pull request #1574: ZEPPELIN-1595. Make ZeppelinContext extensible

2016-11-01 Thread zjffdu
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1574 ZEPPELIN-1595. Make ZeppelinContext extensible ### What is this PR for? For now, ZeppelinContext only support Spark Interpreter. I'd like to make it extensible, so that it can support other

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1567 @minahlee you are right, I guess the next step will be to abstract this logic from rest api and apply to both rest and websocket. --- If your project is set up for it, you can reply to t

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread minahlee
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1567 I tested some of rest apis and it works well. Next step would be applying same policies to websocket. For example `reader` cannot change bound interpreter to note via rest api after this PR, but

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho commented on the issue: https://github.com/apache/zeppelin/pull/1567 @minahlee yeah, actually i am doing this right now, I also updated to todo tasks thanks for your review! --- If your project is set up for it, you can reply to this email and have your re

[GitHub] zeppelin issue #1567: [ZEPPELIN-1586] Add security check in NotebookRestApi

2016-11-01 Thread minahlee
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1567 Thank you for quick response, I only went through the code and it looks good to me. It would be nice if you can add some tests. Meanwhile let me build this branch and test it out. --- If your

[GitHub] zeppelin pull request #1574: ZEPPELIN-1595. Make ZeppelinContext extensible

2016-11-01 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1574 ZEPPELIN-1595. Make ZeppelinContext extensible ### What is this PR for? For now, ZeppelinContext only support Spark Interpreter. I'd like to make it extensible, so that it can support other in

[jira] [Created] (ZEPPELIN-1596) Create ZeppelinContext for flink

2016-11-01 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-1596: Summary: Create ZeppelinContext for flink Key: ZEPPELIN-1596 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1596 Project: Zeppelin Issue Type: New Feat

[jira] [Created] (ZEPPELIN-1595) Make ZeppelinContext extensible

2016-11-01 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-1595: Summary: Make ZeppelinContext extensible Key: ZEPPELIN-1595 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1595 Project: Zeppelin Issue Type: New Featur

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-01 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1567 [ZEPPELIN-1586] Add security check in NotebookRestApi ### What is this PR for? Bring some security check in `NotebookRestApi`. ### What type of PR is it? [Bug Fix |

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-01 Thread anthonycorbacho
GitHub user anthonycorbacho reopened a pull request: https://github.com/apache/zeppelin/pull/1567 [ZEPPELIN-1586] Add security check in NotebookRestApi ### What is this PR for? Bring some security check in `NotebookRestApi`. ### What type of PR is it? [Bug Fix |

[GitHub] zeppelin pull request #1567: [ZEPPELIN-1586] Add security check in NotebookR...

2016-11-01 Thread anthonycorbacho
Github user anthonycorbacho closed the pull request at: https://github.com/apache/zeppelin/pull/1567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea