[GitHub] zeppelin issue #1632: [ZEPPELIN-1639] Add tests with external python depende...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1632
  
Thanks for spending more time investigating this.
I'd agree with your assessment.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1676: [ZEPPELIN-1705] Exclude unnecessary source file when c...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1676
  
@tae-jun Thanks for the contribution. 
Merge this into master if there are no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1677: Add doc for exchanging data frames

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1677
  
Yes, and you also need to update method `__getitem__` so that user don't 
need to construct DataFrame as this. `z.get("myScalaDataFrame")` should return 
DataFrame directly
```
myScalaDataFrame = DataFrame(z.get("myScalaDataFrame"), sqlContext)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1612: ZEPPELIN-1607. Refactor Livy Interpreter to adapt scop...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1612
  
@felixcheung @prabhjyotsingh @Leemoonsoo  Please help review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1677: Add doc for exchanging data frames

[m30m]

Github user m30m commented on the issue:

https://github.com/apache/zeppelin/pull/1677
  
Yes, that's a good idea. Shall I add a commit to this branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1677: Add doc for exchanging data frames

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1677
  
I mean we can internally do this in `PyZeppelinContext` as following:
```
def __setitem__(self, key, item):
if isinstance(item, DataFrame):
   self.z.put(key, item._jdf)
else:
   self.z.put(key, item)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1632: [ZEPPELIN-1639] Add tests with external python depende...

[agoodm]

Github user agoodm commented on the issue:

https://github.com/apache/zeppelin/pull/1632
  
To be honest, I don't see it being that big of a deal. Both profiles take 
about 5 minutes each which I think is fairly short, since up until recently we 
were spending 4 minutes just installing the R dependencies for all of the other 
profiles. Additionally, this would make it much easier to test everything for 
both python 2 and 3, which can be quite a pain to do manually with conda / 
virtualenv (eg, fiddling with the PATH before running tests for each case). 
Also, matplotlib and pandas are most likely used for a large percentage of 
python / pyspark use cases in Zeppelin, so I think having that integration 
tested would be really useful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1677: Add doc for exchanging data frames

[m30m]

Github user m30m commented on the issue:

https://github.com/apache/zeppelin/pull/1677
  
It's not possible to put the DataFrame directly because of this error:
```Exception: Traceback (most recent call last):
  File 
"/spark-2.0.1-bin-hadoop2.7/python/lib/py4j-0.10.3-src.zip/py4j/java_gateway.py",
 line 1124, in __call__
args_command, temp_args = self._build_args(*args)

  File 
"/spark-2.0.1-bin-hadoop2.7/python/lib/py4j-0.10.3-src.zip/py4j/java_gateway.py",
 line 1094, in _build_args
[get_command_part(arg, self.pool) for arg in new_args])

  File 
"/spark-2.0.1-bin-hadoop2.7/python/lib/py4j-0.10.3-src.zip/py4j/protocol.py", 
line 289, in get_command_part
command_part = REFERENCE_TYPE + parameter._get_object_id()

  File "/spark-2.0.1-bin-hadoop2.7/python/pyspark/sql/dataframe.py", line 
841, in __getattr__
"'%s' object has no attribute '%s'" % (self.__class__.__name__, name))

AttributeError: 'DataFrame' object has no attribute '_get_object_id'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1671: Clean unnecessary codes

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1671


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1680: [MINOR] Invalid constructor call in a test caus...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1680


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1680: [MINOR] Invalid constructor call in a test causes all ...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1680
  
LGTM, also hit this issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1680: [MINOR] Invalid constructor call in a test causes all ...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1680
  
@minahlee Good to go! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1680: [MINOR] Invalid constructor call in a test causes all ...

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1680
  
LGTM, merging it as hotfix if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1673
  
LGTM! It significant improvement.

 mvn package -pl zeppelin-web
```
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 02:02 min
[INFO] Finished at: 2016-11-25T10:58:49+05:30
[INFO] Final Memory: 37M/800M
[INFO] 

```

mvn package -DskipTests -pl zeppelin-web
```
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 01:17 min
[INFO] Finished at: 2016-11-25T11:00:13+05:30
[INFO] Final Memory: 34M/653M
[INFO] 

```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1587: [ZEPPELIN-1609] using pyspark(python3) with livy inter...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1587
  
I prefer to use `%livy.pyspark` & `$livy.pyspark3` instead of 
`zeppelin.livy.kind`.  Because if user change `zeppelin.livy.kind` some 
paragraphs may not work again, this is very confusing. So explicitly specifying 
python version is better IMO.  And could you wait for #1612 which is 
refactoring livy interpreter ? After #1612 , it should be pretty easy to add 
`%livy.pyspark3`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1680: [MINOR] Invalid constructor call in a test caus...

[1ambda]

GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/1680

[MINOR] Invalid constructor call in a test causes all CI failure

### What is this PR for?

A small minor fix for CI failure

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?

NO JIRA issue. (small, emergently)

### How should this be tested?

CI will do that :)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
minor/fix-invalid-constructor-call-in-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1680


commit 6c57e4226efffacbdcd47d097f2dc801b96426b5
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-25T05:13:26Z

fix: Invalid constructor call in a test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1587: [ZEPPELIN-1609] using pyspark(python3) with livy inter...

[purechoc]

Github user purechoc commented on the issue:

https://github.com/apache/zeppelin/pull/1587
  
@zjffdu @felixcheung  @Leemoonsoo 
could you merge about this?
or need to fix something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1676: [ZEPPELIN-1705] Exclude unnecessary source file when c...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1676
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1711) Create runnable zeppein docker images per released version

[Hoon Park (JIRA)]

Hoon Park created ZEPPELIN-1711:
---

 Summary: Create runnable zeppein docker images per released version
 Key: ZEPPELIN-1711
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1711
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Hoon Park


Currently, contributors are trying to making a docker base image for zeppelin. 
The next step would be building runnable zeppelin images on the base image. 
This issue is about it.






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1538
  
Now this issue is like more about building base image :) I will start 
working on a new JIRA issue as @bzz mentioned about creating runnable zeppelin 
images per version based on this. That would be the next step.

https://issues.apache.org/jira/browse/ZEPPELIN-1711



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1673
  
Thank you @Leemoonsoo ! Merging to master, if there is no further discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1673
  
Tested and LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1710) Can't type Korean text properly in the editor

[Ahyoung Ryu (JIRA)]

Ahyoung Ryu created ZEPPELIN-1710:
-

 Summary: Can't type Korean text properly in the editor
 Key: ZEPPELIN-1710
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1710
 Project: Zeppelin
  Issue Type: Bug
Reporter: Ahyoung Ryu
 Fix For: 0.7.0


Currently Korean text can't be typed properly in the paragraph. See the 
attached git img. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1632: [ZEPPELIN-1639] Add tests with external python depende...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1632
  
Thank you for CI failure assessment @agoodm ! 

How do you think, how crucial are those tests? May be just documenting on 
how to run them manually could be an option?

Generally, we tried to avoid exploding number of CI profiles to keep the CI 
build time minimum, but if more profiles is not going cost substantial build 
time that defility could be an option. In that case any of the suggested 
solutions sounds good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1673
  
Thank you for review @felizbear !

> it increases npm test time since it tries to install phantom every time

but it reduces `npm install` time, and as soon as on CI we only do 
install\test once - total time should be the same.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1538
  
to recap - theare are two final things, that would be very nice to have in 
this image:
 - find a way to reduce base image size from ~500mb i.e by installing R 
without `build-base make gcc g++`
 - re-use `./testing/install_external_dependencies.sh` as soon as  #1632 is 
merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1168: [MINOR] Add formatter

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1168
  
@bzz 

I created a JIRA issue for this: 
https://issues.apache.org/jira/browse/ZEPPELIN-1709

We can resolve this in 1 PR or can split it into multiples. I think we can 
resolve these things

- update checkstyle.xml
- update maven plugin or introduce more recent a new plugin 
https://github.com/checkstyle/checkstyle (some apache projects use both)
- write a detailed guide about how to format your zeppelin code while 
making contribution


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1709) Keep well formatted, consistent java code

[Hoon Park (JIRA)]

Hoon Park created ZEPPELIN-1709:
---

 Summary: Keep well formatted, consistent java code
 Key: ZEPPELIN-1709
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1709
 Project: Zeppelin
  Issue Type: Improvement
  Components: build, conf, documentation
Reporter: Hoon Park


We have

- outdated checkstyle.xml
- old maven checkstyle plugin
- no detailed style guide for java code (e.g available plugins)

Additionaly, it seems that some modules do not run checkstyle goal during build 
phase

By fixing those issues, we can keep our code clean. It will results the number 
of rebase count (reduced conflict due to just style) and boost our productivity 




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1538
  
> if we want to make dockerfile to the latest version from zeppelin which 
haven't a binary version

This better be handled under a separate JIRA issue as this one is about 
`[ZEPPELIN-1386] Docker images for running Apache Zeppelin releases `. It can 
be done later i.e by setting up CI automation that runs nightly build \w 
something similar to `create_release.sh`. Important thing there would be to 
make sure that's clearly marked as non-release, but just as a developer's 
artefact.



So all that sounds great, and image looks good (except for fat R 
dependencies, but I'm not sure if we can do something about it).. How do you 
guys think, is there anything that's left here?

Or shall we merge this, run `docker build` for old binary releases using 
this image?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1538
  
@mfelgamal @bzz 

I think we should dockerize binary zeppelin images first because more users 
use binary versions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1708) Import of 3rd party library symbol doesn't work

[Ben Hutchison (JIRA)]

Ben Hutchison created ZEPPELIN-1708:
---

 Summary: Import of 3rd party library symbol doesn't work
 Key: ZEPPELIN-1708
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1708
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.6.2
 Environment: AWS EMR
Spark interpreter configured with 3rd party library: 
net.sf.trove4j:trove4j:3.0.3
Reporter: Ben Hutchison


Notebook:

case class OK(hash: gnu.trove.map.hash.TIntIntHashMap)
import gnu.trove.map.hash.TIntIntHashMap
case class Fail(hash: TIntIntHashMap)

Output: 

defined class OK
import gnu.trove.map.hash.TIntIntHashMap
:11: error: not found: type TIntIntHashMap
   case class Fail(hash: TIntIntHashMap)
 ^

Expected output: Compiles successfully as the short-name `TIntIntHashMap` has 
been imported



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin pull request #1679: ZEPPELIN-1707. Pass userName when creating inte...

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1679

ZEPPELIN-1707. Pass userName when creating interpreter through thrift

### What is this PR for?
In ZEPPELIN-1607, I'd like refactor livy interpreter to scoped mode by 
default, this require username when open this interpreter. So I propose to pass 
username when creating interpreter through thrift.
What I did in this PR.
* update RemoteInterpreterService.thrift and regenerate the java thrift 
code.
* I use thrift 0.9.2 because I notice in zeppelin/pom.xml, the 
libthrift.version we use is 0.9.2
* update genthrift.sh, otherwise hashCode method won't be generated 
correctly.


### What type of PR is it?
[Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1707

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1707

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1679


commit 223a48f0ce8d0d768bc2eb0364b82e25f7a633ff
Author: Jeff Zhang 
Date:   2016-11-25T01:32:14Z

ZEPPELIN-1707. Pass userName when creating interpreter through thrift




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1707) Pass userName when creating interpreter through thrift

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-1707:


 Summary: Pass userName when creating interpreter through thrift
 Key: ZEPPELIN-1707
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1707
 Project: Zeppelin
  Issue Type: Improvement
Affects Versions: 0.6.2
Reporter: Jeff Zhang
Assignee: Jeff Zhang


In ZEPPELIN-1607, I'd like refactor livy interpreter to scoped mode by default, 
this require username when open this interpreter. So I propose to pass username 
when creating interpreter through thrift. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1677: Add doc for exchanging data frames

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1677
  
Should we do it implicitly for user in `ZeppelinContext`? Because I feel 
the syntax is not easy to understand if user don't know the internal 
implementation of pyspark. And I think we should not expose such internal 
things to users.

```
z.put("myPythonDataFrame", postsDf._jdf)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Adding Angular API to non-Spark interpreters

[Randy Gelhausen]

I often need to visualize data in other ways than supported by the out of
the box charts. I can do this with Angular notes and custom JavaScript, but
Spark is the only interpreter with capability to set Angular variables.

Could it be possible to automatically expose all interpreter results as
Angular variables using the paragraph ID as the variable name?

This would greatly improve the custom viz capabilities for Zeppelin without
requiring developers of each interpreter to integrate with Zeppelin's
Angular API.

[GitHub] zeppelin issue #1617: ZEPPELIN-1645: JDBC Interpreter does not commit update...

[randerzander]

Github user randerzander commented on the issue:

https://github.com/apache/zeppelin/pull/1617
  
The failed test is in the Python interpreter, unrelated to this JDBC change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...

[mfelgamal]

Github user mfelgamal commented on the issue:

https://github.com/apache/zeppelin/pull/1538
  
Hi @bzz 

So far, we have binary versions from 0.5.0 to 0.6.2, which help us building 
docker image to each version instead of building the source code, but I mean 
that if you want to make dockerfile to the latest version from zeppelin which 
haven't a binary version and is on master branch, so we may need to build the 
zeppelin in the docker. if the latest version isn't necessary now, we can 
ignore this, what do you think?

* Yes, only `R` package requires `gcc`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1617: ZEPPELIN-1645: JDBC Interpreter does not commit update...

[randerzander]

Github user randerzander commented on the issue:

https://github.com/apache/zeppelin/pull/1617
  
@astroshim Added a safety check on autocommit status


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1593: ZEPPELIN-1613. PerUser scoped mode doesn't work

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1593
  
@zjffdu Looks great to me!
Merge to master if there're no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1632: [ZEPPELIN-1639] Add tests with external python depende...

[agoodm]

Github user agoodm commented on the issue:

https://github.com/apache/zeppelin/pull/1632
  
@felixcheung @bzz 

So the pyspark cluster test has two failures. One is a result of matplotlib 
always printing a warning message when it is first loaded, and the other is how 
python 3 handles unicode. For these reason I think we should either move the 
python 3 tests to another profile which doesn't perform this test, or have it 
in a separate profile as I had already done once before. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1339: [ZEPPELIN-1332] Remove spark-dependencies & suggest ne...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1339
  
In case of

  1) Don't have plan to use spark interpreter, just want to use other 
interpreters like python, big query.
  2) Set SPARK_HOME in interpreter property instead of conf/zeppelin-env.sh

User may not interested in local-spark. but user will keep seeing messages 

```
Lees-MacBook:pr1339 moon$ bin/zeppelin-daemon.sh start

You do not have neither local-spark, nor external SPARK_HOME set up.
If you want to use Spark interpreter, you need to run get-spark at least 
one time or set SPARK_HOME.

Zeppelin start [  OK  ]
Lees-MacBook:pr1339 moon$ bin/zeppelin-daemon.sh stop
Zeppelin stop  [  OK  ]
Lees-MacBook:pr1339 moon$ bin/zeppelin-daemon.sh start

You do not have neither local-spark, nor external SPARK_HOME set up.
If you want to use Spark interpreter, you need to run get-spark at least 
one time or set SPARK_HOME.

Zeppelin start [  OK  ]
```

@AhyoungRyu  What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1637
  
Could you keep following files unchanged and resolve conflict with master?

bigquery/src/main/java/org/apache/zeppelin/bigquery/BigQueryInterpreter.java

cassandra/src/main/java/org/apache/zeppelin/cassandra/CassandraInterpreter.java
flink/src/main/java/org/apache/zeppelin/flink/FlinkInterpreter.java
ignite/src/main/java/org/apache/zeppelin/ignite/IgniteSqlInterpreter.java
jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
kylin/src/main/java/org/apache/zeppelin/kylin/KylinInterpreter.java
lens/src/main/java/org/apache/zeppelin/lens/LensInterpreter.java
markdown/src/main/java/org/apache/zeppelin/markdown/Markdown.java
pig/src/main/java/org/apache/zeppelin/pig/PigInterpreter.java

postgresql/src/main/java/org/apache/zeppelin/postgresql/PostgreSqlInterpreter.java

python/src/main/java/org/apache/zeppelin/python/PythonInterpreterPandasSql.java
scalding/src/main/java/org/apache/zeppelin/scalding/ScaldingInterpreter.java
spark/src/main/java/org/apache/zeppelin/spark/DepInterpreter.java
spark/src/main/java/org/apache/zeppelin/spark/PySparkInterpreter.java
spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java
spark/src/main/java/org/apache/zeppelin/spark/SparkSqlInterpreter.java

zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/dev/DevInterpreter.java

zeppelin-interpreter/src/test/java/org/apache/zeppelin/interpreter/remote/mock/MockInterpreterA.java

zeppelin-interpreter/src/test/java/org/apache/zeppelin/interpreter/remote/mock/MockInterpreterB.java

zeppelin-interpreter/src/test/java/org/apache/zeppelin/interpreter/remote/mock/MockInterpreterAngular.java

zeppelin-interpreter/src/test/java/org/apache/zeppelin/interpreter/remote/mock/MockInterpreterResourcePool.java

zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java

zeppelin-zengine/src/test/java/org/apache/zeppelin/interpreter/mock/MockInterpreter2.java

Except for that, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1632: [ZEPPELIN-1639] Add tests with external python depende...

[agoodm]

Github user agoodm commented on the issue:

https://github.com/apache/zeppelin/pull/1632
  
I think the CI failures were due to me somehow inadvertently removing the 
-Ppyspark from the build profile. Let's see how it goes now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1677: Add doc for exchanging data frames

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1677
  
@m30m Awesome!

LGTM and merge to master if there're no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1539: [ZEPPELIN-1567] Let JDBC interpreter use user c...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1539


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1656: Fix Yarn configuration of Spark2.0

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1656
  
LGTM and merge to master if there're no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1654: [ZEPPELIN-1683] Run python process in docker co...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1654


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1613: ZEPPELIN-1643:Make spark web UI accesible from interpr...

[karup1990]

Github user karup1990 commented on the issue:

https://github.com/apache/zeppelin/pull/1613
  
@zjffdu @Leemoonsoo I have handled the cases in 
https://github.com/apache/zeppelin/pull/1678


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1678: [ZEPPELIN-1706] Make spark Ui accesible in vari...

[karup1990]

GitHub user karup1990 opened a pull request:

https://github.com/apache/zeppelin/pull/1678

[ZEPPELIN-1706] Make spark Ui accesible in various interpreter modes

### What is this PR for?
Spark UI should be accessible in various other modes(user, note) and honour 
the properties of the corresponding mode.
Example: In per user mode isolated mode, each logged in user should be 
taken to his/her respective spark UI
In per note isolated mode, each notebook will have its own application and 
the user should be taken the respective spark application UI
All the interpreter modes are handled with this PR

### What type of PR is it?
Bug fix


### What is the Jira issue?
ZEPPELIN-1706

### How should this be tested?
Set various interpreter modes for the interpreter setting and test if the 
spark Application UI is accessible appropriately

### Screenshots (if appropriate)


![zep-1702](https://cloud.githubusercontent.com/assets/5082742/20606056/8b62b2c6-b294-11e6-952f-357a10d68e1f.gif)

The screen capture shows per note isolated mode. But the PR handles all 
interpreter modes
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karup1990/incubator-zeppelin ZEPPELIN-1706

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1678


commit f755fb47dfb2c27daa072af57240eb3c731c8cab
Author: karuppayya 
Date:   2016-11-23T17:07:29Z

Revert "[ZEPPELIN-1667] Fix maven options while updating node, npm packages"

This reverts commit abe03a866fc9ac2563c057d6edc00d3ec0a7d733.

commit afd0b80e4c8670d5cd4288e00c307e763438ff68
Author: karuppayya 
Date:   2016-11-23T18:40:32Z

Fix

commit e2289e5875bbd8368028bc28fcfe85739bedb53a
Author: karuppayya 
Date:   2016-11-24T13:13:56Z

Fix spark url stuff

Signed-off-by: karuppayya 

commit d9404990112bbbe0ec0596eb1cc4aac38ff85fe2
Author: karuppayya 
Date:   2016-11-24T16:49:09Z

Revert "Revert "[ZEPPELIN-1667] Fix maven options while updating node, npm 
packages""

This reverts commit f755fb47dfb2c27daa072af57240eb3c731c8cab.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1677: Add doc for exchanging data frames

[m30m]

GitHub user m30m opened a pull request:

https://github.com/apache/zeppelin/pull/1677

Add doc for exchanging data frames

### What is this PR for?
ZeppelinContext can be used to exchange DataFrames but there are some nasty 
tricks and typecasts.
It's good to provide some examples.


### What type of PR is it?
Documentation

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/m30m/zeppelin patch-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1677


commit a039d5c4ac2e4887ce013b658e25cd1f43861a5b
Author: Mohammad Amin Khashkhashi Moghaddam 
Date:   2016-11-24T16:05:58Z

Add doc for exchanging data frames

ZeppelinContext can be used to exchange DataFrames but there are some nasty 
tricks and typecasts.
It's good to provide some examples.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1676: [ZEPPELIN-1705] Exclude unnecessary source file when c...

[tae-jun]

Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1676
  
@AhyoungRyu Thanks for the review again! 😄 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1676: [ZEPPELIN-1705] Exclude unnecessary source file when c...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1676
  
Tested this PR and checked the error msg is gone 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1706) Make spark UI accessible in various mode(user, note, global)

[Karuppayya (JIRA)]

Karuppayya created ZEPPELIN-1706:


 Summary: Make spark UI accessible in various mode(user, note, 
global) 
 Key: ZEPPELIN-1706
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1706
 Project: Zeppelin
  Issue Type: Bug
Reporter: Karuppayya


The ability to access spark UI is limited to only global mode with this PR
https://github.com/apache/zeppelin/pull/1613

Spark UI should be accessible in various other modes(user, note) and honour the 
properties of the corresponding mode.
Example: In per user mode isolated mode, each logged in user should be taken to 
his/her respective spark UI
In per note isolated mode, each notebook will have it own application and the 
user should be taken the respective spark application UI




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin pull request #1630: [ZEPPELIN-1629] Enable renaming folder from the...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1630


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1339: [ZEPPELIN-1332] Remove spark-dependencies & sug...

[AhyoungRyu]

Github user AhyoungRyu closed the pull request at:

https://github.com/apache/zeppelin/pull/1339


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1339: [ZEPPELIN-1332] Remove spark-dependencies & sug...

[AhyoungRyu]

GitHub user AhyoungRyu reopened a pull request:

https://github.com/apache/zeppelin/pull/1339

[ZEPPELIN-1332] Remove spark-dependencies & suggest new way

### What is this PR for?
Currently, Zeppelin's embedded Spark is located under `interpreter/spark/`. 
For whom **builds Zeppelin from source**, this Spark is downloaded when 
they build the source with [build 
profiles](https://github.com/apache/zeppelin#spark-interpreter). I think this 
various build profiles are useful to customize the embedded Spark, but many 
Spark users are using their own Spark not Zeppelin's embedded one. Nowadays 
only Spark beginners use this embedded Spark. For them, there are too 
many build profiles(it's so complicated i think). 
In case of **Zeppelin binary package**, it's included by default under 
`interpreter/spark/`. That's why Zeppelin package size is so huge. 

 New suggestions
This PR will change the embedded Spark binary downloading mechanism like 
below.

1. `./bin/zeppelin-daemon.sh get-spark` or `./bin/zeppelin.sh get-spark`
2. create `ZEPPELIN_HOME/local-spark/` and will download 
`spark-2.0.1-hadoop2.7.bin.tgz` and untar 
3. we can use this local spark without any configuration like before (e.g. 
setting `SPARK_HOME`)

### What type of PR is it?
Improvement

### Todos
- [x] - trap `ctrl+c` & `ctrl+z` key interruption during downloading Spark
- [x] - test in the different OS 
- [x] - update related document pages again after get feedbacks

### What is the Jira issue?
[ZEPPELIN-1332](https://issues.apache.org/jira/browse/ZEPPELIN-1332)

### How should this be tested?
1. `rm -r spark-dependencies` 
2. Apply this patch and build with `mvn clean package -DskipTests`
3. try`bin/zeppelin-daemon.sh get-spark` or `bin/zeppelin.sh get-spark`
4. should be able to run `sc.version` without setting external `SPARK_HOME`

### Screenshots (if appropriate)
- `./bin/zeppelin-daemon.sh get-spark`
```
$ ./bin/zeppelin-daemon.sh get-spark
Download spark-2.0.1-bin-hadoop2.7.tgz from mirror ...

  % Total% Received % Xferd  Average Speed   TimeTime Time  
Current
 Dload  Upload   Total   SpentLeft  
Speed
100  178M  100  178M0 0  10.4M  0  0:00:17  0:00:17 --:--:-- 
10.2M

spark-2.0.1-bin-hadoop2.7 is successfully downloaded and saved under 
/Users/ahyoungryu/Dev/zeppelin-development/zeppelin/local-spark
```
- if `ZEPPELIN_HOME/local-spark/spark-2.0.1-hadoop2.7` already exists
```
$ ./bin/zeppelin-daemon.sh get-spark
spark-2.0.1-bin-hadoop2.7 already exists under local-spark.
```

### Questions:
- Does the licenses files need update? no
- Is there breaking changes for older versions? no
- Does this needs documentation? Need to update some related documents 
(e.g. README.md, spark.md and install.md ?)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1332

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1339.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1339


commit d377cc6f28dd6cae43364f61135ed8abcba3b269
Author: AhyoungRyu 
Date:   2016-08-16T15:08:19Z

Fix typo comment in interpreter.sh

commit 4f3edfd87e84e65789e0e937b5330c16442fcfbe
Author: AhyoungRyu 
Date:   2016-08-17T01:52:06Z

Remove spark-dependencies

commit 99ef019521ca1fd0fc41958b20da8642773825d5
Author: AhyoungRyu 
Date:   2016-08-17T07:14:35Z

Add spark-2.*-bin-hadoop* to .gitignore

commit 4e8d5ff067c5428a5254e45b4de533c56393f7b4
Author: AhyoungRyu 
Date:   2016-08-17T15:22:25Z

Add download-spark.sh file

commit 6784015b8da439894dd09bbc3e54477a0f3cba84
Author: AhyoungRyu 
Date:   2016-08-17T15:28:51Z

Remove useless comment line in common.sh

commit c866f0b231432b14c092a365d270e81af54a
Author: AhyoungRyu 
Date:   2016-08-18T03:32:11Z

Remove zeppelin-spark-dependencies from r/pom.xml

commit 3fe19bff1bdbdccba63e3163bd7aabfe23a35777
Author: AhyoungRyu 
Date:   2016-08-21T05:38:55Z

Change SPARK_HOME with proper message

commit 99545233c0e84f48fbf98da25ad131eeba6dd293
Author: AhyoungRyu 
Date:   2016-09-06T08:55:20Z

Check interpreter/spark/ instead of SPARK_HOME

commit e6973b3887e9c0d50a1168f26e6f0337f9f78986
Author: AhyoungRyu 
Date:   2016-09-06T08:55:40Z

Refactor download-spark.sh

commit 552185ac03f1b5edc9fabb4d381d471c59078903
Author: AhyoungRyu 
Date:   

[GitHub] zeppelin pull request #1635: [ZEPPELIN-1690] - ZeppelinHubNotebookRepo multy...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1635


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1676: [ZEPPELIN-1705] Exclude unnecessary source file...

[tae-jun]

GitHub user tae-jun opened a pull request:

https://github.com/apache/zeppelin/pull/1676

[ZEPPELIN-1705] Exclude unnecessary source file when check style on scio

### What is this PR for?
When building Zeppelin with `mvn clean package install -DskipTests 
-DskipRat`, it fails on `scio` with an error log below:
```sh
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-checkstyle-plugin:2.13:check 
(checkstyle-fail-build) on project zeppelin-scio_2.10: You have 51 Checkstyle 
violations. -> [Help 1]
```
This is because of **style check on a generated source**, which is exactly 
`$ZEPPELIN_HOME/scio/target/generated-sources/avro/org/apache/zeppelin/scio/avro/Account.java`

This PR will make style check excludes the generated source.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-1705](https://issues.apache.org/jira/browse/ZEPPELIN-1705)

### How should this be tested?
Run `mvn clean package install -DskipTests -DskipRat`. It should print 
`BUILD SUCCESS`

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1705

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1676.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1676


commit 2c1c56be603da91da2a7a3d29fd0d89e1163851f
Author: Jun 
Date:   2016-11-24T11:37:19Z

Exclude unnecessary source file when check style on scio




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1671: Clean unnecessary codes

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1671
  
LGTM. Merge if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1674: [ZEPPELIN-1695] Apply regular maven indent

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1674
  
@bzz We can rebase and merge smaller PRs first like 
https://github.com/apache/zeppelin/pull/1668 and #1339 you mentioned. 

I will rebase #1668 first.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1705) Exclude unnecessary source file when check style on scio

[Tae Jun Kim (JIRA)]

Tae Jun Kim created ZEPPELIN-1705:
-

 Summary: Exclude unnecessary source file when check style on scio
 Key: ZEPPELIN-1705
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1705
 Project: Zeppelin
  Issue Type: Bug
  Components: Interpreters
Reporter: Tae Jun Kim
Assignee: Tae Jun Kim
Priority: Minor


When building with command:
{code}
mvn clean package install -DskipTests -DskipRat
{code}
it fails because check style of a generated source under 
{{scio/target/generated-sources/}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

[tae-jun]

Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1630
  
@AhyoungRyu Fixed what you mentioned :) Always thanks for the review 😄


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1671: Clean unnecessary codes

[astroshim]

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1671
  
@minahlee Thank you for proper pointing out! I just fixed it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1656: Fix Yarn configuration of Spark2.0

[astroshim]

Github user astroshim closed the pull request at:

https://github.com/apache/zeppelin/pull/1656


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1656: Fix Yarn configuration of Spark2.0

[astroshim]

GitHub user astroshim reopened a pull request:

https://github.com/apache/zeppelin/pull/1656

Fix Yarn configuration of Spark2.0

### What is this PR for?
`yarn-client` is deprecated since Spark 2.0, so SparkInterpreter also 
support `yarn` as `application master`.

### What type of PR is it?
Bug Fix | Improvement

### How should this be tested?
Run spark paragraph with Spark2.0 + yarn.

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin fix/yarn-spark2.0

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1656.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1656


commit a4f3fa3742fa1aad6fa2ec698c29aac752cb9ca6
Author: astroshim 
Date:   2016-11-18T14:07:04Z

fix spark2.0 connection error with EMR

commit 93f7f9c20e62121eef88ca8d172892b670c6af16
Author: astroshim 
Date:   2016-11-18T14:58:37Z

update spark conf

commit b225dd4cb1e8fe6250d162792b8a0d3c9bdf7dac
Author: astroshim 
Date:   2016-11-18T15:54:06Z

add master yarn

commit 4374ce0310e760b52938240411c6b67f4ba1d300
Author: astroshim 
Date:   2016-11-19T11:44:42Z

fix spark configuration

commit b9936286f0018a62f6fd14c645a82d0f3bab3daf
Author: astroshim 
Date:   2016-11-23T15:40:47Z

if yarn mode




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1441: [ ZEPPELIN-967 ] Implement search bar in job manager

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1441
  
@cloverhearts 
Tested again and it works well as expected. Seems there are some changes 
after I saw this 2 month ago. 
 - The result is reset after 10 sec
 - User should click search button (or press enter) to run query. Yeah I 
know auto result printing is not good in performance point of view. 

I just want to make sure :)
And I left a comment about really minor UI issue. Except that it looks good 
to me 👍 

(p.s. It'll be great if you can update PR description. Then other ppl who 
are interested in this PR can look through quickly!)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...

[felizbear]

Github user felizbear commented on the issue:

https://github.com/apache/zeppelin/pull/1673
  
@bzz it's definitely the simplest solution I'm aware of. it increases `npm 
test` time since it tries to install phantom every time you run it, but that's 
fine I guess. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1704) Flaky Test - InterpreterIT testShowDescriptionOnInterpreterCreate

[Mina Lee (JIRA)]

Mina Lee created ZEPPELIN-1704:
--

 Summary: Flaky Test - InterpreterIT 
testShowDescriptionOnInterpreterCreate
 Key: ZEPPELIN-1704
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1704
 Project: Zeppelin
  Issue Type: Bug
Reporter: Mina Lee


https://api.travis-ci.org/jobs/178540204/log.txt?deansi=true
{code}
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 42.116 sec <<< 
FAILURE! - in org.apache.zeppelin.integration.InterpreterIT
testShowDescriptionOnInterpreterCreate(org.apache.zeppelin.integration.InterpreterIT)
  Time elapsed: 41.889 sec  <<< ERROR!
org.openqa.selenium.ElementNotVisibleException: Element is not currently 
visible and so may not be interacted with
Command duration or timeout: 31.62 seconds
Build info: version: '2.48.2', revision: 
'41bccdd10cf2c0560f637404c2d96164b67d9d67', time: '2015-10-09 13:08:06'
System info: host: 'testing-docker-7f1edf58-2540-430b-887e-bf70cd807578', ip: 
'172.17.0.3', os.name: 'Linux', os.arch: 'amd64', os.version: 
'4.8.7-040807-generic', java.version: '1.7.0_76'
Session ID: bb27ea4f-a941-44e8-8610-71e899cbbb71
Driver info: org.openqa.selenium.firefox.FirefoxDriver
Capabilities [{platform=LINUX, acceptSslCerts=true, javascriptEnabled=true, 
cssSelectorsEnabled=true, databaseEnabled=true, browserName=firefox, 
handlesAlerts=true, nativeEvents=false, webStorageEnabled=true, 
rotatable=false, locationContextEnabled=true, applicationCacheEnabled=true, 
takesScreenshot=true, version=31.0}]
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
at 
org.openqa.selenium.remote.ErrorHandler.createThrowable(ErrorHandler.java:206)
at 
org.openqa.selenium.remote.ErrorHandler.throwIfResponseFailed(ErrorHandler.java:158)
at 
org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:647)
at 
org.openqa.selenium.remote.RemoteWebElement.execute(RemoteWebElement.java:326)
at 
org.openqa.selenium.remote.RemoteWebElement.click(RemoteWebElement.java:84)
at 
org.apache.zeppelin.integration.InterpreterIT.testShowDescriptionOnInterpreterCreate(InterpreterIT.java:69)
Caused by: org.openqa.selenium.ElementNotVisibleException: Element is not 
currently visible and so may not be interacted with
Build info: version: '2.48.2', revision: 
'41bccdd10cf2c0560f637404c2d96164b67d9d67', time: '2015-10-09 13:08:06'
System info: host: 'testing-docker-7f1edf58-2540-430b-887e-bf70cd807578', ip: 
'172.17.0.3', os.name: 'Linux', os.arch: 'amd64', os.version: 
'4.8.7-040807-generic', java.version: '1.7.0_76'
Driver info: driver.version: unknown
at .fxdriver.preconditions.visible(file:///tmp/anonymous363918669553069384webdriver-profile/extensions/fxdri...@googlecode.com/components/command-processor.js:9981)
at .DelayedCommand.prototype.checkPreconditions_(file:///tmp/anonymous363918669553069384webdriver-profile/extensions/fxdri...@googlecode.com/components/command-processor.js:12517)
at .DelayedCommand.prototype.executeInternal_/h(file:///tmp/anonymous363918669553069384webdriver-profile/extensions/fxdri...@googlecode.com/components/command-processor.js:12534)
at .fxdriver.Timer.prototype.setTimeout/<.notify(file:///tmp/anonymous363918669553069384webdriver-profile/extensions/fxdri...@googlecode.com/components/command-processor.js:621)
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin pull request #1675: [ZEPPELIN-1190] [WIP] Visit and switch notebook...

[khalidhuseynov]

GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/1675

[ZEPPELIN-1190] [WIP] Visit and switch notebook revisions

### What is this PR for?
This is the last step for enabling Zeppelin to work with revisions. It 
addresses ability to visit certain revision, switch among them, and reset to 
certain revision. Note that initial work started from #1304 and manually moved 
commits due to conflicts in `cherry-pick`. Currently WIP.


### What type of PR is it?
Improvement | Feature

### Todos
* [ ] - Task

### What is the Jira issue?
[ZEPPELIN-1190](https://issues.apache.org/jira/browse/ZEPPELIN-1190)

### How should this be tested?
set config in conf/zeppelin-env.sh
```
export 
ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
and switch between notes in note action bar

### Screenshots (if appropriate)
TBD

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
feat/switch-revisions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1675


commit 37f8100f7765aef8cbd2bb8ccbf360d4eef806ce
Author: Khalid Huseynov 
Date:   2016-11-24T04:59:42Z

create new root and call revision

commit e3fdecd3cf33a23d1f65305cdab1d4a1f2d9fd8f
Author: Khalid Huseynov 
Date:   2016-11-24T05:55:18Z

load revision note

commit 2858d273ee221422697d58ff4b8bdb7468fa445a
Author: Khalid Huseynov 
Date:   2016-11-24T06:19:56Z

visit revision when click in dropdown

commit 111a7daad5d60985de65460f4627385cd2dc9e73
Author: Khalid Huseynov 
Date:   2016-11-24T06:44:12Z

set current revision name

commit d2c1be313781fa3fe7da02a565521f651df3cc06
Author: Khalid Huseynov 
Date:   2016-11-24T07:16:25Z

fix quotes

commit 3804e07443eb2cfd5db2b0ddd5aadb271c47a318
Author: Khalid Huseynov 
Date:   2016-11-24T09:49:32Z

fix getNote name change




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1632: [ZEPPELIN-1639] Add tests with external python depende...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1632
  
@agoodm as CI is failing - could you please rebase on latest master, it has 
some CI improvements and then open\close the PR to trigger a new CI here again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1673
  
Thanks for review @1ambda ! Not sure about version number, so kept it blank 
for now..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1668
  
@1ambda it looks like rebase is needed after few other `pom.xml` 
modifications got merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1638: [ZEPPELIN-1666] DON'T share mutable deps, optio...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1638


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1662: [ZEPPELIN-1695] Enforce pom.xml style while rem...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1662


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1548: [ZEPPELIN-917] Apply new mechanism to LensInter...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1548


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1391: ZEPPELIN-1403. Should maintain the using port list

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1391
  
@bzz Sorry for delay, I was in vacation in the last 2 weeks. Regarding move 
it to other places rather than static, I am thinking to use a PortProvider 
class to wrap all the logic and of course this class should be singleton. What 
do you think ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---