[GitHub] zeppelin pull request #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade

[cloverhearts]

GitHub user cloverhearts opened a pull request:

https://github.com/apache/zeppelin/pull/1692

[ZEPPELIN-1710 - WIP] Ace Editor upgrade

### What is this PR for?
The current version of the ace editor is too old.
You should also fix a bug that improperly typed non-English typing in 
Chrome.
The latest ace editor has been modified.

### What type of PR is it?
Improvement

### Todos
- [x]  import ui-ace
- [x] 1.25 version of conformity check and paragraph form correction.
- [ ]  import ace editor new version. (v 1.26)

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1710

### Screenshots (if appropriate)

![aceeditor-125](https://cloud.githubusercontent.com/assets/10525473/20660120/192cecf4-b58b-11e6-8f95-a5912b5a2cbf.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin improve/ace-upgrade

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1692.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1692


commit 122a7f587224da4476c9a64eab89d87f0a97b34a
Author: CloverHearts 
Date:   2016-11-28T07:47:52Z

ace 1.25 import




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1632: [ZEPPELIN-1639] Add tests with external python depende...

[agoodm]

Github user agoodm commented on the issue:

https://github.com/apache/zeppelin/pull/1632
  
@felixcheung @bzz 

The final remaining travis error is unrelated, it seems to be occurring 
with other recent PRs (https://travis-ci.org/apache/zeppelin/builds/179341529). 
Perhaps we should focus on making the logs less verbose, since this profile 
already produces a log file that's bigger 3 MB on master.

In any case, is this good to finally merge?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1686
  
@1ambda Thanks for sharing issue!!

I guess `CTRL+L` short key is being used by some ace editor users.

So, I removed `CTRL-ALT-L` key binding and I changed **Clear output** short 
key from `CTRL + SHIFT + C` to `CTRL-ALT-L`

What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1691: ZEPPELIN-1716. Error of interpreter not found i...

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1691

ZEPPELIN-1716. Error of interpreter not found is not propagated to fr…

### What is this PR for?
It is introduced in ZEPPELIN-1399, we call 
`InterpreterFactory.getInterpreter` before calling `Paragraph.jobRun`. This PR 
would ignore the `InterpreterException` in `Paragraph.isValidIntepreter`


### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1716

### How should this be tested?
Tested manually, see the following screenshot

### Screenshots (if appropriate)

Before this PR, only see the following error in log, but not in frontend
```
ERROR [2016-11-28 15:16:47,378] ({qtp1471868639-17} 
NotebookServer.java[onMessage]:303) - Can't handle message
org.apache.zeppelin.interpreter.InterpreterException: spark.sparkr 
interpreter not found
at 
org.apache.zeppelin.interpreter.InterpreterFactory.getInterpreter(InterpreterFactory.java:1302)
at 
org.apache.zeppelin.notebook.Paragraph.isValidInterpreter(Paragraph.java:596)
at org.apache.zeppelin.notebook.Paragraph.getMagic(Paragraph.java:586)
at 
org.apache.zeppelin.socket.NotebookServer.runParagraph(NotebookServer.java:1337)
at 
org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:226)
at 
org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:59)
```
After this PR

![2016-11-28_1514](https://cloud.githubusercontent.com/assets/164491/20659318/e8d00a58-b57d-11e6-854d-899614c4ca87.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

…ontend.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1716

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1691.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1691


commit ad7ec6373ec2d810cde24f6f47ebd24723d2733f
Author: Jeff Zhang 
Date:   2016-11-28T07:03:22Z

ZEPPELIN-1716. Error of interpreter not found is not propagated to frontend.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1690: [ZEPPELIN-1709] docs: Describe how to use check...

[1ambda]

GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/1690

[ZEPPELIN-1709] docs: Describe how to use checkstyle plugins

### What is this PR for?

The sub issue of https://github.com/apache/zeppelin/pull/1689 (PRs are 
splitted due to `contribute.md` exists in different branch `gh-pages`)

- Describe how to IDE plugins to contribute consistent code


### What type of PR is it?
[Documentation]

### What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1709

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions - NO
* Does this needs documentation - NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin docs/update-checkstyle-plugins

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1690.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1690


commit 099479cf0118b1313aa667fa820e81d04af6bee1
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T07:06:18Z

docs: Update checkstyle plugins




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1681: [ZEPPELIN-1691] Implement NotebookRepoSetting to Zeppe...

[khalidhuseynov]

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1681
  
@anthonycorbacho i'll look into this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1684
  
@marchpig Thanks for this contribution! 
I tested it on Ubuntu and It works well! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1716) Error of interpreter not found is not propagated to frontend.

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-1716:


 Summary: Error of interpreter not found is not propagated to 
frontend.
 Key: ZEPPELIN-1716
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1716
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Jeff Zhang
Assignee: Jeff Zhang


It is introduced in ZEPPELIN-1399, we call InterpreterFactory.getInterpreter 
before calling Paragraph.jobRun



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1681: [ZEPPELIN-1691] Implement NotebookRepoSetting to Zeppe...

[anthonycorbacho]

Github user anthonycorbacho commented on the issue:

https://github.com/apache/zeppelin/pull/1681
  
Please review otherwise i am merging it 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem

[marchpig]

Github user marchpig commented on the issue:

https://github.com/apache/zeppelin/pull/1684
  
I've tested it on both Win7 and Ubuntu 12.04.
 > Win7 32bit (IE11, Chrome 54.0)
 > Ubuntu 12.04 64bit (Firefox 43.0)

This issue only occurred on Ubuntu 12.04 so I think @1ambda's guess is 
reliable.
Is there anyone who can test it on Win7 64bit?
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1672
  
@prabhjyotsingh It works now, but log file permission issue is still here 
which make the spark interpreter fail to run unless user manually set permission


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1632: [ZEPPELIN-1639] Add tests with external python ...

[agoodm]

GitHub user agoodm reopened a pull request:

https://github.com/apache/zeppelin/pull/1632

[ZEPPELIN-1639] Add tests with external python dependencies to CI build

### What is this PR for?
Take 2 of #1618 because I had some earlier problems with rebasing. Since, 
then I have added some new features, namely:

- Matplotlib integration tests for pyspark
- `install_external_dependencies.sh` which conditionally installs the R or 
python dependencies based on the specified build profile in `.travis.yml`. This 
saves several minutes of time for a few of the build profiles since the R 
dependencies are compiled from source and therefore take quite a bit of time to 
install.
- The extra python unit tests which require external dependencies 
(`matplotlib` and `pandas`) are now relegated to two separate build profiles. 
This is done primarily to efficiently test both Python 2 and 3.
- Some minor bugs in the python and pyspark interpreters (mostly with 
respect to python 3 compatibility) were caught as a result of these tests, and 
are also fixed in this PR.

### What type of PR is it?
Improvement and Bugfix

### What is the Jira issue?
[ZEPPELIN-1639](https://issues.apache.org/jira/browse/ZEPPELIN-1639)

### How should this be tested?
CI tests should be green!

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/agoodm/zeppelin ZEPPELIN-1639

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1632.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1632


commit b6b88be38657410f1fb10242014b386450f5282f
Author: Alex Goodman 
Date:   2016-11-08T21:52:33Z

Add python dependencies to .travis.yml

commit 42da31ceb4ce99b8130b455fbf6847d029033632
Author: Alex Goodman 
Date:   2016-11-15T05:59:08Z

Shorten python version

commit 3a76958ca3a4b631ea87ac35ce45a325c3547ee2
Author: Alex Goodman 
Date:   2016-11-15T09:03:07Z

Travis

commit ee95d677dc568f429f6b279f54b2ca10c17c8ed6
Author: Alex Goodman 
Date:   2016-11-21T22:52:45Z

Move python 3 tests to all modules with spark 2.0

commit 5709c5d516df66c28b2714d58ae87c7c40b1278c
Author: Alex Goodman 
Date:   2016-11-24T17:37:58Z

Re-add pyspark to build profile

commit 73663f6c1461e4df20cbb902a1b8029d16380c47
Author: Alex Goodman 
Date:   2016-11-24T18:06:44Z

Update tests for new InterpreterContext constructor

commit 5a60181be31af063d64e0038dfb96438182c76f8
Author: Alex Goodman 
Date:   2016-11-25T07:57:58Z

Isolate python tests

commit a4f43af87d39a46f125bd0fa1a64768cafdc6f79
Author: Alex Goodman 
Date:   2016-11-25T19:05:49Z

Update comments in .travis.yml

commit 363019ec8176384ec6efe368e6de341b4b3e97a7
Author: Alex Goodman 
Date:   2016-11-25T19:29:04Z

Use spark 2.0 with python 3

commit 01380c2d7527204c63034ce60b8361c64fc785dd
Author: Alex Goodman 
Date:   2016-11-27T07:01:46Z

Make sure python 3 profile uses scala 2.11




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1632: [ZEPPELIN-1639] Add tests with external python ...

[agoodm]

Github user agoodm closed the pull request at:

https://github.com/apache/zeppelin/pull/1632


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1684
  
True. Since both cases (`master` and this patch) are working well for me, I 
just wanna know which env can cause this problem. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1637
  
Okay, fixed all problem.
always ci green
i was change test case for zrun in angular object watch test.
@Leemoonsoo Could you please review for this pr?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1689
  
Failed due to log size limitation of travis CI

```
The log length has exceeded the limit of 4 MB (this usually means that the 
test suite is raising the same exception over and over).
```

We might disable `true` only in CI 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1684
  
I am not sure but this might be due to OS

I tested this PR and works well as @marchpig described. (but i didn't 
reproduce this issue like @AhyoungRyu)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1686
  
Ace users also issued about it. https://github.com/ajaxorg/ace/issues/210 

- I think this is a good feature and will be used so many times by so many 
people. Thus we should carefully design this shortcut.
- it is hard and not usual to stroke `CTRL + SHIFT + C` for me at least. 
What about others opinion? we might find better key for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1689
  
\cc @bzz for review thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...

[1ambda]

GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/1689

[ZEPPELIN-1709] Update checkstyle rule file, plugin

### What is this PR for?

We have

- outdated checkstyle.xml
- old maven checkstyle plugin
- no detailed style plugin guide (e.g available plugins, how to use them in 
your IDEA)

By fixing those issues, we can keep our code clean. It will results the 
number of rebase count (reduced conflict due to just style) and boost our 
productivity.

**important note**

This PR set an option to print all checkstyle warnings into stdout.   
The reason is, people should be told about invalid styles of not only 
errors but also warnings. 
Once those warnings are all fixed, we can set 
`warning` to fail build even when 
checkstyle warning is occurred.
By doing that, we can make our code more consistent.

```xml
true

```

### What type of PR is it?
[Improvement]

### Todos
* [x] - update check style plugin
* [x] - update checkstyle.xml 
* [x] - fix some styles
* [x] - print checkstyle WARN

### What is the Jira issue?

[ZEPPELIN-1709](https://issues.apache.org/jira/browse/ZEPPELIN-1709)

### How should this be tested?

```
mvn validate -Denforcer.skip=true
```


### Questions:
* Does the licenses files need update - NO
* Is there breaking changes for older versions - NO
* Does this needs documentation - NO, but I added some docs about how to 
use checkstyle.xml in IDEA


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin feat/update-checkstyle

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1689.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1689


commit 46c59bae0daf38df9dae39203632f0d7a2c8d6d1
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:27:18Z

chore: Use pluginManagement block

so that config be shared in children projects

commit 2fa6f734a1176a35f0cec7a440e0f992fb781cdb
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:28:29Z

chore: Remove useless failOnViolation config

its default value is already `true`

see https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html

commit 1988d41f26c20b1633963abd5ea93d35d7007f4b
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:29:46Z

chore: Remove duplicated  exclude

commit 83e0c7b0d75b52cee695f186ef9743bbc575e31d
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:13:15Z

chore: Update checkstyle version

commit 70b15c9b0d231ec4a12cc01e889e8ed1d75ad828
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:52:15Z

style: Fix Invalid indents in interpreter

[INFO] 

[INFO] Building Zeppelin: Interpreter 0.7.0-SNAPSHOT
[INFO] 

[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ 
zeppelin-interpreter ---
[INFO] There are 5 errors reported by Checkstyle 6.11.2 with 
_tools/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/zeppelin/dep/DependencyResolver.java:[162] 
(indentation) Indentation: 'Collection' have incorrect indentation level 4, 
expected level should be 6.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:[242]
 (indentation) Indentation: 'getClassName' have incorrect indentation level 10, 
expected level should be 12.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[59]
 (indentation) Indentation: 'extends' have incorrect indentation level 2, 
expected level should be 4.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[60]
 (indentation) Indentation: 'implements' have incorrect indentation level 2, 
expected level should be 4.
[ERROR] src/test/resources/log4j.properties:[0] (misc) NewlineAtEndOfFile: 
File does not end with a newline.
[INFO] 

[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ... SUCCESS [  
3.587 s]
[INFO] Zeppelin: Interpreter .. FAILURE [  
0.901 s]

commit 6f0d72fb281c04bd44e839adc08cfbcd4dd9654e
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T03:03:06Z

style: Fix invalid indents in zengine

[INFO] 

[INFO] Building Zeppelin: Zengine 0.7.0-SNAPSHOT
[INFO] 

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1672
  
This is ready for review, have checked this in few flavours of linux, and 
it was working as expected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1686
  
@1ambda Thanks for suggestion. :smile: 

I tried that but current `CTRL+L` short key is already worked by 
editor(ace) as the following picture.
![screenshot from 2016-11-28 
11-27-57](https://cloud.githubusercontent.com/assets/8110458/20654547/cfe37dba-b55d-11e6-9b78-83cbdd83e6eb.png)

Furthermore, those short key such as `CTRL+L`, `CTRL+SHIFT+L` `ALRT+L` seem 
to be interrupt by editor(ace) or browser or OS system. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1688
  
@krskoondra Thanks for your contribution.
If there are UI changes, some screenshot images can help other ppl to 
quickly look into this :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...

[conker84]

Github user conker84 commented on the issue:

https://github.com/apache/zeppelin/pull/1582
  
@felixcheung the CI still fails.
The `org.apache.zeppelin.interpreter.InterpreterOutputChangeWatcherTest` 
fails but in my enviroment it passes the test.
Where am i wrong?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1688: ZEPPELIN-1637 - Add button for "create next blo...

[krskoondra]

GitHub user krskoondra opened a pull request:

https://github.com/apache/zeppelin/pull/1688

ZEPPELIN-1637 - Add button for "create next block as copy of this block"

### What is this PR for?
Added new buttton "Copy paragraph" near run button. This new button create 
copy of current paragraph and insert it below current paragraph.

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1637

### How should this be tested?
Write something into paragraph and click on button "Copy paragraph".

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/krskoondra/zeppelin iss1637

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1688


commit f6716e00fd2f3d657ccd4c46df34886401468f48
Author: Ondřej Krško 
Date:   2016-11-27T19:17:33Z

ZEPPELIN-1637

commit 51165b89a1a6d1bcdbd16b50d94307b96835780a
Author: Ondřej Krško 
Date:   2016-11-27T20:08:37Z

fix




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1687: Branch 0.6

[krskoondra]

Github user krskoondra closed the pull request at:

https://github.com/apache/zeppelin/pull/1687


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1687: Branch 0.6

[krskoondra]

GitHub user krskoondra opened a pull request:

https://github.com/apache/zeppelin/pull/1687

Branch 0.6

### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - 
https://zeppelin.apache.org/contribution/contributions.html


### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. 
[ZEPPELIN-533]

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/zeppelin branch-0.6

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1687.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1687


commit c503f450c78c55e2c1369ecc3e11f082e865b048
Author: CloverHearts 
Date:   2016-06-15T05:01:28Z

ZEPPLIN-976 ] HotFix - zeppelin server does not restart when incorrect 
credentials data.

### What is this PR
zeppelin server does not restart when incorrect credentials data.

reproduce.
1. Click to zeppelin home for web ui.
2. Click to zeppelin Credentials.
3. 'Entity' information without writing, username and password only written 
to storage.
4. Click to zeppelin home for web ui.
5. Click to zeppelin Credentials.
and zeppelin restart.
# but, Zeppelin does not work.

It creates the wrong json file. 'conf / credentials.json' according to the 
null.

### What type of PR is it?
Hot Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-976

### How should this be tested?

1. Click to zeppelin home for web ui.
2. Click to zeppelin Credentials.
3. 'Entity' information without writing, username and password only written 
to storage.
4. Click to zeppelin home for web ui.
5. Click to zeppelin Credentials.
and zeppelin restart.

zeppelin does work!

### Reproduced Screenshots

![zeppelin-server-error2](https://cloud.githubusercontent.com/assets/10525473/15889828/b92590d8-2da7-11e6-9b51-0a82c3bb9f1f.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: CloverHearts 

Closes #976 from cloverhearts/hotfix/CredentialsJsonBug and squashes the 
following commits:

293ab08 [CloverHearts] Merge branch 'master' into hotfix/CredentialsJsonBug
ef256c2 [CloverHearts] Merge branch 'master' into hotfix/CredentialsJsonBug
5079495 [CloverHearts] add test code for credentials backends about invalid 
request.
e9a1e93 [CloverHearts] Merge branch 'master' into hotfix/CredentialsJsonBug
4b9aba3 [CloverHearts] changed status code for CredentialsRestapi
1e5cd72 [CloverHearts] Credentials Json serialize backend bug.

commit ee7ebca065bbe3a2e81ca10118baf047dd3fa561
Author: Jongyoul Lee 
Date:   2016-06-14T15:58:21Z

ZEPPELIN-992 Move some tests from InterpreterFactoryTest to 
LazyOpenInterpreterTest

### What is this PR for?
Moving Interpreter.interpret into LazyOpenInterpreterTest in oder to divide 
test scope between InterpreterFactoryTest and LazyOpenInterpreter. This is 
related to #987 a little bit.

### What type of PR is it?
[Refactoring]

### Todos
* [x] - Divide tests

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-992

### How should this be tested?
Changed only test case

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jongyoul Lee 

Closes #1002 from jongyoul/ZEPPELIN-992 and squashes the following commits:

da851da [Jongyoul Lee] Removed author tag
8ef2be3 [Jongyoul Lee] Moved Interpreter.interpret into 
LazyOpenInterpreterTest

commit 9d8680eacdb8691208a59721c609f8af43d6dd21
Author: Mina Lee 
Date:   2016-06-16T00:41:35Z

[HOTFIX][DOC] Fix image path

### What is this PR for?
Use relative path instead of absolute path so 

[GitHub] zeppelin issue #1647: [ZEPPELIN-1013] Don't run paragraph on selectbox chang...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1647
  
@Mleekko Thanks for your contribution. 
> Since user can choose to run or not to run. Users do not have an option 
in current implementation.

And agree with @1ambda :)
LGTM 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1686
  
@soralee This is cool! 👍 

a small suggestions here :) 

- usually, many tools use `CTRL + L` to clear output. Can we use this 
familiar key instead?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1678: [ZEPPELIN-1706] Make spark Ui accesible in various int...

[karuppayya]

Github user karuppayya commented on the issue:

https://github.com/apache/zeppelin/pull/1678
  
@Leemoonsoo  @zjffdu Ready for review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

[karuppayya]

Github user karuppayya commented on the issue:

https://github.com/apache/zeppelin/pull/1663
  
Updated the PR with test @zjffdu 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---