[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1668
  
Sounds reasonable. CI is green, merging to master then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1700: [DOCS] Update Shiro configuration file with new packag...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1700
  
Looks good to me, merging to master as a hotfix based on user feedback in 
[this thread](http://markmail.org/message/4z6hxxf3eem2wgp2), if there is no 
further discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1696: CI test for 1689

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1696
  
@bzz That's because invalid `_tools/checkstyle.xml`. I'v just updated sorry 
for distraction :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1696: CI test for 1689

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1696
  
Spark 2.0 profile fails with very stragne

```
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check 
(checkstyle-fail-build) on project zeppelin: Failed during checkstyle 
execution: Failed during checkstyle configuration: unable to parse 
configuration stream - Element type "html" must be declared.:6:26 -> [Help 1]
[ERROR] 
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1441: [ ZEPPELIN-967 ] Implement search bar in job manager

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1441
  
change name for item on select box.
Undefined to Interpreter is not set


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1441: [ ZEPPELIN-967 ] Implement search bar in job ma...

[cloverhearts]

Github user cloverhearts closed the pull request at:

https://github.com/apache/zeppelin/pull/1441


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1441: [ ZEPPELIN-967 ] Implement search bar in job ma...

[cloverhearts]

GitHub user cloverhearts reopened a pull request:

https://github.com/apache/zeppelin/pull/1441

[ ZEPPELIN-967 ] Implement search bar in job manager

### What is this PR for?

A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - 
https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?

Feature
### Todos
- [x] add serach bar ui
- [x] implement filter
- [x] show filter loading status.
### What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-967
### How should this be tested?
1. click to jobmanager menu
2. try to use filter by jobmanager filter bar on top.

Enter, Enter, it has been filtered properly?
After inputting, wait about 2 seconds, it has been filtering?
### Screenshots (if appropriate)

https://cloud.githubusercontent.com/assets/10525473/18658644/d6359a62-7f3f-11e6-8c03-030fc107ec2d.gif;>Screenshots


https://cloud.githubusercontent.com/assets/10060731/20595003/a69386ce-b27b-11e6-936f-dc6f78db7e94.gif


### Questions:
- Does the licenses files need update? no
- Is there breaking changes for older versions? no
- Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin 
ZEPPELIN-FILTERBAR-JOBMANAGER

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1441


commit 01b9828e369bcdb4ca55b30f63269b2a76a8e2cc
Author: CloverHearts 
Date:   2016-09-20T05:27:08Z

Implement search bar in job manager

commit 8ddffd02e88b7f9f1874947f1b462afee848ab5b
Author: CloverHearts 
Date:   2016-09-22T05:47:36Z

Merge branch 'master' into ZEPPELIN-FILTERBAR-JOBMANAGER

commit 76e0fb0111c35580f28c4ff22dfe2954df134a67
Author: CloverHearts 
Date:   2016-09-28T04:52:12Z

Merge branch 'master' into ZEPPELIN-FILTERBAR-JOBMANAGER

commit f48b3edfe94a6844881b0fdbd3d8570930ac5b7d
Author: CloverHearts 
Date:   2016-10-05T08:03:53Z

rebase and Merge branch 'master' into ZEPPELIN-FILTERBAR-JOBMANAGER

# Conflicts:
#   zeppelin-web/src/app/jobmanager/jobmanager.controller.js

commit 797483f22727cebf94673c2b103c20854aead217
Author: CloverHearts 
Date:   2016-10-05T08:13:47Z

move to no named function filter to named function filter

commit dc4f09827fe2b081e5d5c814606bfc118c05
Author: CloverHearts 
Date:   2016-10-12T04:11:13Z

Merge branch 'master' into ZEPPELIN-FILTERBAR-JOBMANAGER

# Conflicts:
#   zeppelin-web/src/app/jobmanager/jobmanager.controller.js

commit 41488f47a4bb8851c35187a38997ad1f674257e8
Author: CloverHearts 
Date:   2016-10-12T04:11:38Z

create new file for job manager filter in job controller.js

commit 96b447c2cc8048c1c065ae0d314c9fcce56ab816
Author: CloverHearts 
Date:   2016-10-12T04:34:17Z

change font family normal to inherit

commit d9bd8c19b18fbb6fbc5bb648ce2f850fec20948b
Author: CloverHearts 
Date:   2016-10-12T04:36:35Z

change filter result text for empty data in jobmanager ->  Data does not 
exist to No Job found

commit ba2428cec8ad9c9fcd554b75d27f588bd7f60354
Author: CloverHearts 
Date:   2016-10-12T04:38:18Z

remove legend (ready, abort.. ) in jobmanager

commit 41f95d2f72a4b1cf65b9659aa2f539beb7c38b98
Author: CloverHearts 
Date:   2016-10-12T05:09:34Z

Revert "remove legend (ready, abort.. ) in jobmanager"

This reverts commit ba2428cec8ad9c9fcd554b75d27f588bd7f60354.

commit 6f84a991e2aae36e6d8f2ecdba77128efacc86ee
Author: CloverHearts 
Date:   2016-10-12T08:51:53Z

Merge branch 'master' into ZEPPELIN-FILTERBAR-JOBMANAGER

commit 95f4f0eab938e77bf0de60c6248809c049343f16
Author: CloverHearts 
Date:   2016-11-21T16:42:34Z

Merge branch 'master' into ZEPPELIN-FILTERBAR-JOBMANAGER

# Conflicts:
#   zeppelin-web/src/app/jobmanager/jobmanager.controller.js

commit d975a3df1d4733b9f022140e63831096542ba5da
Author: CloverHearts 
Date:   2016-11-21T17:02:58Z

change name for filter variable notebook -> notename

commit 0ccaad7b7091b72e090dff922676f220c9be46de
Author: CloverHearts 
Date:   2016-11-21T17:43:20Z

add search button

commit 507b947996aac95e5d4cf8fb815213c07e31f77b
Author: CloverHearts 
Date:   

[GitHub] zeppelin issue #1441: [ ZEPPELIN-967 ] Implement search bar in job manager

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1441
  
@Leemoonsoo 
Thank you for your review a lot.

First, the select box's interpreter shows only the first interpreter, 
because it is information about the default interpreter's settings.
In fact, the meaning of this information is that it makes sense to find an 
`uninterpreted note '.

your said pointed all the interpreters, I will implement on this pr later.

The navigation bar of the existing navbar and the search menu of the `job 
task` menu have different meanings.

actually, navbar's search box is a good way to view detailed information 
about all the para-graphs.

but, I think we need search feature on `job menu(task)` are real-time 
response task monitoring.
the search for the `job task` should now filter the real-time information.

For example, if multiple users create and run a new paragraph or note, the 
search results of the `job task` should be changed to match the current 
situation.
The search using lucene is the information at the time the search query was 
requested.
It is detailed but not suitable for `job monitoring`.

I also think that the information on the `job task` can contain more 
information about the current work situation.
I have made a little more preparation for this part. (also your said point 
too)
That's why I think the search for the current navbar's search box and the 
`job task` should go to a different implementation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1700: [DOCS] Update Shiro configuration file with new...

[khalidhuseynov]

GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/1700

[DOCS] Update Shiro configuration file with new package names

### What is this PR for?
Since most of authentication related realm classes has moved from 
`org.apache.zeppelin.server` package into `org.apache.zeppelin.realm`, we need 
to update corresponding `shiro.ini.template` file


### What type of PR is it?
Improvement | Documentation

### Todos
* [x] - update class packages

### What is the Jira issue?
N/A

### How should this be tested?
same as for testing `LdapGroupRealm` or `ActiveDirectoryGroupRealm`

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no 
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
update/shiro-config

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1700.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1700


commit 2eabc24bcda4da10d7e96fbeedb0896a21f1d231
Author: Khalid Huseynov 
Date:   2016-11-29T07:25:41Z

update package names




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1699: [ZEPPELIN-1724] fix conda version

[astroshim]

GitHub user astroshim opened a pull request:

https://github.com/apache/zeppelin/pull/1699

[ZEPPELIN-1724] fix conda version

### What is this PR for?
Because `conda run` command removed since version `4.0.9`, 
PythonCondaInterpreter not working after the `conda-4.0.9`.
This PR fixes this issue.

I tested conda-4.2.12 and conda-4.0.9 .

### What type of PR is it?
Bug Fix | Improvement


### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1724


### How should this be tested?
Please refer to https://github.com/apache/zeppelin/pull/1645 

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1724

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1699.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1699


commit 8c3fbd3a40c24a32094621011608365f6d155d29
Author: astroshim 
Date:   2016-11-29T07:22:25Z

fix conda version




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1681: [ZEPPELIN-1691] Implement NotebookRepoSetting to Zeppe...

[anthonycorbacho]

Github user anthonycorbacho commented on the issue:

https://github.com/apache/zeppelin/pull/1681
  
@khalidhuseynov thanks for the review, i addressed it.

Merging if no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: 0.7 Shiro LDAP authentication changes? Unable to instantiate class [org.apache.zeppelin.server.LdapGroupRealm]

[Khalid Huseynov]

I think during refactoring LdapGroupRealm has moved into different package,
so could you try in your shiro config with:

ldapRealm = org.apache.zeppelin.realm.LdapGroupRealm

On Tue, Nov 29, 2016 at 2:33 AM, Ruslan Dautkhanov 
wrote:

> + dev list
>
> Could somebody please let me know if shiro-LDAP is known to be broken in
> master?
> So I will stop my attempts to work with 0.7.
>
> [org.apache.zeppelin.server.LdapGroupRealm] for object named
> 'ldapRealm'.  Please ensure you've specified the fully qualified class name
> correctly.
> at org.apache.shiro.config.ReflectionBuilder.createNewInstance(
> ReflectionBuilder.java:151)
> at org.apache.shiro.config.ReflectionBuilder.buildObjects(Refle
> ctionBuilder.java:119)
> at org.apache.shiro.config.IniSecurityManagerFactory.buildInsta
> nces(IniSecurityManagerFactory.java:161)
>
>
> Thanks,
> Ruslan
>
>
> On Mon, Nov 28, 2016 at 9:13 AM, Ruslan Dautkhanov 
> wrote:
>
>> Looking at 0.7 docs, Shiro LDAP authentication shiro.ini configuration
>> looks the same.
>> http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/shir
>> oauthentication.html
>>
>> Any ideas why this might be broken in the current snapshot?
>>
>> Exception in thread "main" org.apache.shiro.config.ConfigurationException:
>> Unable to instantiate class [org.apache.zeppelin.server.LdapGroupRealm]
>> for object named 'ldapRealm'.  Please ensure you've specified the fully
>> qualified class name correctly.
>> at org.apache.shiro.config.ReflectionBuilder.createNewInstance(
>> ReflectionBuilder.java:151)
>> at org.apache.shiro.config.ReflectionBuilder.buildObjects(Refle
>> ctionBuilder.java:119)
>> at org.apache.shiro.config.IniSecurityManagerFactory.buildInsta
>> nces(IniSecurityManagerFactory.java:161)
>>
>>
>>
>> --
>> Ruslan Dautkhanov
>>
>> On Mon, Nov 28, 2016 at 8:23 AM, Ruslan Dautkhanov 
>> wrote:
>>
>>> Zeppelin 0.7.0 built from yesterday's snapshot.
>>> Getting below error stack when trying to start Zeppelin 0.7.0.
>>> The same shiro config works fine in 0.6.2.
>>>
>>> We're using LDAP authentication configured in shiro.ini as
>>> ldapRealm = org.apache.zeppelin.server.LdapGroupRealm
>>> ldapRealm.contextFactory.environment[ldap.searchBase] = ...
>>> ldapRealm.contextFactory.url = ...
>>> ldapRealm.contextFactory.authenticationMechanism = SIMPLE
>>> ..
>>>
>>> This config works fine in 0.6.2.
>>> Is org.apache.zeppelin.server.LdapGroupRealm has to be changed in 0.7
>>> to something else?
>>> Or there are other significant changes in Shiro / LDAP authentication?
>>>
>>>
>>>
>>> [1]
>>>
>>> $ ./zeppelin.sh
>>> ...
>>> Exception in thread "main" org.apache.shiro.config.ConfigurationException:
>>> Unable to instantiate class [org.apache.zeppelin.server.LdapGroupRealm]
>>> for object named 'ldapRealm'.  Please ensure you've specified the fully
>>> qualified class name correctly.
>>> at org.apache.shiro.config.ReflectionBuilder.createNewInstance(
>>> ReflectionBuilder.java:151)
>>> at org.apache.shiro.config.ReflectionBuilder.buildObjects(Refle
>>> ctionBuilder.java:119)
>>> at org.apache.shiro.config.IniSecurityManagerFactory.buildInsta
>>> nces(IniSecurityManagerFactory.java:161)
>>> at org.apache.shiro.config.IniSecurityManagerFactory.createSecu
>>> rityManager(IniSecurityManagerFactory.java:124)
>>> at org.apache.shiro.config.IniSecurityManagerFactory.createSecu
>>> rityManager(IniSecurityManagerFactory.java:102)
>>> at org.apache.shiro.config.IniSecurityManagerFactory.createInst
>>> ance(IniSecurityManagerFactory.java:88)
>>> at org.apache.shiro.config.IniSecurityManagerFactory.createInst
>>> ance(IniSecurityManagerFactory.java:46)
>>> at org.apache.shiro.config.IniFactorySupport.createInstance(Ini
>>> FactorySupport.java:123)
>>> at org.apache.shiro.util.AbstractFactory.getInstance(AbstractFa
>>> ctory.java:47)
>>> at org.apache.zeppelin.utils.SecurityUtils.initSecurityManager(
>>> SecurityUtils.java:56)
>>> at org.apache.zeppelin.server.ZeppelinServer.setupRestApiContex
>>> tHandler(ZeppelinServer.java:268)
>>> at org.apache.zeppelin.server.ZeppelinServer.main(ZeppelinServe
>>> r.java:137)
>>> Caused by: org.apache.shiro.util.UnknownClassException: Unable to load
>>> class named [org.apache.zeppelin.server.LdapGroupRealm] from the thread
>>> context, current, or system/application ClassLoaders.  All heuristics have
>>> been exhausted.  Class could not be found.
>>> at org.apache.shiro.util.ClassUtils.forName(ClassUtils.java:148)
>>> at org.apache.shiro.util.ClassUtils.newInstance(ClassUtils.java
>>> :164)
>>> at org.apache.shiro.config.ReflectionBuilder.createNewInstance(
>>> ReflectionBuilder.java:144)
>>> ... 11 more
>>>
>>>
>>
>

[GitHub] zeppelin pull request #1698: Downloading dependency/changing version for an ...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/1698

Downloading dependency/changing version for an interpreter results in error 
sometimes

### What is this PR for?
At times on downloading dependency/changing version for an interpreter 
results in error

```
 INFO [2016-11-29 11:16:52,998] ({qtp60559178-18} 
InterpreterRestApi.java[updateSetting]:137) - Update interpreterSetting 
2C2ENJBEV
ERROR [2016-11-29 11:16:53,047] ({Thread-61} 
InterpreterFactory.java[run]:494) - Error while downloading repos for 
interpreter group : jdbc, go to interpreter setting page click on edit and save 
it again to make this interpreter work properly. : File does not exist: 
/Users/xxx/local-repo/2C2ENJBEV/twill-zookeeper-0.6.0-incubating.jar
java.io.FileNotFoundException: File does not exist: 
/Users/xxx/local-repo/2C2ENJBEV/twill-zookeeper-0.6.0-incubating.jar
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2275)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
at 
org.apache.zeppelin.interpreter.InterpreterFactory$3.run(InterpreterFactory.java:470)
ERROR [2016-11-29 11:16:53,047] ({Thread-64} 
InterpreterFactory.java[run]:494) - Error while downloading repos for 
interpreter group : jdbc, go to interpreter setting page click on edit and save 
it again to make this interpreter work properly. : File does not exist: 
/Users/xxx/local-repo/2C2ENJBEV/zookeeper-3.4.6.jar
java.io.FileNotFoundException: File does not exist: 
/Users/xxx/local-repo/2C2ENJBEV/zookeeper-3.4.6.jar
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2275)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
at 
org.apache.zeppelin.interpreter.InterpreterFactory$3.run(InterpreterFactory.java:470)
```

but on re-saving it works fine.



### What type of PR is it?
[Bug Fix]

### Todos


### What is the Jira issue?
* [ZEPPELIN-1725](https://issues.apache.org/jira/browse/ZEPPELIN-1725)

### How should this be tested?
Configure following as dependencies in JDBC 
```
org.apache.hive:hive-jdbc:2.0.1 
org.apache.hadoop:hadoop-common:2.7.1   
org.apache.hive.shims:hive-shims-0.23:2.1.0 
org.apache.phoenix:phoenix-core:4.7.0-HBase-1.1
```
now try changing one of it, say "org.apache.hadoop:hadoop-common:2.7.1" to 
"org.apache.hadoop:hadoop-common:2.6.0"

Save should happen all the time. 

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1725

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1698.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1698


commit b535bb962f0847885ba2792ba0ffcee01f30942f
Author: Prabhjyot Singh 
Date:   2016-11-29T07:03:32Z

do a check for FileNotFoundException, which would mean it was already 
deleted/not present.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1697: [ZEPPELIN-1352] Refactor Notebook repo versioni...

[anthonycorbacho]

GitHub user anthonycorbacho opened a pull request:

https://github.com/apache/zeppelin/pull/1697

[ZEPPELIN-1352] Refactor Notebook repo versioning to return Revision Empty 
instead of NULL

### What is this PR for?
In Zeppelin notebookRepo, versioning (checkpoint, get, revisionHistory) use 
to return NULL.
It will be better to return Empty (Revision or list).


### What type of PR is it?
[Improvement]

### What is the Jira issue?
* [ZEPPELIN-1352](https://issues.apache.org/jira/browse/ZEPPELIN-1352)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anthonycorbacho/incubator-zeppelin 
ZEPPELIN-1352

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1697.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1697


commit 989a9953f0f36c366ffb335f8017e566746259f8
Author: Anthony Corbacho 
Date:   2016-11-27T14:09:28Z

Add to Revision class a static final empty object that will be used to 
return empty revision instad of null

commit 5127961c45cbf2c1f3985f5427e1b7417150b2be
Author: Anthony Corbacho 
Date:   2016-11-27T14:10:04Z

Change logic to return Empty (Revision or Collection) instead of null

commit 058b3e778bf371a3378f0cd75213ec8cb42b7831
Author: Anthony Corbacho 
Date:   2016-11-27T14:12:08Z

Apply return empty revision instead of null in zeppelinhub notebook repo

commit 974c97631b9643e5df828db735ca441dfec04f18
Author: Anthony Corbacho 
Date:   2016-11-28T02:31:10Z

Fix test in GitNotebookRepo




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1658: [ZEPPELIN-212] Multiple paragraph results

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1658
  
Thanks @agoodm @khalidhuseynov for the review!
Merge to master if there're no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1679: ZEPPELIN-1707. Pass userName when creating interpreter...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1679
  
Looks good to me.

CI is green now, so will merge it to master if there is no further 
discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1339: [ZEPPELIN-1332] Remove spark-dependencies & suggest ne...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1339
  
Short summary and small thought about #1399 

1. Using symlink like `local-spark/master` would be safe i think. It 
enables user replace his local spark without renaming directories. Currently we 
are using hard coded name.

```
SPARK_CACHE="local-spark"
SPARK_ARCHIVE="spark-${SPARK_VERSION}-bin-hadoop${HADOOP_VERSION}"
```

2. about UX, 

- most (experienced in zeppelin) users do not use local spark
- for new comers, we can provide embedded spark using docker will be 
shipped by #1538 
- and storking `get-spark` is not too hard even if new users do not use the 
docker images.

3. Now users need to type `get-spark`. it works as described 

```
$  zeppelin-review git:(pr/1339) ./bin/zeppelin-daemon.sh start
Log dir doesn't exist, create 
/Users/1ambda/github/apache-zeppelin/zeppelin-review/logs
Pid dir doesn't exist, create 
/Users/1ambda/github/apache-zeppelin/zeppelin-review/run

You do not have neither local-spark, nor external SPARK_HOME set up.
If you want to use Spark interpreter, you need to run get-spark at least 
one time or set SPARK_HOME.

Zeppelin start [  OK  ]
$  zeppelin-review git:(pr/1339) ./bin/zeppelin-daemon.sh stop
Zeppelin stop  [  OK  ]
$  zeppelin-review git:(pr/1339) ./bin/zeppelin-daemon.sh get-spark
Download spark-2.0.1-bin-hadoop2.7.tgz from mirror ...

  % Total% Received % Xferd  Average Speed   TimeTime Time  
Current
 Dload  Upload   Total   SpentLeft  
Speed
100  178M  100  178M0 0  7157k  0  0:00:25  0:00:25 --:--:-- 
6953k

spark-2.0.1-bin-hadoop2.7 is successfully downloaded and saved under 
/Users/lambda/github/apache-zeppelin/zeppelin-review/local-spark

$  zeppelin-review git:(pr/1339) ./bin/zeppelin-daemon.sh start
Zeppelin start [  OK  ]
```






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1726) Downloading dependency/changing version for an interpreter results in error sometimes

[Kshitij Badani (JIRA)]

Kshitij Badani created ZEPPELIN-1726:


 Summary: Downloading dependency/changing version for an 
interpreter results in error sometimes
 Key: ZEPPELIN-1726
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1726
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-interpreter
Affects Versions: 0.7.0
Reporter: Kshitij Badani
Priority: Critical
 Fix For: 0.7.0


At times on downloading dependency/changing version for an interpreter results 
in error
{code}
 INFO [2016-11-29 11:16:52,998] ({qtp60559178-18} 
InterpreterRestApi.java[updateSetting]:137) - Update interpreterSetting 
2C2ENJBEV
ERROR [2016-11-29 11:16:53,047] ({Thread-61} InterpreterFactory.java[run]:494) 
- Error while downloading repos for interpreter group : jdbc, go to interpreter 
setting page click on edit and save it again to make this interpreter work 
properly. : File does not exist: 
/Users/xxx/local-repo/2C2ENJBEV/twill-zookeeper-0.6.0-incubating.jar
java.io.FileNotFoundException: File does not exist: 
/Users/xxx/local-repo/2C2ENJBEV/twill-zookeeper-0.6.0-incubating.jar
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2275)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
at 
org.apache.zeppelin.interpreter.InterpreterFactory$3.run(InterpreterFactory.java:470)
ERROR [2016-11-29 11:16:53,047] ({Thread-64} InterpreterFactory.java[run]:494) 
- Error while downloading repos for interpreter group : jdbc, go to interpreter 
setting page click on edit and save it again to make this interpreter work 
properly. : File does not exist: 
/Users/xxx/local-repo/2C2ENJBEV/zookeeper-3.4.6.jar
java.io.FileNotFoundException: File does not exist: 
/Users/xxx/local-repo/2C2ENJBEV/zookeeper-3.4.6.jar
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2275)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
at 
org.apache.zeppelin.interpreter.InterpreterFactory$3.run(InterpreterFactory.java:470)
{code}
but on re-saving it works fine.
Steps to reproduce:
Configure following as dependencies in JDBC 
{code}
org.apache.hive:hive-jdbc:2.0.1 
org.apache.hadoop:hadoop-common:2.7.1   
org.apache.hive.shims:hive-shims-0.23:2.1.0 
org.apache.phoenix:phoenix-core:4.7.0-HBase-1.1
{code}
now try changing one of it, say "org.apache.hadoop:hadoop-common:2.7.1" to 
"org.apache.hadoop:hadoop-common:2.6.0"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZEPPELIN-1725) Downloading dependency/changing version for an interpreter results in error sometimes

[Kshitij Badani (JIRA)]

Kshitij Badani created ZEPPELIN-1725:


 Summary: Downloading dependency/changing version for an 
interpreter results in error sometimes
 Key: ZEPPELIN-1725
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1725
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-interpreter
Affects Versions: 0.7.0
Reporter: Kshitij Badani
Priority: Critical
 Fix For: 0.7.0


At times on downloading dependency/changing version for an interpreter results 
in error
{code}
 INFO [2016-11-29 11:16:52,998] ({qtp60559178-18} 
InterpreterRestApi.java[updateSetting]:137) - Update interpreterSetting 
2C2ENJBEV
ERROR [2016-11-29 11:16:53,047] ({Thread-61} InterpreterFactory.java[run]:494) 
- Error while downloading repos for interpreter group : jdbc, go to interpreter 
setting page click on edit and save it again to make this interpreter work 
properly. : File does not exist: 
/Users/xxx/local-repo/2C2ENJBEV/twill-zookeeper-0.6.0-incubating.jar
java.io.FileNotFoundException: File does not exist: 
/Users/xxx/local-repo/2C2ENJBEV/twill-zookeeper-0.6.0-incubating.jar
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2275)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
at 
org.apache.zeppelin.interpreter.InterpreterFactory$3.run(InterpreterFactory.java:470)
ERROR [2016-11-29 11:16:53,047] ({Thread-64} InterpreterFactory.java[run]:494) 
- Error while downloading repos for interpreter group : jdbc, go to interpreter 
setting page click on edit and save it again to make this interpreter work 
properly. : File does not exist: 
/Users/xxx/local-repo/2C2ENJBEV/zookeeper-3.4.6.jar
java.io.FileNotFoundException: File does not exist: 
/Users/xxx/local-repo/2C2ENJBEV/zookeeper-3.4.6.jar
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2275)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
at 
org.apache.zeppelin.interpreter.InterpreterFactory$3.run(InterpreterFactory.java:470)
{code}
but on re-saving it works fine.
Steps to reproduce:
Configure following as dependencies in JDBC 
{code}
org.apache.hive:hive-jdbc:2.0.1 
org.apache.hadoop:hadoop-common:2.7.1   
org.apache.hive.shims:hive-shims-0.23:2.1.0 
org.apache.phoenix:phoenix-core:4.7.0-HBase-1.1
{code}
now try changing one of it, say "org.apache.hadoop:hadoop-common:2.7.1" to 
"org.apache.hadoop:hadoop-common:2.6.0"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZEPPELIN-1724) conda run command removed in 4.1.0

[Shim HyungSung (JIRA)]

Shim HyungSung created ZEPPELIN-1724:


 Summary: conda run command removed in 4.1.0
 Key: ZEPPELIN-1724
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1724
 Project: Zeppelin
  Issue Type: Bug
Reporter: Shim HyungSung


Because {code}conda run{code} command removed since version {code}4.0.9{code}, 
PythonCondaInterpreter not working after that version  {code}4.0.9{code}.

Related issues. : 
https://github.com/conda/conda/issues/2682
https://github.com/conda/conda/issues/2904




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin pull request #1612: ZEPPELIN-1607. Refactor Livy Interpreter to ada...

[zjffdu]

GitHub user zjffdu reopened a pull request:

https://github.com/apache/zeppelin/pull/1612

ZEPPELIN-1607. Refactor Livy Interpreter to adapt scope mode

### What is this PR for?
ZEPPELIN-1606 will make scoped mode as the default interpreter mode of 
livy. This PR is to refactor livy interpreter to adapt the scoped mode. 
Besides, it also fix several bugs of livy interpreter.  like ZEPPELIN-1516. 
Besides that I also enable livy integration test in travis to make sure the 
refactoring correct. 


### What type of PR is it?
[Refactoring]

### Todos
* Move session creation to open()
* Other refactoring in livy interpreter, especially LivyHelper.java

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1607

### How should this be tested?
Travis is also enabled for livy integration test. 

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1607

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1612.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1612


commit 620e24de1354620c2c70a318ab552a5ad4edbd6d
Author: Jeff Zhang 
Date:   2016-11-03T06:21:33Z

ZEPPELIN-1607. Refactor Livy Interpreter to adapt scope mode

commit b7ddfe260a86e951f363364f74dd9dc66df6c048
Author: Jeff Zhang 
Date:   2016-11-08T08:29:17Z

enable travis for livy integration test

commit b2205a0f1d5c3172755ee8c3c3bc6f4eb883bd92
Author: Jeff Zhang 
Date:   2016-11-08T09:11:10Z

add licence header

commit c6090fb734128ec5bc1d7e3fe120f3404d34c9b5
Author: Jeff Zhang 
Date:   2016-11-08T09:12:25Z

update .travis.yml

commit 0bd69e5c463f73ef901a6a1e8fa5b0a5f8cefa8a
Author: Jeff Zhang 
Date:   2016-11-08T09:44:30Z

update test

commit ce89afd2d1a5751663be41a19f156192d7fd025b
Author: Jeff Zhang 
Date:   2016-11-29T00:12:31Z

change version from 2.3 to 2.6 in .travis.yml




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1612: ZEPPELIN-1607. Refactor Livy Interpreter to ada...

[zjffdu]

Github user zjffdu closed the pull request at:

https://github.com/apache/zeppelin/pull/1612


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1690: [ZEPPELIN-1709] docs: Describe how to use checkstyle p...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1690
  
@1ambda Sounds great thanks! LGTM 👍   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1696: CI test for 1689

[1ambda]

GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/1696

CI test for 1689

This is a comparison group for #1689 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin ci-test-for-1689

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1696.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1696


commit 46c59bae0daf38df9dae39203632f0d7a2c8d6d1
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:27:18Z

chore: Use pluginManagement block

so that config be shared in children projects

commit 2fa6f734a1176a35f0cec7a440e0f992fb781cdb
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:28:29Z

chore: Remove useless failOnViolation config

its default value is already `true`

see https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html

commit 1988d41f26c20b1633963abd5ea93d35d7007f4b
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:29:46Z

chore: Remove duplicated  exclude

commit 83e0c7b0d75b52cee695f186ef9743bbc575e31d
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:13:15Z

chore: Update checkstyle version

commit 70b15c9b0d231ec4a12cc01e889e8ed1d75ad828
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:52:15Z

style: Fix Invalid indents in interpreter

[INFO] 

[INFO] Building Zeppelin: Interpreter 0.7.0-SNAPSHOT
[INFO] 

[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ 
zeppelin-interpreter ---
[INFO] There are 5 errors reported by Checkstyle 6.11.2 with 
_tools/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/zeppelin/dep/DependencyResolver.java:[162] 
(indentation) Indentation: 'Collection' have incorrect indentation level 4, 
expected level should be 6.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:[242]
 (indentation) Indentation: 'getClassName' have incorrect indentation level 10, 
expected level should be 12.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[59]
 (indentation) Indentation: 'extends' have incorrect indentation level 2, 
expected level should be 4.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[60]
 (indentation) Indentation: 'implements' have incorrect indentation level 2, 
expected level should be 4.
[ERROR] src/test/resources/log4j.properties:[0] (misc) NewlineAtEndOfFile: 
File does not end with a newline.
[INFO] 

[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ... SUCCESS [  
3.587 s]
[INFO] Zeppelin: Interpreter .. FAILURE [  
0.901 s]

commit 6f0d72fb281c04bd44e839adc08cfbcd4dd9654e
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T03:03:06Z

style: Fix invalid indents in zengine

[INFO] 

[INFO] Building Zeppelin: Zengine 0.7.0-SNAPSHOT
[INFO] 

[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ 
zeppelin-zengine ---
[INFO] There are 13 errors reported by Checkstyle 6.11.2 with 
_tools/checkstyle.xml ruleset.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java:[348] 
(indentation) Indentation: '.' have incorrect indentation level 5, expected 
level should be 8.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java:[412] 
(indentation) Indentation: '"Information From loaded Interpreter Setting Ref - 
{} "' have incorrect indentation level10, expected level should be 12.
[ERROR] 
src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[37] 
(indentation) Indentation: 'array initialization' child have incorrect 
indentation level 4, expected level shouldbe 6.
[ERROR] 
src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[38] 
(indentation) Indentation: 'array initialization' child have incorrect 
indentation level 4, expected level shouldbe 6.
[ERROR] 
src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[39] 
(indentation) Indentation: 'array initialization' child have incorrect 
indentation level 4, expected level shouldbe 6.
[ERROR] 
src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[44] 
(indentation) Indentation: 'JsonDeserializationContext' have 

[GitHub] zeppelin issue #1690: [ZEPPELIN-1709] docs: Describe how to use checkstyle p...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1690
  
I separated plugin link with setting guide @AhyoungRyu :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1672: ZEPPELIN-1701: User impersonation not work with...

[prabhjyotsingh]

GitHub user prabhjyotsingh reopened a pull request:

https://github.com/apache/zeppelin/pull/1672

ZEPPELIN-1701: User impersonation not work with SPARK_HOME set.

### What is this PR for?
User impersonation of front end user does not work with SPARK_HOME set.

### What type of PR is it?
[Bug Fix | Hot Fix]

### Todos
* [x] - Fix log file permission issue

### What is the Jira issue?
* [ZEPPELIN-1701](https://issues.apache.org/jira/browse/ZEPPELIN-1701)

### How should this be tested?
set SPARK_HOME zeppelin-env.sh and then try to run 


```
%spark
System.getProperty("user.name")
```

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? Yes


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1701

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1672.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1672


commit 62d4eb8027fdea8e486def849533c4354a2c9d98
Author: Prabhjyot Singh 
Date:   2016-11-23T07:35:19Z

ZEPPELIN-1701: User impersonation of front end user does not work with 
SPARK_HOME set.

commit d3d020c8a3faef00bba41617e51f7df73ee50dec
Author: Prabhjyot Singh 
Date:   2016-11-24T11:01:27Z

execute env variables in zeppelin-env.sh

commit aa5de22d6eadccec69f0ae9bc0aaa57353e8587e
Author: Prabhjyot Singh 
Date:   2016-11-25T09:19:43Z

use different log file for different user (in case of user impersonation)

commit 9052f2d56d6075754c5ab745c96ab22d1e083197
Author: Prabhjyot Singh 
Date:   2016-11-28T05:55:14Z

Merge remote-tracking branch 'origin/master' into ZEPPELIN-1701

commit 002950bee03e24b1182abdb60c069bba395dfc50
Author: Prabhjyot Singh 
Date:   2016-11-28T10:16:52Z

adding missing import




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1672: ZEPPELIN-1701: User impersonation not work with...

[prabhjyotsingh]

Github user prabhjyotsingh closed the pull request at:

https://github.com/apache/zeppelin/pull/1672


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1672: ZEPPELIN-1701: User impersonation not work with SPARK_...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1672
  
@zjffdu did you try it again, as this is working for me, or if you can let 
me know your environment I can try on the same. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1693: [ZEPPELIN-1695] chore: Set xml plugin phase to verify ...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1693
  
Looks great to me, thank you @1ambda 

Merging to master if there is no further discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1668
  
rebased to keep sync with master (+ to see CI is green as well)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1686
  
@soralee Tested again with `ctrl + option(alt) + l` and it works well. LGTM 
👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1689
  
Looks great to me, thank you @1ambda !

May be, as soon as CI is green let's try to squash some commits, before 
merging it in - 37 may be a bit too much to be useful in merge commit message 
summary.

Going to merge to master, if there is no further discussion, right after 
that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1684: Fix filter icon not displaying problem

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1684


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1685: [ZEPPELIN-1714] Build error of scio Intepreter on Cent...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1685
  
Merge into master if there are no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1658: [ZEPPELIN-212] Multiple paragraph results

[khalidhuseynov]

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1658
  
tried locally and works as expected, LGTM! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1617: ZEPPELIN-1645: JDBC Interpreter does not commit update...

[matthewLiem]

Github user matthewLiem commented on the issue:

https://github.com/apache/zeppelin/pull/1617
  
@randerzander @Leemoonsoo 
Thanks for this. Do you know of  a workaround we could use in the meantime? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1630
  
@tae-jun Great work! Take your time and feel free to ping me again when 
you're ready. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1606: [ZEPPELIN-777] Math formula support

[tae-jun]

Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1606
  
@giaosudau Thanks! 👍 I appreciate it 😄 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

[tae-jun]

Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1630
  
CI failure is because of me. I will fix it :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1606: [ZEPPELIN-777] Math formula support

[giaosudau]

Github user giaosudau commented on the issue:

https://github.com/apache/zeppelin/pull/1606
  
@tae-jun https://issues.apache.org/jira/browse/ZEPPELIN-1723


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1723) Math formula support library path error

[Chanh Le (JIRA)]

Chanh Le created ZEPPELIN-1723:
--

 Summary: Math formula support library path error
 Key: ZEPPELIN-1723
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1723
 Project: Zeppelin
  Issue Type: Bug
  Components: front-end
Affects Versions: 0.7.0
Reporter: Chanh Le


I set ZEPPELIN_SERVER_CONTEXT_PATH is /zeppelin/

and this is what happen after I do that.
!https://camo.githubusercontent.com/586205cd96d380676754968157d0fe78fafdc78b/687474703a2f2f692e696d6775722e636f6d2f444531556769782e6a7067!

It is working without set ZEPPELIN_SERVER_CONTEXT_PATH.






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1660
  
@Leemoonsoo Yes, I haven't check the front-side. I'll fix it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1660
  
@jongyoul I think key requirement of personalized mode is two or more 
different user want to keep their own dynamic form input and the output of 
paragraph. How can this be done without let user run paragraph?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1660
  
@Leemoonsoo I've not tested the graph. If you mean a dynamic change of 
graph, I'll check it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1660
  
@Leemoonsoo As we discussed before, the first version of personalized mode 
is to avoid changing note simultaneously while two user see a same note. I 
think this version fits it. one user want to change a paragraph or run a 
paragraph, and he has a proper permission, he can change it but the others 
doesn't see his change until they refresh their browser. but they refresh it, 
the newest one is adopted. Isn't it the first version of personalized mode?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1658: [ZEPPELIN-212] Multiple paragraph results

[agoodm]

Github user agoodm commented on the issue:

https://github.com/apache/zeppelin/pull/1658
  
Very nice @Leemoonsoo 👍 

I have tested this with the matplotlib tutorial notebook just to see if 
[ZEPPELIN-1638](https://issues.apache.org/jira/browse/ZEPPELIN-1638) is also 
resolved by this, and everything checks out!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1722) Modernize visualization/transformation using ES6 class

[Lee moon soo (JIRA)]

Lee moon soo created ZEPPELIN-1722:
--

 Summary: Modernize  visualization/transformation using ES6 class
 Key: ZEPPELIN-1722
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1722
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Lee moon soo


ZEPPELIN-1003 abstracted visualization.js and transformation.js using class. 
And classes are defined using prototype. Since ZEPPELIN-1667 is resolved, we 
can use es6 class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZEPPELIN-1721) Create / manage settings inside of each visualization.

[Lee moon soo (JIRA)]

Lee moon soo created ZEPPELIN-1721:
--

 Summary: Create / manage settings inside of each visualization.
 Key: ZEPPELIN-1721
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1721
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Lee moon soo
Assignee: Lee moon soo
 Fix For: 0.7.0


ZEPPELIN-1003 provides two abstraction layer:
 - visualization.js
 - transformation.js

However, both of them does not abstract 'settings'. So pivot keys,groups,values 
selection, scatter chart column selection, line chart checkboxes are 
implemented out-side of visualization/transformation.

transformation/visualization should have capability to render it's own setting 
ui component and interact with it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin pull request #1695: Zeppelin 1283

[PetroKostyuk]

GitHub user PetroKostyuk opened a pull request:

https://github.com/apache/zeppelin/pull/1695

Zeppelin 1283

### What is this PR for?
It's adding option to specify column in scatterPlot, that will be displayed 
in label


### What type of PR is it?
Feature

### Todos
I had trouble to get label displayed for most of points. Label was 
triggered by cursor on different position than point was. See picture, my 
cursor was on position of red X. But this problem was there even before my 
edits and I think it should be handeled as separate issue. Mostly I was able to 
trigger labels when I selected only Y axis and hovered on points on bottom of 
chart.
![screenshot from 2016-11-26 
13-51-10](https://cloud.githubusercontent.com/assets/11884177/20685020/d433d54a-b5b2-11e6-863e-e99aa01d24ee.png)


### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1283

### How should this be tested?
reate scatterPlot and put some column in new 'label' field. Values from 
that column should appear in label corresponding to selected point.

### Screenshots (if appropriate)
![screenshot from 2016-11-28 
19-51-52](https://cloud.githubusercontent.com/assets/11884177/20684948/7b2b55b8-b5b2-11e6-947a-f22628983853.png)
![screenshot from 2016-11-28 
19-51-18](https://cloud.githubusercontent.com/assets/11884177/20684950/7f1dc124-b5b2-11e6-9ed1-9309f67a4e5c.png)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PetroKostyuk/zeppelin ZEPPELIN-1283

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1695.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1695


commit 347d56a4c49968a9b4c02593ec5c871601de25aa
Author: Petro Kostyuk 
Date:   2016-11-28T20:17:23Z

[ZEPPELIN-1283] added labels to scatterPlot

commit 1c2c77e859779828fa221884054ad8e277a01cbf
Author: Petro Kostyuk 
Date:   2016-11-28T20:25:40Z

[ZEPPELIN-1283] added labels to scatterPlot fix




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1694
  
Haven't tried it yet, but IMO we should have a check at backned for the 
same (both API and websocket).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

[prabhu-pictink]

Github user prabhu-pictink commented on the issue:

https://github.com/apache/zeppelin/pull/1694
  
Haven't tried it yet, but I think we should have a check at backned for the 
same (both API and websocket).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

[epahomov]

Github user epahomov commented on the issue:

https://github.com/apache/zeppelin/pull/1688
  
Yeaaa, I love it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

[krskoondra]

Github user krskoondra commented on the issue:

https://github.com/apache/zeppelin/pull/1688
  
OK, @Leemoonsoo, the button is now in the dropdown menu of the paragraph 
and new keyboard shortcut ctrl+shift+c is added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1630: [ZEPPELIN-1629] Enable renaming folder from the main p...

[tae-jun]

Github user tae-jun commented on the issue:

https://github.com/apache/zeppelin/pull/1630
  
@AhyoungRyu Sorry for my late response! But it's due to tests :)

I reproduced the error you mentioned and you were right!

Furthermore, chasing a reason of the error, I notice that there are more 
possibilities of error. So I wrote more codes and added more test cases.

## Folder merging test

![rename_folder_merging](https://cloud.githubusercontent.com/assets/8201019/20678891/cd35d0da-b5db-11e6-8371-96f366fbb715.gif)

## Renaming a high depth folder test

![rename_folder_complex2](https://cloud.githubusercontent.com/assets/8201019/20678921/e94740b0-b5db-11e6-9c9e-f6c926e68a0a.gif)

I thought this new feature is simple to implement... but now I don't think 
so...^^; I tested a lot of times, but maybe there are more bugs. So please test 
this when you have some time.

Thanks 😄 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1637
  
@cloverhearts Thanks for the great contribution.
LGTM and merge to master if there're no more discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1637
  
@Leemoonsoo Sorry, I think I misunderstood your answer. All edits are 
complete.
Thank you for your reply.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1637
  
Sorry, I think I misunderstood your answer. All edits are complete.
Thank you for your reply.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1685: [ZEPPELIN-1714] Build error of scio Intepreter on Cent...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1685
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1685: [ZEPPELIN-1714] Build error of scio Intepreter on Cent...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1685
  
@astroshim Tested on CentOS 7 again and faced the issue you described. 
Also I checked the other files that contains `import scala.tools.nsc.*` 
(e.g. 
[FlinkInterpreter.java](https://github.com/apache/zeppelin/blob/master/flink/src/main/java/org/apache/zeppelin/flink/FlinkInterpreter.java),
 
[DepInterpreter.java](https://github.com/apache/zeppelin/blob/master/spark/src/main/java/org/apache/zeppelin/spark/DepInterpreter.java),
 
[IgniteInterpreter.java](https://github.com/apache/zeppelin/blob/master/ignite/src/main/java/org/apache/zeppelin/ignite/IgniteInterpreter.java)
 and etc etc.. ) are all importing not `tools.nsc..` but `scala.tools.nsc...`. 
So anyway LGTM :D 👍


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1637
  
ci retry


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1694: [ZEPPELIN-1718] Prevent anonymous user to set n...

[AhyoungRyu]

GitHub user AhyoungRyu reopened a pull request:

https://github.com/apache/zeppelin/pull/1694

[ZEPPELIN-1718] Prevent anonymous user to set note permission / interpreter 
owner

### What is this PR for?
Currently anonymous user can set note permission / interpreter's owner like 
below

e.g. 
 - An anonymous user can type `admin` / `user1` to the note permission 
setting fields. (but it doesn't work actually)
 - The anonymous user can remove predefined `Owners` in the interpreter 
menu by editing it since we don't check the user's principal for this.

It doesn't make sense actually. At least we should disallow the 
non-authenticated users by deactivating those permission related features. So 
what I did in this PR is
 - "Set permission" checkbox for interpreter owner setting with notice 
sentence & related docs link: 
https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/shiroauthentication.html#security-setup
 - Hide note authorization setting fields with notice sentence & related 
docs link: 
https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/notebook_authorization.html

### What type of PR is it?
Bug Fix | Improvement

### Todos
- [ ] disallow anon users to edit all the other interpreter properties : 
not only "Set permissions" but also ...

### What is the Jira issue?
[ZEPPELIN-1718](https://issues.apache.org/jira/browse/ZEPPELIN-1718)

### How should this be tested?

### Screenshots (if appropriate)
 - Hide authorization setting fields for anon user in the note
https://cloud.githubusercontent.com/assets/10060731/20671445/c0553240-b5c0-11e6-8fe8-21ba4f4ae1dc.gif;>

 - Disable "Set permission" checkbox to anon user in the interpreter 
creation page
https://cloud.githubusercontent.com/assets/10060731/20671464/cf1beb5c-b5c0-11e6-8faf-47a73b0ebf38.png;>

 - Disable "Set permission" checkbox to anon user in the interpreter 
setting update page 
https://cloud.githubusercontent.com/assets/10060731/20671496/e548cf44-b5c0-11e6-9148-63946829db27.gif;>

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/zeppelin prevent-anon-user

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1694.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1694


commit b59c22b0c4e71c158ffed4bd48d728059ad6077e
Author: AhyoungRyu 
Date:   2016-11-27T16:46:20Z

Prevent to set permission by anonymous user

commit 465a58547f0e383bddced37b294546f5ac1dc165
Author: AhyoungRyu 
Date:   2016-11-28T08:31:49Z

Remove some redundant parts

commit 29a0a08696215dc85bda467f80b0163ee671d35f
Author: AhyoungRyu 
Date:   2016-11-28T10:17:40Z

Revert again




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1647: [ZEPPELIN-1013] Don't run paragraph on selectbox chang...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1647
  
Although it changes user experience, it is more consistent behavior 
considering other type of dynamic form behavior (input, checkbox).

Regarding the test, while other types of dynamic forms also don't have 
automated test. I have created 
https://issues.apache.org/jira/browse/ZEPPELIN-1720 and we can resolve it 
separately.

LGTM and merge to master if there're no more discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1720) Make tests to ensure behavior of dynamic form

[Lee moon soo (JIRA)]

Lee moon soo created ZEPPELIN-1720:
--

 Summary: Make tests to ensure behavior of dynamic form
 Key: ZEPPELIN-1720
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1720
 Project: Zeppelin
  Issue Type: Test
Reporter: Lee moon soo
Priority: Minor


Behavior of dynamic form - i.e. change form and click 'run' to update - is not 
enforced by automated test.

Test will help prevent unintended change of the behavior.

Adding using selenium in 
[ParagraphActionsIT.java|https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java]
 is one way to do.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1688
  
Thanks for updatding description! 
Agree with @Leemoonsoo. And FYI, you can refer #1686 for assigning keyboard 
shortcut :D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1684
  
Merge into master if there are no more comments 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1694: [ZEPPELIN-1718] Prevent anonymous user to set n...

[AhyoungRyu]

GitHub user AhyoungRyu opened a pull request:

https://github.com/apache/zeppelin/pull/1694

[ZEPPELIN-1718] Prevent anonymous user to set note permission / interpreter 
owner

### What is this PR for?
Currently anonymous user can set note permission / interpreter's owner like 
below

e.g. 
 - An anonymous user can type `admin` / `user1` to the note permission 
setting fields. (but it doesn't work actually)
 - The anonymous user can remove predefined `Owners` in the interpreter 
menu by editing it since we don't check the user's principal for this.

It doesn't make sense actually. At least we should disallow the 
non-authenticated users by deactivating those permission related features. So 
what I did in this PR is
 - "Set permission" checkbox for interpreter owner setting with notice 
sentence & related docs link: 
https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/shiroauthentication.html#security-setup
 - Hide note authorization setting fields with notice sentence & related 
docs link: 
https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/notebook_authorization.html

### What type of PR is it?
Bug Fix | Improvement

### Todos
- [ ] disallow anon users to edit all the other interpreter properties : 
not only "Set permissions" but also ...

### What is the Jira issue?
[ZEPPELIN-1718](https://issues.apache.org/jira/browse/ZEPPELIN-1718)

### How should this be tested?

### Screenshots (if appropriate)
 - Hide authorization setting fields for anon user in the note
https://cloud.githubusercontent.com/assets/10060731/20671445/c0553240-b5c0-11e6-8fe8-21ba4f4ae1dc.gif;>

 - Disable "Set permission" checkbox to anon user in the interpreter 
creation page
https://cloud.githubusercontent.com/assets/10060731/20671464/cf1beb5c-b5c0-11e6-8faf-47a73b0ebf38.png;>

 - Disable "Set permission" checkbox to anon user in the interpreter 
setting update page 
https://cloud.githubusercontent.com/assets/10060731/20671496/e548cf44-b5c0-11e6-9148-63946829db27.gif;>

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/zeppelin prevent-anon-user

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1694.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1694


commit b59c22b0c4e71c158ffed4bd48d728059ad6077e
Author: AhyoungRyu 
Date:   2016-11-27T16:46:20Z

Prevent to set permission by anonymous user

commit 465a58547f0e383bddced37b294546f5ac1dc165
Author: AhyoungRyu 
Date:   2016-11-28T08:31:49Z

Remove some redundant parts

commit 29a0a08696215dc85bda467f80b0163ee671d35f
Author: AhyoungRyu 
Date:   2016-11-28T10:17:40Z

Revert again




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1688: [ZEPPELIN-1637] Add button for "create next block as c...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1688
  
Top right corner of each paragraph was pretty crowded in early days of 
Zeppelin.
Run, Move up, Move down, Delete, Show title, Show codes, Hides output, and 
so on.

Because it was too crowded, we decided to move most of them under dropdown 
menu of the paragraph. 

Shell we move this button into dropdown menu and assign keyboard short cut 
instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1637: [ZEPPELIN-1665] Z.run with external note executable an...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1637
  
I still can see some unnecessary changes on the import code block in many 
files.
Could you manage them unchanged? I have listed files in previous comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1686
  
Ctrl+Alt+L sounds good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1681: [ZEPPELIN-1691] Implement NotebookRepoSetting to Zeppe...

[khalidhuseynov]

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1681
  
@anthonycorbacho tested and works as expected. may check comment for log, 
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1719) Error parsing %table when first cell in row is html

[Abhijit Bhole (JIRA)]

Abhijit Bhole created ZEPPELIN-1719:
---

 Summary: Error parsing %table when first cell in row is html
 Key: ZEPPELIN-1719
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1719
 Project: Zeppelin
  Issue Type: Bug
  Components: Core
Affects Versions: 0.6.2
Reporter: Abhijit Bhole


Hi, I think there is a bug in the display system of zeppelin when the first 
cell contains %html tag

Example - 

%spark.pyspark 

print '%table\nName\tCol\tCol2\tCol3\n%html 
578445507377268487\tThis name\t%html 
57844550737726848\tNew\n%html 
578445507377268487\tThis name\t%html 
57844550737726848\tNew'


Output generated is 

578445507377268487  This name   %html 57844550737726848 New 
578445507377268487  This name   %html 57844550737726848 New

i.e. no table is printed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1632: [ZEPPELIN-1639] Add tests with external python depende...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1632
  
I think it is mostly the test output that pollutes the CI logs...

So, if I read TravisCI logs right - with 2 new profiles  `Elapsed time 31 
min`, and on `master` i.e 
[yesterday](https://travis-ci.org/apache/zeppelin/builds/179087724) `Elapsed 
time 31 min 14 sec`

Looks great to me, merging to master if there is no further discussion!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1718) Should prevent to set permission by anonymous user

[Ahyoung Ryu (JIRA)]

Ahyoung Ryu created ZEPPELIN-1718:
-

 Summary: Should prevent to set permission by anonymous user
 Key: ZEPPELIN-1718
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1718
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.6.2
Reporter: Ahyoung Ryu
Assignee: Ahyoung Ryu
 Fix For: 0.7.0


Currently anonymous user can do something in permission menus(note permission, 
interpreter owner setting). 

e.g. the anonymous user can type "admin" / "user1" to the note permission 
setting fields. Or the anonymous user can remove "Owners" in the interpreter 
menu by editing it since we don't check the user's principal for this. 

It doesn't make sense actually. At least we should disallow the 
non-authenticated users by deactivating those permission related features i 
think.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1689
  
Thank you @1ambda !
I think it's a great idea to have checkstyle off the most of profiles, but 
add a new one with just checkstyle.

After CI finishes, let's post the CI time statistics in PR description, in 
order to verify the hypothesis that this change actually does speed up the CI 
build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1690: [ZEPPELIN-1709] docs: Describe how to use checkstyle p...

[bzz]

Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1690
  
Looks great to me, thank you for taking care of both, Eclipse and IDEA


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #918: ZEPPELIN-885 Add option to send email in scheduler exec...

[vgmartinez]

Github user vgmartinez commented on the issue:

https://github.com/apache/zeppelin/pull/918
  
Hi @Leemoonsoo, 
I have refactored the code to be able to add more channels of 
notifications, e.g slack, SNS (in the next PR)...
Please take a look...

thks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1717) Weird output for SparkR

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-1717:


 Summary: Weird output for SparkR
 Key: ZEPPELIN-1717
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1717
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Jeff Zhang


This is my source code and output


{code}
%spark.r

df <- as.DataFrame(faithful)
head(df)
{code}

Output
{code}
1 function (x, df1, df2, ncp, log = FALSE)
2 {
3 if (missing(ncp))
4 .Call(C_df, x, df1, df2, log)
5 else .Call(C_dnf, x, df1, df2, ncp, log)
6 }
{code}

The output in spark-shell is
{code}
> head(df)
  eruptions waiting
1 3.600  79
2 1.800  54
3 3.333  74
4 2.283  62
5 4.533  85
6 2.883  55
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1691: ZEPPELIN-1716. Error of interpreter not found is not p...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1691
  
@Leemoonsoo Please help review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1693: [ZEPPELIN-1695] chore: Set xml plugin phase to verify ...

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1693
  
Thanks @1ambda for the contribution :smile: 
I tested on Ubuntu and it works well as expected  


```
---
 T E S T S
---
Running org.apache.zeppelin.markdown.Markdown4jParserTest
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in 
[jar:file:/home/sora/.m2/repository/org/apache/zeppelin/zeppelin-interpreter/0.7.0-SNAPSHOT/zeppelin-interpreter-0.7.0-SNAPSHOT.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in 
[jar:file:/home/sora/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
log4j:WARN No appenders could be found for logger 
(org.apache.zeppelin.interpreter.Interpreter).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for 
more info.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.162 sec - 
in org.apache.zeppelin.markdown.Markdown4jParserTest
Running org.apache.zeppelin.markdown.PegdownParserTest
Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.888 sec 
- in org.apache.zeppelin.markdown.PegdownParserTest

Results :

Tests run: 14, Failures: 0, Errors: 0, Skipped: 0

[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 7.581 s
[INFO] Finished at: 2016-11-28T17:59:03+09:00
[INFO] Final Memory: 20M/268M
[INFO] 


```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1686
  
Thanks for review @AhyoungRyu  @Leemoonsoo, and could you check this PR 
again, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1693: [ZEPPELIN-1695] chore: Set xml plugin phase to ...

[1ambda]

GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/1693

[ZEPPELIN-1695] chore: Set xml plugin phase to verify (minor)

### What is this PR for?

Changed the phase of xml validation plugin from validate to verify so that 
developers can use `mvn test` in submodule dirctories
(**this PR doesn't affect on runtime application behaivor.**)

```
[INFO] --- xml-maven-plugin:1.0.1:validate (default) @ zeppelin-markdown ---
[INFO] 

[INFO] BUILD FAILURE
[INFO] 

[INFO] Total time: 1.643 s
[INFO] Finished at: 2016-11-28T17:53:47+09:00
[INFO] Final Memory: 17M/307M
[INFO] 

[ERROR] Failed to execute goal 
org.codehaus.mojo:xml-maven-plugin:1.0.1:validate (default) on project 
zeppelin-markdown: Failed to load schema with public ID null, system ID 
_tools/maven-4.0.0.xsd: 
/Users/lambda/github/apache-zeppelin/zeppelin-feature/markdown/_tools/maven-4.0.0.xsd
 (No such file or directory) -> [Help 1]
[ERROR]
```

### What type of PR is it?
[Improvement]

### Todos


### What is the Jira issue?


[ZEPPELIN-1695](https://issues.apache.org/jira/browse/ZEPPELIN-1695?filter=-3)

### How should this be tested?

```
$ cd markdown
$ mvn test
```

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
chore/modify-xml-plugin-phase-to-verify

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1693.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1693


commit cc3858b6bafbb7cb70753205069b14591b33087b
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T08:09:41Z

chore: Set xml plugin phase to verify




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1691: ZEPPELIN-1716. Error of interpreter not found i...

[zjffdu]

GitHub user zjffdu reopened a pull request:

https://github.com/apache/zeppelin/pull/1691

ZEPPELIN-1716. Error of interpreter not found is not propagated to fr…

### What is this PR for?
It is introduced in ZEPPELIN-1399, we call 
`InterpreterFactory.getInterpreter` before calling `Paragraph.jobRun`. This PR 
would ignore the `InterpreterException` in `Paragraph.isValidIntepreter`


### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1716

### How should this be tested?
Tested manually, see the following screenshot

### Screenshots (if appropriate)

Before this PR, only see the following error in log, but not in frontend
```
ERROR [2016-11-28 15:16:47,378] ({qtp1471868639-17} 
NotebookServer.java[onMessage]:303) - Can't handle message
org.apache.zeppelin.interpreter.InterpreterException: spark.sparkr 
interpreter not found
at 
org.apache.zeppelin.interpreter.InterpreterFactory.getInterpreter(InterpreterFactory.java:1302)
at 
org.apache.zeppelin.notebook.Paragraph.isValidInterpreter(Paragraph.java:596)
at org.apache.zeppelin.notebook.Paragraph.getMagic(Paragraph.java:586)
at 
org.apache.zeppelin.socket.NotebookServer.runParagraph(NotebookServer.java:1337)
at 
org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:226)
at 
org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:59)
```
After this PR

![2016-11-28_1514](https://cloud.githubusercontent.com/assets/164491/20659318/e8d00a58-b57d-11e6-854d-899614c4ca87.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1716

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1691.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1691


commit ad7ec6373ec2d810cde24f6f47ebd24723d2733f
Author: Jeff Zhang 
Date:   2016-11-28T07:03:22Z

ZEPPELIN-1716. Error of interpreter not found is not propagated to frontend.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1691: ZEPPELIN-1716. Error of interpreter not found i...

[zjffdu]

Github user zjffdu closed the pull request at:

https://github.com/apache/zeppelin/pull/1691


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade

[cloverhearts]

GitHub user cloverhearts reopened a pull request:

https://github.com/apache/zeppelin/pull/1692

[ZEPPELIN-1710 - WIP] Ace Editor upgrade

### What is this PR for?
The current version of the ace editor is too old.
You should also fix a bug that improperly typed non-English typing in 
Chrome.
The latest ace editor has been modified.

### What type of PR is it?
Improvement

### Todos
- [x]  import ui-ace
- [x] 1.25 version of conformity check and paragraph form correction.
- [ ]  import ace editor new version. (v 1.26)

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1710

### Screenshots (if appropriate)

![aceeditor-125](https://cloud.githubusercontent.com/assets/10525473/20660120/192cecf4-b58b-11e6-8f95-a5912b5a2cbf.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin improve/ace-upgrade

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1692.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1692


commit 122a7f587224da4476c9a64eab89d87f0a97b34a
Author: CloverHearts 
Date:   2016-11-28T07:47:52Z

ace 1.25 import




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---